Nice looking script here, will take it for a test drive soon.
There is something that I don't quite agree with:
Simba Code:
procedure horizontalPattern(slots:TIntegerArray);
var
I: Integer;
mouse: TPoint;
begin
for I:=0 to Length(slots)-1 do
begin
mouse := MiddleBox(invBox(slots[I]));
customMouse(point(mouse.X + random(-5,5),mouse.Y + random(-5,5)));
sleep(random(20,100));
case random(0,30) of
0..29: fastClick(mouse_Left);
30: // Never have I heard of anyone right clicking a herb to clean?
begin // That's just my experience though.
fastClick(mouse_Right);
waitOption('Clean ',random(20,50));
end
end
sleep(random(50,100));
end
end
As I've said in my comments, never have I right clicked a herb and selected clean. As far as I'm concerned most legit players spam click their herbs in set patterns, for example:
Code:
1 2 3 4
8 7 6 5
9 10 11 12 // And so on.
Any reason you've put this in other than to randomise it a bit?
The best pattern that is utilised is:
Simba Code:
procedure crossPattern(slots:TIntegerArray);
var
I: Integer;
mouse: TPoint;
begin
for I:=0 to Length(cross)-1 do
begin
mouse := MiddleBox(invBox(cross[I]));
customMouse(point(mouse.X + random(-5,5),mouse.Y + random(-5,5)));
sleep(random(20,100));
case random(0,20) of
0..19: fastClick(mouse_Left);
20:
begin
fastClick(mouse_Right);
waitOption('Clean ',random(20,50));
end
end
sleep(random(50,100));
end
end
I feel this is probably the second most utilised pattern due to this Herblore guide. If you don't wish to watch it, the video maker states that this cross pattern is the fastest pattern to clean the herbs in.
Also (this is probably due to my ping to the OSRS servers due to being in Australia and having bad internet to start with), I've found that sometimes the script will be depositing each herb one at a time. Basically it's trying to clean them in the bank, although I stopped the script when it did this to reset it so I didn't see if it resolved the problem by itself.
Congratulations on release .