Results 1 to 22 of 22

Thread: Fishy Combiner [AL][Reflection]

  1. #1
    Join Date
    May 2012
    Posts
    108
    Mentioned
    3 Post(s)
    Quoted
    45 Post(s)

    Cool Fishy Combiner [AL][Reflection]


    Current Release: 2.3

    Finally updating the script. Tested on about 3500 jugs of wine on f2p, tell me if anything goes wrong or if you have any suggestions.

    1. What the Script Does
    - Combines two items together obviously! This means using an item on another item then making them. For example: stringing bows or making potions.
    - Works with making potions, unfinished potions, stringing bows, jugs of wine, battlestaves... maybe more?

    2. Features
    - Supports whatever item you want it to!
    - Progress graphic
    - Antiban
    - Failsafes
    - Supports npc and booth banking
    - Stops if out of material

    3. Instructions
    - Not necessary, but start with the items you want to use in the top right of your bank, this will make it a lot quicker.
    - Start in front of the bank booth. Tested mostly at VWest and GE.
    - Finish the user setup
    - If you wish you make battlestaves, you must change the script to only right click the items, rather than left click. Just some simple changes in Make()
    - Have brightness at max, zoom set to default, and fixed screen
    - Have interpreter set to lape
    - Report back with suggestions or feedback!

    4. What You Need
    - AeroLib: https://villavu.com/forum/showthread.php?t=108953
    - Reflection (lape): https://villavu.com/forum/showthread.php?t=111662
    - Latest version of SMART and Simba

    5. Credits
    - Anth - Used some of his old scripts as the base for mine

    6. TODO
    - Add breaks (only if it is highly requested, don't really care for them)
    - Add support for bank chest
    - Suggestions

    7. Changelog
    = 2.3
    - Fixed levelUp stopping program
    - Made Withdraw and Make procedures more random
    - Now chooses f2p/p2p world based on user input
    - Improved antiban procedure
    - Added to Withdraw so it won't accidentally withdraw notes
    - plenty of other random stuff I noticed when looking through my code again
    = 2.2
    - Small change to antiban procedure
    - Solved some problems in make
    = 2.1
    - Fixed case of running out of one item
    - Moved reflection objects to the funcs they are used in

    FishyCombiner[2.3].simba
    FishyCombiner[2.2].simba
    FishyCombiner[2.1].simba
    FishyCombiner[2.0].simba
    Attached Images Attached Images
    Last edited by Blak Fishy; 09-07-2016 at 01:30 PM. Reason: updating to 2.3

  2. #2
    Join Date
    Apr 2013
    Posts
    680
    Mentioned
    13 Post(s)
    Quoted
    341 Post(s)

    Default

    Good Job! I haven't really got a use for this atm; but i may try to make some bows or something.

    Though this would have many uses. with a little changes it could be reflection fletching script =D

    <------------------>



  3. #3
    Join Date
    Mar 2013
    Location
    Earth some place
    Posts
    108
    Mentioned
    2 Post(s)
    Quoted
    66 Post(s)

    Default

    Good stuff bro! I will be sure to check it out and improve on it if I can. Glad to see this here man, people will love it.
    "We're all someone else to someone else." - Calvin & Hobbes.
    A story of life. Inside everyone are two wolves. It is a terrible fight. One is evil, one is good. Which one wins? The one you feed.

  4. #4
    Join Date
    May 2012
    Posts
    108
    Mentioned
    3 Post(s)
    Quoted
    45 Post(s)

    Default

    Updated to release 2.1
    Fixed issue of running out of one item, moved reflection objects to prevent memory leaks, and optimized many functions.
    Script runs very smoothly now: is there anything wanted next?

  5. #5
    Join Date
    May 2012
    Posts
    108
    Mentioned
    3 Post(s)
    Quoted
    45 Post(s)

    Default

    On release 2.2. Just wanted to say I check on this every update to make sure the script still works and test for 30 minutes or so. Please report if anything is wrong, if you liked the script, or any suggested improvements.

  6. #6
    Join Date
    Oct 2015
    Posts
    80
    Mentioned
    2 Post(s)
    Quoted
    35 Post(s)

    Default

    Blak Fishy, I just wanted to test this script and I downloaded Reflection as per the instruction on reflection's thread. When I try to run this script, I get a new tab opened on SIMBA called SimbaEX and get this error:

    Error: Unknown declaration "init" at line 623
    Compiling failed.
    The line 623 in this new tab SimbaEX is:

    S.init();

  7. #7
    Join Date
    Jun 2012
    Posts
    586
    Mentioned
    112 Post(s)
    Quoted
    296 Post(s)

    Default

    Quote Originally Posted by terrorbyte View Post
    Blak Fishy, I just wanted to test this script and I downloaded Reflection as per the instruction on reflection's thread. When I try to run this script, I get a new tab opened on SIMBA called SimbaEX and get this error:



    The line 623 in this new tab SimbaEX is:
    Update ProSocks.




    Skype: obscuritySRL@outlook.com

  8. #8
    Join Date
    Oct 2015
    Posts
    80
    Mentioned
    2 Post(s)
    Quoted
    35 Post(s)

    Default

    Quote Originally Posted by Obscurity View Post
    Update ProSocks.
    Yes, sorry for not updating the post. I was able to update the ProSocks and able to run the script. I have not, however, tested the script itself yet since my bot doesn't have the required herblore level to test the script out.

    But compiler itself is working so I am going to assume for now that the script will most likely work as well. Will post an update once I've thoroughly tested out the script.

  9. #9
    Join Date
    Aug 2015
    Posts
    16
    Mentioned
    0 Post(s)
    Quoted
    8 Post(s)

    Default

    Error: Unknown declaration "getInvCount" at line 361

    tmpCount := getInvCount();

  10. #10
    Join Date
    May 2012
    Posts
    108
    Mentioned
    3 Post(s)
    Quoted
    45 Post(s)

    Default

    Script is currently outdated: will be coming out soon with a completely redone script only using reflection.
    The problems now are menial and should be able to be figured out if you look up updated reflection commands to replace them.

  11. #11
    Join Date
    Oct 2015
    Posts
    80
    Mentioned
    2 Post(s)
    Quoted
    35 Post(s)

    Default

    Quote Originally Posted by Blak Fishy View Post
    Script is currently outdated: will be coming out soon with a completely redone script only using reflection.
    The problems now are menial and should be able to be figured out if you look up updated reflection commands to replace them.
    Can't wait, Fishy

  12. #12
    Join Date
    Feb 2012
    Posts
    31
    Mentioned
    0 Post(s)
    Quoted
    1 Post(s)

    Default

    This looks great, cant wait to try it
    I tried real life once, the graphics where great but the storyline was terrible.

    What do these tags do?

  13. #13
    Join Date
    Dec 2015
    Posts
    15
    Mentioned
    0 Post(s)
    Quoted
    8 Post(s)

    Default

    Great script. One problem I noticed with this is that it would often withraw the selected items as a note and then it would think that it had run out of the selected items and log out. This happened with both version 2.1 and 2.2. I made a very slight adjustment to the withdraw function which seems to have fixed the problem. This change I made was between lines 268-285 of version 2.2. Instead of reposting the whole script, I will just paste the withdraw function because I only added 2 lines and they were in the withdraw function.

    case random(0, 1) of
    0:
    begin
    Notes(False); //This is the only change made. I added it again for the other case (first item)
    ScndB.Withdraw(-14);
    case random(0, 1) of
    0: FrstB.Withdraw(-14);
    1: FrstB.Withdraw(-1);
    end;
    end;
    1:
    begin
    Notes(False); // this is the only change that I made
    FrstB.Withdraw(-14);
    case random(0, 1) of
    0: ScndB.Withdraw(-14);
    1: ScndB.Withdraw(-1);
    end;

  14. #14
    Join Date
    Feb 2012
    Posts
    31
    Mentioned
    0 Post(s)
    Quoted
    1 Post(s)

    Default

    Nice ty!
    I tried real life once, the graphics where great but the storyline was terrible.

    What do these tags do?

  15. #15
    Join Date
    Mar 2016
    Location
    Isle de Muerta
    Posts
    40
    Mentioned
    0 Post(s)
    Quoted
    23 Post(s)

    Default

    2.2 version doesn't work for me for combining herbs with vial of water. (Says that names are bad, doesn't matter what you type in, always same error)
    2.1 version works for that but gets stuck a lot

  16. #16
    Join Date
    Oct 2011
    Location
    England
    Posts
    401
    Mentioned
    10 Post(s)
    Quoted
    176 Post(s)

    Default

    Quote Originally Posted by kyyskis View Post
    2.2 version doesn't work for me for combining herbs with vial of water. (Says that names are bad, doesn't matter what you type in, always same error)
    2.1 version works for that but gets stuck a lot
    Have you tried putting the names in case-sensitive?
    Yer a wizard, 'oopi

  17. #17
    Join Date
    Mar 2016
    Location
    Isle de Muerta
    Posts
    40
    Mentioned
    0 Post(s)
    Quoted
    23 Post(s)

    Default

    Quote Originally Posted by anth_ View Post
    Have you tried putting the names in case-sensitive?
    yep,i tried but it didn't worked

    P.S. just re downloaded script 2.2 version, and typed in other herbs and now worked

  18. #18
    Join Date
    May 2012
    Posts
    108
    Mentioned
    3 Post(s)
    Quoted
    45 Post(s)

    Default

    Quote Originally Posted by kyyskis View Post
    yep,i tried but it didn't worked

    P.S. just re downloaded script 2.2 version, and typed in other herbs and now worked
    Just tested with a couple herbs and it still worked, will try to update soon with a big update to fix everything. Been away for a while but I've been trying some random stuff lately and perfecting this sounds fun.

  19. #19
    Join Date
    May 2012
    Posts
    108
    Mentioned
    3 Post(s)
    Quoted
    45 Post(s)

    Default

    Update to 2.3 posted. Fixed some problems with recent updates like placeholders. Also fixed existing problems like choice f2p/p2p login and noted items being withdrawn. Finally, I added some behavior changes to make detection harder. Tested by making over 3500 wines and had no problems. If you have any problems or have any suggestions for further improvements feel free to post them.

  20. #20
    Join Date
    Dec 2015
    Location
    Toronto, Ontario
    Posts
    85
    Mentioned
    2 Post(s)
    Quoted
    21 Post(s)

    Default

    Hey, great script. Only suggestion is to add support for multiple items. Say if you are doing herblore and want to go onto the next herb once another has run out. Shouldn't be too difficult. I'd be happy to do it myself and post back if you would like but I am pretty busy.

  21. #21
    Join Date
    Feb 2013
    Posts
    33
    Mentioned
    0 Post(s)
    Quoted
    17 Post(s)

    Default

    Hey, just letting you know that your script rocks! Thank you for sharing

  22. #22
    Join Date
    Feb 2013
    Posts
    33
    Mentioned
    0 Post(s)
    Quoted
    17 Post(s)

    Default

    PS: just letting anyone doing hosidius know - comment out lines 387 to 397 (do NOT comment out 398, it's connected to another function). It will skip "Make all" option, which doesn't pop up when making things like sulphurous fertiliser for favours - you will still have to press continue every now and then when it levels up farming, haven't wrapped my head around that one yet

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •