Well, first of all, for the Loading of the DTM's, put them both in one procedure.. And your standards are a bit off, i fixed them for you
You don't need to make a procedure called CloseTheBank, seeing as how SRL has one.
As for your fletching procedure, i suppose its all right, seeing as how its not for RS, as long as you know that this would NEVER suffice for Runescape.. That being said, you also, click on the option to 'Make X', but you never type in how many you want to make.
And after it is typed in, you should add a repeat function so it repeats waiting until it finds the DTM in the last inventory spot, or a failsafe is reached(which i have included in version below) Fixed in the edited version below!
There were a few small compiling errors also.. Such as:
SCAR Code:
Line 41: [Error] (14492:24): Variable Expected in script
Failed when compiling
Line 47: [Error] (14498:20): Variable Expected in script
Failed when compiling
Line 47: [Error] (14498:46): 'THEN' expected in script
For the first two, you need to include Variables in the FindDTM function, i think someone answered your thread about this, but not sure, so i added it anyway.. And the last error, you can not put a semicolon directly after an If statement, because you need to place the "Then" there. So you do not want to do this:
SCAR Code:
If(FindDTM(OakLong, x, y, 688, 421,736, 468)); then
You want to do this:
SCAR Code:
If(FindDTM(OakLong, x, y, 688, 421,736, 468))Then
And here is the totally edited version:
SCAR Code:
program Fletcher;
{.include SRL/SRL.scar}
Var
Oak, OakLong : Integer;
Procedure LoadOak;
Begin
Oak := DTMFromString('78DA639CCBC0C050C180022615BA806946289' +
'F712990286040038CA86A5601896A026A40E63410503307483413' +
'50339908353D40A296809A5E4CBF63A801854F3E0356005303006' +
'D020B24');
OakLong := DTMFromString('78DA633CC9C4C0B08B910119CCAC1502D3305' +
'1C69D4035EB50D5C064E16A7601D5AC25A0E61050CD46026ACE00' +
'D51C24A0E60250CD4922D41CC5AF0600CFA80BD1');
End;
Procedure WithdrawOaks;
Begin
If (FindDTM(Oak,x,y,56, 49,474, 310))Then
Begin
Mouse(x,y,0,0,false);
ChooseOption(x, y, 'All');
End;
End;
Procedure Fletch;
Var
FletchMark : Integer;
Begin
MarkTime(FletchMark);
Mouse(585,229,0,0,true);
Wait(150);
Mouse(625,228,0,0,true);
Wait(200);
Mouse(375,414,0,0,false);
ChooseOption(x, y, 'X,');
TypeSend('27');
Repeat
Wait(100);
Until(FindDTM(OakLong, x, y, 688, 421,736, 468)) OR (TimeFromMark(FletchMark) >= 180000);
End;
Procedure BankLongBows;
Begin
If(FindDTM(OakLong, x, y, 688, 421,736, 468))Then
Begin
Mouse(x,y,0,0,false);
Wait(500);
ChooseOption(x,y, 'All');
End;
End;
begin
LoadOak;
Repeat
OpenBank;
WithdrawOaks;
CloseBank;
Fletch;
OpenBank;
BankLongBows;
Until(false);
end.
REMEMBER! ALL OF MY CRITICISM IS CONSTRUCTIVE!