Results 1 to 12 of 12

Thread: My first script! (not for RS)

  1. #1
    Join Date
    Jul 2007
    Posts
    37
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default My first script! (not for RS)

    Could someone have a look over it and tell me what i could do to improve it?
    (if you can understand it, its messy)

    SCAR Code:
    program Fletcher;
    {.include SRL/SRL.scar}

    Var
    Oak: Integer;
    OakLong: Integer;

    Procedure LoadOak;
    begin;
      Oak := DTMFromString('78DA639CCBC0C050C180022615BA806946289' +
           'F712990286040038CA86A5601896A026A40E63410503307483413' +
           '50339908353D40A296809A5E4CBF63A801854F3E0356005303006' +
           'D020B24');
    end;

    Procedure LoadOakLong;
    begin
      OakLong := DTMFromString('78DA633CC9C4C0B08B910119CCAC1502D3305' +
           '1C69D4035EB50D5C064E16A7601D5AC25A0E61050CD46026ACE00' +
           'D51C24A0E60250CD4922D41CC5AF0600CFA80BD1');
           end;

    Procedure WithdrawOaks;
    begin
    if (FindDTM(Oak,x,y,56, 49,474, 310)) then
    begin
    Mouse(x,y,0,0,false);
          ChooseOption(x, y, 'All');
          end;
          end;


    Procedure CloseTheBank;
    begin
    Mouse(459,41,0,0,true);
    Wait(400);
    end;

    Procedure Fletch;
    begin
    Mouse(585,229,0,0,true);
    Wait(150);
    Mouse(625,228,0,0,true);
    Wait(200);
    Mouse(375,414,0,0,false);
          ChooseOption(x, y, 'X,');
    If(FindDTM(OakLong, 688, 421,736, 468)) then
    end;


    Procedure BankLongBows;
    begin
    If(FindDTM(OakLong,688, 421,736, 468)); then
    begin
    Mouse(x,y,0,0,false);
    Wait(500);
    ChooseOption(x,y, 'All');
    end;
    end;






    begin
    LoadOak;
    LoadOakLong;
    Repeat
    OpenBank;
    WithdrawOaks;
    CloseTheBank;
    Fletch;
    OpenBank;
    BankLongBows;
    Until(false);
    end.



    Thanks!

  2. #2
    Join Date
    Feb 2007
    Location
    SparklesProd.com
    Posts
    2,406
    Mentioned
    1 Post(s)
    Quoted
    0 Post(s)

    Default

    How could this possibly be not for rs? =P

  3. #3
    Join Date
    Jul 2007
    Posts
    37
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Private server

  4. #4
    Join Date
    Jun 2007
    Location
    ENGLAND
    Posts
    220
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Who would make a fletcher auto for a private server, Only if had the newb point scheme..

  5. #5
    Join Date
    Jul 2007
    Posts
    37
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by exppo View Post
    Who would make a fletcher auto for a private server, Only if had the newb point scheme..


    Why not?

    I didnt ask you to judge me, only the script

  6. #6
    Join Date
    Jan 2007
    Location
    Illinois.. >.<
    Posts
    1,158
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Well, first of all, for the Loading of the DTM's, put them both in one procedure.. And your standards are a bit off, i fixed them for you You don't need to make a procedure called CloseTheBank, seeing as how SRL has one.
    SCAR Code:
    CloseBank

    As for your fletching procedure, i suppose its all right, seeing as how its not for RS, as long as you know that this would NEVER suffice for Runescape.. That being said, you also, click on the option to 'Make X', but you never type in how many you want to make. And after it is typed in, you should add a repeat function so it repeats waiting until it finds the DTM in the last inventory spot, or a failsafe is reached(which i have included in version below) Fixed in the edited version below!

    There were a few small compiling errors also.. Such as:
    SCAR Code:
    Line 41: [Error] (14492:24): Variable Expected in script
    Failed when compiling
    Line 47: [Error] (14498:20): Variable Expected in script
    Failed when compiling
    Line 47: [Error] (14498:46): 'THEN' expected in script

    For the first two, you need to include Variables in the FindDTM function, i think someone answered your thread about this, but not sure, so i added it anyway.. And the last error, you can not put a semicolon directly after an If statement, because you need to place the "Then" there. So you do not want to do this:
    SCAR Code:
    If(FindDTM(OakLong, x, y, 688, 421,736, 468)); then

    You want to do this:
    SCAR Code:
    If(FindDTM(OakLong, x, y, 688, 421,736, 468))Then

    And here is the totally edited version:

    SCAR Code:
    program Fletcher;
    {.include SRL/SRL.scar}

    Var
    Oak, OakLong : Integer;

    Procedure LoadOak;
    Begin
      Oak := DTMFromString('78DA639CCBC0C050C180022615BA806946289' +
           'F712990286040038CA86A5601896A026A40E63410503307483413' +
           '50339908353D40A296809A5E4CBF63A801854F3E0356005303006' +
           'D020B24');
      OakLong := DTMFromString('78DA633CC9C4C0B08B910119CCAC1502D3305' +
           '1C69D4035EB50D5C064E16A7601D5AC25A0E61050CD46026ACE00' +
           'D51C24A0E60250CD4922D41CC5AF0600CFA80BD1');
    End;

    Procedure WithdrawOaks;
    Begin
    If (FindDTM(Oak,x,y,56, 49,474, 310))Then
    Begin
      Mouse(x,y,0,0,false);
      ChooseOption(x, y, 'All');
      End;
    End;

    Procedure Fletch;
    Var
      FletchMark : Integer;
    Begin
      MarkTime(FletchMark);
      Mouse(585,229,0,0,true);
      Wait(150);
      Mouse(625,228,0,0,true);
      Wait(200);
      Mouse(375,414,0,0,false);
      ChooseOption(x, y, 'X,');
      TypeSend('27');
      Repeat
        Wait(100);
      Until(FindDTM(OakLong, x, y, 688, 421,736, 468)) OR (TimeFromMark(FletchMark) >= 180000);
    End;


    Procedure BankLongBows;
    Begin
      If(FindDTM(OakLong, x, y, 688, 421,736, 468))Then
      Begin
        Mouse(x,y,0,0,false);
        Wait(500);
        ChooseOption(x,y, 'All');
      End;
    End;






    begin
     LoadOak;
     Repeat
       OpenBank;
       WithdrawOaks;
       CloseBank;
       Fletch;
       OpenBank;
       BankLongBows;
     Until(false);
    end.

    REMEMBER! ALL OF MY CRITICISM IS CONSTRUCTIVE!

  7. #7
    Join Date
    Jul 2007
    Posts
    37
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Hmm i look an idiot now with all those mistakes


    Nah im kidding, i take it all as CC, thanks alot

  8. #8
    Join Date
    Jan 2007
    Location
    Illinois.. >.<
    Posts
    1,158
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    No problem Phil.

  9. #9
    Join Date
    Mar 2007
    Posts
    562
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    so what do we use this on??????

    haxor

  10. #10
    Join Date
    Jul 2007
    Posts
    242
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    it's for a private server





  11. #11
    Join Date
    Jul 2006
    Posts
    259
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    actually private servers are good to test scripts on because if it gets stuck in a loop or somthing you wont really lose anything
    "your always where you supposed to be"

  12. #12
    Join Date
    Apr 2007
    Posts
    379
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Hey Phil if you ever do plan on adapting that to actually work on the official runescape servers, what ever you do, do NOT use coords. Mainly because they are very easily detechted and become very unreliable after 4 minutes of running.

    Nice first attempt tho!

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •