Page 4 of 4 FirstFirst ... 234
Results 76 to 82 of 82

Thread: [SRL-OSR]Flight's AIO Fisher

  1. #76
    Join Date
    May 2013
    Posts
    96
    Mentioned
    1 Post(s)
    Quoted
    32 Post(s)

    Default

    noticed a couple quirks with 1.3

    theres an issue changing tabs on resizable modern, resizable classic works fine.

    at mount q. on the middle spot with ~15% zoom and the camera facing North it was clicking the spot when its already fishing. zoomed in a bit and doesnt seem to be doing it anymore.

    keep up the great work!

  2. #77
    Join Date
    Mar 2013
    Posts
    4
    Mentioned
    0 Post(s)
    Quoted
    2 Post(s)

    Default

    Quote Originally Posted by EZ41 View Post
    noticed a couple quirks with 1.3

    theres an issue changing tabs on resizable modern, resizable classic works fine.

    at mount q. on the middle spot with ~15% zoom and the camera facing North it was clicking the spot when its already fishing. zoomed in a bit and doesnt seem to be doing it anymore.

    keep up the great work!
    Have noticed the clicking of fishing spots as well.. I usually keep my camera fairly zoomed out and it was spam clicking the spot at Grotto.

    Minnows do seem to be going a lot smoother though!

  3. #78
    Join Date
    Aug 2007
    Location
    Colorado
    Posts
    7,371
    Mentioned
    267 Post(s)
    Quoted
    1420 Post(s)

    Default

    Quote Originally Posted by EZ41 View Post
    noticed a couple quirks with 1.3

    theres an issue changing tabs on resizable modern, resizable classic works fine.

    at mount q. on the middle spot with ~15% zoom and the camera facing North it was clicking the spot when its already fishing. zoomed in a bit and doesnt seem to be doing it anymore.

    keep up the great work!
    Quote Originally Posted by Tringy View Post
    Have noticed the clicking of fishing spots as well.. I usually keep my camera fairly zoomed out and it was spam clicking the spot at Grotto.

    Minnows do seem to be going a lot smoother though!
    Alright I believe I know where this issue originated at. I had increased the accuracy of fishing detection while pole fishing so much that I made an adjustment elsewhere to further refine accuracy for our player VS those fishing next to us, though I never actually saw false positives to begin with. So I'll change this back quickly and try it myself.

    The tab-switching issue I don't believe I've seen before; would you mind describing that one a bit more in detail? It may be something I'll have to patch up in the include itself as the script relies solely on the include for that.

    Edit:
    I believe I've patched it. Would either of you two be willing to test out the patched version for me to see if the problem has been fixed?
    Last edited by Flight; 11-23-2021 at 02:11 PM.

    Current projects:
    [ AIO Crafter, Auto-SlayerR&D, SRL-OSR ]

    "I won't fall in your gravity. Open your eyes,
    you're the Earth and I'm the sky..."


  4. #79
    Join Date
    Mar 2013
    Posts
    4
    Mentioned
    0 Post(s)
    Quoted
    2 Post(s)

    Default

    Quote Originally Posted by Flight View Post
    Alright I believe I know where this issue originated at. I had increased the accuracy of fishing detection while pole fishing so much that I made an adjustment elsewhere to further refine accuracy for our player VS those fishing next to us, though I never actually saw false positives to begin with. So I'll change this back quickly and try it myself.

    The tab-switching issue I don't believe I've seen before; would you mind describing that one a bit more in detail? It may be something I'll have to patch up in the include itself as the script relies solely on the include for that.

    Edit:
    I believe I've patched it. Would either of you two be willing to test out the patched version for me to see if the problem has been fixed?
    Would be definitely happy to test it out for you.

  5. #80
    Join Date
    May 2013
    Posts
    96
    Mentioned
    1 Post(s)
    Quoted
    32 Post(s)

    Default

    sure.

    edit: re the tabs, I think I was mistaken and this might be something to do with my setup or some weirdness when ive had simba open too long, i went back and it was happening in resizeable classic. set it to resizable modern, restarted simba and the client, and it worked fine.

    but its very obvious when it happens, ill start the script and when it goes to check the zoom it will either hover settings and seemingly not click or it, or click the wrong tab. it looks very suspect so i usually kill it manually but i think eventually it gives up.

    sorry for any inconvenience.

  6. #81
    Join Date
    Feb 2007
    Posts
    107
    Mentioned
    0 Post(s)
    Quoted
    13 Post(s)

    Default

    Thanks for 1.3, testing a bit now.

    Fishing at the fishing guild seems to work fine.
    +---| STATS |----------------------------------------
    |- Script Runtime : 01h 56m 16s
    |- XP gained : 50560(26089 / hr)
    |- Fishing for : Tuna
    |- Fish caught : 567(293 / hr)
    |- Until break : 00:34:26
    |- Until shutdown : 02h 14m 03s

    One progress report, but has been running for longer in total.

    Some feedback:
    1. When banking the delay should be like 0,5 seconds longer when trying to bank fish. Right now it click to bank tuna and swordfish and then tries to bank swordfish again however it already banked. Happens like 50% of the time.
    2. When banking it would make more sense to just set banking options to "All" and just 1-click left click mouse on fish to bank.
    3. Any way to add fishing without harpoon as an option? Got barbarian harpoon fishing unlocked.
    4. Haven't gotten stuck at all at the guild.

    Do You think adding Karambwan fishing option would be too difficult? With fairy rings.

    //Something more I noticed.
    5. Exiting the bank by the "X" in the top corner. A legit player would never even click there, but they would just click on the minimap to return to the fishing spot.
    6. Sometimes the script idles too long. Lets say a legit player would use Runelite and have an idle notification enabled for 5 seconds. So a player wouldn't really just stand for more than 5 seconds at a time (with expetions of course). However the script sometimes idles too long when returning to the fishing spots or when a fishing spot disappears (for 10-20 seconds and I don't mean the antiban random idling). Is there a way to speed up the scripts checking for idling?
    Last edited by inkw10; 11-29-2021 at 12:16 PM.

  7. #82
    Join Date
    Aug 2007
    Location
    Colorado
    Posts
    7,371
    Mentioned
    267 Post(s)
    Quoted
    1420 Post(s)

    Default

    Quote Originally Posted by inkw10 View Post
    Thanks for 1.3, testing a bit now.

    Fishing at the fishing guild seems to work fine.
    +---| STATS |----------------------------------------
    |- Script Runtime : 01h 56m 16s
    |- XP gained : 50560(26089 / hr)
    |- Fishing for : Tuna
    |- Fish caught : 567(293 / hr)
    |- Until break : 00:34:26
    |- Until shutdown : 02h 14m 03s

    One progress report, but has been running for longer in total.

    Some feedback:
    1. When banking the delay should be like 0,5 seconds longer when trying to bank fish. Right now it click to bank tuna and swordfish and then tries to bank swordfish again however it already banked. Happens like 50% of the time.
    2. When banking it would make more sense to just set banking options to "All" and just 1-click left click mouse on fish to bank.
    3. Any way to add fishing without harpoon as an option? Got barbarian harpoon fishing unlocked.
    4. Haven't gotten stuck at all at the guild.

    Do You think adding Karambwan fishing option would be too difficult? With fairy rings.

    //Something more I noticed.
    5. Exiting the bank by the "X" in the top corner. A legit player would never even click there, but they would just click on the minimap to return to the fishing spot.
    6. Sometimes the script idles too long. Lets say a legit player would use Runelite and have an idle notification enabled for 5 seconds. So a player wouldn't really just stand for more than 5 seconds at a time (with expetions of course). However the script sometimes idles too long when returning to the fishing spots or when a fishing spot disappears (for 10-20 seconds and I don't mean the antiban random idling). Is there a way to speed up the scripts checking for idling?
    Great feedback and suggestions, thanks for this.

    1) Dully noted. I have a separate banking routine from a different script that I will introduce into AIO Fisher which should improve the human-like touch and speed alike.
    2) This is the way I've always personally banked therefore it's what I stuck with. I couldn't say how many players prefer to use the All quantity button when depositing but I agree it's good idea to go ahead and switch that over.
    3) I had planned on this in the past but never got around to it. If I've the time I'll add this as an option.
    4) Karambwan fishing: possibly in the future but no immediate plans to do this.
    5) Unless you're walking via the mainscreen, then manually exiting the bank screen is required.
    6) When returning to a fishing spot (from banking or cooking) the script should begin searching for spots immediately, so I'm not sure how your described situation is occurring. The idle after a spot disappears can be explained through an instance such as players walking/animating very close to your player even though you're currently idle. This sends a false positive to the script that your player is currently fishing, depending on fishing modes.

    Now that I have a weekend available I'll spend some time and hopefully release 1.35. Best case scenario, within the next couple of days.


    Edit:
    Updated to version 1.35
    • Patched fly-fishing bug
    • Improved banking
    • Improved dropping speed
    • Improved logic of switching spots when inventory is nearly full

    For those of you using powerfishing mode you should notice a sizable increase in XP/Hour.
    Last edited by Flight; Today at 12:20 AM.

    Current projects:
    [ AIO Crafter, Auto-SlayerR&D, SRL-OSR ]

    "I won't fall in your gravity. Open your eyes,
    you're the Earth and I'm the sky..."


Page 4 of 4 FirstFirst ... 234

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •