Results 1 to 4 of 4

Thread: Can someone please tell me what is wrong with this script?

  1. #1
    Join Date
    Sep 2007
    Posts
    41
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default Can someone please tell me what is wrong with this script?

    Okay, the problem with this script is that it doesn't seem to find the flag, cause after clicking a color, it goes automaticly on to the next command... Start with both players in the lumbridge bank (btw, if you try it out, you will have to re-adjust the color of the ladder, i will make an autocoloring once i get a chance):

    SCAR Code:
    {problem was solved, script removed from thread}
    http://www.fenjer.com/adnan/SRL/23/1...%20Chopper.png
    Well, it is finished, but it is too unsecure and it doesn't always work properly (1 out of 3 attempts fail), So I will stop scripting for a while, focusing on learning new functions and procedures to make this safer.

  2. #2
    Join Date
    Jun 2007
    Location
    Belgium
    Posts
    333
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Just had a quick look over your script
    SCAR Code:
    RadialWalk(9198640, 80, 90, 71, 0, 0);
      Flag;
      RadialWalk(MMRoadColor, 120, 90, 69, 0, 0);
    First, the radius can be a maximum of 70, second, it's better to go for a radius of 60, cause with the 70 radius one the flag might not show up on the minimap at the initial click, so your script will see it as the flag being gone and continue. If using a radius of 60 is not an option, then i suggest using a pauze before looking for the flag, like Wait(200 + Random(50)); That way the player will move towards the flag, so it shows up on to the minimap before it starts to look for it.

    Some other advice:
    - Replace Flag with FFlag(0), it does the same but FFlag has better failsafes.
    - Remove the FindFastRandoms procedure, FindNormalRandoms does it all
    - If possible, make your bitmaps smaller

  3. #3
    Join Date
    Nov 2007
    Posts
    155
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    just to let you know you dont need bitmap for your spells... you can you these functions for the includes folder {.Include SRL\SRL\skill\Magic.scar}:

    SCAR Code:
    {*******************************************************************************
    function CastSpell(SpellNumber: Integer): Boolean;
    By: Spky
    Description: Cast's the selected spell specified by SpellNumber,
    returns true if enough runes to complete.
    *******************************************************************************}


    {*******************************************************************************
    function Cast(TheSpell: String): Boolean;
    By: Wizzup?, Flyboy, Cheesehunk, Freddy
    Description: Cast's the selected spell, returns true if enough runes to complete.
    *******************************************************************************}


    and here are the spell numbers

    1: TheSpell := 'Home Teleport';
          2: TheSpell := 'Wind Strike';
          3: TheSpell := 'Confuse';
          4: TheSpell := 'Bolt Enchantment';
          5: TheSpell := 'Water Strike';
          6: TheSpell := 'Enchant Level 1 Jewelry';
          7: TheSpell := 'Earth Strike';
          8: TheSpell := 'Weaken';
          9: TheSpell := 'Fire Strike';
          10: TheSpell := 'Bones to Bananas';
          11: TheSpell := 'Wind Bolt';
          12: TheSpell := 'Curse';
          13: TheSpell := 'Bind';
          14: TheSpell := 'Low Level Alchemy';
          15: TheSpell := 'Water Bolt';
          16: TheSpell := 'Varrock Teleport';
          17: TheSpell := 'Enchant Level 2 Jewelry';
          18: TheSpell := 'Earth Bolt';
          19: TheSpell := 'Lumbridge Teleport';
          20: TheSpell := 'Telekinetic grab';
          21: TheSpell := 'Fire Bolt';
          22: TheSpell := 'Falador Teleport';
          23: TheSpell := 'Crumble Undead';
          24: TheSpell := 'House teleport';
          25: TheSpell := 'Wind Blast';
          26: TheSpell := 'Superheat Item';
          27: TheSpell := 'Camelot Teleport';
          28: TheSpell := 'Water Blast';
          29: TheSpell := 'Enchant Level 3 Jewelry';
          30: TheSpell := 'Iban Blast';
          31: TheSpell := 'Snare';
          32: TheSpell := 'Magic Dart';
          33: TheSpell := 'Ardougne teleport';
          34: TheSpell := 'Earth Blast';
          35: TheSpell := 'High Level Alchemy';
          36: TheSpell := 'Charge Water Orb';
          37: TheSpell := 'Enchant Level 4 Jewelry';
          38: TheSpell := 'Watchtower Teleport';
          39: TheSpell := 'Fire Blast';
          40: TheSpell := 'Charge Earth Orb';
          41: TheSpell := 'Bones to Peaches';
          42: TheSpell := 'Saradomin Strike';
          43: TheSpell := 'Claws of Guthix';
          44: TheSpell := 'Flames of Zamorak';
          45: TheSpell := 'Trollheim Teleport';
          46: TheSpell := 'Wind Wave';
          47: TheSpell := 'Charge Fire Orb';
          48: TheSpell := 'Ape Atoll teleport';
          49: TheSpell := 'Water Wave';
          50: TheSpell := 'Charge Air Orb';
          51: TheSpell := 'Vulnerability';
          52: TheSpell := 'Enchant Level 5 Jewelry';
          53: TheSpell := 'Earth Wave';
          54: TheSpell := 'Enfeeble';
          55: TheSpell := 'Teleother Lumbridge';
          56: TheSpell := 'Fire Wave';
          57: TheSpell := 'Entangle';
          58: TheSpell := 'Stun';
          59: TheSpell := 'Charge';
          60: TheSpell := 'Teleother Falador';
          61: TheSpell := 'Tele Block';
          62: TheSpell := 'Enchant Level 6 Jewelry ';
          63: TheSpell := 'Teleother Camelot';

  4. #4
    Join Date
    Sep 2007
    Posts
    41
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    I think I found out what the problem is: The entire Minimap constants (MMX1, MMY1, MMX2, MMY2) are out of position: it doesn't find the colors on the minimap, it doesn't put the compass into a north position when i tell it to MakeCompass('N'), it doesn't do radial walks, and it doesn't find any sort of flag function, no matter which one i use. I have ActivateClient in my script and pulled the cross hair on it before i start the script, but it still doesn't do what I tell it to do... what should I do? I am going to try re-installing scar, but could this have something to do with the new runescape graphical update?

    EDIT: I re-installed Scar, seems to work fine now, thanks for your help guys
    http://www.fenjer.com/adnan/SRL/23/1...%20Chopper.png
    Well, it is finished, but it is too unsecure and it doesn't always work properly (1 out of 3 attempts fail), So I will stop scripting for a while, focusing on learning new functions and procedures to make this safer.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Similar Threads

  1. What's wrong with this script?
    By daniiboy69 in forum OSR Help
    Replies: 1
    Last Post: 10-09-2008, 06:25 AM
  2. What Am I doing wrong with script?
    By mrpickle in forum OSR Help
    Replies: 6
    Last Post: 08-17-2008, 04:44 PM
  3. What's wrong with this script.
    By igotgrapes in forum OSR Help
    Replies: 4
    Last Post: 04-06-2008, 12:44 AM
  4. What's wrong with my script?
    By Zeta in forum OSR Help
    Replies: 2
    Last Post: 08-01-2007, 08:19 PM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •