Poll: What u think of my first script ?

Results 1 to 7 of 7

Thread: NoobieTanner

  1. #1
    Join Date
    Aug 2007
    Posts
    43
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default NoobieTanner

    Hi everyone,

    This is my first script ever i know it crashes and stuff but it is only my first scrip ...

    get all coins needed in first inv slot
    and all cowhides in first bank slot

    and fill in setup

  2. #2
    Join Date
    Feb 2008
    Posts
    29
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    If i had Cow Hides id test it but ive looked over it and it looks pretty nice :P

  3. #3
    Join Date
    Aug 2007
    Posts
    43
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Thanks, it was just first thing that came up to me.
    A tanner

  4. #4
    Join Date
    Dec 2006
    Location
    .̿̂̔͋͗̎̆ͥ̍̒ͤ͂̾̌̀̅
    Posts
    3,012
    Mentioned
    1 Post(s)
    Quoted
    3 Post(s)

    Default

    Walking looks a bit tricky.. And failsafes, pweeaze?

    SCAR Code:
    repeat
              FindColor(x,y,KebabColor,mmx1,mmy1,mmx2,mmy2);
              Wait(502+random(120));
              Mouse(x,y,1,1,true);
            until (FindColor(x,y,KebabColor,mmx1,mmy1,mmx2,mmy2));

    What if it never finds it? Then it'll just go on and on and on.. Plus findcolor isn't that good, I suggest FindColorTolerance or FindColorSpiralTolerance (sorry if i spelt one of the two wrong)... And that goes for other parts in the script too, not just this procedure.

    Now after reading it more I noticed other things...

    SCAR Code:
    procedure DepositLeather;
    begin
          Mouse(620,228,5,5,true);
          Mouse(665,227,5,5,false);
          ClickOption('All', 2);
          Wait(1000+random(150));
    end;

    I suggest first finding a leather in the inventory with for example a DTM, as what if there'd be for example a item from a random event in that spot, it wouldn't bank the leathers... And just generally coordinate clicking is not good (goes to other places in the script too).

    The TerminateScript; in the end isn't really needed as it'll end anyways. And once again, failsafes. I also suggest adding multiplayer to the script.

    Quite good for a first script, but it still lacks some things.

  5. #5
    Join Date
    Feb 2007
    Location
    South East England
    Posts
    2,906
    Mentioned
    2 Post(s)
    Quoted
    8 Post(s)

    Default

    Basic, but it works and compiles.

    Just it would be endless. And instead of letting them pick colours, if the colours are always the same you can pick it for them :]
    Jus' Lurkin'

  6. #6
    Join Date
    Feb 2008
    Posts
    11
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    I thought it worked pretty well. Good job.

    im not expert on scripts, so i can't figure out certain problems.

  7. #7
    Join Date
    Mar 2008
    Posts
    11
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Worked for me

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •