Results 1 to 6 of 6

Thread: What section of this script isn't working!?-

  1. #1
    Join Date
    Feb 2008
    Posts
    28
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default What section of this script isn't working!?-

    It's either a case or the 28 stank procedures ;D

    This is definitely my first script; and I wanted to try out cases. If I run the script, the script successfully logs in, withdraws from the 3rd bank slot, but does not go through the random burying process.

    I know the script has many inefficiencies; I would like only to know why it isn't clicking.

    (The Bn1-Bn28 is a simple way of me getting the script not to bury a bone twice; I'm just hoping for a first bury right now!)

    If you have any tips as to why none of the "stank" procedures aren't working; please let me know!

    The inefficiencies, no use of DTM's, ETC... will be fixed while I become a better scripter; as for now.... WHY WONT IT BURY!!!!

    SCAR Code:
    program PigGuysBury;
    {.Include Srl/Srl.scar}
    Var
    s, RadRand, Countuh, BN1, BN2, BN3, BN4, BN5, BN6, BN7, BN8, BN9, BN10, BN11, BN12, BN13, BN14, BN15, BN16, BN17, BN18, BN19, BN20, BN21, BN22, BN23, BN24, BN25, BN26, BN27, BN28: Integer ;


    Const
     LoadNumber= 5;
     POPS= 28;
    Procedure DeclarePlayers;
    begin
      NumberOfPlayers(1);
      CurrentPlayer := 0;
      Players[0].Name :='43';
      Players[0].Pass :='62';
      Players[0].Nick :='21';
      Players[0].Active := True;
      Players[0].Loc    := 'vwb' // used later... for now... I just need it working!!
     
    end;


    Procedure Taking;
    begin
     OpenBankFast('veb')      //Fill in bank info...
     wait(1000+random(800))    // veb = Varrock east, vwb = Varrock west
     Withdraw(1,1,0)            // feb = Fally east, fwb= Fally west
     Wait(2000+random(1234))     // db = Draynor bank, lb = Lumby bank
     CloseBank                    // Theres more; I just MENTAL BLOKKED!
     Wait(100+random(900))
     FindNormalRandoms
    end;

    Procedure NoobyScriptPart;
    Begin
     Countuh :=-1
     s :=-1
     BN1 :=0
     BN2 :=0
     BN3 :=0
     BN4 :=0
     BN5 :=0
     BN6 :=0
     BN7 :=0
     BN8 :=0
     BN9 :=0
     BN10 :=0
     BN11 :=0
     BN12 :=0
     BN13 :=0
     BN14 :=0
     BN15 :=0
     BN16 :=0
     BN17 :=0
     BN18 :=0
     BN19 :=0
     BN20 :=0
     BN21 :=0
     BN22 :=0
     BN23 :=0
     BN24 :=0
     BN25 :=0
     BN26 :=0
     BN27 :=0
     BN28 :=0
    end;

    Procedure stank1;
    begin;
     if BN1 = 1 then exit;
          begin;
          Mousebox(564, 213, 594, 243, 0);
          BN1 := 1;
          end;
    end;

    Procedure stank2;
    begin;
     if BN2 = 2 then exit;
          begin;
          Mousebox(607, 213, 636, 243, 0)
          BN2 := 2
          end;
    end;

    Procedure stank3;
    begin;
     if BN3 = 3 then exit;
          begin;
          Mousebox(650, 213, 678, 243, 0)
          BN3 := 3
          end;
    end;

    Procedure stank4;
    begin;
     if BN4 = 4 then exit;
          begin;
          Mousebox(693, 213, 720, 243, 0)
          BN4 := 4
          end;
    end;

    Procedure stank5;
    begin;
     if BN5 = 5 then exit;
          begin;
          Mousebox(564, 250, 594, 280, 0)
          BN5 := 5
          end;
    end;

    Procedure stank6;
    begin;
     if BN6 = 6 then exit;
          begin;
          Mousebox(607, 250, 636, 280, 0)
          BN6 := 6
          end;
    end;

    Procedure stank7;
    begin;
     if BN7 = 7 then exit;
          begin;
          Mousebox(650, 250, 768, 280, 0)
          BN7 := 7
          end;
    end;

    Procedure stank8;
    begin;
     if BN8 = 8 then exit;
          begin;
          Mousebox(693, 250, 720, 280, 0)
          FindNormalRandoms
          BN8 := 8
          end;
    end;

    Procedure stank9;
    begin;
     if BN9 = 9 then exit;
          begin;
          Mousebox(564, 287, 594, 317, 0)
          BN9 := 9
          end;
    end;

    Procedure stank10;
    begin;
     if BN10 = 10 then exit;
          begin;
          Mousebox(607, 287, 636, 317, 0)
          BN10 := 10
          end;
    end;

    Procedure stank11;
    begin;
     if BN11 = 11 then exit;
          begin;
          Mousebox(650, 287, 678, 317, 0)
          FindNormalRandoms
          BN11 := 11
          end;
    end;

    Procedure stank12;
    begin;
     if BN12 = 12 then exit;
          begin;
          Mousebox(693, 287, 720, 317, 0)
          BN12 := 12
          end;
    end;

    Procedure stank13;
    begin;
     if BN13 = 13 then exit;
          begin;
          Mousebox(564, 324, 594, 354, 0)
          BN13 := 13
          end;
    end;

    Procedure stank14;
    begin;
     if BN14 = 14 then exit;
          begin;
          Mousebox(607, 324, 636, 354, 0)
          FindNormalRandoms
          BN14 := 14
          end;
    end;

    Procedure stank15;
    begin;
     if BN15 = 15 then exit;
          begin;
          Mousebox(650, 324, 678, 354, 0)
          BN15 := 15
          end;
    end;

    Procedure stank16;
    begin;
     if BN16 = 16 then exit;
          begin;
          Mousebox(693, 324, 720, 354, 0)
          FindNormalRandoms
          BN16 := 16
          end;
    end;

    Procedure stank17;
    begin;
     if BN17 = 17 then exit;
          begin;
          Mousebox(564, 361, 594, 391, 0)
          BN17 := 17
          end;
    end;

    Procedure stank18;
    begin;
     if BN18 = 18 then exit;
          begin;
          Mousebox(607, 361, 636, 391, 0)
          BN18 := 18
          end;
    end;

    Procedure stank19;
    begin;
     if BN19 = 19 then exit;
          begin;
          Mousebox(650, 361, 678, 391, 0)
          FindNormalRandoms
          BN19 := 19
          end;
    end;

    Procedure stank20;
    begin;
     if BN20 = 20 then exit;
          begin;
          Mousebox(693, 361, 720, 391, 0)
          BN20 := 20
          end;
    end;

    Procedure stank21;
    begin;
     if BN21 = 21 then exit;
          begin;
          Mousebox(564, 398, 594, 428, 0)
          FindNormalRandoms
          BN21 := 21
          end;
    end;

    Procedure stank22;
    begin;
     if BN22 = 22 then exit;
          begin;
          Mousebox(607, 398, 636, 428, 0)
          BN22 := 22
          end;
    end;

    Procedure stank23;
    begin;
     if BN23 = 23 then exit;
          begin;
          Mousebox(650, 398, 678, 428, 0)
          BN23 := 23
          end;
    end;

    Procedure stank24;
    begin;
     if BN24 = 24 then exit;
          begin;
          Mousebox(693, 398, 720, 428, 0)
          FindNormalRandoms
          BN24 := 24
          end;
    end;

    Procedure stank25;
    begin;
     if BN25 = 25 then exit;
          begin;
          Mousebox(564, 435, 594, 465, 0)
          BN25 := 25
          end;
    end;

    Procedure stank26;
    begin;
     if BN26 = 26 then exit;
          begin;
          Mousebox(607, 435, 636, 465, 0)
          FindNormalRandoms
          BN26 := 26
          end;
    end;

    Procedure stank27;
    begin;
     if BN27 = 27 then exit;
          Begin;
          Mousebox(650, 435, 678, 465, 0)
          FindNormalRandoms
          BN27 := 27
          end;
    end;

    Procedure stank28;
    begin;
     if BN28 = 28 then exit;
          Begin;
          Mousebox(693, 435, 720, 465, 0)
          BN28 := 28
          end;
    end;

    Procedure Burying;
    Begin;
    wait(3000+random(4000))
     s := s+1
     RadRand := 1+(Random(28))
      Case 1+(random(28)) of
    1: Stank1;
    2: Stank2;
    3: Stank3;
    4: Stank4;
    5: Stank5;
    6: Stank6;
    7: Stank7;
    8: Stank8;
    9: Stank9;
    10: Stank10;
    11: Stank11;
    12: Stank12;
    13: Stank13;
    14: Stank14;
    15: Stank15;
    16: Stank16;
    17: Stank17;
    18: Stank18;
    19: Stank19;
    20: Stank20;
    21: Stank21;
    22: Stank22;
    23: Stank23;
    24: Stank24;
    25: Stank25;
    26: Stank26;
    27: Stank27;
    28: Stank28;
    end;
    end;
    begin
     SetUpSrl;
      DeclarePlayers;
       NoobyScriptPart;
        LoginPlayer;
         Taking;
           Burying;
    end.

  2. #2
    Join Date
    Apr 2007
    Location
    Perth, Australia
    Posts
    3,926
    Mentioned
    3 Post(s)
    Quoted
    2 Post(s)

    Default

    The last parameter of MouseBox (which you have as 0) can only be 1, 2 or 3. 1 for moving and left clicking the mouse. 2 For moving and right clicking and 3 for just moving. Since you've got 0, it won't do anything.

  3. #3
    Join Date
    Feb 2008
    Posts
    28
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Ya see; in the SRL guide it said true false or none; then i had put true; it gave an error!!!



    *Bows in praise*

    I love the fact that there are *nearly* no noob bashers in here =D

  4. #4
    Join Date
    Apr 2007
    Location
    Perth, Australia
    Posts
    3,926
    Mentioned
    3 Post(s)
    Quoted
    2 Post(s)

    Default

    Quote Originally Posted by wasapiguy2 View Post
    I love the fact that there are *nearly* no noob bashers in here =D
    I wouldn't bet on that. As long as you don't act too nooby and follow the rules you should be fine.

  5. #5
    Join Date
    Feb 2008
    Posts
    28
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Well nooby is going to be hard for me to stay away from for a little while; until I finish this learning script =D.

    And following the rules (IRONY ALERT: "Following the rules on a site meant to distribute quickly and efficiently scripts breaking Jagex's Terms of Use") is pretty easy to do, and so far I personally haven't run into a noob basher.


    (JustOneMoreThing: Could you point me onto a good tut to make a non-smart script into a smart one? Ive been looking for a while and I just can't find a good tutorial, no matter how InFrontOfMyFace it is.
    *And I don't want to take the shortcut and edit the SRL.Scar and Smart.Scar; I want to be able to give a script to someone and let them hit "Play" and be done with it.*)

  6. #6
    Join Date
    Aug 2007
    Location
    Georgia, U.S.
    Posts
    890
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    just go to the smart section. there are good tuts there.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •