It's an ok script. There are a couple things that you could do to improve it.
1:
SCAR Code:
procedure clear;
begin
a:=0;
end;
Is there any need of doing this? You can just define "a" as 0 when you want to revert it back to 0 INSIDE another procedure. You don't have to make another one for that purpose only. The only time you would make a procedure for defining variables as 0 would be if you have MANY variables to revert.
2:
ALL integer values for undefined variables are automatically defined as 0 for its next use. So you didnt need to put z:=0 at all.
3:
SCAR Code:
Procedure walksmelter;
begin
Mouse(570, 50, 2, 2, True);
wait(4000);//Why did you put a wait function?
fflag(8);
mouse(556,50,2,2,true);
wait(6000);//Why did you put a wait function?
fflag(8);
end;
There was no purpose in putting a wait function for that procedure. What the function FFlag does (in essence) is it waits for the Flag to be in range before continuing onto the next procedure. There would be no point in putting a Wait function in there.
4:
You probably shouldn't use exact coordinates to make a flag present. Why don't you use radialwalk? There are plenty of Tutorials around: 1,2,3.
This script called the Radial Walk Aid- by YakMan can help you Radial Walk Later (I have attached it below.)
5:
You probably didn't have to do this. Fflag(1) is almost the same as Flag or FFlag(0);
6:
*Gasp* I just looked at the script and it neither has "consts" or a "DeclarePlayer"! Those are so important for random events, antibans, and logins. You should probably add them in...
7:
SCAR Code:
end else Writeln('Could not open bank');
mouse(195,236,2,2,true)
OpenBankQuiet('feb');
wait(1000);
deposit(1,1,true);
Make sure that every time you use an "end else" followed up with a number of functions over 1 you use a begin and end. Like so....
SCAR Code:
end else
begin
Writeln('Could not open bank');
mouse(195,236,2,2,true)
OpenBankQuiet('feb');
wait(1000);
deposit(1,1,true);
end;
//continue script;
8:
I can honestly say that you have very poor standards. This is what you did.
SCAR Code:
procedure clear;
begin
a:=0;
end;
Procedure startbank;
begin
z:=0;
z:=z+1;
Withdraw(1,1,5);
wait(1000)
withdraw(2,1,20);
closebank;
end;
Procedure walksmelter;
begin
Mouse(570, 50, 2, 2, True);
wait(4000);
fflag(8);
mouse(556,50,2,2,true);
wait(6000);
fflag(8);
end;
This is what a perfectly standarded script should look like...
SCAR Code:
procedure clear;
begin
a:=0;
end;
procedure startbank;
begin
z:=0;
z:=z+1;
Withdraw(1,1,5);
wait(1000)
withdraw(2,1,20);
closebank;
end;
procedure walksmelter;
begin
Mouse(570, 50, 2, 2, True);
wait(4000);
fflag(8);
mouse(556,50,2,2,true);
wait(6000);
fflag(8);
end;
//rest of script with these standards.
Anyway those were some of my comments. However, I do wish to address that you don't have that many backup failsafes to better your script. What happens in case of antirandoms, legit players, and if the character gets stuck. Good luck with your script.
~Rep me if I helped.