Results 1 to 11 of 11

Thread: smelter and banker at Falador

  1. #1
    Join Date
    May 2008
    Posts
    15
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default smelter and banker at Falador

    this is my first script so any help would be great. so far it only smelts mith bars. put mith in first bank slot and coal in the second. face north and look strait down. and start with your bank open. this script is still pretty bata other then that have fun and good luck.

  2. #2
    Join Date
    Dec 2006
    Posts
    3
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    good beta version...though it did get lost after it smelted 40 bars and i ended up in west fally...not sure what happened

  3. #3
    Join Date
    Nov 2007
    Location
    Poland
    Posts
    139
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Remember!! Never use coordinate clicking!!

  4. #4
    Join Date
    May 2008
    Location
    in front of computer
    Posts
    13
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    is it smart to use this script or can i use better a other smelt script

  5. #5
    Join Date
    May 2008
    Posts
    21
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    This script works beautifully for me

    I can do about 300 bars before something happens like a random that messes it up, but other than that if you start in the right spot it won't mess up. Does this have anti-random?

  6. #6
    Join Date
    Feb 2008
    Posts
    41
    Mentioned
    1 Post(s)
    Quoted
    12 Post(s)

    Default

    nice script, I used it for a while.

  7. #7
    Join Date
    Jan 2008
    Location
    Stanford, CA
    Posts
    329
    Mentioned
    0 Post(s)
    Quoted
    1 Post(s)

    Default

    It's an ok script. There are a couple things that you could do to improve it.

    1:
    SCAR Code:
    procedure clear;
    begin
    a:=0;
    end;

    Is there any need of doing this? You can just define "a" as 0 when you want to revert it back to 0 INSIDE another procedure. You don't have to make another one for that purpose only. The only time you would make a procedure for defining variables as 0 would be if you have MANY variables to revert.

    2:
    SCAR Code:
    z:=0;

    ALL integer values for undefined variables are automatically defined as 0 for its next use. So you didnt need to put z:=0 at all.

    3:
    SCAR Code:
    Procedure walksmelter;
    begin
    Mouse(570, 50, 2, 2, True);
    wait(4000);//Why did you put a wait function?
    fflag(8);
    mouse(556,50,2,2,true);
    wait(6000);//Why did you put a wait function?
    fflag(8);
    end;

    There was no purpose in putting a wait function for that procedure. What the function FFlag does (in essence) is it waits for the Flag to be in range before continuing onto the next procedure. There would be no point in putting a Wait function in there.

    4:
    SCAR Code:
    mouse(556,50,2,2,true);

    You probably shouldn't use exact coordinates to make a flag present. Why don't you use radialwalk? There are plenty of Tutorials around: 1,2,3.
    This script called the Radial Walk Aid- by YakMan can help you Radial Walk Later (I have attached it below.)

    5:
    SCAR Code:
    fflag(1);

    You probably didn't have to do this. Fflag(1) is almost the same as Flag or FFlag(0);

    6:

    *Gasp* I just looked at the script and it neither has "consts" or a "DeclarePlayer"! Those are so important for random events, antibans, and logins. You should probably add them in...

    7:
    SCAR Code:
    end else Writeln('Could not open bank');
    mouse(195,236,2,2,true)
    OpenBankQuiet('feb');
    wait(1000);
    deposit(1,1,true);

    Make sure that every time you use an "end else" followed up with a number of functions over 1 you use a begin and end. Like so....

    SCAR Code:
    end else
      begin
        Writeln('Could not open bank');
        mouse(195,236,2,2,true)
        OpenBankQuiet('feb');
        wait(1000);
        deposit(1,1,true);
      end;
      //continue script;

    8:

    I can honestly say that you have very poor standards. This is what you did.

    SCAR Code:
    procedure clear;
    begin
    a:=0;
    end;
    Procedure startbank;
    begin
    z:=0;
    z:=z+1;
    Withdraw(1,1,5);
    wait(1000)
    withdraw(2,1,20);
    closebank;
    end;
    Procedure walksmelter;
    begin
    Mouse(570, 50, 2, 2, True);
    wait(4000);
    fflag(8);
    mouse(556,50,2,2,true);
    wait(6000);
    fflag(8);
    end;

    This is what a perfectly standarded script should look like...

    SCAR Code:
    procedure clear;
    begin
      a:=0;
    end;

    procedure startbank;

    begin
      z:=0;
      z:=z+1;
      Withdraw(1,1,5);
      wait(1000)
      withdraw(2,1,20);
      closebank;
    end;

    procedure walksmelter;

    begin
      Mouse(570, 50, 2, 2, True);
      wait(4000);
      fflag(8);
      mouse(556,50,2,2,true);
      wait(6000);
      fflag(8);
    end;
    //rest of script with these standards.



    Anyway those were some of my comments. However, I do wish to address that you don't have that many backup failsafes to better your script. What happens in case of antirandoms, legit players, and if the character gets stuck. Good luck with your script.

    ~Rep me if I helped.

  8. #8
    Join Date
    Aug 2007
    Posts
    16
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    It Dosnt run that long for me it dose like 114 bars and then stops????

  9. #9
    Join Date
    May 2008
    Posts
    21
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    markmccain has stopped working on this script and has since left this forum. He gave is bata to me and asked me to work on it since then i have spent some time on this script and the new and improved version is at http://www.villavu.com/forum/showthr...hlight=smelter

  10. #10
    Join Date
    Aug 2008
    Posts
    4
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    looks pretty good downloading it now

  11. #11
    Join Date
    Oct 2007
    Posts
    10
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default .

    i'll probably use it bit too

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Similar Threads

  1. Kave's Falador Smelter
    By Kave in forum RS3 Outdated / Broken Scripts
    Replies: 14
    Last Post: 12-16-2008, 02:36 PM
  2. [SRL][SS]Jini's Falador Smelter
    By Jinijini in forum First Scripts
    Replies: 29
    Last Post: 11-10-2008, 01:34 PM
  3. West falador bronze smelter
    By ihavefriends in forum RS3 Outdated / Broken Scripts
    Replies: 5
    Last Post: 05-19-2007, 07:19 PM
  4. West Falador Smelter
    By ngovil21 in forum RS3 Outdated / Broken Scripts
    Replies: 14
    Last Post: 02-11-2007, 09:48 AM
  5. a falador smelter!
    By the scar noob in forum RS3 Outdated / Broken Scripts
    Replies: 11
    Last Post: 12-30-2006, 06:24 PM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •