Results 1 to 15 of 15

Thread: West Falador Smelter

  1. #1
    Join Date
    Jun 2006
    Posts
    5
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default West Falador Smelter

    This is my first SCAR Script. I've spent a lot of time of it. Most of the code is my own, but I did tweak some of the SRL Functions to work better with my script.

    I tried using DTMs to find the road color, but they don't always work... If anyone could tell me of the best way to get the road color, that would be cool. I tried bitmaps, but they were always getting the wrong color.

    This script doesn't have multiplayers because I don't see the need to have multiple people running.


    As long as the road color is found it runs for me flawlessly.

    I didn't put in to many randoms because I have never gotten any other than talking ones and wanted the least amount of lag on my slow computer, although there might be too many other wasted stuff.

    Comments and constructive criticism would be nice. Also post progress reports would be appreciated.

    Remember to start from WEST Falador bank, NOT East Falador.

    Edit 1: Improved the Road DTMs I hope.

    Edit 2: Added TaraJunky's cexy Falador Road Color Finder and added it will nwo walk you to West Falador Bank if you are in East Falador Bank.

  2. #2
    Join Date
    Sep 2006
    Location
    Scripter's Heaven
    Posts
    455
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    very good, i probably wont look at it much about finding the road color, i would seriously suggest large DTMs set a very high tolerance for the color picked for the road, and pick the new color from where it finds that point on the DTM. there might be something special about RRW. idk, ask fawaki, i think he is very pround of it (i think he made it)

    And check out my pascal interpreter!
    <R0b0t1> No, really, I went to a bar and picked up a transvestite.

  3. #3
    Join Date
    Jun 2006
    Posts
    5
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Thanks for the quick reply. I looked at radial road walker and didn't find anything special. Also FindFaladorRoadColor wasn't working very well for me.

    I updated the DTM a little to what I find is more accurate and efficient.

    The script also should walk back from the furnace if start in the furnace.

  4. #4
    Join Date
    Mar 2006
    Posts
    3,051
    Mentioned
    1 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by ngovil21 View Post
    Thanks for the quick reply. I looked at radial road walker and didn't find anything special. Also FindFaladorRoadColor wasn't working very well for me.

    I updated the DTM a little to what I find is more accurate and efficient.

    The script also should walk back from the furnace if start in the furnace.
    Try this! Should be flawless.


    Code:
    function FindFallyRoadColor:integer;  // By Tarajunky
    var red,green,blue:integer;
    var TestColor,a,b,GenericFallyRoadColor:integer;
    begin
      GenericFallyRoadColor:=6518652;
      Flag;
      a:=595;
      b:=30;
      repeat
        b:=b+1;
        repeat;
          a:=a+1;
          if FindColorTolerance(x,y,GenericFallyRoadColor,a,b,700,120,60) then
          begin
            a:=x;
            b:=y;
            TestColor:=GetColor(x,y);
            red:=(TestColor mod 256);
            green:=((TestColor/256) mod 256);
            blue:=((TestColor/256) / 256);
            if Red-Green>=2 then if Red-Green<=15 then
            if Red-Blue>=20 then if Red-Blue<=30 then
            if Green-Blue>=10 then if Green-Blue<=26 then
            begin
              if GetColor(a+5,b+5)=TestColor then
              if GetColor(a+3,b+3)=TestColor then
              if GetColor(a,b+5)=TestColor then
              if GetColor(a+5,b)=TestColor then
              if GetColor(a,b+3)=TestColor then
              if GetColor(a+3,b)=TestColor then
              if GetColor(a+5,b+3)=TestColor then
              if GetColor(a+3,b+5)=TestColor then
              begin
                result:=TestColor;
                Writeln('Falador RoadColor = '+IntToStr(TestColor));
                exit;
              end;
            end;
          end else a:=700;
        until a>=700;
        a:=595;
      until b>=120;
      Writeln('Could not find Falador Road Color!');
      result:=0;
    end;
    Replace your roadcolor finding procedure with this and then call RoadColor:=FindFallyRoadColor in your script.

    Definitely let me know how it works for you!

  5. #5
    Join Date
    Jun 2006
    Posts
    5
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Wow thanks TaraJunky, that procedure works awesome. Way, way better then my nooby DTM method. No wonder you're a developer.

    Anyways now I added the ability to automatically walk from East Falador Bank to West Falador bank if you accidently didn't follow the directions.

  6. #6
    Join Date
    Mar 2006
    Posts
    3,051
    Mentioned
    1 Post(s)
    Quoted
    0 Post(s)

    Default

    You can remove the begins and ends from this part of the code...

    Code:
    'bronze' : begin bmp:= BronzeBar end;
          'iron' :   begin bmp:=IronBar end;
          'silver' : begin bmp:=SilverBar end;
          'steel' :  begin bmp:=SteelBar end;
          'gold' :   begin bmp:=GoldBar end;
          'mithril' : begin bmp:=MithrilBar end;
          'admantite' : begin bmp:=AdamantBar end;
          'rune' :     begin bmp:=RuniteBar end;
    Just have 'blah': bmp:=blahbar;

    You can also remove all the banking information for Varrock and Al kharid since you are never going to use it.

    Looks great. I don't have any smelters to test this with, so no progress reports. Clean up your standards a bit and post some progress reports yourself if you get new ones.


  7. #7
    Join Date
    Jun 2006
    Posts
    5
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Thanks for the feedback.

    I'll clean up the code a bit including a bunch of the unnecessary parentheses. Cut me some slack, this is my first script. Anyways thanx on the feedback. I think I'm going to start working on a Rimmington Miner and Banker.

  8. #8
    Join Date
    Oct 2006
    Posts
    119
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    I can hook you up with my methods for finding the road color that work very well for me if you would like... I'm still writing my first official RS2 script, so just PM or reply here saying so and ill try to come back and post it.

  9. #9
    Join Date
    Nov 2006
    Posts
    120
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Seems to work pretty good but i can't seem to get it to pick up the coal from the bank. When i select steel it just get iron, pauses, then walkes toward the furnace and freaks out because I have no coal lol. Any ideas? I looked through the script and it seemed ok. I'm no expert though. Any ideas?

    Ransom

    Edit: Maybe the bitmap isn't working anymore?

    Edit2: I replaced the CoalOre bitmap in the smithing skill include to

    SCAR Code:
    (13, 13, 'z78DA8D935B0EC4200845B724' +
           '4FF1B356BBFF258D2D7E38433BA9263744C309C29513310A17AA5' +
           '80418B0A57341FA5D7E02B49161A6460DCBAA7E2B9D1BA98A206D' +
           '1E071A8081A58E152BD4951C3439474D84AAC737B43EB6380D8FB' +
           '1936B7C85EE32EAD6430A758FDFD088477F283233CACE5F1A6928' +
           '286091B6EAA4C9E816E5A6C2396705E657349FC5AAD72C2C69E66' +
           '2A23B5767DED062550F9375CED48B7C435B3AFF8A663ADCE1F193' +
           'DFBE384F34E7D49CF8707DEF5E3EDD5E5DFD76A5C5DCE97061C6C' +
           '35D34990BEDAF9FA7329F35887126706F878943ECF04D7F0C1BF4' +
           '598FFF91AB2A23DD787BC89AB91F5BF1CFF4')

    Now it works flawlessly. But it does use over twice the memory as the old smaller bitmap.

  10. #10
    Join Date
    Jun 2006
    Posts
    5
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    @CamHart:No I have gotten the road color to work flawlessly thanx to tarajunky. Good luck with your first script.

    @Ransom:The problem wasn't with the SRL bitmaps. I had just set the tolerance levels of the bitmaps too high. I lowered them and now it shouldn't do that. All I hope now is that the tolerance isn't too low.

  11. #11
    Join Date
    Oct 2006
    Posts
    34
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    still dont work...


    r] (18347:10): Duplicate identifier 'FINDFALLYROADCOLOR' in script C:\Documents and Settings\Eigenaar\Local Settings\Temporary Internet Files\Content.IE5\P11O1HDG\WestFaladorSmelter[1].scar

  12. #12
    Join Date
    Jan 2007
    Posts
    5
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    rename the findfallyroadcolor function and the call for it to something else. I had the same problem but couldn't find what caused it, but a rename fixed it.

  13. #13
    Join Date
    Sep 2006
    Posts
    5,219
    Mentioned
    4 Post(s)
    Quoted
    1 Post(s)

    Default

    Because since srl 3.6 tarajunky's auto colors have been in srl, and this hasn't been updated since then.

  14. #14
    Join Date
    Dec 2006
    Posts
    2
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    nice just woundering has eny one been baned from it ?

  15. #15
    Join Date
    Dec 2006
    Location
    Helsinki, Finland
    Posts
    177
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Dunno, u maybe get banned with this, coz I can't see any antibans, but it's ur decide to run or not to run it.
    U can always put ur own antibans into it

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Similar Threads

  1. [SRL][SS]Jini's Falador Smelter
    By Jinijini in forum First Scripts
    Replies: 29
    Last Post: 11-10-2008, 01:34 PM
  2. smelter and banker at Falador
    By markmccain in forum First Scripts
    Replies: 10
    Last Post: 08-24-2008, 05:01 PM
  3. Fally West Smelter By SKy Scripter
    By SKy Scripter in forum RS3 Outdated / Broken Scripts
    Replies: 77
    Last Post: 12-04-2007, 03:15 PM
  4. West falador bronze smelter
    By ihavefriends in forum RS3 Outdated / Broken Scripts
    Replies: 5
    Last Post: 05-19-2007, 07:19 PM
  5. a falador smelter!
    By the scar noob in forum RS3 Outdated / Broken Scripts
    Replies: 11
    Last Post: 12-30-2006, 06:24 PM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •