Results 1 to 6 of 6

Thread: What do I need to add to make this script safer? And where?

  1. #1
    Join Date
    Nov 2008
    Posts
    30
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default What do I need to add to make this script safer? And where?

    SCAR Code:
    // Big thanks to bazzbarrett, Boreas, and Pur3bl00d

    //                         What this script does

    //Logs player in
    //Finds and walks to Varrock East Bank (player must be within range)
    //Opens bank screen quickly
    //Withdraws 14 Clay and 14 Filled Buckets (must be in first two bank slots)
    //Uses 1st inventory item with 15th inventory item
    //Makes "All" into Soft Clay
    //Deposits Soft Clay and Empty Buckets back into the bank
    //Withdraws 14 Clay and 14 Filled Buckets, and the process repeats
    //______________________________________________________________________________

    //                 Things to do before using this script

    //Buckets must be filled with water already.
    //Buckets and Clay must be in first two bank slots in the first row.
    //Have character standing within Varrock East Bank (preferably inside).
    //Fill out lines 26-29!

    Program ClaySoftener;
    {.include SRL/SRL.scar}

    Var
      X, Y, loadsdone : Integer;

    Const
    LoadsToDo     = 72; //Loads of soft clay to make (14 filled buckets and 14 hard clay needed per load)

    Procedure DeclarePlayers; //Used for normal randoms
    Begin
      HowManyPlayers := 1;
      NumberOfPlayers(HowManyPlayers);
      CurrentPlayer := 0;

      Players[0].Name        := '';
      Players[0].Pass        := '';
      Players[0].Nick        := '';
      Players[0].pin         := '';
      Players[0].Active      := True;
    End;

    Procedure CheckRandoms;
    Begin
      FindNormalRandoms;
      FindNonInventoryRandoms;
    End;

    Procedure Setup;
    Begin
      setupsrl;
      Disguise('Windows Media Player');
      ActivateClient;
      declareplayers;
      wait(1000+random(210));
      makecompass('S');   //Find out what this does!
      makecompass('N');   //Find out what this does!
      loadsdone :=0
    End;

    Procedure WithdrawClayAndBuckets;
    Begin
      if not loggedin then terminatescript;
      if not bankscreen then FindBank('veb');
        Begin
          wait(100+random(55))
          withdraw(2, 1, 14)
          wait(50+random(25))
          withdraw(1, 1, 14)
        End;
      checkrandoms;
      wait(120+random(50))
      closebank;
    end;

    Function UseClayAndBucket : Boolean;
    Begin
      Begin
        MouseItem(1, False);
        Wait(RandomRange(500, 1000));
        If ChooseOption('se') Then
          Begin
            MouseItem(15, True);
            Result := True;
          End;
      End;
    End;

    Procedure SoftenClay;
    Begin
      wait(554+random(120));
      setupsrl;
      FindNPCChatText('oft',Clickright);
      ChooseOption('Make All');
      wait(18000+random(2000));
    End;

    Procedure DepositSoftClayAndBuckets;
    Begin
      if not loggedin then terminatescript;
      if not bankscreen then FindBank('veb');
      checkrandoms;
      if not InvEmpty then DepositAll;
    End;

    Procedure MainLoop;
    Begin
      Repeat
        WithdrawClayAndBuckets;
        UseClayAndBucket;
        SoftenClay;
        DepositSoftClayAndBuckets;      //Add loads done
      Until (loadsdone=loadstodo)
    End;

    Begin                        
      ClearDeBug;
      Setup;
      ActivateClient;
      if not(loggedin) then
        Begin
          ActivateClient;
          loginplayer;
        End;
      Repeat
        MainLoop;
      Until(false);
    End.

    All I have is checkforrandoms at a few places and some "if...then terminatescript" Other than that, I don't really have any thing standing between me and a ban.

    Assuming that the script always withdraws buckets and clay and never anything else (this assumes no human error lol). What failsafes, antirandoms, and anti-ban should I add and where? I was looking through the tutorials, but quite a few of them seem to use methods that are no longer safe, so I figured posting here was my best bet.

    Thanks!!!!

    I'm new to scripting so please bear with me.

  2. #2
    Join Date
    Jan 2007
    Location
    the middle of know-where
    Posts
    1,308
    Mentioned
    0 Post(s)
    Quoted
    1 Post(s)

    Default

    Start by taking out your username and password.. post more later...

    SCAR Code:
    //////////////////////
    procedure AntiBan; ////Help from Aser////
     begin
      if not LoggedIn then Exit;
       case(Random(75)) of
        1:HoverSkill('skill goes here',False);
        7:GameTab(1);
        16:RandomMovement;
        20:HoverSkill('skill goes here',False);
        24:RandomMovement;
        37:BoredHuman;
        41:Wait(5000 + random(6000));
        57:GameTab(1);
        61:RandomMovement;
        73:BoredHuman;
       end;
     end;

    Try putting something like this in there.... you can change numbers and whatnot and change what you want it to do.


    Edit: thanks for changing that for him
    On vacation in NeverLand,
    Code:
    typedef int bool;
    enum { false, true };

  3. #3
    Join Date
    Dec 2007
    Location
    Williston, ND
    Posts
    3,106
    Mentioned
    0 Post(s)
    Quoted
    3 Post(s)

    Default

    left name and pass in there, changed it for you

    Check you pm's
    Proud owner of "Efferator" my totally boted main account!
    "You see, sometimes, science is not a guess" -Xiaobing Zhou (my past physics professor, with heavy Chinese accent)

  4. #4
    Join Date
    Nov 2008
    Posts
    30
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by Brain View Post
    left name and pass in there, changed it for you

    Check you pm's
    Thanks a million!

    Thought that would be the one mistake I would be sure not to make

    And thanks for the help anonymity, that looks like it will help my script become much safer.

    Any one else have help?

  5. #5
    Join Date
    May 2008
    Posts
    1,345
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Instead of wait(18000+random(2000)); while waiting, I suggest making yourself a Custom wait procedure that waits while it can find a bmp in the inventory, as well as checking for random events/stopping making clay. I can take a more detailed look in the morning, as it's like 10pm here.

  6. #6
    Join Date
    Oct 2008
    Location
    C:\Simba\Includes\
    Posts
    7,566
    Mentioned
    19 Post(s)
    Quoted
    180 Post(s)

    Default

    You don't need two ActivateClient's in there, only one is needed. Also, it is wise to check for randoms after almost every click. You also have a random setupsrl in the softenclay procedure. You only need to setupsrl once, in the beginning of the script. Here is what I did, sorry if I changed your script too much =/
    SCAR Code:
    // Big thanks to bazzbarrett, Boreas, and Pur3bl00d

    //                         What this script does

    //Logs player in
    //Finds and walks to Varrock East Bank (player must be within range)
    //Opens bank screen quickly
    //Withdraws 14 Clay and 14 Filled Buckets (must be in first two bank slots)
    //Uses 1st inventory item with 15th inventory item
    //Makes "All" into Soft Clay
    //Deposits Soft Clay and Empty Buckets back into the bank
    //Withdraws 14 Clay and 14 Filled Buckets, and the process repeats
    //______________________________________________________________________________

    //                 Things to do before using this script

    //Buckets must be filled with water already.
    //Buckets and Clay must be in first two bank slots in the first row.
    //Have character standing within Varrock East Bank (preferably inside).
    //Fill out lines 26-29!

    Program ClaySoftener;
    {.include SRL/SRL.scar}

    Var
      X, Y, loadsdone : Integer;

    Const
    LoadsToDo     = 72; //Loads of soft clay to make (14 filled buckets and 14 hard clay needed per load)

    Procedure DeclarePlayers; //Used for normal randoms
    Begin
      HowManyPlayers := 1;
      NumberOfPlayers(HowManyPlayers);
      CurrentPlayer := 0;

      Players[0].Name        := '';
      Players[0].Pass        := '';
      Players[0].Nick        := '';
      Players[0].pin         := '';
      Players[0].Active      := True;
    End;

    Procedure CheckRandoms; // Updated by Camo Kyle
    Begin
      FindNormalRandoms;
      FindNonInventoryRandoms;
      FindTalk;
      LampSkill := 'Crafting'; // Can change if wanted.
    End;

    Procedure AntiBan; // By Camo Kyle
    Begin
      If not LoggedIn then Exit;
        case random(60) of
         1 : MMouse(0, 0, 700, 500);
         2 : Hoverskill('Crafting', false);
         4 : BoredHuman;
         5 : RandomMovement;
         6 : GameTab(1);
        end;
    End;

    Procedure Setup;   // Fixed
    Begin
      Disguise('Windows Media Player');
      wait(1000+random(210));
      makecompass('S');   //Find out what this does!
      makecompass('N');   //Find out what this does!
      loadsdone :=0
    End;

    Procedure WithdrawClayAndBuckets;      // Added Randoms and AntiBan
    Begin
      if not loggedin then terminatescript;
      if not bankscreen then FindBank('veb');
        Begin
          wait(100+random(55))
          withdraw(2, 1, 14)
          CheckRandoms;
          wait(50+random(25))
          withdraw(1, 1, 14)
          CheckRandoms;
          AntiBan;
        End;
      wait(120+random(50))
      closebank;
    end;

    Function UseClayAndBucket : Boolean;    // Added a counter failsafe
    Var
      Counter : Integer;
    Begin
      if not LoggedIn then TerminateScript;
      Repeat
        MouseItem(1, False);
        Wait(RandomRange(500, 1000));
        If ChooseOption('se') Then
          Begin
            MouseItem(15, True);
            CheckRandoms;
            Result := True;
            AntiBan;
          end else
            Inc(Counter);
      Until ((Result = True) or (Counter = 10));  // Change counter # if needed
        if (Counter=10) then
        begin
          WriteLn('Couldn''t use clay with bucket.');
          Logout;
          TerminateScript;
        end;
    End;

    Procedure SoftenClay;        // Updated
    Begin
      if not LoggedIn then TerminateScript;
      wait(554+random(120));
      FindNPCChatText('oft',Clickright);
      ChooseOption('Make All');
      CheckRandoms;
      AntiBan;
      wait(18000+random(2000));
    End;

    Procedure DepositSoftClayAndBuckets;      // Updated
    Begin
      if not loggedin then terminatescript;
      if not bankscreen then FindBank('veb');
      if not InvEmpty then DepositAll;
      CheckRandoms;
      AntiBan;
    End;

    Procedure MainLoop;
    Begin
      Repeat
        WithdrawClayAndBuckets;
        UseClayAndBucket;
        SoftenClay;
        DepositSoftClayAndBuckets;      //Add loads done
      Until (loadsdone=loadstodo)
    End;

    Begin                 // Correctly setup
      ClearDeBug;
      Setupsrl;
      DeclarePlayers;
      ActivateClient;
      Setup;
      if not(loggedin) then
          loginplayer;
      Repeat
        MainLoop;
      Until(false);
    End.
    Hope this helps

    ~Camo
    Away for awhile, life is keeping me busy. | Want to get my attention in a thread? @Kyle Undefined; me.
    { MSI Phoenix || SRL Stats Sigs || Paste || Scripts || Quotes || Graphics }

    When posting a bug, please post debug! Help us, help you!

    I would love to change the world, but they won't give me the source code. || To be the best, you've got to beat the rest. || Logic never changes, just the syntax.
    If you PM me with a stupid question or one listed in FAQ, or about a script that is not mine, I will NOT respond.


    SRL is a Library of routines made by the SRL community written for the Program Simba. We produce Scripts for the game Runescape.


Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Similar Threads

  1. Whats safer?
    By Cookiemonster37 in forum News and General
    Replies: 5
    Last Post: 01-05-2009, 09:51 PM
  2. how to make this script
    By bloodydemon in forum OSR Help
    Replies: 4
    Last Post: 12-16-2008, 10:11 PM
  3. Would like to make a script with someone else...
    By Pwnt by Pwnt in forum RS3 Outdated / Broken Scripts
    Replies: 8
    Last Post: 03-24-2008, 08:49 AM
  4. Is it safer to use Unsigned Applet?
    By solarwind in forum Bot Information and Spottings
    Replies: 32
    Last Post: 05-21-2007, 04:52 AM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •