I am sorry. I dont own a Member account, so I cant check it...
But browsing through your code now:
PHP Code:
procedure login1;
begin
if(not(loggedin)) then LoginPlayer;
end;
Thats exactly what LoginPlayer does. Obsolete.
PHP Code:
procedure findbank1;
begin
makecompass('N');
if (FindSymbol(x,y, 'bank')) then
wait(2002 + random(6 * 6 / 2 + 5 - 2));
MMouse(x, y, 0, 0);
wait(1002 + random(40 * 2 / 2 + 6 - 1));
Mouse(x, y - 2, 0 , 0, true);
antirandoms;
flag;
end;
If you check for the banksymbol while walking, you will end up with the wrong x and y coords, since you wait at least 2 seconds, and the minimap has moved. It will miss the bank.
Does your pickflax procedure checks for not loggedin? otherwise please insert everywhere there is a chance of infinite loop:
PHP Code:
if not LoggedIn then Exit;
PHP Code:
procedure tospiningwheel;
.
.
.
FindBitMapTol(X, Y, ladder, 552, 8, 714, 148);
Mouse(x, y , 1 , 1, true);
.
.
.
end;
Make MouseClick more random. 1,1 randomisation is not enough, do at least 4,4!
PHP Code:
procedure Door;
begin
MakeCompass('N');
repeat
if FindObj(x, y, 'Door', 2453648, 5) then //Only one of the FindObj was necessary
begin
if IsUpText('Open') then //Only need to check for the 'Open' text
begin
Mouse(x, y, 0, 0, False);
Wait(500+Random(250)); //Use a random timing to reduce detectability
ChooseOption(x, y, 'Open');
Flag;
end else
Break;
end;
Wait(500+Random(500));
until(false);
antirandoms;
end;
What happens if this procedure doenst find the Door? Exactly, it loops....
There are more situations where you use repeat until, without a failsafe. Look for instance at my Draynor melter. There is a lot of loops in there, but all will failsafes. Eventually your script gets stuck somewhere in a loop for sure. Believe me, I have been there
Anything that can go wrong, will....
But, good clean code, easy to follow and I am sure it works even though I couldnt test it