I got a load of feedback
.
SCAR Code:
procedure FishOnce;
var xx, yy: Integer;
begin
FindObj(xx, yy, 'et Fis', 9798519, 15);
Mouse(xx, yy, 2, 3, True);
end;
Use FindObjCustom.
It works like this :
SCAR Code:
FindObjCustom(x,y,['uptext1','uptext2','uptext3'],[Color1,Color2,Color3],Tolerance);
It Doesn't fish once ! It will keep fishing until :
you get a level or
you get full inventory
So it wouldn't work.
I'd use it like this :
SCAR Code:
Procedure Fish;
begin
If Not(LoggedIn) then //If the player isn't logged in
begin //it will log in the player.
LoginPlayer;
FindNormalRandoms; //Finds if there are any randoms
end;
If (FindObjCustom(x,y,['ishing','et','pot'],[FishingSpotColor1,FishingSpotColor2,FishingSpotColor3],5)) then //Finds fishing spot
begin
GetMousePos(x,y);//Stores the mouse location (pos = position) in x and y.
Wait(100+random(25));
Mouse(x,y,0,0,true); //Clicks on fishing spot
repeat
Wait(100+random(25));
If (FindLvUp) then//You should have made this procedure, doesn't exist in SRL I think.
Break;
until(InvFull);//The loop with wait will be repeated until inventory is full.
end else //if it couldn't find fishing spot, it will TerminateScript (not a good idea).
begin
Writeln('Could not find fishing spot.');
TerminateScript;
end;
end;
SCAR Code:
procedure AntiBanRandoms;
begin
if FindNormalRandoms then Randoms:=Randoms+1;
if FindFight then
begin
RunAway('E', True, 0, 10000);
Randoms:=Randoms+1;
end;
case random(7) of
0: BoredHuman;
1: PickUpMouse;
2: RandomRClick;
3: RandomRClick;
4: RandomRClick;
5: PickUpMouse;
6: PickUpMouse;
end;
end;
becomes :
SCAR Code:
procedure AntiBanRandoms;
begin
if FindNormalRandoms then Randoms:=Randoms+1;
if FindFight then
begin
RunAway('E', True, 0, 10000);
Randoms:=Randoms+1;
end;
case random(7) of
0: BoredHuman;
1: PickUpMouse;
2,3,4: RandomRClick;
5,6: PickUpMouse;
end;
end;
I also reccomend to make some custom antiban, not to be mean but the one included in SRL is quite... Unefficient
.
SCAR Code:
procedure MainLoop;
begin
for ml:= 1 to LoadsToDo do begin
FishFull;
AntiBanRandoms;
DropAllExcept;
AntiBanRandoms;
end;
end;
No need for FishFull with my Fish procedure
.
SCAR Code:
SetupSRL;
SetupFishing;
DropAllExcept;
MainLoop;
Progress;
I never saw any "SetupFishing;" in there
.
I reccomend you to post a script when it can compile.
(Skipped over the smaller stuff).
For Logging in players use :
For logging out use :