ChooseOptionMulti + WizzyPlugin

[Nava2]

What is the purpose of the function exactly...? I don't get why your making it so complicated if its just to return all the TPAs that are do not match point from the TBox..? Unless i'm not understanding what your trying to do exactly...



~NS

It's the easiest and fastest way todo it.

[Nadeem]

Yes, I got it. I was thinking of something else at that time.

This is what I got, but its more less the same. I was thinking of maybe even making a pre-TPA gathering all the valid TBox points and if then for the filter at the end, but thats more time consuming :/

function ReturnPointsNotInTPA(const TotalTPA: TPointArray; Box: TBox): TPointArray;
var
  I, II, R, L, W, H: Integer;
  B: array of array of Boolean;
begin
  W := iAbs(Box.x2 - Box.x1);
  H := iAbs(Box.y2 - Box.y1);
  if (W = 0) or (H = 0) then
  begin
    SetLength(Result, 1);
    Result[0].x := -1;
    Result[0].y := -1;
    Exit;
  end;
  
  SetLength(B, W + 1, H + 1);
  SetLength(Result, (W + 1) * (H + 1));
  L := Length(TotalTPA) - 1;
  
  // This could also be, B[][] := PointInBox(TotalTPA[I], Box);
  for I := 0 to L do
    if (TotalTPA[I].x >= Box.x1) and (TotalTPA[I].x <= Box.x2) and
       (TotalTPA[I].y >= Box.y1) and (TotalTPA[I].y <= Box.y2) then
      B[TotalTPA[I].x - Box.x1][TotalTPA[I].y - Box.y1] := True;
  
  for I := 0 to W do
    for II := 0 to H do
      if not B[I][II] then
      begin
        Result[R].x := I + Box.x1;
        Result[R].y := II + Box.y1;
        R := R + 1;
      end;
      
  SetLength(B, 0, 0);
  SetLength(Result, R);
end;

~NS

[nielsie95]

Okay, so I have been playing with the ReturnPointsNotInTPA and I cannot seem to fix it.

Anyone else have any solutions? Here is what is in there:

Function ReturnPointsNotInTPA(Const TotalTPA: TPointArray; const Box: TBox): TPointArray;
var
  x, y, w, h, i, l: integer;
  B: Array of Array of Boolean;
begin;
  w := Box.x2 - Box.x1;
  h := Box.y2 - Box.y1;
  if (w = 0) and (h = 0) then
    Exit;
  SetLength(b, w + 1, h + 1);
  l := High(TotalTPA);
  x := 0;
  for i := 0 to l do
    if ((TotalTPA[i].x >= Box.x1) and (TotalTPA[i].x <= Box.x2) and
        (TotalTPA[i].y >= Box.y1) and (TotalTPA[i].y <= Box.y2)) then
    begin;
      Inc(x);
      B[TotalTPA[i].x-Box.x1][TotalTPA[i].y-Box.y1] := True;
    end;
  if x = 0 then
    Exit;
  SetLength(result,(w + 1) * (h + 1) - x);
  i := 0;
  for x := 0 to w do
    for y := 0 to h do
      if not B[x][y] then
      begin;
        Result[i].x := x + Box.x1;
        Result[i].y := y + Box.y1;
        Inc(i);
      end;
  SetLength(b,0);
end;

Remove the -x or add a check if you already set the point when counting x.
Also, see this.

EDIT: Nadeem's code should work too?

Although this is a bit over the top:

if (W = 0) or (H = 0) then
  begin
    SetLength(Result, 1);
    Result[0].x := -1;
    Result[0].y := -1;
    Exit;
  end;

[noidea]

I just redownloaded SRL and both my friend and I get [Runtime Error] : Exception: in line 584 in script C:\Program Files\SCAR 3.20\includes\SRL/SRL/Core/Text.scar
every time ChooseOption is called.
Thanks for working on this guys

[Daniel]

Never happened to me, never. Running Win7 with SCAR 3.20d, portable and non-portable. No problems

[Home]

I just redownloaded SRL and both my friend and I get [Runtime Error] : Exception: in line 584 in script C:\Program Files\SCAR 3.20\includes\SRL/SRL/Core/Text.scar
every time ChooseOption is called.
Thanks for working on this guys

Same thing Hopefully it will be fixed soon Thanks for your effort guys!


~Home

[Runescape Pro]

In a function i wrote that handles the gate for the cows south of falador, I use 2 things that in my mind set off the error i get.

error: Access violation at address 00529608 in module 'scar.exe'. Read of address 0000006C

I use "FindColorSpiralTolerance" and "ChooseOption".

heres the function:

Function HandleGate: boolean;
var
  G:TPoint;
begin
  G:=Point(3032, 3313);
  if not(loggedin) then exit;
  MyRandoms;
  if FindObjectEx(G, 7050, 5) then
  begin
    Writeln('Attempting to handle gate.');
    if (GetMyPos.x = 3031) then
    begin
      if FindColorSpiralTolerance(x, y, 5401208, 257, 183, 281, 237, 4) then
      begin
        MMouse(x, y, 2, 2);
        wait(100+Random(75));
        if IsUpText('pen') then
        begin
          Mouse(x, y, 0, 0, false);
          wait(100+Random(75));
          ChooseOption('pen');
          Writeln('Successfully opened gate. =D');
          GatesOpened:=GatesOpened+1;
        end else
        begin
          Writeln('Failed to find gate.');
          LogOut;
          TerminateScript;
        end;
      end else
      begin
        Writeln('Failed to find gate.');
        LogOut;
        TerminateScript;
      end;
    end else
    begin
      if FindColorSpiralTolerance(x, y, 5401208, 208, 119, 225, 225, 4) then
      begin
        MMouse(x, y, 2, 2);
        wait(100+Random(75));
        if IsUpText('pen') then
        begin
          Mouse(x, y, 0, 0, false);
          wait(100+Random(75));
          ChooseOption('pen');
          Writeln('Successfully opened gate. =D');
          GatesOpened:=GatesOpened+1;
        end else
        begin
          Writeln('Failed to find gate.');
          LogOut;
          TerminateScript;
        end;
      end else
      begin
        Writeln('Failed to find gate.');
        LogOut;
        TerminateScript;
      end;
    end;
  end else Writeln('Gate already open, walking in the cow pen now.');
end;

Can anyone help me? I think its a problem with scar, but i have no idea.

[Naum]

Try this my friend, I replaced the ChooseOption with a find text .

Function HandleGate: boolean;
var
  G:TPoint;
begin
  G:=Point(3032, 3313);
  if not(loggedin) then exit;
  MyRandoms;
  if FindObjectEx(G, 7050, 5) then
  begin
    Writeln('Attempting to handle gate.');
    if (GetMyPos.x = 3031) then
    begin
      if FindColorSpiralTolerance(x, y, 5401208, 257, 183, 281, 237, 4) then
      begin
        MMouse(x, y, 2, 2);
        wait(100+Random(75));
        if IsUpText('pen') then
        begin
          Mouse(x, y, 0, 0, false);
          wait(100+Random(75));
          ChooseOption('pen');
          Writeln('Successfully opened gate. =D');
          GatesOpened:=GatesOpened+1;
        end else
        begin
          Writeln('Failed to find gate.');
          LogOut;
          TerminateScript;
        end;
      end else
      begin
        Writeln('Failed to find gate.');
        LogOut;
        TerminateScript;
      end;
    end else
    begin
      if FindColorSpiralTolerance(x, y, 5401208, 208, 119, 225, 225, 4) then
      begin
        MMouse(x, y, 2, 2);
        wait(100+Random(75));
        if FindText(x, y, 'pen', UpChars, x, y, x + 100, y + 100) then
        begin
          Mouse(x, y, 0, 0, false);
          wait(100+Random(75));
          ChooseOption('pen');
          Writeln('Successfully opened gate. =D');
          GatesOpened:=GatesOpened+1;
        end else
        begin
          Writeln('Failed to find gate.');
          LogOut;
          TerminateScript;
        end;
      end else
      begin
        Writeln('Failed to find gate.');
        LogOut;
        TerminateScript;
      end;
    end;
  end else Writeln('Gate already open, walking in the cow pen now.');
end;

[Runescape Pro]

I'll try that, although it looks like you changed absolutely nothing. =\
maybe im blind.

EDIT: NVM, lol, i see it now. =]
i hope it works =]

EDIT again >.>: Didn't work, im still getting an access violation error. Im soooo confused. =[

[Nadeem]

Fine nielsie :P

Here:

function ReturnPointsNotInTPA(const TotalTPA: TPointArray; Box: TBox): TPointArray;
var
  I, II, R, L, W, H: Integer;
  B: array of array of Boolean;
begin
  W := iAbs(Box.x2 - Box.x1);
  H := iAbs(Box.y2 - Box.y1);
  if (W = 0) or (H = 0) then Exit;
  SetLength(B, W + 1, H + 1);
  SetLength(Result, (W + 1) * (H + 1));
  L := Length(TotalTPA) - 1;

  for I := 0 to L do
    if (TotalTPA[I].x >= Box.x1) and (TotalTPA[I].x <= Box.x2) and
       (TotalTPA[I].y >= Box.y1) and (TotalTPA[I].y <= Box.y2) then
      B[TotalTPA[I].x - Box.x1][TotalTPA[I].y - Box.y1] := True;

  for I := 0 to W do
    for II := 0 to H do
      if not B[I][II] then
      begin
        Result[R].x := I + Box.x1;
        Result[R].y := II + Box.y1;
        R := R + 1;
      end;
  SetLength(B, 0, 0);
  SetLength(Result, R);
end;

Hey, Try this:

Function HandleGate: boolean;
var
  G:TPoint;
  V: TIntegerArray;
begin
  G:=Point(3032, 3313);
  if not(loggedin) then exit;
  MyRandoms;
  if FindObjectEx(G, 7050, 5) then
  begin
    Writeln('Attempting to handle gate.');
    V := [257, 183, 281, 237, 4, 208, 119, 225, 225, 4];
    if (GetMyPos.x = 3031) then F := 0 else F := 5;
    if FindColorSpiralTolerance(x, y, 5401208, V[F], V[F+1], V[F+2], V[F+3], V[F+4]) then
    begin
      MMouse(x, y, 2, 2);
      wait(100+Random(75));
      if IsUpText('pen') then
      begin
        GetMousePos(x, y);
        Mouse(x, y, 0, 0, false);
        wait(100+Random(75));
        ChooseOption('pen');
        Writeln('Successfully opened gate. =D');
        GatesOpened:=GatesOpened+1;
      end else
      begin
        Writeln('Failed to find gate.');
        LogOut;
        TerminateScript;
      end;
    end else
    begin
      Writeln('Failed to find gate.');
      LogOut;
      TerminateScript;
    end;
  end else
    Writeln('Gate already open, walking in the cow pen now.');
end;

I shortened up the code, and added GetMousePos(); If that doesn't work, try increasing the characters used in ChooseOption? Ex: 'pen gat', 'Open'



~NS

[Shuttleu]

get srl dev rev 32
i done it and i havent got one runtime error since
something was changed in wizzyplugin in dev rev 33

~shut

[Naum]

Rune Pro: Sorry my bad use this:

Function HandleGate: boolean;
var
  G:TPoint;
begin
  G:=Point(3032, 3313);
  if not(loggedin) then exit;
  MyRandoms;
  if FindObjectEx(G, 7050, 5) then
  begin
    Writeln('Attempting to handle gate.');
    if (GetMyPos.x = 3031) then
    begin
      if FindColorSpiralTolerance(x, y, 5401208, 257, 183, 281, 237, 4) then
      begin
        MMouse(x, y, 2, 2);
        wait(100+Random(75));
        if IsUpText('pen') then
        begin
          Mouse(x, y, 0, 0, false);
          wait(100+Random(75));
          if FindText(x, y, 'pen', UpChars, x, y, x + 100, y + 100) then
            Mouse(x, y, 0, 0, True);
          Writeln('Successfully opened gate. =D');
          GatesOpened:=GatesOpened+1;
        end else
        begin
          Writeln('Failed to find gate.');
          LogOut;
          TerminateScript;
        end;
      end else
      begin
        Writeln('Failed to find gate.');
        LogOut;
        TerminateScript;
      end;
    end else
    begin
      if FindColorSpiralTolerance(x, y, 5401208, 208, 119, 225, 225, 4) then
      begin
        MMouse(x, y, 2, 2);
        wait(100+Random(75));
        if IsUpText('pen') Then
        begin
          Mouse(x, y, 0, 0, false);
          wait(100+Random(75));
          if FindText(x, y, 'pen', UpChars, x, y, x + 100, y + 100) then
            Mouse(x, y, 0, 0, True);
          Writeln('Successfully opened gate. =D');
          GatesOpened:=GatesOpened+1;
        end else
        begin
          Writeln('Failed to find gate.');
          LogOut;
          TerminateScript;
        end;
      end else
      begin
        Writeln('Failed to find gate.');
        LogOut;
        TerminateScript;
      end;
    end;
  end else Writeln('Gate already open, walking in the cow pen now.');
end;

That should work

[Runescape Pro]

The first one got this: [Error]: Access violation at address 00529608 in module 'scar.exe'. Read of address 00000280

second one: [Error]: Access violation at address 00529608 in module 'scar.exe'. Read of address 0000018C

I have no idea what could be wrong...

[Nadeem]

Hmm... Maybe try this on a different version of SCAR...? Or probably just do what Shuttleu's recommending, i.e: dl dev rev 32



~NS

[noidea]

Hmm... Maybe try this on a different version of SCAR...? Or probably just do what Shuttleu's recommending, i.e: dl dev rev 32



~NS

I just used 3.15b, and it worked. I then updated it's SRL, and then it stopped working.

Something has changed is the latestt revs

[Nava2]

Yes... The function ReturnPoints was changed.

[Nadeem]

Then maybe revert back to the previous one, or at least differentiate between what was changed to pin point error and come up with a better solution?



~NS

[noidea]

Here is the old plugin if any one wants.

[Nadeem]

nice post only one thing, its a dll...! a .dbr or .pas would've been better/easier IMO



~NS

[noidea]

Here. The dll was just for people that need to use. Here is the other

[Nava2]

I have an idea to fix it. Give me a few.

[Nava2]

Double posting, but does the newest one work?

[ZephyrsFury]

Double posting, but does the newest one work?

No, same error. Happens in ChooseOption for me.

[Nadeem]

What was there change? I'd like to see please



~NS

[Wizzup?]

Fine nielsie :P

Here:

function ReturnPointsNotInTPA(const TotalTPA: TPointArray; Box: TBox): TPointArray;
var
  I, II, R, L, W, H: Integer;
  B: array of array of Boolean;
begin
  W := iAbs(Box.x2 - Box.x1);
  H := iAbs(Box.y2 - Box.y1);
  if (W = 0) or (H = 0) then Exit;
  SetLength(B, W + 1, H + 1);
  SetLength(Result, (W + 1) * (H + 1));
  L := Length(TotalTPA) - 1;

  for I := 0 to L do
    if (TotalTPA[I].x >= Box.x1) and (TotalTPA[I].x <= Box.x2) and
       (TotalTPA[I].y >= Box.y1) and (TotalTPA[I].y <= Box.y2) then
      B[TotalTPA[I].x - Box.x1][TotalTPA[I].y - Box.y1] := True;

  for I := 0 to W do
    for II := 0 to H do
      if not B[I][II] then
      begin
        Result[R].x := I + Box.x1;
        Result[R].y := II + Box.y1;
        R := R + 1;
      end;
  SetLength(B, 0, 0);
  SetLength(Result, R);
end;

~NS

I honestly don't see the use for all those failsafes... If you just make sure you pass a correct box everything is well... I've already submitted a patch to nava which should fix the issue.

All this checking is just too much overhead IMO. If I start passing random params to Functions in SCAR it will most likely crash too. You can't add failsafes for everything...