Sorry, I don't do that. You need to read this page.
Sorry, I don't do that. You need to read this page.
SRL's F.A.Q. (Error fixes) | How to Convert SRL-5 Scripts to SRL-6 | Draynor Chop N' Bank (RS3)| AIO Superheater (RS3)
T - E - A - MTogether Everyone Achieves More
Script updated. A could things:
- The banking issue was in SRL, which I've fixed. The script should work when your SRL updates.
- The latest version of the script (Rev. 81) has updated Willow tree colors. This should improve accuracy and the script should no longer find the bridge west of the bank as another tree.
Enjoy,
Coh3n
SRL's F.A.Q. (Error fixes) | How to Convert SRL-5 Scripts to SRL-6 | Draynor Chop N' Bank (RS3)| AIO Superheater (RS3)
T - E - A - MTogether Everyone Achieves More
Do you have any idea when SRL is going to get an update? I want to try out your script but unfortunately, it doesn't bank very well so that's why I'm asking you this. Thanks in advance.
This is the banking issue you're talking about, right?
Code:[0:00:24]: ---- isMouseOverText() [0:00:24]: ------ Current mouse-over text: "Bank Counter" [0:00:24]: ------ Found "Bank" in mouse-over string: "Bank Counter" [0:00:24]: ---- isMouseOverText(): True [0:00:24]: ---- We found correct mouse-over text [0:00:35]: ---- Bankscreen or pinscreen never opened [0:00:35]: ---- isMouseOverText() [0:00:35]: ------ Current mouse-over text: "" [0:00:35]: ------ Current mouse-over text: "Withdraw-1 Yew shortL'ow 0gggBB i # st AFFgrgFX i @ze AggB i ArrBV TXFB i RgnBB4 gFBB4 i Fgs$ IBvBI i gg" [0:00:35]: ------ Current mouse-over text: "Withdraw-1 Yew shortL'ow 0gggBB i # st AFFgrgFX i @ze AggB i ArrBV TXFB i RgnBB4 gFBB4 i Fgs$ IBvBI i gg" [0:00:35]: ------ Current mouse-over text: "Withdraw-1 Yew shortL'ow 0gggBB i # st AFFgrgFX i @ze AggB i ArrBV TXFB i RgnBB4 gFBB4 i Fgs$ IBvBI i gg" [0:00:35]: ------ Current mouse-over text: "Withdraw-1 Yew shortL'ow 0gggBB i # st AFFgrgFX i @ze AggB i ArrBV TXFB i RgnBB4 gFBB4 i Fgs$ IBvBI i gg" [0:00:35]: ---- isMouseOverText(): False [0:00:35]: ---- Mouse-over text wasn't correct [0:00:35]: -- TRSBankscreen.__openNPC(): result = False [0:00:35]: ERROR: Bank_Logs: Failed to open bank, retrying... [0:00:36]: ERROR: Bank_Logs: Failed to find bank screen [0:00:36]: -- TRSGameTabs.openTab(2) [0:00:36]: ---- Opening tab via gametab navigation bar
No, that's a different problem. What I updated was the finding of the bank. According to that debug it's clicking the bank, but it's never detecting that it's open. Make sure your graphics are set properly. Sometimes the bank screen can move a few pixels, which messes up the finder.
The bankscreen detection is working. Unless there was an update since last night that broke it.
Last edited by Coh3n; 09-08-2014 at 02:34 PM.
SRL's F.A.Q. (Error fixes) | How to Convert SRL-5 Scripts to SRL-6 | Draynor Chop N' Bank (RS3)| AIO Superheater (RS3)
T - E - A - MTogether Everyone Achieves More
I just tested and everything worked like it should:
Make sure you reset your interfaces. Like I said before, the bankscreen can be accidentally shifted and needs to be reset. I've seen it happen several times before.Progress Report:-- TRSBankscreen.__openNPC() ---- TRSMinimap.getDots() ------ Found 22 minimap dots (ID: 0) ---- TRSMinimap.getDots(): [{X = 671, Y = 19}, {X = 671, Y = 23}, {X = 633, Y = 43}, {X = 729, Y = 57}, {X = 698, Y = 58}, {X = 673, Y = 63}, {X = 701, Y = 75}, {X = 631, Y = 80}, {X = 661, Y = 82}, {X = 771, Y = 82}, {X = 645, Y = 93}, {X = 664, Y = 96}, {X = 680, Y = 102}, {X = 680, Y = 106}, {X = 679, Y = 114}, {X = 679, Y = 118}, {X = 746, Y = 129}, {X = 682, Y = 142}, {X = 670, Y = 149}, {X = 743, Y = 154}, {X = 741, Y = 156}, {X = 743, Y = 160}] ---- isMouseOverText() ------ Current mouse-over text: "" ------ Current mouse-over text: "" ------ Current mouse-over text: "Bank Banker" ------ Found "Bank" in mouse-over string: "Bank Banker" ---- isMouseOverText(): True ---- We found correct mouse-over text ---- Bankscreen or pinscreen is open -- TRSBankscreen.__openNPC(): result = True Bankscreen is open.
SRL's F.A.Q. (Error fixes) | How to Convert SRL-5 Scripts to SRL-6 | Draynor Chop N' Bank (RS3)| AIO Superheater (RS3)
T - E - A - MTogether Everyone Achieves More
Yep you were right, something was messed up with the bankscreen, now it banks without any problem although I didn't touch any settings. Is it normal that it detects a lot of the environment as a tree? I understand that a lot of the colours in the area are very similar to each other but could this possibly be fixed by using bonsai's idea?
Everything seems to work fine though he spends like 4-5seconds at a tree no matter what i change the settings too
Current Rank Supreme Master First Class
SRL's F.A.Q. (Error fixes) | How to Convert SRL-5 Scripts to SRL-6 | Draynor Chop N' Bank (RS3)| AIO Superheater (RS3)
T - E - A - MTogether Everyone Achieves More
I don't know suddenly it has stopped working.. i updated my simba and i know i have my graphics and interfaces set up as required ,
though the script thinks im in bank when im not when he is actually standing at willwos .. so he will over click on the mini map so its just by elder tree and then fails to find willows ..
If i start it from the bank it clicks to the willows and does a tree or two and then fails after that .. it's hard to get what the debug box says because it spams it like crazy and ends the script where it clears it and just displays your proggy .. but i did manage to catch it before it cleared it and it said ..
any advice would be greatCode:[0:01:04]: ---- Found symbol bitmap 42 [0:01:04]: -- TRSMinimap._getSymbolColor(): -1 [0:01:04]: ERROR: Chop_Trees: Failed to find enough colors for tree [0:01:04]: DETAIL: Chop_Relocate: Relocating to trees [0:01:04]: -- TRSMinimap._getSymbolColor() [0:01:04]: ---- Loaded symbol: Fishing Spot [0:01:04]: ---- Found symbol bitmap 42 [0:01:04]: -- TRSMinimap._getSymbolColor(): -1 [0:01:04]: ERROR: Chop_Trees: Failed to find enough colors for tree [0:01:04]: DETAIL: Chop_Relocate: Relocating to trees [0:01:04]: -- TRSMinimap._getSymbolColor() [0:01:04]: ---- Loaded symbol: Fishing Spot [0:01:04]: ---- Found symbol bitmap 42 [0:01:04]: -- TRSMinimap._getSymbolColor(): -1 [0:01:04]: ERROR: Chop_Trees: Failed to find enough colors for tree [0:01:04]: DETAIL: Chop_Relocate: Relocating to trees [0:01:04]: -- TRSMinimap._getSymbolColor() [0:01:04]: ---- Loaded symbol: Fishing Spot [0:01:04]: ---- Found symbol bitmap 42 [0:01:04]: -- TRSMinimap._getSymbolColor(): -1 [0:01:04]: ERROR: Chop_Trees: Failed to find enough colors for tree [0:01:04]: DETAIL: Chop_Relocate: Relocating to trees [0:01:04]: -- TRSMinimap._getSymbolColor() [0:01:04]: ---- Loaded symbol: Fishing Spot [0:01:04]: ---- Found symbol bitmap 42 [0:01:04]: -- TRSMinimap._getSymbolColor(): -1 [0:01:04]: ERROR: Chop_Trees: Failed to find enough colors for tree [0:01:04]: DETAIL: Chop_Relocate: Relocating to trees [0:01:04]: -- TRSMinimap._getSymbolColor() [0:01:04]: ---- Loaded symbol: Fishing Spot [0:01:05]: ---- Found symbol bitmap 42 [0:01:05]: -- TRSMinimap._getSymbolColor(): -1 [0:01:05]: ERROR: Chop_Trees: Failed to find trees 60 times [0:01:05]: -- TPlayer.logout()
EDIT:
Well after some frustration .. i should have done this earlier insted of complaining .. i found the problem myself and seeing as the colour wasn't being found and asuming you used ACA to get the color ,hue,sat ect.. i did the same and it seems to be working fine again ..
anyone with that has a problem with the script not being able to find the tree i'd suggest to get the Auto Colour Aid tool
from here and load the image from client and set your settings to CTS 2 and then just pick the colors of the tree and not the leaves or anything as it may and im pretty sure it will think that the ground is the tree too xD
well anyways once you get all the colours just input these
into here
only change line 235 to 237 and line 239 with the numbers you get on the ACA.
I hope it works for whoever comes across this problem.. if not then ..im still learning XD
Current Rank Supreme Master First Class
what is TRS and what program do you use for script opener? im using simba, but for me not works
The location detection doesn't work. It relies on SRL's symbol finding, which doesn't work right now. It seems that the colors need to be updated often, which is annoying. I might implement a system to read the color settings from a server, so I don't have to release a new version of the script every time. We'll see if I get time.
In the meantime your post should help others with the same issue. Thanks for that.
You have to run it with Simba. You can't just post and say it doesn't work. No one can help you with that information.
SRL's F.A.Q. (Error fixes) | How to Convert SRL-5 Scripts to SRL-6 | Draynor Chop N' Bank (RS3)| AIO Superheater (RS3)
T - E - A - MTogether Everyone Achieves More
Great settings, somehow this works better for me, thanks!
Coh3n, I added a tiny bit of randomness to your script:
I've commented out minimap.clickCompass(); and added one with a random range, so it would turn the in game camera if it has to relocate for trees.Simba Code:function Chop_Relocate(tree: TTree): boolean;
var
p: TPoint;
tmpAcc: extended = minimap.symbolAccuracy;
begin
DcnB_Debug('Chop_Relocate', 'Relocating to trees', DEBUG_DETAILS);
minimap.symbolAccuracy := 0.6;
if (InRange(minimap.getAngleDegrees(), 10.0, 350.0)) then
begin
//minimap.clickCompass();
minimap.setAngle(randomRange(300, 360)); //added
mainscreen.setAngle(MS_ANGLE_HIGH);
end;
Then I've also added something at the of the Walk_ToLoc(which: Integer): Boolean; function so it would turn the in game camera when it has banked and arrived back at the trees:
Simba Code:Wait(500 + Random(500));
Players[CurrentPlayer].location := Walk_ConstToLoc(which);
DCnB_Debug('Walk_ToLoc', 'Walked to location: ' + Walk_ConstToLoc(which), DEBUG_SUCCESS);
if not tabBackpack.isFull() then //added
minimap.setAngle(randomRange(300, 360)); //added
end;
I don't know if this could be handy for someone but it kind of is for me.
EDIT: When it wants to log out (for example when it's time for a break) it just opens the options menu. I guess it's pressing the escape button. Is this a bug in SRL or is this because of Runescape's updates?
Last edited by Spaceblow; 09-12-2014 at 09:52 PM. Reason: spelling
I have the script setup correctly, but when I run it, it logs in and everything. It opens my backpack, and then I get:
Exception in Script: Runtime error: "Access violation" at line 873, column 35
Any help?
Last edited by SOmesand; 09-13-2014 at 10:55 PM.
Srry fail post, i forgiven how to setup the settings XD!
SRL's F.A.Q. (Error fixes) | How to Convert SRL-5 Scripts to SRL-6 | Draynor Chop N' Bank (RS3)| AIO Superheater (RS3)
T - E - A - MTogether Everyone Achieves More
I made sure my player info was correct. It seems like it cant find my current location. I'm not sure what I'm doing wrong. I tried starting at both the trees and at the bank. This is what I am getting.
[0:00:02]: -- TPlayerArray.setup(): Success
[0:00:02]: Loading, please wait...
[0:00:02]: -- TPlayer.login()
[0:00:02]: ---- Already logged in
[0:00:02]: ---- Logged in:
[0:00:02]: ------ TRSGameTab.__initTabs(): Setup gametab properties
[0:00:03]: -- TPlayer.login(): True
[0:00:03]: -- TRSMinimap._getSymbolColor()
[0:00:03]: ---- Loaded symbol: Fishing Spot
[0:00:03]: ---- Found symbol bitmap 42
[0:00:03]: -- TRSMinimap._getSymbolColor(): -1
[0:00:03]: PLAYER: Find_PlayerLocation: : Location = Bank
[0:00:03]: Exception in Script: Runtime error: "Access violation" at line 873, column 35
The following bitmaps were not freed: [Minimap Mask, SMART Debug Image, Gametab Bitmap[0], Gametab Bitmap[1], Gametab Bitmap[2], Gametab Bitmap[3], Gametab Bitmap[4], Gametab Bitmap[5], Gametab Bitmap[6], Gametab Bitmap[7], Gametab Bitmap[8], Gametab Bitmap[9], Gametab Bitmap[10], Gametab Bitmap[11], Gametab Bitmap[12], Gametab Bitmap[13]]
Last edited by SOmesand; 09-15-2014 at 07:19 PM. Reason: Thought I fixed issue. didn't.
The location part won't work since SRL's symbol finding doesn't work, so you can forget about that. As for the error, though, I don't know why that happens. What is line 873 in the script?
SRL's F.A.Q. (Error fixes) | How to Convert SRL-5 Scripts to SRL-6 | Draynor Chop N' Bank (RS3)| AIO Superheater (RS3)
T - E - A - MTogether Everyone Achieves More
Line 873 reads:
Players[CurrentPlayer].location := Find_PlayerLocation;
If i delete it, I get an access violation elsewhere that uses the player location.
That line is 584. Which reads:
if (Players[CurrentPlayer].location = Walk_ConstToLoc(which)) then
Deleting that line basically renders it useless as I get more errors, and I'm not able to script. I'd like to, but I need time to learn.
SRL's F.A.Q. (Error fixes) | How to Convert SRL-5 Scripts to SRL-6 | Draynor Chop N' Bank (RS3)| AIO Superheater (RS3)
T - E - A - MTogether Everyone Achieves More
I'm not exactly sure how to setup the declare players correctly. I looked at the tutorial on here, and the format in the script is different. It won't login. I start it logged in.
How would I setup this correctly?
Players.Setup(['Player''s Nickname/Login Name/Display Name'], 'PlayerFileName');
CurrentPlayer := 0;
I get the filename part, but the filling in of the names and everything boggles my mind...
SRL's F.A.Q. (Error fixes) | How to Convert SRL-5 Scripts to SRL-6 | Draynor Chop N' Bank (RS3)| AIO Superheater (RS3)
T - E - A - MTogether Everyone Achieves More
Seems to be working, but why does it click on the same tree every 1/2 seconds, even if it is chopping it?
I was finally able to get it to work!!!!! The script works great. keep up the good work!
There are currently 1 users browsing this thread. (0 members and 1 guests)