Results 1 to 25 of 25

Thread: [R] PotatoesArentWild

  1. #1
    Join Date
    Aug 2007
    Posts
    152
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default [R] PotatoesArentWild


    By KyleIsntWild

    Special thanks to Seroko for all his continued help with my scripting!!

    Description:
    - Picks potatoes from the patch in Draynor and banks them

    Features:
    - "Loads to do" option to set when the script ends
    - Very good at opening/detecting the troublesome gate to the patch
    - Lots of failsafes to make sure the script doesn't mess up
    - Multiplayer
    - G.E. price grabber
    - Detailed proggy with profit per hour and individual player report
    - Realistic antiban
    - All reflection So everything is just more accurate
    - Epic form NEW!
    - Option to sleep if single player NEW!

    Setup:
    - Make sure you have the most up-to-date version of SRL and Reflection
    - Position all characters in Draynor bank
    - Fill out the form
    - Press play and enjoy!

    Change Log

    Code:
    v1.0 - 10 Aug 2009: never publicly released
    v1.5 - 16 Aug 2009: multiplayer added, walking finally fixed, public release
    v2.0 - 20 Aug 2009: form added, breaks added, antiban fixed up, failsafes fixed up, potato picking fixed up

    Updates to come
    - General speed increases
    - Resting with musician will be added eventually
    - Better antiban
    - Better/more failsafes
    - Cooking potatoes

    Proggies:

    Current best:
    PHP Code:
    ===========================================
    |          
    Potatoes Arent Wild            |
    ===========================================
    |
    Run Time21 Hours29 Minutes and 20 Seconds|
    |
    Taters Picked8484                      |
    |
    Profit661752                           |
    |
    Profit per hour30795                   |
    ===========================================
    |             
    By KyleIsntWild             |
    ===========================================

    Player[0]: ActiveTrue Taters Picked3584 Profit Made279552
    Player
    [1]: ActiveTrue Taters Picked4900 Profit Made382200 
    By me. Stopped because of SMART whitescreen (Potato price 78 gp)

    If anyone else gets decent proggies I'll throw em up here.

    GLHF
    Last edited by Sir R. M8gic1an; 10-11-2009 at 07:58 PM.

  2. #2
    Join Date
    Apr 2007
    Location
    UK
    Posts
    2,295
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Looking good.

    You may want to add a cooking option to do baked potatoes = more profit for members

    Rogeruk's Al-Kharid Tanner V1.1 [Released]
    Rogeruk's Barbarian Crafter [Coming Soon]
    Rogeruk's Guild Fisher [Coming Soon]
    !! - Taking Requests - !!

  3. #3
    Join Date
    Aug 2007
    Posts
    152
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by rogeruk View Post
    Looking good.

    You may want to add a cooking option to do baked potatoes = more profit for members
    Good idea I might try and add that.

  4. #4
    Join Date
    Apr 2007
    Location
    UK
    Posts
    2,295
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Doest work for me.

    Goes to potatoes clicks on one and then just gotos skill and moves the bar up and down repeating

    Rogeruk's Al-Kharid Tanner V1.1 [Released]
    Rogeruk's Barbarian Crafter [Coming Soon]
    Rogeruk's Guild Fisher [Coming Soon]
    !! - Taking Requests - !!

  5. #5
    Join Date
    Feb 2009
    Location
    Hungary (GMT + 1)
    Posts
    1,774
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by rogeruk View Post
    Doest work for me.

    Goes to potatoes clicks on one and then just gotos skill and moves the bar up and down repeating
    That was a problem in SRL. Must be fixed in latest dev repository. Not sure though.

  6. #6
    Join Date
    Apr 2007
    Location
    UK
    Posts
    2,295
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Problem with his antiban i think. Completly removed it and its working now

    Problem with your potato picking too. It clicks, then clicks again bit bad for banning.

    Your using reflection so just count the inv items. if it +1 then you picked a potato. Shouldnt have to click all the time.

    Taters := Taters + 28;
    Your progress reports will be inaccurate. Again. Count the potatoes before banking

    procedure Run;
    var
    Energy: Integer;
    begin
    Energy := StrToInt(GetInterfaceText(750, 5));
    if Energy > 50 then
    SetRun(true)
    else
    SetRun(false);
    end;
    No Need for that.

    Code:
    RunEnergy(50);
    ** Warning in R_OpenBankBooth: Could not find Bank Booth.**
    WTF there is no bank here!
    Walking back to potatoes with full inv?. Failsafes needed.

    Any reason why you turn off run when picking potatoes?. Would be faster with run on.

    Suggestion: If you rested at the musician you would prob get a faster bank.

    Rogeruk's Al-Kharid Tanner V1.1 [Released]
    Rogeruk's Barbarian Crafter [Coming Soon]
    Rogeruk's Guild Fisher [Coming Soon]
    !! - Taking Requests - !!

  7. #7
    Join Date
    Feb 2009
    Location
    Hungary (GMT + 1)
    Posts
    1,774
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    I can give you links. It WAS srl. There was something messed up in the skill-coords. So when you removed his anti-ban you removed that srl function which caused the bug.
    I just like clearing up things. No offence.

  8. #8
    Join Date
    Aug 2007
    Posts
    152
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by rogeruk View Post
    Problem with his antiban i think. Completly removed it and its working now

    Problem with your potato picking too. It clicks, then clicks again bit bad for banning.

    Your using reflection so just count the inv items. if it +1 then you picked a potato. Shouldnt have to click all the time.


    Your progress reports will be inaccurate. Again. Count the potatoes before banking



    No Need for that.

    Code:
    RunEnergy(50);


    Walking back to potatoes with full inv?. Failsafes needed.

    Any reason why you turn off run when picking potatoes?. Would be faster with run on.

    Suggestion: If you rested at the musician you would prob get a faster bank.
    I have never had that problem... when my antiban calls the hoverskill it has always hovered over a random skill.

    Thanks for the RunEnergy lol, didn't know about that.

    And it only clicks twice every so often for me, which I liked because if I was manually picking potatoes, I would click twice sometimes too But I like your idea for counting, I shall do this instead. And the proggy would only count wrong by 1 or 2... if you got a random event mystery box or something, but I will add your suggestion.

    And it should not walk to the potatoes with a full inventory... The banking procedure contains:

    SCAR Code:
    if not OpenBankReflection('db') then
      begin
        repeat
          Writeln('WTF there is no bank here!');
          Inc(Fails);
          WalkToBank;
          wait(1000+Random(1500));
        until (OpenBankReflection('db'))or (Fails > 3);

    That means it will keep trying to walk to the bank until it finds it, or it fails to do so 4 times, at which point it will set the player inactive.

    And I have run turned off at potato picking so it regenerates run engery, I think its faster that way.

    And as for the musician, I have been thinking about doing this to. I will probably add it in the next version with your other suggestions.

    Thank you very much for your feedback

  9. #9
    Join Date
    Apr 2007
    Location
    UK
    Posts
    2,295
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Yea dont take it the wrong way im not flaming or anything its a good script.

    Just needs fine tuning now. I believe if you run all the way and sit down at the musician it should be alot faster.

    All my characters logged out stuck at the bottom left of the field.

    I havnt checked, (off to work). You may want to add some code to stop the character from wondering off from the center of the field.

    Over 3 chars, about 50kgp worth of potatoes.

    Rogeruk's Al-Kharid Tanner V1.1 [Released]
    Rogeruk's Barbarian Crafter [Coming Soon]
    Rogeruk's Guild Fisher [Coming Soon]
    !! - Taking Requests - !!

  10. #10
    Join Date
    May 2007
    Location
    NSW, Australia
    Posts
    2,823
    Mentioned
    3 Post(s)
    Quoted
    25 Post(s)

  11. #11
    Join Date
    Apr 2007
    Location
    UK
    Posts
    2,295
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    ===========================================
    | Potatoes Arent Wild |
    ===========================================
    |Run Time: 23 Minutes and 54 Seconds |
    |Taters Picked: 84 |
    |Profit: 6552 |
    |Profit per hour: 16444 |
    ===========================================
    Back from work .. lol.. player stuck in bottom left of field.

    Rogeruk's Al-Kharid Tanner V1.1 [Released]
    Rogeruk's Barbarian Crafter [Coming Soon]
    Rogeruk's Guild Fisher [Coming Soon]
    !! - Taking Requests - !!

  12. #12
    Join Date
    Aug 2007
    Posts
    152
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by rogeruk View Post
    Back from work .. lol.. player stuck in bottom left of field.
    Thanks for proggy lol but umm... stuck in the bottom left... I can't think of why that is happening. Maybe your character is trying to walk to the bank but the gate was closed? Are you starting all you chars in the bank?

    In the next version I'll add in a check to see if your still in the patch if you fail to find the bank, that should do the trick.

    Next version will come either tonight or tommorow And it has a form now

  13. #13
    Join Date
    Apr 2007
    Location
    UK
    Posts
    2,295
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Yes all players are starting in bank.

    Focus on the script rather than forms.

    Rogeruk's Al-Kharid Tanner V1.1 [Released]
    Rogeruk's Barbarian Crafter [Coming Soon]
    Rogeruk's Guild Fisher [Coming Soon]
    !! - Taking Requests - !!

  14. #14
    Join Date
    Aug 2007
    Posts
    152
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Ok v2 is now released!

    Updates:
    - Awesome form added
    - Problem with hover skill in the antiban has been removed, added a pickup mouse chance as well
    - If you are using single player, the option to take breaks
    - If you are using single player, it will now end the script once your loads are complete
    - Gate opening/checking from INSIDE the farm has been fixed (no more finding chars in bottom left of the field)
    - No more walking to potatoes if your inventory is full
    - Added a TBox check to tell if your in the farm or not
    - Oh yeah, did I mention AWESOME FORM ADDED!

    And I tried the RunEnergy(50); thing instead of my run procedure, but it is not working, so old Run procedure stays.

    Setting up 3 players right now, shooting to break 24 hours with this one.

    Post any comments/concerns/suggestions/proggies.
    Last edited by kyleisntwild; 08-21-2009 at 02:44 AM.

  15. #15
    Join Date
    Nov 2008
    Posts
    258
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    [Runtime Error] : Exception: Access violation at address 0053219D in module 'scar.exe'. Write of address 00000000 in line 125 in script C:\Program Files (x86)\SCAR 3.20\includes\SRL/SRL/Core/Players.scar

    keep getting this message after i start the script after the form... it's not an issue with your script, obviously, but could anyone help me figure out why it's doing that?

  16. #16
    Join Date
    Apr 2007
    Location
    UK
    Posts
    2,295
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Dont know how you got that progress report. But it fails to work for me. Gets stuck without getting to gate.

    Gets lost walking and goes back

    Rogeruk's Al-Kharid Tanner V1.1 [Released]
    Rogeruk's Barbarian Crafter [Coming Soon]
    Rogeruk's Guild Fisher [Coming Soon]
    !! - Taking Requests - !!

  17. #17
    Join Date
    Aug 2007
    Posts
    152
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by rogeruk View Post
    Dont know how you got that progress report. But it fails to work for me. Gets stuck without getting to gate.

    Gets lost walking and goes back
    "Gets lost walking".. like walks halfway then says its there and retries to walk, or walks to some random place or what?

    I don't know how this happening to you but I guess try uncommenting the R_Flag lines in WalkToTaters and WalkToBank, that way it wont try and walk to the next tile until the flag disappears on the minimap. My 21 hour proggy was with R_Flag enabled i think, but I have gotten multiple 7 hour+ proggies with v2 exactly how it is presented when you download. Only has stopped due to randoms, and once one of my chars got stuck in the wheat field.

    If you think the R-Flag walking looks too bot like and my normal walking isnt working for you, try adjusting the randomness or even create a new path array (very easy to do with Summiliions path maker tool).

    Thanks for your feedback tho Rogeruk, I will try adjusting the walking I guess, maybe make the points even closer together. Anyone else besides Rogeruk having any troubles with this script?

    and @blulightning - no clue why that is happening. Maybe try resintalling scar/srl/reflection (dev versions) and/or restarting your computer, those things have fixed countless errors for me
    Last edited by kyleisntwild; 08-24-2009 at 08:47 AM.

  18. #18
    Join Date
    Apr 2007
    Location
    UK
    Posts
    2,295
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    SCAR Code:
    R_Flag;

    Waits for the character to have a complete stop. (CharacterMoving).

    For more human like walking you should be using
    SCAR Code:
    R_FFlag(3);

    Once your character is within dist of 3 it will move to next.

    I have my own script to pick potatoes but im not gonna release yet.

    Seroko still helping you with this?

    Rogeruk's Al-Kharid Tanner V1.1 [Released]
    Rogeruk's Barbarian Crafter [Coming Soon]
    Rogeruk's Guild Fisher [Coming Soon]
    !! - Taking Requests - !!

  19. #19
    Join Date
    Aug 2007
    Posts
    152
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by rogeruk View Post
    SCAR Code:
    R_Flag;

    Waits for the character to have a complete stop. (CharacterMoving).

    For more human like walking you should be using
    SCAR Code:
    R_FFlag(3);

    Once your character is within dist of 3 it will move to next.

    I have my own script to pick potatoes but im not gonna release yet.

    Seroko still helping you with this?
    Lol rogeruk I know, it was just a sugegstion if your walking if messing up because it will mess up less if you wait till the flag is gone. R_FFlag(3); would be useless because the walking atm has a dist of like 2 I think.

    I guess the only thing you could try is making a new path array with tiles closer together :/.

    And Seroko still helps me with lots of stuff, if I have a question I just ask him lolz. In this script he specifically helped a lot with the gate opening, with offset and what not. But ya hes like my scripting mentor kinda hehe

  20. #20
    Join Date
    Mar 2007
    Location
    Finland, Espoo
    Posts
    96
    Mentioned
    0 Post(s)
    Quoted
    1 Post(s)

    Question same here

    Quote Originally Posted by blulightning View Post
    [Runtime Error] : Exception: Access violation at address 0053219D in module 'scar.exe'. Write of address 00000000 in line 125 in script C:\Program Files (x86)\SCAR 3.20\includes\SRL/SRL/Core/Players.scar

    keep getting this message after i start the script after the form... it's not an issue with your script, obviously, but could anyone help me figure out why it's doing that?
    im getting same error, i have latest scar (3.21), rev (152) and SRL so i have no idea why it doesnt work...

  21. #21
    Join Date
    Aug 2007
    Posts
    152
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by Alligaattor View Post
    im getting same error, i have latest scar (3.21), rev (152) and SRL so i have no idea why it doesnt work...
    You'll need the latest version of reflection as well. Maybe bluelightning forgot that too.
    If you don't know how to get dev reflection, look in this guide: http://www.villavu.com/forum/showthread.php?t=47714
    Last edited by kyleisntwild; 08-27-2009 at 12:35 AM.

  22. #22
    Join Date
    Aug 2007
    Posts
    152
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Script is in working condition, but just wanted to point out the most probable reason teh walking fails so much: http://www.villavu.com/forum/showthread.php?t=50049

    Once that gets fixed this script should work much faster

  23. #23
    Join Date
    Dec 2006
    Location
    @ yard
    Posts
    318
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    yea, it isn`t werry good to use, bot mainly stuck outside patato field (outside the field, and click on patato all the time, but gete is closed.. so hes out and stuck forever.. till random), .. and loses on walking...
    i`m here as long as don`t get in the way...

  24. #24
    Join Date
    Apr 2007
    Location
    UK
    Posts
    2,295
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by kyleisntwild View Post
    Script is in working condition, but just wanted to point out the most probable reason teh walking fails so much: http://www.villavu.com/forum/showthread.php?t=50049

    Once that gets fixed this script should work much faster
    There is a fix in the thread linked.

    Rogeruk's Al-Kharid Tanner V1.1 [Released]
    Rogeruk's Barbarian Crafter [Coming Soon]
    Rogeruk's Guild Fisher [Coming Soon]
    !! - Taking Requests - !!

  25. #25
    Join Date
    Aug 2007
    Posts
    152
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by rogeruk View Post
    There is a fix in the thread linked.
    Yeah, I put it in the script, but to me its working the same as just adding R_Flag... i clicks a point, waits till it stops, then clicks next one. Ill upload version with the fix (no need to change anything in any include files just run the script).

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •