Page 1 of 2 12 LastLast
Results 1 to 25 of 30

Thread: Smartest Karamja Fisher!

  1. #1
    Join Date
    Jul 2008
    Location
    Canada
    Posts
    1,612
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default Smartest Karamja Fisher!

    Smartest Karamja Fisher!

    Hai everybody, I decided to learn reflection and make a script!-(i know color already )- So I made this karamja fisher and seller for DA leechers :P. This script is currently in the alpha stages, so it needs testing. You'll notice a lot of the script is commented out, due to changes . So please everyone post progress reports and comments discussing the script.


    Setup:

    - Setup players at karamja dock, with their chats to how you like :P.
    - Make sure each and every one of them has a harpoon or lobster pot,
    - In the declareplayers, 'age' = cage fishing, 'arpoon' = harpoon fishing..
    I would have made that into a simple boolean but im too lazy right now.

    Version History:
    SCAR Code:
    {----------------------------------------------------------------------------------------------------------------------------------------------------------------}
    Version History:
    {{----------------------------------------------------------------------------------------------------------------------------------------------------------------}
    Version History:
    {----------------------------------------------------------------------------------------------------------------------------------------------------------------}
    '1.0' : - First version.
            - 303 lines.
            - Walking was broken.
            - Selling was half-broken, wouldn`t sell the fish, only find the shopkeeper and open the screen.
            - Fishing was working. :D
            - Fish Counting and Load count was done.
            - No progress report.
    {----------------------------------------------------------------------------------------------------------------------------------------------------------------}
    '2.0' : - Second version, [PARTIAL] revamp of original.
            - YAY we surpassed 400 lines.
            - Fixed walking to pefection. (-I think :P-)...
            - Fixed Selling.
            - Small edit to fishing func.
            - Fish count and Load count was modified.
            - Added small vague proggy :P.
            - New func : RCompass : Changes compass randomly and sets its back to north.
            - New func : WhilstFishing : Assures that the player will always be fishing.
            - Used MouseSpeed change, to speed up selling.
            - Commented out DebugPath.
            - Removed DoneLoad as it wasn`t necessary.
    {----------------------------------------------------------------------------------------------------------------------------------------------------------------}
    '2.1' : - Fixed some nasty runtime error occuring in gametab :S
    {----------------------------------------------------------------------------------------------------------------------------------------------------------------}
    '2.2' : - Added Tad`s uber walking functions, script should be flawless now.
             - Proggy is broken :S.
    {----------------------------------------------------------------------------------------------------------------------------------------------------------------}
    '2.21': - Fixed walking and proggy, thanks to Pure1993.
    {----------------------------------------------------------------------------------------------------------------------------------------------------------------}

    Sample Proggy:
    Note : looks wayyy neater in scar'
    PHP Code:
    ==============================================================|
    |+-------------------
    Made BySmarter Child----------------- +|
    |              
    Script has ran for: 6 Minutes and 23 Seconds                   |
    |              
    Script has done1 loads                        |
    |              
    Script has caught25 fish                       |
    |                        
    Script has switched0 times                      |
    |--------------------------------------------------------------|
    | ****: 
    Done1 loadsCaught0 Tuna25 Lobsters0 Swordies    |
    |--------------------------------------------------------------|
    Post all proggies/comments/suggestions/bugs on script thread |
    |==============================================================| 
    Enjoy!!


    BUGS~
    -When fishing, it sometimes click the spot again, even though your currently fishing
    -Omg new bug, you might get runtime error in gametab, idk why exactly though :s, please download newest version..
    -Sometimes clicks spot even if your inventory is full, don't worry about this, the script will re-calibrate itself .

    Update: New walk function, should make script flawless and able to run longer, big credits to Tad for his path walking function, download new version pl0x
    NEW VERSION~~
    Last edited by Sir R. M8gic1an; 09-18-2009 at 08:38 PM. Reason: added prefix, made proggy look gd :)

  2. #2
    Join Date
    Jul 2008
    Location
    Canada
    Posts
    1,612
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Proggies, i still have to get some
    Edit: Got 1 short proggy, cuz my computer is bitching at me.
    Code:
    |==============================================================|
    |+-------------------Made By: Smarter Child----------------- +|
    |              Script has ran for: 50 Minutes and 5 Seconds                   |
    |              Script has done: 7 loads                        |
    |              Script has caught: 168 fish                       |
    |                        Script has switched: 0 times                      |
    |--------------------------------------------------------------|
    | ***: Done: 7 loads, Caught: 0 Tuna, 168 Lobsters, 0 Swordies    |
    |--------------------------------------------------------------|
    | Post all proggies/comments/suggestions/bugs on script thread |
    |==============================================================|
    Last edited by Smarter Child; 08-23-2009 at 05:58 AM.

  3. #3
    Join Date
    Oct 2008
    Location
    Canada
    Posts
    28
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Looks good, I'll save this spot for a proggie
    EDIT: I don't know if this was an error on the script's part or maybe my computer did something too but when the time came to sell the lobbies, the program continually wanted to click the run icon when ever it had just one point and run around the store for about three minutes. It was very nice how it corrected itself eventually but the proggie:
    |================================================= =============|
    |+-------------------Made By: Smarter Child----------------- +|
    | Script has ran for: 22 Minutes and 37 Seconds |
    | Script has done: 50 loads |
    | Script has caught: 1300 fish |
    | Script has switched: 0 times |
    |--------------------------------------------------------------|
    | rues: Done: 50 loads, Caught: 0 Tuna, 1300 Lobsters, 0 Swordies |
    |--------------------------------------------------------------|
    | Post all proggies/comments/suggestions/bugs on script thread |
    |================================================= =============|
    can be a little misleading xD
    I'll be sure to post a better one later!
    Last edited by JuvLupin; 08-24-2009 at 09:44 PM.

  4. #4
    Join Date
    Sep 2007
    Location
    Pennsylvania
    Posts
    3,396
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Looks pretty nice, good job

    You left your password in the latest version, I changed it and PMed the new one to you.

  5. #5
    Join Date
    Apr 2009
    Posts
    49
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    |================================================= =============|
    |+-------------------Made By: Smarter Child-------------------+|
    | Script has ran for: 41 Minutes and 0 Seconds |
    | Script has done: 13 loads |
    | Script has caught: 340 fish |
    | Script has switched: 0 times |
    |--------------------------------------------------------------|
    |sica: Done: 13 loads, Caught: 0 Tuna, 340 Lobsters, 0 Swordies|
    |--------------------------------------------------------------|
    | Post all proggies/comments/suggestions/bugs on script thread |
    |================================================= =============|

  6. #6
    Join Date
    Jul 2008
    Location
    Canada
    Posts
    1,612
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Nice proggies, any suggestions? I think the walking is fail atm xD
    Edit: NEW VERSION, PLEASE REDOWNLOAD 2.2.
    Edi2: script is flawless, although proggy is messed up in 2.2, will have fix soon
    Last edited by Smarter Child; 08-25-2009 at 05:36 AM.

  7. #7
    Join Date
    Dec 2006
    Location
    Canada, BC
    Posts
    728
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Very nice ;] i might abuse this someday. good luck trying to get me to post a proggy though xP
    Lance. Da. Pants.

  8. #8
    Join Date
    Jan 2009
    Location
    new york bK all day
    Posts
    100
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Lightbulb

    Quote Originally Posted by lancerawks aka Lance View Post
    Very nice ;] i might abuse this someday. good luck trying to get me to post a proggy though xP
    lmfao that's mean

    testing it out now

  9. #9
    Join Date
    Jul 2008
    Location
    Canada
    Posts
    1,612
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by xking View Post
    lmfao that's mean

    testing it out now
    Oh no, Lance means it in a friendly way .

  10. #10
    Join Date
    Oct 2006
    Location
    H0M3
    Posts
    142
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    its running as i'm typing this. i have noticed that its slightly buggy when it comes to finding the shop owner. it keeps waking in and out of the shop. it might be just for me though. apart ffrom that this looks like a brilliant script. its very lazy/boored human like, which is ideal as its a power fisher. brilliant anti-ban aswell. oh almost for got the progress report, as mentioned by owner it need fixing. but apart from that its really good. i'm using it on my second main, just to give you an idea how much i like it. heres the current progress report and i will post more as time goes on:
    SCAR Code:
    |==============================================================|
    |+-------------------Made By: Smarter Child----------------- +|
    |              Script has ran for: 13 Minutes and 6 Seconds                   |
    |              Script has done: 45 loads                        |
    |              Script has caught: 1170 fish                       |
    |                        Script has switched: 0 times                      |
    |--------------------------------------------------------------|
    | iya: Done: 45 loads, Caught: 0 Tuna, 1170 Lobsters, 0 Swordies    |
    |--------------------------------------------------------------|
    | Post all proggies/comments/suggestions/bugs on script thread |
    |==============================================================|

  11. #11
    Join Date
    Oct 2006
    Location
    H0M3
    Posts
    142
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    |================================================= =============|
    |+-------------------Made By: Smarter Child----------------- +|
    | Script has ran for: 1 Hours, 1 Minutes and 49 Seconds |
    | Script has done: 146 loads |
    | Script has caught: 3796 fish |
    | Script has switched: 0 times |
    |--------------------------------------------------------------|
    | iya: Done: 146 loads, Caught: 0 Tuna, 3796 Lobsters, 0 Swordies |
    |--------------------------------------------------------------|

    script terminated inside the shop with a full inv and no shop screen. i guess it couldnt find the sk.

  12. #12
    Join Date
    Oct 2006
    Location
    H0M3
    Posts
    142
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    SCAR Code:
    |==============================================================|
    |+-------------------Made By: Smarter Child----------------- +|
    |              Script has ran for: 2 Hours, 53 Minutes and 24 Seconds                   |
    |              Script has done: 323 loads                        |
    |              Script has caught: 8398 fish                       |
    |                        Script has switched: 0 times                      |
    |--------------------------------------------------------------|
    | iya: Done: 323 loads, Caught: 0 Tuna, 8398 Lobsters, 0 Swordies    |
    |--------------------------------------------------------------|
    | Post all proggies/comments/suggestions/bugs on script thread |
    |==============================================================|
    [Runtime Error] : Out Of Range in line 281 in script C:\Users\Ahmed\AppData\Local\Temp\Karamja Fisher & Seller 2.2.scar
    the script terminated while i was out in the garden. once i logged back in he was stood ourside the shop with full inv.

  13. #13
    Join Date
    Jul 2008
    Location
    Canada
    Posts
    1,612
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Nice proggy, Ahmed, ill see wats wrong. (+Im arab(muslim)+) too

    Yah i also have to fix counting it worked in previous version but latest has good walking and thats all i changed

    Edit: Yes, i think i did good job with the antiban .

  14. #14
    Join Date
    Mar 2009
    Location
    AUS QLD brisbane.
    Posts
    66
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Lmao whats with all those proggies being f@k#d up?

    13 minutes and 1k fish bs lol ill post a real -proggy for you Smarter child

  15. #15
    Join Date
    Sep 2009
    Posts
    5
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Sorry for idiot question: How i can run that script ?

  16. #16
    Join Date
    Jul 2008
    Location
    Canada
    Posts
    1,612
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Proggy, is broken, and i might have to use a color alternative to the counting, such as ItemAmount. Martinike, download SRL include and make sure you reflection dev svn latest, check the wiki .

  17. #17
    Join Date
    Sep 2009
    Posts
    5
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Loaded all chars. (NPCChars, TradeChars, SmallChars, StatChars, UpChars)
    Include file C:\Program Files\SCAR 3.12\includes\SRL\SRL\Misc\Smart.Scar does not exist.
    Include file C:\Program Files\SCAR 3.12\includes\SRL\SRL.Scar does not exist.
    Include file C:\Program Files\SCAR 3.12\includes\SRL\SRL\Reflection\Reflection.Scar does not exist.
    Failed when compiling
    Help

  18. #18
    Join Date
    Jan 2008
    Location
    Frankfurt, Germany
    Posts
    742
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    As for your proggy problem, here is why it is happening:
    SCAR Code:
    function R_WalkPath(Path: TPointArray; Randomness: Integer): boolean;
    var
      i, t, l, fails: integer;
      NTile, D : TPoint;
    begin
      NTile := NextTile(Path, 10);
      i := TileToIndex(NTile, Path);
      fails := 0;
      l := GetSystemTime;
      while (i < High(Path)) and (fails < 20) do
      begin
       // AntiRandoms;
        if (Path[i].x = Path[i+1].x) and (Path[i].y = Path[i+1].y) then
        begin
          Inc(i);
          Continue;
        end;
        t := GetSystemTime;
        while not (NextGoodTile(Path, i, NTile)) and (GetSystemTime - t < 20000) do
          wait(200+random(100));
        if NextGoodTile(Path, i, NTile) then
          if WalkToTile(NTile, Randomness, 17+random(10)) then
            i := TileToIndex(NTile, Path)
          else
            Inc(fails)
        else
          Inc(fails);
      end;
      result := fails < 20;
      if result then
      begin
        MarkTime(t);
        if not GetFlag(D) then Exit;
        repeat
          if not GetFlag(D) then break;
          if DistanceFrom(D) < 2 then break; //REMOVE THIS
          if not CharacterMoving then break;
        until(TimeFromMark(t) > 30000);
      end;
    end;

    SCAR Code:
    Procedure Loop;
    begin
      Players[CurrentPlayer].Integers[6] := 0;
      SetPos('Both');
      WhilstFishing;
      if InvFull then
      begin
        CountFish;
        Proggy;
        R_WalkPath(ShopPath, 2);
       // WalkToTile(Point(2907, 3148), 1, 0);
        if isidle then // problem is here ;)
        begin
          SellFish;
          MouseSpeed := 15;
          Proggy;
          R_WalkPath(DockPath, 2);
          Switch;
        end;
      end;
    end;

    IsIdle <> GetFlag(D)
    IsIdle = not CharacterMoving;

    It will count the fishes quite often... and it is also the core of most walking problems which have been mentioned here.
    There is nothing right in my left brain and there is nothing left in my right brain.

  19. #19
    Join Date
    Jul 2008
    Location
    Canada
    Posts
    1,612
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Thanks Pure1993!

    ########### NEW VERSION ###############
    ########### Version ###############
    ########### 2.21 ###############

  20. #20
    Join Date
    Jan 2009
    Posts
    10
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Seems to work OK. Will post prog soon

  21. #21
    Join Date
    Jul 2008
    Location
    Canada
    Posts
    1,612
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    It works? Well if you get proggy, post it, and i can fix all the bugs.

  22. #22
    Join Date
    Sep 2009
    Posts
    37
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    some of these proggys seem really off tbh

  23. #23
    Join Date
    Sep 2009
    Location
    singapore
    Posts
    32
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    is this working at the moment?

  24. #24
    Join Date
    Dec 2008
    Posts
    2,813
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by mizuno View Post
    is this working at the moment?
    D: Again, test the script. Your posts will be considered spam with punishment if you keep this up. I won't report you for now, but please try not to spam like this.

  25. #25
    Join Date
    Jul 2009
    Posts
    11
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    thanks for this!

Page 1 of 2 12 LastLast

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •