Results 1 to 12 of 12

Thread: Lollage's StableSpinner [Lumby]

  1. #1
    Join Date
    Jul 2009
    Posts
    47
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default Lollage's StableSpinner [Lumby]

    Lollage's StableSpinner


    Flax spinning is a great way of getting crafting xp and money. This Script, while developing, gave me 10-65 crafting in 2 weeks of membership. I am also doing school, girlfriend, friends etcetcetc, so its pretty nice.

    Specs, positive:
    • breaks 1 minute every 10~15 minutes.

    • breaks 15 minutes every 90 muinutes.

    • state definition for flawless running, needs some work though.

    • AntiBan, AntiRandom. I disabled the GetSkillInfo in the antiban since its working buggy. Make your own antiban, it's not that hard...

    • Doesn't hit much randoms. I once ran 5 hours without any random report.

    • spins approx. 800 flax/h.


    Specs, negative:

    • Not multiplayer, but can be built in easily.

    • Sometimes fails on "ClimbDown", but logs out, in, and repairs itself.




    Notes:

    Best personal proggy is over 7 hours.

    This script Just needs more testing and more work. My members subscription runs out so that's why im publishing now. This script is good, but it can be made better. For Juniors, you easily have a Flax Spinner now. Take some time for pefecting it. I enjoyed it very much the month I was member.


    I WILL update this, if someone provides me a member PIN!

    Good luck and cheers! Lollage22

    Instructions:
    Put Flax in your first bank slot, and the bowstrings in the second.
    Let your account be anywhere on the 1st or 2nd floor of the lumbridge castle.
    Have flax in your inventory or not, I do not care (State definitions ftw!)
    Fill out the DeclarePlayers etc...
    Press Play!


    PS. The script is not SMART, since the symbols are not recognized very well, and FindObjEx doesnt seem to work properly. The script is useful for overnight, so why should you use SMART anyway? If someone can make it SMART, i would be positively impressed =D

    PPS, members, how would this do on a SRL subscription?
    Last edited by Sir R. M8gic1an; 10-11-2009 at 07:39 PM.

  2. #2
    Join Date
    Mar 2008
    Location
    New Jersey
    Posts
    1,673
    Mentioned
    1 Post(s)
    Quoted
    9 Post(s)

    Default

    It looks very nice, but here's a few things I've noticed.

    You should add multiplayer, some people might say no just because it doesn't support multiplayer which is a SRL golden rule.

    In climbdown, you have q:= 0, then:

    Code:
        if (not FindObjTPA(x,y,10791596 ,4,2,25,25,25*25-150,['limb'])) then
          q:=1;
    
        
        if (q=1) then
        begin
          if FindObjEx(x,y,['down'],[10791596 ],4,50,MSX1,MSY1,MSX2,MSY2) then
            q:=0;
        end;
    
        if q=0 then
    well what if it never found the first obj tpa? q would = 0 by default, no? either set q = to something else, like 5, at first, or have the last find obj tpa set q to something else other than 0. It may result true when it shouldn't have. And why do you use FindObjTPA? you made your own TPA's earlier, why you ObjTPA when yuo can make your own? It'd look better in my opinion.

    You never use result in WalkToLowStairs, it could just be a procedure.

    I don't really like this:
    Code:
    if p=30 then
        writeln('We may be not in the bank. Risky!');
      Result:=True;
    you should check if you are in the bank by checking for the bank symbol, or checking for something you know is only in the bank or something, if you might not be in the bank I don't think it should result true And in that same procedure, I don't know why you would repeat making the compass north for up to 30 times lol, call it once before the repeat.


    In this:

    Code:
    if Bankscreen then
        begin
          MouseBox(382,299,411,317,1);
          wait(300+random(400));
    
          if (StartAmount=-1) then StartAmount:=GetAmount(95, 95);
          CurrentAmount:=GetAmount(95, 95);
          StringsDone:=CurrentAmount-StartAmount;
          FlaxToGo:=GetAmount(49, 94);
    
          if ((not FindColorTolerance(x,y,10920520 ,30,80,100,160,3)) or (FlaxToGo < 10)) then
          begin
            Logout;
            writeln('Out of Flax! Good job!');
            TerminateScript;
          end;
    I think you need to call CloseWindow; before trying to logout.

    I like the antiban in the end of the bank procedure though, how it randomly closes bank sometimes and sometimes doesn't.

    In spinwheel, you have you failsafe noted, for if it doesn't find the spin wheel, it logs out, it's noted, so if it doesn't find it, it continues on with the procedure.

    I like your use of TPA's to see if you are spinning still or not. Kinda creative.

    I have no clue, but when you level up, if it stops spinning you need to make it start spinning again, unless it stats spinning again after clicking the pop-up box which it looks like you have it do.


    Just a few things you could fix up, after you add multiplayer, since you have TPA's there's a chance you could get members, but I would suggest learning DDTM's and using that for your walking, then it would almost definitely be a yes, if you used DDTM's to walk. Multiplayer, TPA's, and DDTM's, that's what most people like to see. Fix some standards, like in setup, there's a bunch of unneeded spaces, taking up more lines then you need to. But I like this script, I would probably vote yes.


    Oh and one more thing, I saw a lot of wait's without randomness, you should do wait(x+random(xx)); instead of just wait(x);, makes it more human-like, since we don't always wait the exact same amount of milliseconds. but good job, I like this script. You have some good potential.

  3. #3
    Join Date
    Jul 2009
    Posts
    47
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    First of all: THANKS for the great feedback Baked!

    Just because I stopped being member I decided to publish my script. It's out of the blue, without any "publish revising" on standards, adding multiplayer etc.

    Quote Originally Posted by Baked0420 View Post

    You should add multiplayer, some people might say no just because it doesn't support multiplayer which is a SRL golden rule.
    I could do this, but in a members script... are there people who auto more members accounts? Pretty waste of your (real life) money, i'd guess... Just let every account do it's own script.



    In climbdown, you have q:= 0, then:

    Code:
        if (not FindObjTPA(x,y,10791596 ,4,2,25,25,25*25-150,['limb'])) then
          q:=1;
    
        
        if (q=1) then
        begin
          if FindObjEx(x,y,['down'],[10791596 ],4,50,MSX1,MSY1,MSX2,MSY2) then
            q:=0;
        end;
    
        if q=0 then
    well what if it never found the first obj tpa? q would = 0 by default, no? either set q = to something else, like 5, at first, or have the last find obj tpa set q to something else other than 0. It may result true when it shouldn't have.[/QUOTE]

    I guess no. I put q:=0.
    The first if asks: if (not FindObjTPA(...)); So, if the finding fails, not FindObjTPA() is true. Then, q:=1 and it will search using FindObjEx. is FindObjTPA succeeds, q remains 0 and the script will click accordingly.

    I must agree, this can be scripted much smoother. However, I'm not member anymore, so I'm not going to do it :P


    And why do you use FindObjTPA? you made your own TPA's earlier, why you ObjTPA when yuo can make your own? It'd look better in my opinion.
    Hmm, the FindObjTPA function is in SRL, so why not use it?
    I try first FindObjTPA , then FindObjEx. Still, ClimbDown fails occasionally. I've been working on it serveral times, and without SMART this now works properly. It's been a real pain in the bottoms for me though.


    You never use result in WalkToLowStairs, it could just be a procedure.
    Oh, you're right. Is a procedure faster?

    I don't really like this:
    Code:
    if p=30 then
        writeln('We may be not in the bank. Risky!');
      Result:=True;
    you should check if you are in the bank by checking for the bank symbol, or checking for something you know is only in the bank or something, if you might not be in the bank I don't think it should result true And in that same procedure, I don't know why you would repeat making the compass north for up to 30 times lol, call it once before the repeat.
    You're pretty right, this was a left-over from my programming ventures, before the state defenitions. It wasn't really planned to stay. My apologies.

    About the compass: yeah who cares :P? i persume MakeCompass first checks if the angle is already taken, so it hardly does anything in computational sense.


    In this:

    Code:
    if Bankscreen then
        begin
          MouseBox(382,299,411,317,1);
          wait(300+random(400));
    
          if (StartAmount=-1) then StartAmount:=GetAmount(95, 95);
          CurrentAmount:=GetAmount(95, 95);
          StringsDone:=CurrentAmount-StartAmount;
          FlaxToGo:=GetAmount(49, 94);
    
          if ((not FindColorTolerance(x,y,10920520 ,30,80,100,160,3)) or (FlaxToGo < 10)) then
          begin
            Logout;
            writeln('Out of Flax! Good job!');
            TerminateScript;
          end;
    I think you need to call CloseWindow; before trying to logout.
    Oh yeah, they changed that in a last update. The LogOut X is removed when in a bankscreen. I might just do that.

    I like the antiban in the end of the bank procedure though, how it randomly closes bank sometimes and sometimes doesn't.
    Could do the same with climbing up and down the stairs, using the SpecialChat instead of the RightClick.

    In spinwheel, you have you failsafe noted, for if it doesn't find the spin wheel, it logs out, it's noted, so if it doesn't find it, it continues on with the procedure.
    Again, some left-overs from the pre-"stage definition"-time. My apologies. Now, when SpinWheel fails, the script will find GetInfo=3 and it will all work out.


    I have no clue, but when you level up, if it stops spinning you need to make it start spinning again, unless it stats spinning again after clicking the pop-up box which it looks like you have it do.
    It does, I checked it.


    Just a few things you could fix up, after you add multiplayer, since you have TPA's there's a chance you could get members, but I would suggest learning DDTM's and using that for your walking, then it would almost definitely be a yes, if you used DDTM's to walk. Multiplayer, TPA's, and DDTM's, that's what most people like to see. Fix some standards, like in setup, there's a bunch of unneeded spaces, taking up more lines then you need to. But I like this script, I would probably vote yes.
    Thank you, I'll have a look at DDTM's for my next script: Some auto-fighter/prayer trainer You can use pretty much every approach in pretty much every script, whatever you would like to program. Ill keep your advice in mind.

    About standards: Lol, theyre very important, i know. But as i'm not applying, i dont really care .


    About randomness: I checked them all, it shouldn't create a problem, since there is always a function after the wait which involves randomness. But eventually randomness is better indeed.


    Once again: Really THANKS! It's good to know I'm on the right track.

  4. #4
    Join Date
    Mar 2008
    Location
    New Jersey
    Posts
    1,673
    Mentioned
    1 Post(s)
    Quoted
    9 Post(s)

    Default

    well if you're going to apply, you could try using this script, and if you don't get in, then you have some time to make your new members app script, I'd say give it a shot with this, you never know, it does show some good scripting. But the parts that aren't needed like how you said it was leftover from a pre-stage, you should just delete all those out real quick, then try applying. The worst that happens is you get more no's then yes's and gotta reapply later.

    Also, if you don't make it, you'd see from other people what they expect, and what they saw wrong.

  5. #5
    Join Date
    Apr 2007
    Location
    The Netherlands
    Posts
    5,553
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Well am I the only one who haves some strange thoughts about:
    am also doing school, girlfriend, friends etcetcetc, so its pretty nice.
    He must be busy a lot.
    ~Hermen

  6. #6
    Join Date
    Apr 2007
    Location
    UK
    Posts
    2,295
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    I dont think the script would hold up to SRL Membership.

    Your script has alot of room for improvement. Use of cases would be a major advantage in many parts.

    Standards are pretty off. Whats up with all the white space?

    Rogeruk's Al-Kharid Tanner V1.1 [Released]
    Rogeruk's Barbarian Crafter [Coming Soon]
    Rogeruk's Guild Fisher [Coming Soon]
    !! - Taking Requests - !!

  7. #7
    Join Date
    Dec 2009
    Posts
    146
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    I can't get this script to do anything for me. First it had some sort of error related to the "down" variable. I changed all references to down2, and then it compiled, but when it ran it never could find the wheel or find the bank. So, it spent like 10 minutes with the mouse jumping around looking for the wheel, even when I manually placed it over the wheel, it still went back to jumping around looking for the wheel. Sorry but this script strikes out with me.

  8. #8
    Join Date
    Jan 2010
    Posts
    5,227
    Mentioned
    6 Post(s)
    Quoted
    60 Post(s)

    Default

    Quote Originally Posted by jimthesoundman View Post
    I can't get this script to do anything for me. First it had some sort of error related to the "down" variable. I changed all references to down2, and then it compiled, but when it ran it never could find the wheel or find the bank. So, it spent like 10 minutes with the mouse jumping around looking for the wheel, even when I manually placed it over the wheel, it still went back to jumping around looking for the wheel. Sorry but this script strikes out with me.
    Four months old..

  9. #9
    Join Date
    Dec 2009
    Posts
    146
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Well, it would be nice if someone took down the scripts that are invalid/outdated/obsolete. I'm not a mind reader.

  10. #10
    Join Date
    Jan 2010
    Posts
    5,227
    Mentioned
    6 Post(s)
    Quoted
    60 Post(s)

    Default

    Quote Originally Posted by jimthesoundman View Post
    Well, it would be nice if someone took down the scripts that are invalid/outdated/obsolete. I'm not a mind reader.
    Neither am I.

    "09-30-2009, 08:01 PM"

    That's when the post above yours was posted..

  11. #11
    Join Date
    Oct 2009
    Location
    Stockton, CA
    Posts
    2,040
    Mentioned
    0 Post(s)
    Quoted
    1 Post(s)

    Default

    Quote Originally Posted by jimthesoundman View Post
    Well, it would be nice if someone took down the scripts that are invalid/outdated/obsolete. I'm not a mind reader.
    They shouldn't be taken down because of archive purposes.
    Also, there is a thread somebody made that has all working scripts in it.
    Let me dig it up like the nice guy I am....
    Here it is: http://www.villavu.com/forum/showthread.php?t=54289 .
    Last edited by Sex; 01-27-2010 at 07:45 AM.
    Join the IRC! irc.rizon.net:6667/srl | SQLite (0.99rc3+) | SRL Doc | Simba Doc | Extra Simba Libraries (openSSL & sqlite3)
    Quote Originally Posted by #srl
    10:45 < Toter> daphil when can get sex anyday I want
    10:45 < Toter> he is always on #SRL
    "A programmer is just a tool which converts caffeine into code"

  12. #12
    Join Date
    Feb 2006
    Location
    Tracy/Davis, California
    Posts
    12,631
    Mentioned
    135 Post(s)
    Quoted
    418 Post(s)

    Default

    Quote Originally Posted by jimthesoundman View Post
    Well, it would be nice if someone took down the scripts that are invalid/outdated/obsolete. I'm not a mind reader.
    If its an old thread/hasn't had any new posts in a long time, its most likely outdated.
    Also if you read the last few posts many times they say weather or not the script is working or not.
    It's usually not too hard to figure out weather a script is out of date or not.
    Closed! (Script author PM a mod when/if you update this!)

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •