It looks very nice, but here's a few things I've noticed.
You should add multiplayer, some people might say no just because it doesn't support multiplayer which is a SRL golden rule.
In climbdown, you have q:= 0, then:
Code:
if (not FindObjTPA(x,y,10791596 ,4,2,25,25,25*25-150,['limb'])) then
q:=1;
if (q=1) then
begin
if FindObjEx(x,y,['down'],[10791596 ],4,50,MSX1,MSY1,MSX2,MSY2) then
q:=0;
end;
if q=0 then
well what if it never found the first obj tpa? q would = 0 by default, no? either set q = to something else, like 5, at first, or have the last find obj tpa set q to something else other than 0. It may result true when it shouldn't have. And why do you use FindObjTPA? you made your own TPA's earlier, why you ObjTPA when yuo can make your own? It'd look better in my opinion.
You never use result in WalkToLowStairs, it could just be a procedure.
I don't really like this:
Code:
if p=30 then
writeln('We may be not in the bank. Risky!');
Result:=True;
you should check if you are in the bank by checking for the bank symbol, or checking for something you know is only in the bank or something, if you might not be in the bank I don't think it should result true
And in that same procedure, I don't know why you would repeat making the compass north for up to 30 times lol, call it once before the repeat.
In this:
Code:
if Bankscreen then
begin
MouseBox(382,299,411,317,1);
wait(300+random(400));
if (StartAmount=-1) then StartAmount:=GetAmount(95, 95);
CurrentAmount:=GetAmount(95, 95);
StringsDone:=CurrentAmount-StartAmount;
FlaxToGo:=GetAmount(49, 94);
if ((not FindColorTolerance(x,y,10920520 ,30,80,100,160,3)) or (FlaxToGo < 10)) then
begin
Logout;
writeln('Out of Flax! Good job!');
TerminateScript;
end;
I think you need to call CloseWindow; before trying to logout.
I like the antiban in the end of the bank procedure though, how it randomly closes bank sometimes and sometimes doesn't.
In spinwheel, you have you failsafe noted, for if it doesn't find the spin wheel, it logs out, it's noted, so if it doesn't find it, it continues on with the procedure.
I like your use of TPA's to see if you are spinning still or not. Kinda creative.
I have no clue, but when you level up, if it stops spinning you need to make it start spinning again, unless it stats spinning again after clicking the pop-up box which it looks like you have it do.
Just a few things you could fix up, after you add multiplayer, since you have TPA's there's a chance you could get members, but I would suggest learning DDTM's and using that for your walking, then it would almost definitely be a yes, if you used DDTM's to walk. Multiplayer, TPA's, and DDTM's, that's what most people like to see. Fix some standards, like in setup, there's a bunch of unneeded spaces, taking up more lines then you need to. But I like this script, I would probably vote yes.
Oh and one more thing, I saw a lot of wait's without randomness, you should do wait(x+random(xx)); instead of just wait(x);, makes it more human-like, since we don't always wait the exact same amount of milliseconds.
but good job, I like this script. You have some good potential.