Page 2 of 3 FirstFirst 123 LastLast
Results 26 to 50 of 75

Thread: [SKS] Sabzi's Kharid Smelter

  1. #26
    Join Date
    Feb 2009
    Location
    Hungary (GMT + 1)
    Posts
    1,774
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    No, there isn't any symbol finding at all. It searches for the big greyish furnace on the screen. Never had that problem before. And I know what the error means . Thx for the proggy and the only thing I can suggest you is to set the graphics to lowest, 32 bit color, max brightness. Happens often to you?

    EDIT: I have revealed quite some possibilities to make it better . Currently the lvl up finding is broken(it's an srl function) so when you lvl up the script will just stand there.(although there is a time limit, but it's too big now, will make it a const or something)
    Can you suggest me the approx smelting times? For example smelting 14 bronze bar takes 2 minute and so on.

    Oh, almost forget the most important why I edit. I appreciate the account payton gave me to test.(credits ftw!)
    Furnace finding works well.
    Last edited by Sabzi; 01-09-2010 at 08:34 PM.

  2. #27
    Join Date
    Mar 2006
    Location
    Rural New Zealand
    Posts
    688
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    i can get it to do mroe than 20 odd loads befor it loggs out due to not finding the furnace or the bank.i have an account you can use pm me if u want to use it
    Come Add A Few Hits To My Site
    Cakemix lives on

  3. #28
    Join Date
    Feb 2009
    Location
    Hungary (GMT + 1)
    Posts
    1,774
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Are guys sure everything is set up correctly and you are up to date?
    I don't need more account atm, but thanks.

    So 1.3 is up. It compiles ... This is the only thing I can say as I haven't tested it but I have made serious changes that may fail.

    Oh and I am still curious:
    Quote Originally Posted by Sabzi View Post
    Can you suggest me the approx smelting times? For example smelting 14 bronze bar takes 2 minute and so on.

  4. #29
    Join Date
    Mar 2006
    Location
    Rural New Zealand
    Posts
    688
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    ok testing as of now (1.3) and will do some smelting times
    Come Add A Few Hits To My Site
    Cakemix lives on

  5. #30
    Join Date
    Dec 2007
    Location
    Belgium
    Posts
    228
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Might give this a try after I'm done with 99 fletching!
    How do I know? Know how.

  6. #31
    Join Date
    Aug 2009
    Posts
    155
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    seems to get stuck sometimes for me. it walks to the furnace but stops toward the east side so the furnace is not completely showing and logs out saying oh my god in the debug.

  7. #32
    Join Date
    Feb 2009
    Location
    Hungary (GMT + 1)
    Posts
    1,774
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Thanks for that, just a coordinate to be changed. How level up recognizing and then starting the smelting again works? Total fail or not working?

  8. #33
    Join Date
    Dec 2009
    Posts
    40
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    It happens every minute or so. Will try changing graphics. And I'm trying 1.3 in a min.

  9. #34
    Join Date
    Aug 2009
    Posts
    155
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    i am leaving for collage in a few hours so i can not test the script for long. but a load of 5 mith bars takes a little under 14 seconds from the time it clicks "smith 10" to pulling the last bar out.


    something i would change is the wait time for the flag on the minimap to go down when returning to the bank, because if it clicks to far west, it will never go down and the player stands right next to the bankers doing nothing until it times out.

    Payton

  10. #35
    Join Date
    Aug 2008
    Location
    Finland
    Posts
    2,851
    Mentioned
    3 Post(s)
    Quoted
    2 Post(s)

    Default

    I notice you are autocoloring bank booth but still you use tolerance 10 when finding it?
    No point there. Either autocolor and tolerance 0 or pick a static color and use tolerance 10. Just a hint

  11. #36
    Join Date
    Aug 2009
    Posts
    155
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Script runtime: 1 Hours, 32 Minutes and 44 Seconds
    [=============================]
    [ sh ]
    [ Active : True ]
    [ Location : bank ]
    [ Loads : 86 ]
    [ XP gained : 12900 ]
    [ XP/hr : 8417 ]
    [ Lvlups : 0 ]
    [ Xp to goal : 437186 ]
    [ Bars made : 430 ]
    [ Bars/hr : 281 ]
    [ Breaks done : 0 ]
    [ Smelting : mithril ]
    [ Worked : 01h 3*m **s ]
    [=============================]


    working great...shut it down manually.

    Payton

  12. #37
    Join Date
    Dec 2009
    Posts
    40
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    [=========================]
    [ kuma ]
    [ Active : True ]
    [ Location : bank ]
    [ Loads : 12 ]
    [ XP gained : 1890 ]
    [ XP/hr : 7937 ]
    [ Lvlups : 0 ]
    [ Xp to goal : 3091958 ]
    [ Hours to goal : 389 ]
    [ Bars made : 108 ]
    [ Bars/hr : 454 ]
    [ Breaks done : 0 ]
    [ Smelting : steel ]
    [ Worked : 14m 17s ]
    [=========================]
    Lvld up!

    So yes, it does mess up on level ups. Other than, all is good.

  13. #38
    Join Date
    Feb 2009
    Location
    Hungary (GMT + 1)
    Posts
    1,774
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by marpis View Post
    I notice you are autocoloring bank booth but still you use tolerance 10 when finding it?
    No point there. Either autocolor and tolerance 0 or pick a static color and use tolerance 10. Just a hint
    I have tested that with lots of tolerance/auto-color. Trust me, it's good. Too many similar colors are there so if I use only one color it wouldn't be accurate. On the other hand, using a static color with bigger tolerance would give bad results too. I have really tested it a lot with debugging the TPAs/ATPAs and this seems to be the best method. If you write me a better one I would implement it gladly . Without credits of course. Those codes belongs to me!!! Joking, just joking.

  14. #39
    Join Date
    Mar 2006
    Location
    Rural New Zealand
    Posts
    688
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    script runtime: 27 Minutes and 48 Seconds
    [=========================]
    [ ihi ]
    [ Active : True ]
    [ Location : bank ]
    [ Loads : 23 ]
    [ XP gained : 3622 ]
    [ XP/hr : 8083 ]
    [ Lvlups : 0 ]
    [ Xp to goal : 1783013 ]
    [ Hours to goal : 220 ]
    [ Bars made : 207 ]
    [ Bars/hr : 462 ]
    [ Breaks done : 0 ]
    [ Smelting : steel ]
    [ Worked : 26m 53s ]
    [=========================]
    [Runtime Error] : Out Of Range in line 527 in script

    stoped as usual use to a randeom error
    Come Add A Few Hits To My Site
    Cakemix lives on

  15. #40
    Join Date
    Feb 2009
    Location
    Hungary (GMT + 1)
    Posts
    1,774
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by JiveTonto@Gmail.com View Post
    script runtime: 27 Minutes and 48 Seconds
    [=========================]
    [ ihi ]
    [ Active : True ]
    [ Location : bank ]
    [ Loads : 23 ]
    [ XP gained : 3622 ]
    [ XP/hr : 8083 ]
    [ Lvlups : 0 ]
    [ Xp to goal : 1783013 ]
    [ Hours to goal : 220 ]
    [ Bars made : 207 ]
    [ Bars/hr : 462 ]
    [ Breaks done : 0 ]
    [ Smelting : steel ]
    [ Worked : 26m 53s ]
    [=========================]
    [Runtime Error] : Out Of Range in line 527 in script

    stoped as usual use to a randeom error
    What is line 527 at you? As I am fixing the bugs in my version the lines are always different.

  16. #41
    Join Date
    Dec 2009
    Posts
    40
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    For me it still doesn't find the furnace every 5 or so runs.... have done all that suggested but no luck.

  17. #42
    Join Date
    Feb 2009
    Location
    Hungary (GMT + 1)
    Posts
    1,774
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by JackF View Post
    For me it still doesn't find the furnace every 5 or so runs.... have done all that suggested but no luck.
    I haven't got any time during the week and I was out today. I will see what can I do tomorrow.

    EDIT: I will dig up some of my army characters and will iron out the levelling bug. Other bugs are easy to fix.(I think now ...)
    Last edited by Sabzi; 01-16-2010 at 09:42 PM.

  18. #43
    Join Date
    Dec 2009
    Location
    Next to my PC
    Posts
    61
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    My character just stands there after he lvled up. He writes he lvled up, but he doesn't move at all after that, I'll try to figure this out on my own. I'll edit this post if I got it :P

    [edit]I didn't really know if i got it, as i haven't had a lvl up yet, but I got another problem (was mentioned earlier)
    Runtime Error] : Out Of Range in line 527 in script C:\*\Scar 3.23\Scripts\Sabzi's Kharid Smelter v1.3.scar
    That line is:
    527: if Players[i].Strings[1] = 'r' then
    Last edited by swisspking; 01-19-2010 at 09:08 PM.

  19. #44
    Join Date
    Feb 2009
    Location
    Hungary (GMT + 1)
    Posts
    1,774
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Uppppppppppppppppdate!
    See change log.

    Also I would be quiet happy if an advanced scripter would review the code.(not the breaking/switching part, it's messy but okay)
    For example I have found out now that I did not freed a dtm up(there from v1). More eyes sees more and I don't want stupid mistakes like that.

    Thanks for using, helping, posting proggies/bugs in advance!

    OhDAMN: I forgot to do anything with the maxtime while you are smithing. What do you think the maximum can be? Like 2 minutes for 28 ores smelted? Currently it's 5 minutes.
    Last edited by Sabzi; 01-20-2010 at 11:23 AM.

  20. #45
    Join Date
    Aug 2009
    Posts
    155
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    I think it takes 1:31 from the time the first bar goes in to the time the 28th comes out so you could use 1:45 for the max time. are you going to use 1 max time for all bar types? you could set a max time per bar and have the script take that times 4, 9, 14, 28 or whatever to find the max time for the current load.

    Payton

  21. #46
    Join Date
    Feb 2009
    Location
    Hungary (GMT + 1)
    Posts
    1,774
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by payton View Post
    I think it takes 1:31 from the time the first bar goes in to the time the 28th comes out so you could use 1:45 for the max time. are you going to use 1 max time for all bar types? you could set a max time per bar and have the script take that times 4, 9, 14, 28 or whatever to find the max time for the current load.

    Payton
    Well, that would not effect the script too much so it's not a big problem anyway. I just forgot it. Will fix that with your idea((thx)you are already in the credits, amirite?) later when I got bigger things to do. (I am planning to make a form)
    Sadly I will got an operation soon(not a serious one, just a little) so I won't go to school in this week.

  22. #47
    Join Date
    Aug 2009
    Posts
    155
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    you need to lower the wait time from when it walks to the bank(and flag stays on mm) and when it clicks on banker. it is 5-10 seconds to long right now.

    and you are right i am in the credits. thanks

    Payton

  23. #48
    Join Date
    Feb 2009
    Location
    Hungary (GMT + 1)
    Posts
    1,774
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by payton View Post
    you need to lower the wait time from when it walks to the bank(and flag stays on mm) and when it clicks on banker. it is 5-10 seconds to long right now.

    and you are right i am in the credits. thanks

    Payton
    That wait is not because of my script. It's in SRl. But I may find something to work around that. Should be easy.

  24. #49
    Join Date
    Aug 2009
    Posts
    155
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    ok. have you been testing this with 1 player? for me after the first break it will just do 1 load then break again.

    Payton

  25. #50
    Join Date
    Feb 2009
    Location
    Hungary (GMT + 1)
    Posts
    1,774
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by payton View Post
    ok. have you been testing this with 1 player? for me after the first break it will just do 1 load then break again.

    Payton
    Hmmm... I had that problem before than sorted things but it seems I mucked up something not too long ago. I will surely investigate that too. But only expect things tomorrow as it's 23:12 here and I can't script now.

    EDIT: I really appreciate that you are helping to make this a better script. Thx (must spread some rep to give you again ...)

Page 2 of 3 FirstFirst 123 LastLast

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •