Results 1 to 8 of 8

Thread: Simple Edgeville Addy Smelter

  1. #1
    Join Date
    Dec 2009
    Posts
    146
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default Simple Edgeville Addy Smelter

    Made this simple smelter today, ran it for four hours and it seemed to do okay but it didn't encounter any randoms.

    Any comments/suggestions are welcomed.

    Feel free to take it and expand it to handle other ores.


    Edit 1/21/10: I updated a few small things with the mouse clicks and rewrote the includes and functions as suggested. All comments welcomed.
    Edit 1/22/10: Added a DeclarePlayers function as it was causing part of AntiRandoms.scar to crash without it.

    Jim
    Last edited by jimthesoundman; 01-23-2010 at 06:03 AM.

  2. #2
    Join Date
    Dec 2009
    Location
    Next to my PC
    Posts
    61
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Why is this tagged as Runecrafting and why do you include runecrafting.scar in a smithing script? Other than that I'd suggest you to add DeclarePlayers.

    Script looks good at first look although I don't like the "blindclick for furnace", how about running to the tree there or something?

    ~Swiss
    Last edited by swisspking; 01-20-2010 at 12:17 PM.

  3. #3
    Join Date
    Dec 2009
    Location
    Newcastle, Australia
    Posts
    888
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    You have many issues...
    A: You included runecrafting.scar in a smelting script
    B: You created a find furnace function, when there already is one in smithing.scar
    C: Co-Ordinate Clicking
    D: Poor organisation, Whist standards are great...your organisation of functions/procedures are poor, personally i prefer a seperate functions for walking...

    You also want basic things like...Login functions, checkout login.scar, its located in includes/SRL/Base/login.scar (Don't include its already included)

    right... now how to improve the errors you made...
    A: Fairly simple...delete that line... don't include uncessesary files
    B: always look at skill relevant, Skill includes... the are at {scarfolder}/includes/SRL/skill/
    C: DTMs to find the co-ordinates, many guides to help you...and it makes it much easier to get all the bar types and reduces detectability
    D:Like I said, one function at a time, Walk to furnace, Smelt, Walk to bank, Bank, 4 basic sections and progress reports...

    These basic things can help you improve...just remember we all start somewhere,

  4. #4
    Join Date
    Feb 2009
    Location
    Hungary (GMT + 1)
    Posts
    1,774
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    @B: The one in smithing.scar is not really working so modifying that/making your own is a better option.

  5. #5
    Join Date
    Dec 2009
    Posts
    146
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    My bad, I was also working on a ZMI script and after all that going back and forth I guess my brain has just turned to mush. I copied part of the ZMI script over to start this one and when I posted it I still was being braindead and tagged it as Runecrafting instead of Smithing. So, how do I change that RC icon at the top to Smithing?

    JIM

  6. #6
    Join Date
    Dec 2009
    Posts
    146
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by swisspking View Post
    Script looks good at first look although I don't like the "blindclick for furnace", how about running to the tree there or something?
    The bank and the furnace are so close together, that on the rare occasion when the FindSymbol function might fail, it's not a stretch to use a blindclick as a backup. Doesn't seem like there is any way the blindclick could fail, unless the user rotated the camera or something like that. I ran it for four hours and it was always able to find the furnace.

    JMHO,

    JIM

  7. #7
    Join Date
    Feb 2009
    Location
    Hungary (GMT + 1)
    Posts
    1,774
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    1st: use the edit button, pls don't double post
    2nd: just report the thread using the little red cross near the blue rep+/- tick and say that you want to change the icon from rc to smithing and a staff member will do that

  8. #8
    Join Date
    Dec 2009
    Location
    Newcastle, Australia
    Posts
    888
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Oh, didn't realise the findfurnace didn't work, assumed it would...never did anything involving smelting...

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •