We completely kinda re-wrote it. Not trying to be a credit hoar. Shouldn't it be something like this though?
by: NCDS, Coh3n, Sabzi, nielsie95, and Timer
We completely kinda re-wrote it. Not trying to be a credit hoar. Shouldn't it be something like this though?
by: NCDS, Coh3n, Sabzi, nielsie95, and Timer
Waiting 45 seconds if the bankscreen isn't open.
No thanks.
Now honestly, I haven't had any problems with BankScreen in two years. Is this really necessary to tinker with stuff if it's working fine to get 100 ms out of something that isn't even used in a loop? I mean if you need to optimize it that bad then make a BankScreen2 in your script. Comon.
I'm not forcing anyone to add this to the SRL include. I simply pointed out that this way is faster and am leaving the rest up to the public and dev's.
I see nothing wrong with that.
Doesn't it also make sense though to keep our include running as fast and efficient as possible?
Bankscreen is really stable right now, so why even bother messing with it? What are you going to do with an excess of 150ms? It usually takes the bankscreen around that time to load your items after the text appears anyways. Even if you could add the 150 ms excess to the actual script efficiency time the average script does 30 trips per an hour so you save 3 seconds an hour. Great.
I don't see why this frustrates you so much. Is this not what this section of the forums are for?
There is no need to continue to "debate" this. I did my part by bringing this to everyone's attention. Whatever happens now is up to everyone else. That's that.
Bump.
I suggest this is implanted, as current BankScreen always gives false positives.
This will not help prevent false positives, it uses the same argument for results.
"Result := FindTextTPA(4106994, 20, 20, 22, 400, 45, 'Bank', upchars, Nothing);"
The current bankscreen will exit immediately if a suspected bankscreen is not open hence the looping is done after a color check
"if (CountColor(0, MSX1, MSY1, MSX2, MSY2) > 113000) then"
The one suggested here will always wait 5+ seconds if the bankscreen is not up.
I don't think everyone wants to wait 5+ seconds if the bankscreen is not up. This isn't exactly the kinda thing you want to be universal in every script that uses SRL.
If you still have problems with the current one (which I don't) then I suggest you find another solution(suggested fix) or make a "BankScreen2" for one that fits your current purpose better.
There are currently 1 users browsing this thread. (0 members and 1 guests)