Page 2 of 2 FirstFirst 12
Results 26 to 39 of 39

Thread: Re-organized BankScreen for faster result

  1. #26
    Join Date
    May 2007
    Location
    Ohio
    Posts
    2,296
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    We completely kinda re-wrote it. Not trying to be a credit hoar. Shouldn't it be something like this though?

    by: NCDS, Coh3n, Sabzi, nielsie95, and Timer

  2. #27
    Join Date
    Oct 2007
    Location
    #srl
    Posts
    6,102
    Mentioned
    39 Post(s)
    Quoted
    62 Post(s)

    Default

    Quote Originally Posted by Timer View Post
    We completely kinda re-wrote it. Not trying to be a credit hoar. Shouldn't it be something like this though?

    by: NCDS, Coh3n, Sabzi, nielsie95, and Timer
    Fixed that too

  3. #28
    Join Date
    May 2007
    Location
    Ohio
    Posts
    2,296
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by NCDS View Post
    Fixed that too
    I wish we were all Devs. :<

  4. #29
    Join Date
    Dec 2006
    Location
    Houston, TX USA
    Posts
    4,791
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Waiting 45 seconds if the bankscreen isn't open.

    No thanks.

  5. #30
    Join Date
    Oct 2007
    Location
    #srl
    Posts
    6,102
    Mentioned
    39 Post(s)
    Quoted
    62 Post(s)

    Default

    Quote Originally Posted by IceFire908 View Post
    Waiting 45 seconds if the bankscreen isn't open.

    No thanks.
    I thought that too when I read it but assumed it was left from the previous function. I think a 5 second wait would suffice.

  6. #31
    Join Date
    Dec 2006
    Location
    Houston, TX USA
    Posts
    4,791
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Now honestly, I haven't had any problems with BankScreen in two years. Is this really necessary to tinker with stuff if it's working fine to get 100 ms out of something that isn't even used in a loop? I mean if you need to optimize it that bad then make a BankScreen2 in your script. Comon.

  7. #32
    Join Date
    Oct 2007
    Location
    #srl
    Posts
    6,102
    Mentioned
    39 Post(s)
    Quoted
    62 Post(s)

    Default

    Quote Originally Posted by IceFire908 View Post
    Now honestly, I haven't had any problems with BankScreen in two years. Is this really necessary to tinker with stuff if it's working fine to get 100 ms out of something that isn't even used in a loop? I mean if you need to optimize it that bad then make a BankScreen2 in your script. Comon.
    I'm not forcing anyone to add this to the SRL include. I simply pointed out that this way is faster and am leaving the rest up to the public and dev's.

    I see nothing wrong with that.

    Doesn't it also make sense though to keep our include running as fast and efficient as possible?

  8. #33
    Join Date
    Dec 2006
    Location
    Houston, TX USA
    Posts
    4,791
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Bankscreen is really stable right now, so why even bother messing with it? What are you going to do with an excess of 150ms? It usually takes the bankscreen around that time to load your items after the text appears anyways. Even if you could add the 150 ms excess to the actual script efficiency time the average script does 30 trips per an hour so you save 3 seconds an hour. Great.

  9. #34
    Join Date
    Oct 2007
    Location
    #srl
    Posts
    6,102
    Mentioned
    39 Post(s)
    Quoted
    62 Post(s)

    Default

    I don't see why this frustrates you so much. Is this not what this section of the forums are for?

    There is no need to continue to "debate" this. I did my part by bringing this to everyone's attention. Whatever happens now is up to everyone else. That's that.

  10. #35
    Join Date
    May 2007
    Location
    Ohio
    Posts
    2,296
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Bump.

    I suggest this is implanted, as current BankScreen always gives false positives.

  11. #36
    Join Date
    Jan 2007
    Posts
    8,876
    Mentioned
    123 Post(s)
    Quoted
    327 Post(s)

    Default

    Quote Originally Posted by Timer View Post
    Bump.

    I suggest this is implanted, as current BankScreen always gives false positives.
    If this doesn't give false positives then I agree

  12. #37
    Join Date
    Dec 2006
    Location
    Houston, TX USA
    Posts
    4,791
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    This will not help prevent false positives, it uses the same argument for results.

    "Result := FindTextTPA(4106994, 20, 20, 22, 400, 45, 'Bank', upchars, Nothing);"

    The current bankscreen will exit immediately if a suspected bankscreen is not open hence the looping is done after a color check

    "if (CountColor(0, MSX1, MSY1, MSX2, MSY2) > 113000) then"

    The one suggested here will always wait 5+ seconds if the bankscreen is not up.

    I don't think everyone wants to wait 5+ seconds if the bankscreen is not up. This isn't exactly the kinda thing you want to be universal in every script that uses SRL.

    If you still have problems with the current one (which I don't) then I suggest you find another solution(suggested fix) or make a "BankScreen2" for one that fits your current purpose better.

  13. #38
    Join Date
    Oct 2007
    Location
    #srl
    Posts
    6,102
    Mentioned
    39 Post(s)
    Quoted
    62 Post(s)

    Default

    Quote Originally Posted by IceFire908 View Post
    This will not help prevent false positives, it uses the same argument for results.

    "Result := FindTextTPA(4106994, 20, 20, 22, 400, 45, 'Bank', upchars, Nothing);"

    The current bankscreen will exit immediately if a suspected bankscreen is not open hence the looping is done after a color check

    "if (CountColor(0, MSX1, MSY1, MSX2, MSY2) > 113000) then"

    The one suggested here will always wait 5+ seconds if the bankscreen is not up.

    I don't think everyone wants to wait 5+ seconds if the bankscreen is not up. This isn't exactly the kinda thing you want to be universal in every script that uses SRL.

    If you still have problems with the current one (which I don't) then I suggest you find another solution(suggested fix) or make a "BankScreen2" for one that fits your current purpose better.
    Could you please explain this:
    SCAR Code:
    MouseBox(26, 138, 489, 157, 1);
    in the current BankScreen function? I've wondered about that for a while now.

    I don't like the current BankScreen function honestly, but it has been working fine for me lately.

  14. #39
    Join Date
    Dec 2006
    Location
    Houston, TX USA
    Posts
    4,791
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by NCDS View Post
    Could you please explain this:
    SCAR Code:
    MouseBox(26, 138, 489, 157, 1);
    in the current BankScreen function? I've wondered about that for a while now.

    I don't like the current BankScreen function honestly, but it has been working fine for me lately.
    It's been like this since OpenDev Rev 1, ask Wizzup I guess

Page 2 of 2 FirstFirst 12

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •