Results 1 to 13 of 13

Thread: InvCount or DepositAll bug, I'm not sure..

  1. #1
    Join Date
    Dec 2009
    Posts
    146
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default InvCount or DepositAll bug, I'm not sure..

    I was testing a new script last night. Ran fine for over four hours, no problems at all.

    Woke up this morning and decided to make sure Scar and SRL were all up to date so I Tortoise'd them both to make sure they were up to date.

    Now I'm having a wierd issue with a snippet of code that was running flawlessly last night.

    It is part of a banking procedure:

    Code:
    if (PinScreen then
       InPin(IntToStr(PinNumber));
    until BankScreen;
    FindNormalRandoms;
    if InvCount>0 then
       begin
       DepositAll;
       wait(1000+random(1000));
       end;
    So, last night it worked find.
    Today, what it's doing is:after the bankscreen opens up, the mouse is moving to about 656,187 and hovering around over where the inventory tab would be. But since the bankscreen is already open, there is no tab there. It just hovers there and moves around a bit, but it doesn't click or anything.
    I've tried commenting out the FindNormalRandoms to see if that was causing it. Didn't change anything.
    Then I tried to comment out the DepositAll line and substitute a blindclick at 397,307 but that didn't change anything either.
    Then I tried to substitute a FindColorTolerance for the InvCount>0 to see if that was causing it, but it didn't change anything either.

    Next I figured maybe somehow my SCAR or SRL got corrupted so I downloaded both of them from scratch and reinstalled them. Still no change.

    So I'm stumped.

    Anyone have any ideas?

  2. #2
    Join Date
    Aug 2009
    Location
    Inside the Matrix...yes it has me, and it has you too.
    Posts
    1,896
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by jimthesoundman View Post
    I was testing a new script last night. Ran fine for over four hours, no problems at all.

    Woke up this morning and decided to make sure Scar and SRL were all up to date so I Tortoise'd them both to make sure they were up to date.

    Now I'm having a wierd issue with a snippet of code that was running flawlessly last night.

    It is part of a banking procedure:

    Code:
    if (PinScreen then
       InPin(IntToStr(PinNumber));
    until BankScreen;
    FindNormalRandoms;
    if InvCount>0 then
       begin
       DepositAll;
       wait(1000+random(1000));
       end;
    So, last night it worked find.
    Today, what it's doing is:after the bankscreen opens up, the mouse is moving to about 656,187 and hovering around over where the inventory tab would be. But since the bankscreen is already open, there is no tab there. It just hovers there and moves around a bit, but it doesn't click or anything.
    I've tried commenting out the FindNormalRandoms to see if that was causing it. Didn't change anything.
    Then I tried to comment out the DepositAll line and substitute a blindclick at 397,307 but that didn't change anything either.
    Then I tried to substitute a FindColorTolerance for the InvCount>0 to see if that was causing it, but it didn't change anything either.

    Next I figured maybe somehow my SCAR or SRL got corrupted so I downloaded both of them from scratch and reinstalled them. Still no change.

    So I'm stumped.

    Anyone have any ideas?
    Hmm...I'm getting the same bug with the script I'm working on, I'm not sure if it's clicking or not, because it is already on the inventory tab.
    NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN

  3. #3
    Join Date
    Nov 2007
    Posts
    77
    Mentioned
    0 Post(s)
    Quoted
    1 Post(s)

    Default

    ive got some problem since this morning too :S with banking part it was working fine yesterday.... mmouseitem problem, mayb updates

  4. #4
    Join Date
    Jan 2008
    Location
    Ontario, Canada
    Posts
    7,805
    Mentioned
    5 Post(s)
    Quoted
    3 Post(s)

    Default

    Its probably checking for inventory randoms..

    Take out the FindNormalRandoms from that spot and it should work.
    Writing an SRL Member Application | [Updated] Pascal Scripting Statements
    My GitHub

    Progress Report:
    13:46 <@BenLand100> <SourceCode> @BenLand100: what you have just said shows you 
                        have serious physchological problems
    13:46 <@BenLand100> HE GETS IT!
    13:46 <@BenLand100> HE FINALLY GETS IT!!!!1

  5. #5
    Join Date
    Aug 2009
    Location
    Inside the Matrix...yes it has me, and it has you too.
    Posts
    1,896
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by Nava2 View Post
    Its probably checking for inventory randoms..

    Take out the FindNormalRandoms from that spot and it should work.
    i have all the FindNormalRandoms edited out of the script for its testing stage, as it needs a declareplayers section to compile, which i dont have atm. That's not it
    NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN

  6. #6
    Join Date
    Apr 2007
    Location
    Melbourne, Aus
    Posts
    202
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by jimthesoundman View Post
    Code:
    if (PinScreen then
       InPin(IntToStr(PinNumber));
    until BankScreen;
    FindNormalRandoms;
    if InvCount>0 then
       begin
       DepositAll;
       wait(1000+random(1000));
       end;
    Try this:
    Code:
    repeat
      if PinScreen then InPin(IntToStr(PinNumber));
    until BankScreen;
    FindNormalRandoms;
    if InvCount>0 then
    begin
      DepositAll;
      wait(1000+random(1000));
    end;

  7. #7
    Join Date
    Dec 2009
    Posts
    146
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    That was a typo in my post, not in my script.

    The original was:

    Code:
    procedure Banking;
    begin
    ClickNorth(true);
    repeat
      if not OpenBankNPC then
      if not OpenBank('lb',false,false) then
      if not FindBank('lb') then
      if not OpenBankGlass('lb', false, false) then
      OpenBankFast('lb');
      if (PinScreen) then 
         InPin(IntToStr(PinNumber));
    until BankScreen;
    FindNormalRandoms;
    if InvCount>0 then
    begin
      DepositAll;
      wait(1000+random(1000));
    end;
    mouse(53,107,10,10,false); //Rightclick on flax
    getmousepos(xx,yy);
    wait(500+random(500));
    mouse(xx,yy+103+random(2),30,0,true); //Left click on withdraw all
    wait(500+random(500));
    CloseBank;
    end;
    but I'll try your version just to see what happens. Thanks!

    EDIT: Nope, doesn't work any better than before, but now it hovers at a different spot 716,482 near where the music menu tab would be. I have no idea what is going on here.
    Last edited by jimthesoundman; 02-02-2010 at 12:14 AM.

  8. #8
    Join Date
    Feb 2006
    Location
    L.A, USA
    Posts
    1,632
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Yeah I get the same thing too.
    I think there's something wrong with InvFull, InvCount, > ExistsItem > GameTab()

    I'm too sleepy right now to figure out exactly what

    EDIT: Runescape updated?
    Last edited by WhiteShadow; 02-02-2010 at 12:19 AM.

  9. #9
    Join Date
    Aug 2009
    Location
    Inside the Matrix...yes it has me, and it has you too.
    Posts
    1,896
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by WhiteShadow View Post
    Yeah I get the same thing too.
    I think there's something wrong with InvFull, InvCount, > ExistsItem > GameTab()

    I'm too sleepy right now to figure out exactly what
    Hmm...that gives me an idea...
    It might be InvFull, because out of those four things, thats the only thing i use in my script.
    Ill take it out and use
    SCAR Code:
    If FindBlackChatMessage('Your inventory is too full to hold any more logs.') Then
    Begin
      Writeln('Inventory is full.');
      Exit;
    End;
    Will get back to you

    E: oo i gave it away that its a wcer ^.^ meh w/e thats only a part of it

    E: it worked, but now im sad, as i found out my chop detection method dosn't work
    Last edited by Bionicle; 02-02-2010 at 12:23 AM.
    NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN

  10. #10
    Join Date
    May 2007
    Location
    Ohio
    Posts
    2,296
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Hahaha.. fail. I already updated my SRL manually.

  11. #11
    Join Date
    Aug 2009
    Location
    Inside the Matrix...yes it has me, and it has you too.
    Posts
    1,896
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by Timer View Post
    Hahaha.. fail. I already updated my SRL manually.
    Command | Update
    Completed | At revision: 360
    I have the latest revision =.=
    NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN

  12. #12
    Join Date
    Jan 2008
    Location
    Ontario, Canada
    Posts
    7,805
    Mentioned
    5 Post(s)
    Quoted
    3 Post(s)

    Default

    Its BankScreen.

    Thats why its messing up. I think BankScreen is broken, its the only way that it would mess up. BankScreen must be returning true.
    Writing an SRL Member Application | [Updated] Pascal Scripting Statements
    My GitHub

    Progress Report:
    13:46 <@BenLand100> <SourceCode> @BenLand100: what you have just said shows you 
                        have serious physchological problems
    13:46 <@BenLand100> HE GETS IT!
    13:46 <@BenLand100> HE FINALLY GETS IT!!!!1

  13. #13
    Join Date
    Aug 2009
    Location
    Inside the Matrix...yes it has me, and it has you too.
    Posts
    1,896
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by Nava2 View Post
    Its BankScreen.

    Thats why its messing up. I think BankScreen is broken, its the only way that it would mess up. BankScreen must be returning true.
    I fixed one of the things that was messing up a lot of the functions:
    http://www.villavu.com/forum/showthread.php?t=54662
    GameTab and Inventory functions are fixed with this AFAIK
    NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN NYAN

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •