HERR Blore!

[blackelvis]

i tried changing the bitmaps for vial of water, clean ranarr, and unf ranarr, to make unf ranarrs w/ clean herbs but to no avail. also what is vialmask and leafmask? idk but maybe that is the problem.

[ForgotMyName]

i tried changing the bitmaps for vial of water, clean ranarr, and unf ranarr, to make unf ranarrs w/ clean herbs but to no avail. also what is vialmask and leafmask? idk but maybe that is the problem.

The masks are a set of black/white bitmaps that specify which pixels in an icon are considered important (i.e. used in comparisons) and which aren't. Since the icons themselves have changed shapes and not just color makeup, you'd need to update the masks too. In particular, I suspect you're now catching bits of the inventory background and missing bits of the herb/vial in question.

[WT-Fakawi]

Have they changed the bitmaps already? Sure? Are you running safe mode and 32-bits color scheme?

[blackelvis]

yeah i know the vials are all changed and i am almost certain the herbs are, too. a lot of mats got changed in this update like logs etc. I'd be more than happy to get all the bitmaps or w/e you need, i just dont know how to put it all together it myself.

[WT-Fakawi]

yeah i know the vials are all changed and i am almost certain the herbs are, too. a lot of mats got changed in this update like logs etc. I'd be more than happy to get all the bitmaps or w/e you need, i just dont know how to put it all together it myself.

Hmmm, last time they did that was loooong ago. Anyway; halfway down the first page of this thread I wrote a small tut how to make your own bitmaps. Shouldnt be to hard. Just make sure you dont take any outline (shadow) in the bitmap.

[blackelvis]

so i updated the bitmaps and it works, insofar as it can withdraw everything but when it tries to use a clean w/ a vial of water it chooses to use the vial instead of using the herb with the vial

[ForgotMyName]

so i updated the bitmaps and it works, insofar as it can withdraw everything but when it tries to use a clean w/ a vial of water it chooses to use the vial instead of using the herb with the vial

Read my post above about bitmap masks. You'll have to change all the inputs to the functions and not just some. Specifically, I think you need to replace the masks for leaves and vials. I think the core logic should still work fine, though.

[blackelvis]

i dont think i explained it correctly. The script can select the herb and then try to use it with the vial. But, recently, there's been added an option, which allows you to right click with an item selected for use, and instead of using your already selected item, select the second item for use on something entirely different. E.G. if i have a Clean Ranarr selected for use and right click a Vial of Water, I will be presented with the option to use the herb with the vial or to just 'use' the vial.

[ForgotMyName]

Oh sorry. I misunderstood at first.
You want it to select:
Use clean avantoe -> Vial of water
rather than
Use vial of water

First, I'm rather surprised it right clicks the second when it should do just as well left clicking it.

Right, so currently, around line 730, we have

If WeHave(CleanHerb, 'inv', x, y) then
begin
Mouse(x, y, 8, 8, False);
if not ChooseOption('Use') then
begin
end
end
else
Quit('Out of CleanHerb');

If WeHave(VialOfWater, 'inv', x, y) then
begin
Mouse(x, y, 8, 8, False);
if not ChooseOption('Use') then
begin
end
end
else
Quit('Out of Vials');

The first one is still fine. There's only one use option when you first select the herb. The second one is ambiguous. We ask it to click "Use" but don't specify which one.

My idea would be to make it go for the herb name, since that's unambiguously present in only one part of the menu. That will require a bit of work on your part to get it to change the name depending on which herb you're using.

Also, beware, you probably need to make this change for the other modes as well.

EDIT:

I did suggest you could apply a rough fix by making it left click the second item. I'm not entirely sure there aren't other consequences from that though. If Fawki made his script do right clicks, there may be a reason I didn't notice.

[blackelvis]

If WeHave(CleanHerb, 'inv', x, y) then
begin
Mouse(x, y, 8, 8, False);
if not ChooseOption('Use') then
begin
end
end
else
Quit('Out of CleanHerb');

If WeHave(VialOfWater, 'inv', x, y) then
begin
Mouse(x, y, 8, 8, False);
if not ChooseOption('anarr') then   <-------------
begin
end
end
else
Quit('Out of Vials');

thanks for the advice! this worked for making unf pots with clean ranarrs. same lines around 730 or w/e

[WT-Fakawi]

The rightclicks are neccesary because many times left clicks fail. not because SRL fails, but because runescape does


I will take a look at it once I have a member at my disposal