+ Reply to Thread
Results 1 to 7 of 7

Thread: MSI_GetReportInfo

  1. #1
    Join Date
    Aug 2007
    Location
    in a random little world
    Posts
    5,778
    Mentioned
    0 Post(s)
    Quoted
    7 Post(s)

    Default MSI_GetReportInfo

    while testing out the form which i made earlier today i noticed that the activity isnt updating in the report
    i think it should be changed to


    SCAR Code:
    procedure MSI_GetReportInfo;
    var
      skill, i: Integer;
    begin
      for i:=0 to (HowManyPlayers-1) do
        with ProgressReportArray[i] do
        begin
          if (i=CurrentPlayer) then
          begin
            skill := MSI_Scripts[MSI_Players[i].Scripts[CurrentScript]].SkillConstant;
            ScriptInfo[i].PlayerSkillLevel := GetSkillLevel(skill);
          end;

          PlayerLoc    := MSI_Players[i].Location;
          PlayerStatus := MSI_Players[i].Active;
        end;
    end;

    ~shut
    Last edited by Shuttleu; 07-22-2010 at 08:34 PM.

  2. #2
    Join Date
    Jul 2007
    Location
    Right now? Chair.
    Posts
    8,488
    Mentioned
    3 Post(s)
    Quoted
    12 Post(s)

    Default

    Waste of time:
    SCAR Code:
    level := GetSkillLevel(skill);
            if (level > ScriptInfo[CurrentScript].PlayerSkillLevel) then
              ScriptInfo[i].PlayerSkillLevel := level;
          end;

    //better off

    ScriptInfo[i].PlayerSkillLevel := GetSkillLevel(skill);

    otherwise looks good

    ~RM

    I & I know Zion. It is in the spirit, body and mind of every one of us
    RMouse(obj: TMSIObject): boolean;

  3. #3
    Join Date
    Aug 2007
    Location
    in a random little world
    Posts
    5,778
    Mentioned
    0 Post(s)
    Quoted
    7 Post(s)

  4. #4
    Join Date
    Jul 2007
    Location
    Right now? Chair.
    Posts
    8,488
    Mentioned
    3 Post(s)
    Quoted
    12 Post(s)

    Default

    Quote Originally Posted by Shuttleu View Post
    it just if we have it the way it is at the mo then if you set a user from false to true then it wont update the activity in the report even though the user is set to true

    ~shut
    I know, I never 'complained' about anything like that

    The level thing is just something that I picked up now

    ~RM

    I & I know Zion. It is in the spirit, body and mind of every one of us
    RMouse(obj: TMSIObject): boolean;

  5. #5
    Join Date
    Aug 2007
    Location
    in a random little world
    Posts
    5,778
    Mentioned
    0 Post(s)
    Quoted
    7 Post(s)

    Default

    Quote Originally Posted by Rasta Magician View Post
    I know, I never 'complained' about anything like that

    The level thing is just something that I picked up now

    ~RM
    yea, i just left it like that because that is what it is like at the mo

    i will update the first post with your idea

    ~shut

  6. #6
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    The level thing is there because sometimes GetSkillLevel doesn't work and it results in -1, causing the report to print "Not yet defined". Also, the ScriptInfo[i] still needs to be ScriptInfo[CurrentScript].

    Anyway, committed.

  7. #7
    Join Date
    Aug 2007
    Location
    in a random little world
    Posts
    5,778
    Mentioned
    0 Post(s)
    Quoted
    7 Post(s)

    Default

    Quote Originally Posted by Coh3n View Post
    The level thing is there because sometimes GetSkillLevel doesn't work and it results in -1, causing the report to print "Not yet defined". Also, the ScriptInfo[i] still needs to be ScriptInfo[CurrentScript].

    Anyway, committed.
    ah, didnt realise, i mistook it for CurrentPlayer

    but anyway, glad i could help

    ~shut

+ Reply to Thread

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may post replies
  • You may post attachments
  • You may edit your posts
  •