Results 1 to 19 of 19

Thread: Magic.Scar

  1. #1
    Join Date
    Dec 2009
    Location
    Newcastle, Australia
    Posts
    888
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default Magic.Scar

    Found a bug, and solved, the Magic.scar Spell information has a simple bug, which I have already solved.
    line 770
    (Coords.Y1 := P div 7 * 24 + 217; )

    needs to be changed to

    Coords.Y1 := P div 6 * 24 + 217;
    Last edited by Bad Boy JH; 01-04-2011 at 01:58 AM.

    Current Script Project
    Pot of flour gatherer - 95% done

    Can't get Simba to work? Click here for a tutorial

  2. #2
    Join Date
    Oct 2007
    Location
    #srl
    Posts
    6,102
    Mentioned
    39 Post(s)
    Quoted
    62 Post(s)

    Default

    Quote Originally Posted by Bad Boy JH View Post
    Found a bug, and solved, the Magic.scar Spell information has a simple bug, which I have already solved.
    line 770
    (Coords.Y1 := P div 7 * 24 + 217; )

    needs to be changed to

    Coords.Y1 := P div 6 * 24 + 217;
    That doesn't work for all spells on all the sorts, neither does how it currently is, but I found the current way to have a higher success rate than 'div 6'.

  3. #3
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    It's helpful if you explain what exactly the bug is.

  4. #4
    Join Date
    Dec 2009
    Location
    Newcastle, Australia
    Posts
    888
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    its not going to the correct row of the spells, which are 6 spells across.
    The 7th one, (1st spell, 2nd line) Goes to the 1st spell, (1st Spell 1st line),
    The 8th one (2nd spell, 2nd line), goes to the 8th spell.

    the 13th one (1st spell, 3rd line), goes to te 7th spell, (1st Spell, 2nd line),
    the 14th one (2nd spell, 3rd line), goes to the 8th spell, (2nd spell 2nd line),
    the 15th one (3rd spell, 3rd line), goes to the 15th spell.

    for the record the variable "P" for the Nth spell is N-1

    Current Script Project
    Pot of flour gatherer - 95% done

    Can't get Simba to work? Click here for a tutorial

  5. #5
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    I think we need a formula that works for all the spells before I commit anything else.

  6. #6
    Join Date
    Dec 2009
    Location
    Newcastle, Australia
    Posts
    888
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    perhaps it detects which books are open, and then uses an appropriate formula from there...

    Current Script Project
    Pot of flour gatherer - 95% done

    Can't get Simba to work? Click here for a tutorial

  7. #7
    Join Date
    Oct 2007
    Location
    #srl
    Posts
    6,102
    Mentioned
    39 Post(s)
    Quoted
    62 Post(s)

    Default

    Quote Originally Posted by Bad Boy JH View Post
    perhaps it detects which books are open, and then uses an appropriate formula from there...
    That would be quite simply done with a case, but I'm not sure if it would ever be added. Things like that don't generally satisfy the dev's.

    Just do case SpellBookSort of or whatever the var is and see what people say.

  8. #8
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    Quote Originally Posted by Bad Boy JH View Post
    perhaps it detects which books are open, and then uses an appropriate formula from there...
    I think that already exists? I may be wrong though. Considering there's an array of spell modes it would only make sense that there's the option to select them.

  9. #9
    Join Date
    Oct 2007
    Location
    #srl
    Posts
    6,102
    Mentioned
    39 Post(s)
    Quoted
    62 Post(s)

    Default

    Quote Originally Posted by Coh3n View Post
    I think that already exists? I may be wrong though. Considering there's an array of spell modes it would only make sense that there's the option to select them.
    It could be done using 'SpellIsSort' and 'BookSortedBy' but a case would still be necessary in SpellAvailable to select the appropriate equation to use. If this method is used, that is.

  10. #10
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    Quote Originally Posted by NCDS View Post
    It could be done using 'SpellIsSort' and 'BookSortedBy' but a case would still be necessary in SpellAvailable to select the appropriate equation to use. If this method is used, that is.
    I don't see anything wrong with a case. Sounds like it would work perfectly.

  11. #11
    Join Date
    Dec 2009
    Location
    Newcastle, Australia
    Posts
    888
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    I will have to experement, which I will do today, to see when each equation works...

    Current Script Project
    Pot of flour gatherer - 95% done

    Can't get Simba to work? Click here for a tutorial

  12. #12
    Join Date
    Aug 2007
    Location
    Hawaii
    Posts
    3,880
    Mentioned
    7 Post(s)
    Quoted
    152 Post(s)

    Default

    I just noticed that when ever I set my script to cast High Level Alchemy it doesn't left click. It just right clicks then chooses High Level Alchemy then alches, which is much slower and bannable as no rs player right clicks the spell, chooses the spell, then casts it for alching...

    While were at it, it also hovers over the spell options waay to much.
    Faith is an oasis in the heart which will never be reached by the caravan of thinking.

  13. #13
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    Quote Originally Posted by kingarabian View Post
    I just noticed that when ever I set my script to cast High Level Alchemy it doesn't left click. It just right clicks then chooses High Level Alchemy then alches, which is much slower and bannable as no rs player right clicks the spell, chooses the spell, then casts it for alching...
    It never used to to this, I'm not sure why it would start now, unless for some reason the uptext has changed.

    Quote Originally Posted by kingarabian View Post
    While were at it, it also hovers over the spell options waay to much.
    I have no idea what that means? More description would be helpful here.

    On another note (this isn't directed at you, but everyone who says things and "really bannable"; probably one of my pet peeves): when was the last time you heard of an SRL user being banned, especially for something as trivial as right clicking instead of left? I highly, highly doubt something like that would alert Jagex even the slightest. The option is in the game, you can't get banned for using it. Also, 90% of all bans are from accounts being flagged from being reported. No one can report you when they can't tell if you're right or left clicking.

    Sorry for that little rant, but I've wanted to say that for a very long time.

  14. #14
    Join Date
    Nov 2010
    Location
    Australia
    Posts
    1,472
    Mentioned
    0 Post(s)
    Quoted
    8 Post(s)

    Default

    I would say the easiest way to cast spells is to make a bitmap of the image and then find it and click it, i tried using magic.scar and it failed me as well.

  15. #15
    Join Date
    Aug 2007
    Location
    Hawaii
    Posts
    3,880
    Mentioned
    7 Post(s)
    Quoted
    152 Post(s)

    Default

    Quote Originally Posted by Coh3n View Post
    It never used to to this, I'm not sure why it would start now, unless for some reason the uptext has changed.


    I have no idea what that means? More description would be helpful here.

    On another note (this isn't directed at you, but everyone who says things and "really bannable"; probably one of my pet peeves): when was the last time you heard of an SRL user being banned, especially for something as trivial as right clicking instead of left? I highly, highly doubt something like that would alert Jagex even the slightest. The option is in the game, you can't get banned for using it. Also, 90% of all bans are from accounts being flagged from being reported. No one can report you when they can't tell if you're right or left clicking.

    Sorry for that little rant, but I've wanted to say that for a very long time.

    Alright lemme clarify more:

    You know what mouse hovering is right, like when the mouse goes over a certain thing/object/item etc repeatedly but does not click on anything/

    What I mean by bannable, is if I keep botting and my account gets flagged, Jagex will look at my mouse movements and my techniques. So if I get flagged for suspicion that I am currently botting my Mage with the High Level Alchemy spell, they will realize that each time I alch, I am right clicking the spell, then clicking the spell from the menu option, then casting it on the item. That doesn't make sense because a real player would just left click the spell and cast it on the item as its much easier, and less time consuming. It's my opinion and yours could be different.
    Faith is an oasis in the heart which will never be reached by the caravan of thinking.

  16. #16
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    Quote Originally Posted by kongking View Post
    I would say the easiest way to cast spells is to make a bitmap of the image and then find it and click it, i tried using magic.scar and it failed me as well.
    SRL was working perfectly for us. There was probably some minor update in RS that caused a couple spells to work. magic.scar is also pretty confusing in some places which may have cause you to use it incorrectly in some places. It took me a few tries to get it working properly.

    Quote Originally Posted by kingarabian View Post
    Alright lemme clarify more:

    You know what mouse hovering is right, like when the mouse goes over a certain thing/object/item etc repeatedly but does not click on anything/
    Yeah... so? Does it hover the high alchemy spell and wait for a while before right clicking? If that's the case, then it definitely sounds like an uptext issue. I'd have to look in magic.scar in SRL to see where the uptext is used.

    Quote Originally Posted by kingarabian View Post
    What I mean by bannable, is if I keep botting and my account gets flagged, Jagex will look at my mouse movements and my techniques. So if I get flagged for suspicion that I am currently botting my Mage with the High Level Alchemy spell, they will realize that each time I alch, I am right clicking the spell, then clicking the spell from the menu option, then casting it on the item. That doesn't make sense because a real player would just left click the spell and cast it on the item as its much easier, and less time consuming. It's my opinion and yours could be different.
    I know exactly what you mean. And I'm just saying the chances of you getting flagged are next to 0 because people can't report you when they can't see how you're clicking. Then, if for some reason you were to get flagged, I guarantee Jagex doesn't carefully watch every single account individually as that would be very inefficient and frankly a waste of time. But yeah, that's my opinion and you're entitled to yours.

    E: Wow, just realized this was in the Public SVN Section, nit MSI. Kingarabian, you aren't using the MSI Alcher are you?
    Last edited by Coh3n; 12-26-2010 at 03:55 PM.

  17. #17
    Join Date
    Oct 2007
    Location
    #srl
    Posts
    6,102
    Mentioned
    39 Post(s)
    Quoted
    62 Post(s)

    Default

    Quote Originally Posted by Coh3n View Post
    Yeah... so? Does it hover the high alchemy spell and wait for a while before right clicking? If that's the case, then it definitely sounds like an uptext issue. I'd have to look in magic.scar in SRL to see where the uptext is used.
    Simba Code:
    //  Mousebox(B.X1, B.Y1, B.X2, B.Y2, 3);
      GetMousePos(X, Y);
      if AutoCast then
      begin
        if not WaitUpTextMulti(['Autocast', 'ocast', 'utoca'], 300+Random(100)) then
          Exit;

        if not(CountColor(16711422, B.X1-10, B.Y1-10, B.X2+10, B.Y2+10) > 50) then
        begin
          Mouse(X, Y, 0, 0, True);
          Result := True;
        end;
        Exit;
      end;

      Mouse(X, Y, 0, 0, not SInfo.AutoCast);
      if SInfo.AutoCast then
        Result := WaitOptionMulti(['Cast', 'ast', 'Cas'], 300+Random(100))
      else
        Result := WaitUpTextMulti(['Cast', 'ast', 'Cas'], 500+Random(100));
    end;
    In Cast();

    I don't remember if the 'Wait*Multi' was committed or not, if not, then change it manually and it should solve your problem. Before it was just Wait*.

    I posted about it quite some time ago.

  18. #18
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    @King, let me know if that WaitMulti fixes your problem. If it does, I'll commit it if it hasn't been already. Thanks, NCDS.

  19. #19
    Join Date
    Aug 2007
    Location
    Hawaii
    Posts
    3,880
    Mentioned
    7 Post(s)
    Quoted
    152 Post(s)

    Default

    Quote Originally Posted by Coh3n View Post
    SRL was working perfectly for us. There was probably some minor update in RS that caused a couple spells to work. magic.scar is also pretty confusing in some places which may have cause you to use it incorrectly in some places. It took me a few tries to get it working properly.


    Yeah... so? Does it hover the high alchemy spell and wait for a while before right clicking? If that's the case, then it definitely sounds like an uptext issue. I'd have to look in magic.scar in SRL to see where the uptext is used.


    I know exactly what you mean. And I'm just saying the chances of you getting flagged are next to 0 because people can't report you when they can't see how you're clicking. Then, if for some reason you were to get flagged, I guarantee Jagex doesn't carefully watch every single account individually as that would be very inefficient and frankly a waste of time. But yeah, that's my opinion and you're entitled to yours.

    E: Wow, just realized this was in the Public SVN Section, nit MSI. Kingarabian, you aren't using the MSI Alcher are you?
    No lol, I was trying to implement it into my script, but I dont think I can...

    Edit: Sec Ill test it now.
    Faith is an oasis in the heart which will never be reached by the caravan of thinking.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •