Results 1 to 10 of 10

Thread: FaladorSmith

  1. #1
    Join Date
    Nov 2010
    Posts
    61
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default FaladorSmith

    Instructions:
    -Start in bank or smithy
    -No bank setup required!

    Features:
    -Great AntiBan actually looks like a bored human player
    -Flawless smelting and banking
    -Anti-randoms
    -Tested with over 200 bronze bars, 500 iron bars, and 500 steel bars.
    -Multiplayer compatible
    -Accurate bar counting

    Update Log:
    V1.1 - Implement TomTuff's suggestions
    V1.2
    - Better AntiBan implementations
    - 2 Paths for getting to and back from the bank
    - Progress report update thanks to Trickyy
    - TileInBox state determination added
    - Custom breaks/rests added(Not Working)
    V1.3
    - Fixed breaks
    - Added a stop reason system to let you know why it stopped
    - Now it can smelt your last few ores, even if you don't have enough for a inventory full
    - Random stuff cleaned up or reorganized
    V1.31
    - Cleaned up the code more
    - Optional use color or reflection randoms
    V1.32
    - Improved smelting method, fails less often
    - Fixed possible loophole in GetState
    V1.33
    - Fixed a bug in the walking function
    V2
    - Smithing bars at anvils
    - Smelt bars then smith them
    - Smith best item option
    - Better debugging info
    - Cleaner script

    V2 is SRL Members only find it there.

    Code:
    Steel Bars
    [----------------------------------------------------------------------------]
    [                                  Ver 2.0                                   ]
    [----------------------------------------------------------------------------]
    [                           12/12/10  03:03:08 PM                            ]
    [----------------------------------------------------------------------------]
    [                        FaladorSmith ~ By KillerTHC                         ]
    [----------------------------------------------------------------------------]
    [                    Credits to Tickyy for his ProgReport                    ]
    [----------------------------------------------------------------------------]
    [  Total Time Running: 3 Hours, 54 Minutes and 42 Seconds                    ]
    [  Total XP: 37800                                                           ]
    [  Total Breaks: 4                                                           ]
    [  Total Loads Done: 112                                                     ]
    [  Total Bars Smelted and Banked: 1008                                       ]
    [  Smelting Rate: 257 Bars/Hr                                                ]
    [  Smithing Levels Gained: 0                                                 ]
    [  AntiBans Done: 441                                                        ]
    [----------------------------------------------------------------------------]
    [                               Players Report                               ]
    [----------------------------------------------------------------------------]
    [     Player Number     |      Nick    |     Active    |       Bars Smelted  ]
    [           0           |      jalo    |       T       |        1008         ]
    [           1           |              |       F       |        0            ]
    [----------------------------------------------------------------------------]
    
    
    
    [----------------------------------------------------------------------------]
    [                                  Ver 1.32                                  ]
    [----------------------------------------------------------------------------]
    [                           12/05/10  03:36:15 PM                            ]
    [----------------------------------------------------------------------------]
    [                        FaladorSmith ~ By KillerTHC                         ]
    [----------------------------------------------------------------------------]
    [                    Credits to Tickyy for his ProgReport                    ]
    [----------------------------------------------------------------------------]
    [  Total Time Running: 2 Hours, 47 Minutes and 58 Seconds                    ]
    [  Total Breaks: 3                                                           ]
    [  Total Loads Done: 92                                                      ]
    [  Total Bars Smelted and Banked: 819                                        ]
    [  Smelting Rate: 292 Bars/Hr                                                ]
    [  Smithing Levels Gained: 2                                                 ]
    [  AntiBans Done: 438                                                        ]
    [----------------------------------------------------------------------------]
    [                               Players Report                               ]
    [----------------------------------------------------------------------------]
    [     Player Number     |      Nick    |     Active    |       Loads         ]
    [           0           |      jalo    |       T       |        92           ]
    [           1           |              |       F       |        0            ]
    [----------------------------------------------------------------------------]
    Please post bugs and progress reports, thanks!
    Suggestions are welcomed!
    Last edited by KillerTHC; 12-13-2010 at 01:02 PM. Reason: Updated Script

  2. #2
    Join Date
    Feb 2009
    Location
    Irvine, CA
    Posts
    2,873
    Mentioned
    8 Post(s)
    Quoted
    138 Post(s)

    Default

    "Invalid Attachment specified. If you followed a valid link, please notify the administrator"

    I get that when trying to open the script. try re-uploading it.

  3. #3
    Join Date
    Feb 2008
    Posts
    748
    Mentioned
    1 Post(s)
    Quoted
    14 Post(s)

    Default

    Quote Originally Posted by TomTuff View Post
    "Invalid Attachment specified. If you followed a valid link, please notify the administrator"

    I get that when trying to open the script. try re-uploading it.
    I just opened it o.O

  4. #4
    Join Date
    Feb 2009
    Location
    Irvine, CA
    Posts
    2,873
    Mentioned
    8 Post(s)
    Quoted
    138 Post(s)

    Default

    yeah it's working all of a sudden

    First off, try using a with..do statement in DeclarePlayers. It makes the script look nice and tidy, and is easier to fill in for multiplayer since you only have to change the 0 to a 1 once (or to whatever number, but yeah). Speaking multiplayer, instead of using global variables that only work for a single player, use the array of TUsers in SRL (AKA Players ) instead. An example of implementing this would be instead of doing
    Simba Code:
    SmithingLevel := GetSkillLevel('smithing');
    you could do
    Simba Code:
    Players[CurrentPlayer].Integers[0] := GetSkillLevel('smithing');
    and instead of using a single BarType, use Players[CurrentPlayer].Strings[0]. Multiplayer functionality is something you will need to learn eventually.

    one small thing: in SetBest, you don't need to set currentLevel; just do case GetSkillLevel('smithing') of...
    that will save you a whole 3 lines

    I like that you use states - a lot of people don't know about this. However, instead of using TileOnMM, I would reccomend doing TileInBox(xs, ys, xe, ye, GetMyPos). This is more reliable for the occasional instance where your current system might screw up.

    Instead of doing NextPlayer(False), i would reccomend logging out the player upon failure and at the beginning of every procedure/function that requires the player to be logged in, do a simple "if not LoggedIn then Exit;" and repeat the main loop until not(LoggedIn), THEN do NextPlayer(False). Repeat that loop within another loop until all players are inactive (AllPlayersInactive). That is again another thing you'll have to do to add multiplayer.

    All in all, nice script especially for someone as new as you. Just fix up your multiplayer and youre set!
    Last edited by TomTuff; 12-02-2010 at 02:55 AM.

  5. #5
    Join Date
    Nov 2010
    Posts
    61
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Yeah sorry, it might have been my fault was re-uploading the cleaner version.

    Thanks for all the tips, they will be implemented soon. I'm not as new as you think, I started autoing 8 years ago, back when SCAR was all we had. I went through onto Aryan, and IBot, however I eventually quit after RS implemented the anti scam value trading crap. After helping develop a bot for another MMO, I decided to come back to where it all started.
    Last edited by KillerTHC; 12-02-2010 at 03:03 AM.

  6. #6
    Join Date
    Feb 2009
    Location
    Irvine, CA
    Posts
    2,873
    Mentioned
    8 Post(s)
    Quoted
    138 Post(s)

    Default

    Quote Originally Posted by KillerTHC View Post
    Yeah sorry, it might have been my fault was re-uploading the cleaner version.

    Thanks for all the tips, they will be implemented soon. I'm not as new as you think, I started autoing 8 years ago, back when SCAR was all we had. I went through onto Aryan, and IBot, however I eventually quit after RS implemented the anti scam value trading crap. After helping develop a bot for another MMO, I decided to come back to where it all started.
    That explains a good bit. Welcome back, enjoy yourself, and have fun.

  7. #7
    Join Date
    May 2007
    Location
    Everywhere
    Posts
    1,428
    Mentioned
    0 Post(s)
    Quoted
    2 Post(s)

    Default

    Cool, need a smither for my fake main
    I'll get a prog when I can get some ore on it and after I finish solving more randoms.

  8. #8
    Join Date
    Nov 2010
    Posts
    61
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Updated the script with your suggestion TomTuff, I haven't tested it but it should work as it was just some variables being removed/replaced.

    EDIT:
    V1.2 works with steel now. Just waiting on confirmation from Trickyy that I can use their code.
    Last edited by KillerTHC; 12-03-2010 at 02:07 AM.

  9. #9
    Join Date
    Nov 2010
    Posts
    61
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Version 1.2 uploaded, works great. I tested it for over 1 hour with steel bars and so far no problems. If anyone could look at my break code and tell me why it doesn't work that would be awesome!

    EDIT:
    Version 1.3 uploaded, works faster than before and breaks work now.
    Last edited by KillerTHC; 12-05-2010 at 01:40 AM.

  10. #10
    Join Date
    Nov 2010
    Posts
    61
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Updated to Version 1.32, it runs awesome, makes a lot of GP if you mine the iron and buy coal to make steel bars.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •