I guess I should have mentioned that my computer is SLOW. There is a good chance the lag caused the gear check to fail. Do you have any clue why it is finding the beekeeper random?
Something to do with random solving. Are you using ref or col antirandoms? You should report the bug in the respective thread. That's the only reasoning I can figure.
Adding in a second check for the GearCheck is really simple.
Replace SetupPlayer with this:
Simba Code:Procedure SetupPlayer;
Begin
Wait(2000);
MarkTime(BRTime); //Sets the time before breaking, used for knowing when to break
SetAngle(true);
R_MakeCompass('n'); //Set the initial conditions
SetRun(True);
StartLev := R_GetSkillLevel(Skill_Fishing); //Collect data for the player (used to reduce using Player values
StartEx := R_GetSkillExperience(Skill_Fishing);
If (StartLev < 1) Then StartLev := GetSkillLevel(Skill_Fishing);
If (StartEx < 1) Then StartEx := GetXP(Skill_Fishing);
Debug('StartLev : ' + ToStr(StartLev) + ' StartXP : ' + ToStr(StartEx));
GameTab(Tab_Inv);
LoadsDone := 0;
If Not Decider Then Failure('Decider'); //If no fishOption can be determined then quit
If Not GearCheck(ToFish) Then
Begin
Wait(RandomRange(150,300));
If not GearCheck(ToFish) Then Failure('GearCheckSetup'); //If no gear then quit
End;
DoRandom;
If Not LoggedIn Then Exit;
ScriptSettings; //Determine the settings
End;
It's located around line 1420 for me, it will be lower for you because you have more players set up.
Replace the main loop with this:
Simba Code:Begin
ScriptSetup;
LoginPlayer;
Wait(1500);
Repeat
SetupPlayer;
Repeat
If Not LoggedIn Then Break;
Repeat
DoRandom;
If Not LoggedIn Then Break;
If Not GearCheck(ToFish) Then
Begin
Wait(RandomRange(100,300));
If Not GearCheck(ToFish) Then Failure('GearCheckMain');
End;
If Not Fishing Then Failure('FishingMain');
Until (InvFull);
If Not LoggedIn Then Break;
R_MakeCompass(0);
If Not Walk(ToStore) Then Failure('WalkToStore');
If Not LoggedIn Then Break;
If Not AfterFishes Then Failure('AfterFishing');
If Not LoggedIn Then Break;
If Not Walk(ToDock) Then Failure('WalkToDock');
If Not LoggedIn Then Break;
DataCollecter;
Rester;
Proggy;
Until (Not LoggedIn);
Players[CurrentPlayer].Active := False;
If AllPlayersInactive Then
TerminateScript;
Debug('Player was logged out, next player');
NextPlayer(False);
Until (AllPlayersInactive)
End.
These fixes will be included in the next release, I am going to release the entire update when it is ready though, so this will function while you wait![]()
When I run this script, RS takes considerably more time to load than other scripts, like 10-15 minutes of load time. It also does not go through the lobby, right when it enters the username and password I am completely logged in. Is this supposed to happen?
EDIT: also resets all my graphics settings as well.
Last edited by doublex8; 01-05-2011 at 07:40 AM.
ahh I see. Thank you very much for the info![]()
There's a lot of debates about the unsigjnged vs signed, and I'm too drunk to find the info right now, but youy can do a searcgh for the stuff by Moparisthebest (he's so fucking smart) and find out the threard.
3Garrett3's Fisherer 0.1 Progress Report
*********************************************
Ran for: 6 Hours, 32 Minutes and 4 Seconds
Fished : 936 Total Fish
Fished : 936 Lobsters
*********************************************
0: | False | 78 Fish | 3 Loads | 1 Levels | 7020 Experience|
1: | False | 364 Fish | 14 Loads | 3 Levels | 29790 Experience|
2: | False | 26 Fish | 1 Loads | 0 Levels | 0 Experience|
3: | False | 104 Fish | 4 Loads | 1 Levels | 7020 Experience|
4: | False | 208 Fish | 8 Loads | 1 Levels | 18720 Experience|
5: | False | 26 Fish | 1 Loads | 0 Levels | 2340 Experience|
6: | False | 130 Fish | 5 Loads | 2 Levels | 11160 Experience|
This was the only problem that killed all of my players. It happens when it left clicks on a fishing spot and the menu pops up with all the players names and stuff, it will look at the fishing spot option, but it will be a Net option and it wont click it. The menu then stays open and blocks the entire screen so the script cant find any spots.[02:56:48] We were too far from the dock, getting closer
[02:57:05] FindSpot activating, could not find spot with TPA
[02:57:08] Fish Spot was found, but was not found on MS after attempts to relocate
[02:57:08] Fishing Spot not found, player should be on dock however, please report this error.
[02:57:08] Script failed at: FishingMain
It was hard to explain, but if you need a screenshot or something just ask.
Edit* Quick solution: Less crowded world. Haha
Last edited by King of the Nites; 01-08-2011 at 03:03 AM.
possible to add only pickup fish and note them?
Yeah the secondary menu thing is hard to make it find. I made it move the mouse away from the menu if it doesn't find the text, but maybe it doesn't move far enough? The easiest solution is like you said, don't use in a crowded world.
I can, swords, lobsters and tuna?
Uhhh what can i say? THANK YOU! Im sorry but I cant give any script details, i came back to find Simba was closed, luckily it saves the progress reports. Here is what I see after logging into RS.3Garrett3's Fisherer 0.1 Progress Report
*********************************************
Ran for: 14 Hours, 55 Minutes and 17 Seconds
Fished : 2080 Total Fish
Fished : 2080 Lobsters
*********************************************
0: | False | 0 Fish | 0 Loads | 0 Levels | 0 Experience|
1: | False | 26 Fish | 1 Loads | 0 Levels | 1620 Experience|
2: | False | 416 Fish | 16 Loads | 3 Levels | 36180 Experience|
3: | True | 728 Fish | 28 Loads | 4 Levels | 64350 Experience|
4: | False | 234 Fish | 9 Loads | 2 Levels | 20430 Experience|
5: | False | 286 Fish | 11 Loads | 2 Levels | 23760 Experience|
6: | False | 390 Fish | 15 Loads | 3 Levels | 35010 Experience|
0: Just standing on the dock with a half full invy of lobbies.
1: Same as ^
2: Same as ^
3: Leo random failed.
4: Same as 0
5: Mime random failed.
6: Same as 0.
Im guessing it was the same problem as last time for those 5 accounts. But thank you, it works amazing!
Welcome!
I'll have to try and get some time to work out the kinks in the text finding.. Everything else seems to be doing well though?
Edit:
Made a couple small changes to the script to help fix the text finding thing. Also added the better TPA fish finder, and made it work with the newest Reflection rev.
Last edited by 3Garrett3; 01-09-2011 at 06:05 PM.
yes 3garrett3 swords lobs and tuna. just whatever gets dropped. thatll help me make a bit of cash on the side
Umm im trying to make one myself and i had a quick look though to see how you find stiles, cuz i always fail
So do you use color(What im trying) or do you use
If so, could i use it please and give you and JP credit please.Simba Code:Function GetNPCsAtX(t: TTile): TNPCArray; //Credit to JP I believe?
Thanks
Originally Posted by DD on IRC
I must of missed that, also what color because i cant seem to find a working color.
Thanks![]()
Originally Posted by DD on IRC
Same thing happened as last time, Simba was closed so im not sure about all the details of what happened.3Garrett3's Fisherer 0.1 Progress Report
*********************************************
Ran for: 10 Hours, 34 Minutes and 51 Seconds
Fished : 1019 Total Fish
Fished : 1019 Lobsters
Slept: 2 Times
Slept for: 1 Hours, 58 Minutes and 39 Seconds
Antiban used: 3711
TPA Finder worked: 119 Times
Reflection Finder worked: 9 Times
*********************************************
0: | False | 104 Fish | 4 Loads | 1 Levels | 9000 Experience|
1: | False | 157 Fish | 6 Loads | 2 Levels | 14130 Experience|
2: | False | 0 Fish | 0 Loads | 0 Levels | 0 Experience|
3: | False | 131 Fish | 5 Loads | 2 Levels | 11790 Experience|
4: | False | 27 Fish | 1 Loads | 1 Levels | 2430 Experience|
5: | True | 391 Fish | 15 Loads| 4 Levels | 35190 Experience|
6: | False | 209 Fish | 8 Loads | 3 Levels | 18810 Experience|
0:Standing at the dock, half full invy
1: ^^
2: ^^
3: ^^
4: Morduat
5: At dock, empty invy
6: Drill demon
I keep a log of the levels of my bots and one thing i noticed was that how much your script says i leveled, didnt match with how much i checked. It almost seemed like a couple players off. ex. i noticed my account #4 leveled 5 levels, but the script only said it leveled 1 time. My accounts #5&6 did not level at all, but the script said otherwise.
Im not sure what to make of this, but thats what i noticed.
EDIT* Also, I had it set to not sleep, but the proggy said it slept. So I'm also a little confused on that.
EDIT2** I restarted it and watched it. It would click on a fishing spot. A huge list of players/fishing spots/fish would pop up, it would move over to the fishing spot option, and even if cage was a choice, it wouldnt click it. it would just keep hovering over different players names.
Last edited by King of the Nites; 01-14-2011 at 12:47 AM.
I keep getting this;
File[C:\Simba\Includes\SRL/logs/SRL log 14-01-11 2.txt] has not been freed in the script, freeing it now.
The basic bug is the long list of text. I guess I could commit the mostly finished new version (.2 or .3 I actually don't remember) which has a little failsafe for this. Also, the line of code says "If Sleeping Then" and then starts sleeping. There can't really be a failsafe for this. I don't know what to tell you? It only increases the sleeped variable after it sleeps and only prints it in the proggy if sleeped is >0.
Also, leveling works by getting the player's start level at the beginning of each log in, and checking each load to see if it has gone up, if so, inc by the difference. It should work, but I can take a look.
I need the lines above this in the script, because that line is not actually a bug.
Edit:
Simba Code:Function FindStilesTPA: Boolean;
Var
TPA: TPointArray;
TDPA: T2DPointArray;
I, CTS, H, X, Y, Tries: Integer;
Begin
If Not LoggedIn Then Exit;
SetAngle(False); //This makes it a lot easier to find Stiles
MakeCompass('n');
cts := GetColorToleranceSpeed;
ColorToleranceSpeed(2);
SetColorspeed2Modifiers(0.09, 0.36);
For Tries := 0 To 2 Do
Begin
FindColorsSpiralTolerance(MSCX, MSCY, TPA, 11185079, MSX1, MSY1, MSX2, MSY2, 16); //Looks for his shirt
If Length(TPA) = 0 Then
FindColorsSpiralTolerance(MSCX, MSCY, TPA, 11185079, MSX1, MSY1, MSX2, MSY2, 25);
TDPA := TPAtoATPAEx(TPA, 30, 20);
If Length(TDPA) = 0 Then Continue;
SortATPASize(TDPA, True); //Sorts the biggest ATPA first
//DebugATPABounds(TDPA);
H := High(TDPA);
For i := 0 To H Do
Begin
Wait(5);
MiddleTPAEx(TDPA[i], x, y);
MMouse(x + 5, y, 2, 2); //Mouse over to the middle of each ATPA
If WaitUpText('tiles', 1000) Then
Begin
GetMousePos(x, y);
Mouse(x, y, 0, 0, False); //If we find the uptext, click the exact mouse position
If WaitOptionMulti(['Exchange', 'xcha', 'change', 'nge'], 900) Then
Begin
Result := True;
ColorToleranceSpeed(cts);
Flag;
Exit;
End;
End;
End;
End; //End tries loop
Result := False; //If it doesn't find Stiles it will make it to this point.
ColorToleranceSpeed(cts);
End;
Function FindStiles: Boolean;
Var
Stiles: TNPC;
StilesMS: TPoint;
Begin
If Not LoggedIn Then Exit;
Debug('Finding Stiles');
If Not GetClosestNPC(Stiles, 'Stiles') Then //Gets the closest NPC
Stiles := GetNPC('Stiles'); //Else gets the only NPC (should do the same thing)
If Not TileOnMS(Stiles.Tile, 0) Then
WalkToTile(Stiles.Tile, 1, 0); //Walks to his tile if he's not on the MS
If TileOnMS(Stiles.Tile, 0) Then
Begin
R_Flag;
Debug('Finding MS coords');
StilesMS := TileToMS(Stiles.Tile, 0); //Gets the MS coords
Mouse(StilesMS.x, StilesMS.y, 2, 2, False); //Clicks Stiles
If Not WaitOption('Exchange', 900) Then //If it doesn't find the option to exchange
Begin
If Not GetClosestNPC(Stiles, 'Stiles') Then //Try the entire thing all over again (allows for misclick)
Stiles := GetNPC('Stiles');
StilesMS := TileToMS(Stiles.Tile, 0);
Mouse(StilesMS.x, StilesMS.y, 2, 2, False);
Result := WaitOption('Exchange', 900);
R_Flag;
Exit;
End Else //if Waitoption works the first time
Begin
R_Flag;
Result := True;
Exit;
End;
End; //If nothing works
Result := False;
Debug('Stiles wasn''t found');
End;
Line 1200 is the Stiles part, so you know.
Ask if you need anything else![]()
Last edited by 3Garrett3; 01-14-2011 at 05:16 PM.
Hi, I'm getting this problem on the Ver.2:
which is this function and the line " NPCs := GetNPCs(FishSpot);" that messes it up. I'm not too sure what the problem is however:[Error] (352:28): Invalid number of parameters at line 351
Compiling failed.
Simba Code:Function GetNPCsOnTile(Tile: TPoint): TNPCArray; //Not sure who gets credit for this. Maybe I made it?
Var
i, h, resCounter: Integer;
NPCs: TNPCArray;
Begin
NPCs := GetNPCs(FishSpot);
SetLength(Result, Length(NPCs));
h := High(NPCs);
For i := h Downto 0 Do
Begin
If (Not NPCs[i].Tile.X = Tile.X) Or (Not NPCs[i].Tile.Y = Tile.Y) Then
Continue;
Result[resCounter] := NPCs[i];
Inc(resCounter);
End;
SetLength(Result, resCounter);
End;
Live simply so that others may simply live.
No problem, tell me how it goes!
On another note, I am updating a few things, hopefully adding a bunch of big ol failsafes for the text finding, and then I'll make sure the sleeping thing is working, and likely add in picking up fish and noting, depending on if ground items is working, it could be problematic because I'd imagine there is a large line of text when you try to pick stuff up and SRL doesn't exactly like that. Also I'm working on adding stats, so hopefully this will be a large, sexy update!![]()
When will the update be coming? Because I cant find a world that is empty enough so that the script doesnt fail because of the huge chooseoption screen.
Its weird because it
1) clicks the fishing spot
2) huge chooseoption screen comes up
3) moves mouse to fishing option
4) second choose option for fishing comes up
5) even if it's the cage option it wont click...
Thanks.
EDIT* Also a way to get rid of choose option screen is to move the mouse very far away from the choose options. Anywhere on the right side near the inventory or minimap.
There are currently 1 users browsing this thread. (0 members and 1 guests)