+ Reply to Thread
Page 1 of 2 12 LastLast
Results 1 to 25 of 32

Thread: Fishing- Not Detecting if Fishing

  1. #1
    Join Date
    Jul 2007
    Location
    Ohio
    Posts
    1,103
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default Fishing- Not Detecting if Fishing

    Details: Fly fishing at edgeville

    My account will be fishing at one of the fishing spots, but the script will keep clicking over and over again on the same spot about every 10 seconds. It will also move over to the other area where you can fish, while there is still a spot at the one my account is currently standing by.

    If you need more of an explanation or any other details, just ask.

    Thanks.

  2. #2
    Join Date
    Feb 2007
    Location
    Alberta, Canada
    Posts
    4,615
    Mentioned
    50 Post(s)
    Quoted
    429 Post(s)

    Default

    Fishing has been in general disarray for a bit now. I'll contact NCDS/other SL's and see what they're up to with working on it..

    Scripts: Edgeville Chop & Bank, GE Merchanting Aid
    Tutorials: How to Dominate the Grand Exchange

    Quote Originally Posted by YoHoJo View Post
    I like hentai.

  3. #3
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    I think this may be a good time to implement a reflection/color hybrid system on the objects..

  4. #4
    Join Date
    Oct 2007
    Location
    #srl
    Posts
    6,102
    Mentioned
    39 Post(s)
    Quoted
    62 Post(s)

    Default

    Quote Originally Posted by Coh3n View Post
    I think this may be a good time to implement a reflection/color hybrid system on the objects..
    Not a bad idea.

    I'm going to get back to working on this tonight as much as I can.

  5. #5
    Join Date
    Jul 2007
    Location
    Ohio
    Posts
    1,103
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Okay thanks for letting me know! If you need any accounts to test on just ask.

  6. #6
    Join Date
    May 2007
    Location
    Tasmania, Aus
    Posts
    898
    Mentioned
    0 Post(s)
    Quoted
    1 Post(s)

    Default

    ^same problem, PM me if you have an update and want me to test it

    many thanks,
    Sgt Soul

  7. #7
    Join Date
    Sep 2006
    Location
    Canada
    Posts
    1,124
    Mentioned
    0 Post(s)
    Quoted
    5 Post(s)

    Default

    Edit: My bad, didn't know what section this was
    Last edited by Capricorn; 12-30-2010 at 05:58 AM.

  8. #8
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    Are everyone's graphics settings set properly?

  9. #9
    Join Date
    May 2007
    Location
    Tasmania, Aus
    Posts
    898
    Mentioned
    0 Post(s)
    Quoted
    1 Post(s)

    Default

    I have minimum graphics and fixed screen, my only problem is that my player is at a fishing spot, fishing (as it does) and then it will constantly click on that fishing spot even though the player is already fishing. Also after it has clicked probably 10 or 20 times it decides to move the player to the other fishing spot and does the same thing over and over until there is a full load.

    If you would like any more detail I could draw up diagrams of what happens and post them on here for you

    many thanks,
    Sgt Soul

  10. #10
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    Quote Originally Posted by sgt soul View Post
    I have minimum graphics and fixed screen, my only problem is that my player is at a fishing spot, fishing (as it does) and then it will constantly click on that fishing spot even though the player is already fishing. Also after it has clicked probably 10 or 20 times it decides to move the player to the other fishing spot and does the same thing over and over until there is a full load.

    If you would like any more detail I could draw up diagrams of what happens and post them on here for you

    many thanks,
    Sgt Soul
    It's okay, I know exactly what you mean, and yes we are aware of this. We're working on a new, more accurate object finding method.

    E: Sorry that may not have made much sense. I got this thread and the other fishing thread mixed up.

  11. #11
    Join Date
    May 2007
    Location
    Tasmania, Aus
    Posts
    898
    Mentioned
    0 Post(s)
    Quoted
    1 Post(s)

    Default

    that is fine, I have been reading over both threads to see if there might have been a fix anyway hahaha

    Talking on the other thread I don't see how their camera angle doesn't go straight to the highest point when they log on.. Mine does :/

  12. #12
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    Quote Originally Posted by sgt soul View Post
    that is fine, I have been reading over both threads to see if there might have been a fix anyway hahaha

    Talking on the other thread I don't see how their camera angle doesn't go straight to the highest point when they log on.. Mine does :/
    Are you using an unsigned client?

  13. #13
    Join Date
    May 2007
    Location
    Tasmania, Aus
    Posts
    898
    Mentioned
    0 Post(s)
    Quoted
    1 Post(s)

    Default

    I use signed, the graphics are too detailed and lagg up heaps when I use unsigned :S

  14. #14
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    Quote Originally Posted by sgt soul View Post
    I use signed, the graphics are too detailed and lagg up heaps when I use unsigned :S
    Yeah, see the people having the angle problem are using unsigned; although, I still don't understand why it wouldn't work.

  15. #15
    Join Date
    Oct 2007
    Location
    #srl
    Posts
    6,102
    Mentioned
    39 Post(s)
    Quoted
    62 Post(s)

    Default

    Quote Originally Posted by Coh3n View Post
    although, I still don't understand why it wouldn't work.
    Just because SMART lags so bad when first loading the unsigned client that sometimes your not fully logged in when it tries to set the angle, and sometimes it will move the angle up just a little because that's all that registered. Just what I've noticed in the past.

    I don't think there is anything anyone can do about it, just set the angle yourself if you need to I guess.

  16. #16
    Join Date
    Mar 2007
    Posts
    1,700
    Mentioned
    0 Post(s)
    Quoted
    8 Post(s)

    Default

    Quote Originally Posted by NCDS View Post
    Just because SMART lags so bad when first loading the unsigned client that sometimes your not fully logged in when it tries to set the angle, and sometimes it will move the angle up just a little because that's all that registered. Just what I've noticed in the past.

    I don't think there is anything anyone can do about it, just set the angle yourself if you need to I guess.
    That's easy to fix, just add a while loop and a few getcolors to make sure all parts of the screen have loaded before setting the angle (after logging in).

  17. #17
    Join Date
    Oct 2007
    Location
    #srl
    Posts
    6,102
    Mentioned
    39 Post(s)
    Quoted
    62 Post(s)

    Default

    Quote Originally Posted by lordsaturn View Post
    That's easy to fix, just add a while loop and a few getcolors to make sure all parts of the screen have loaded before setting the angle (after logging in).
    Perhaps that should be done to SRL's LoggedIn function?

    I can probably do it if anyone agrees, either way it would have to be done for MSI.

  18. #18
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    Quote Originally Posted by NCDS View Post
    Perhaps that should be done to SRL's LoggedIn function?

    I can probably do it if anyone agrees, either way it would have to be done for MSI.
    I think that should have been done a long time ago.

  19. #19
    Join Date
    Oct 2007
    Location
    #srl
    Posts
    6,102
    Mentioned
    39 Post(s)
    Quoted
    62 Post(s)

    Default

    It seems that the screen loads in sort of 4 boxes that fill the main screen. Either way, if the center of the MS is loaded, the game probably is too.

    This little bit here just checks a 40x40px box around MSCx, MSCy, and checks if there are more than 20 occurrences of color '0' (The black of the unloaded RS client). If so, it continues to wait up to 5 seconds.

    As you can see it still sets the final Result depending on the original color check.

    Side note: I know the explanation probably wasn't necessary, but I felt like I should.

    Simba Code:
    function LoggedIn: Boolean;
    var
      cx, cy, t: Integer;
    begin
      t := GetSystemTime + 5000;
      while (not (Result)) and (t > GetSystemTime) do
      begin
        Result := (CountColor(0, MSCx - 20, MSCy - 20, MSCx + 20, MSCy + 20) < 20);
        Wait(3);
      end;

      Result := FindColor(cx, cy, 16777215, 439, 491, 440, 492);
    end;

    Tested and it worked perfectly fine, though I wasn't really having the problem before, only sometimes.

    There may be other ways you would find to be 'better' than this, but I don't see why it wouldn't work.

    anyway, let me know your thoughts.

  20. #20
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    Post in Public SVN, along with an explanation of why it was needed. I'd like to see what other people think first since it's a change to a major function.

  21. #21
    Join Date
    Feb 2007
    Location
    Alberta,Canada
    Posts
    2,358
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by 3Garrett3 View Post
    Fishing has been in general disarray for a bit now. I'll contact NCDS/other SL's and see what they're up to with working on it..
    whats in disarray in the include?
    “Ignorance, the root and the stem of every evil.”

  22. #22
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    Quote Originally Posted by Blumblebee View Post
    whats in disarray in the include?
    The IsFishing methods don't work that well, IIRC.

  23. #23
    Join Date
    Feb 2007
    Location
    Alberta, Canada
    Posts
    4,615
    Mentioned
    50 Post(s)
    Quoted
    429 Post(s)

    Default

    Quote Originally Posted by Blumblebee View Post
    whats in disarray in the include?
    Most of the Fishing portions which actually do anything, tbh

    Scripts: Edgeville Chop & Bank, GE Merchanting Aid
    Tutorials: How to Dominate the Grand Exchange

    Quote Originally Posted by YoHoJo View Post
    I like hentai.

  24. #24
    Join Date
    Oct 2007
    Location
    #srl
    Posts
    6,102
    Mentioned
    39 Post(s)
    Quoted
    62 Post(s)

    Default

    This problem should now be fixed.

    It was an extremely small thing causing all this trouble >.<.

    I plan on doing a bit more with it tomorrow, but you should notice a significant difference already.

  25. #25
    Join Date
    May 2007
    Location
    Tasmania, Aus
    Posts
    898
    Mentioned
    0 Post(s)
    Quoted
    1 Post(s)

    Default

    Quote Originally Posted by NCDS View Post
    This problem should now be fixed.

    It was an extremely small thing causing all this trouble >.<.

    I plan on doing a bit more with it tomorrow, but you should notice a significant difference already.
    so when fishing the player wont keep clicking on the fishing spot or changing fishing spots until the spot has run out?

+ Reply to Thread
Page 1 of 2 12 LastLast

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may post replies
  • You may post attachments
  • You may edit your posts
  •