Page 1 of 3 123 LastLast
Results 1 to 25 of 58

Thread: TomTuff's Superglass Maker

  1. #1
    Join Date
    Feb 2009
    Location
    Irvine, CA
    Posts
    2,873
    Mentioned
    8 Post(s)
    Quoted
    138 Post(s)

    Default TomTuff's Superglass Maker

    Welcome to the thread for my latest script - a Superglass Maker!

    Intro:
    This script uses 100% pure color. That means you could run it in the RS client by simply commenting out line 2. This script makes great profit, amazing mage XP, and even better crafting XP. Read on for more info about setup and how it works.

    Requirements:
    • 77 Magic
    • Completed Lunar Diplomacy
    • Membership
    • Have the Lunar spell book on


    Setup:
    Start your script in Varrock west bank. Have Astral and fire runes in your inventory with an air staff equipped. Every cast consumes 2 Astral, 6 Fire, and 10 Air runes. One cost converts every pair of Seaweed and Bucket of Sand in your inventory into molten glass (1 to 2 glass per set). 13 sets of sand and seaweed are used in every inventory. Have your sand and seaweed (not the edible variety!) near the top of your bank.

    Bugs:
    • None?

    Post any others!


    Reports:
    Progress Report by TomTuff:
    /---------------------------------------------------\
    |            TomTuff's Super Glass Maker            |
    |                       Rev 01                      |
    |---------------------------------------------------|
    |  Time Ran: 01h 06m 18s                            |
    |  Times Casted Superglass Make: 308                |
    |  Times Casted per Hour: 6                         |
    |  Molten Glass Made: 5196                          |
    |  Molten Glass Made per Hour: 92                   |
    |  Experience Gained: 24024                         |
    |  Experience Gained per Hour: 0                    |
    \---------------------------------------------------/


    Revision history is at the bottom of the file.
    Last edited by TomTuff; 03-21-2011 at 04:12 AM.

  2. #2
    Join Date
    May 2007
    Location
    Some where fun.
    Posts
    2,891
    Mentioned
    1 Post(s)
    Quoted
    5 Post(s)

    Default

    Nice job! This looks good!

  3. #3
    Join Date
    Feb 2009
    Location
    Irvine, CA
    Posts
    2,873
    Mentioned
    8 Post(s)
    Quoted
    138 Post(s)

    Default

    Quote Originally Posted by Camaro' View Post
    Nice job! This looks good!
    Thanks!

    I just requested a few variables for SRL Stats to be implemented. You can help by taking a screen shot of the message that comes up in the chat box when you get a magic level. I already have one for the crafting level. Post any proggies!

  4. #4
    Join Date
    May 2007
    Location
    Some where fun.
    Posts
    2,891
    Mentioned
    1 Post(s)
    Quoted
    5 Post(s)

    Default

    Can't post progress reports

  5. #5
    Join Date
    Sep 2010
    Location
    Northern Kentuckeh
    Posts
    759
    Mentioned
    0 Post(s)
    Quoted
    1 Post(s)

    Default

    I should really start gettin on that quest...I've been putting it off.

  6. #6
    Join Date
    Aug 2007
    Location
    Hawaii
    Posts
    3,880
    Mentioned
    7 Post(s)
    Quoted
    152 Post(s)

    Default

    Waiting for 1k seaweed to sell...
    Faith is an oasis in the heart which will never be reached by the caravan of thinking.

  7. #7
    Join Date
    Feb 2009
    Location
    Irvine, CA
    Posts
    2,873
    Mentioned
    8 Post(s)
    Quoted
    138 Post(s)

    Default

    Quote Originally Posted by kingarabian View Post
    Waiting for 1k seaweed to sell...
    It takes forever, put it at max. It's still profit lol.

    EDIT:
    Also, Revision 3 uploaded. Now with SRL Stats!
    Last edited by TomTuff; 01-25-2011 at 05:31 AM.

  8. #8
    Join Date
    Aug 2007
    Location
    Hawaii
    Posts
    3,880
    Mentioned
    7 Post(s)
    Quoted
    152 Post(s)

    Default

    Hopefully its fixes the withdrawing seaweed problem. Wont withdraw nufin'.
    Faith is an oasis in the heart which will never be reached by the caravan of thinking.

  9. #9
    Join Date
    Feb 2009
    Location
    Irvine, CA
    Posts
    2,873
    Mentioned
    8 Post(s)
    Quoted
    138 Post(s)

    Default

    Quote Originally Posted by kingarabian View Post
    Hopefully its fixes the withdrawing seaweed problem. Wont withdraw nufin'.
    Yes, i just started having the same problem. Fixed in Revision 03QP (Quick Patch).

    Proof:
    Progress Report:
    /---------------------------------------------------\
    |            TomTuff's Super Glass Maker            |
    |                     Rev 03QP                      |
    |---------------------------------------------------|
    |  Time Ran: 06m 03s                                |
    |  Times Casted Superglass Make: 23                 |
    |  Molten Glass Made: 361                           |
    |  Experience Gained: 1794                          |
    \---------------------------------------------------/

  10. #10
    Join Date
    Aug 2007
    Location
    Hawaii
    Posts
    3,880
    Mentioned
    7 Post(s)
    Quoted
    152 Post(s)

    Default

    /---------------------------------------------------\
    | TomTuff's Super Glass Maker |
    | Rev 03QP |
    |---------------------------------------------------|
    | Time Ran: 11m 36s |
    | Times Casted Superglass Make: 40 |
    | Molten Glass Made: 670 |
    | Experience Gained: 3120 |
    | Reason for stopping: |
    | could not withdraw the seaweed |
    \---------------------------------------------------/
    Ran out of supplies.
    Faith is an oasis in the heart which will never be reached by the caravan of thinking.

  11. #11
    Join Date
    Feb 2009
    Location
    Irvine, CA
    Posts
    2,873
    Mentioned
    8 Post(s)
    Quoted
    138 Post(s)

    Default

    Revision 4:
    • Fixed OpenVWBank to search for Males AND Females, and to require more points in a TPA before it checks it (10 ==> 90).
    • Fixed OpenVWBank to split the ATPA in to smaller boxes because some of the plantes behind the bankers were throwing it off (40x40 boxes ==> 30x30 boxes)
    • Removed SetAngle(True); from OpenVWBank and instead added it to the beginning of the main loop. To compensate for the wait time gained by using SetAngle, A longer static wait time was added after successfully casting the spell
    • Fixed a bug with the SRL Stats Implementation (forgot to re-mark time).


    Fixed lots of stuff with Xanith's input.

  12. #12
    Join Date
    Aug 2007
    Location
    Hawaii
    Posts
    3,880
    Mentioned
    7 Post(s)
    Quoted
    152 Post(s)

    Default

    Quote Originally Posted by TomTuff View Post
    Revision 4:
    • Fixed OpenVWBank to search for Males AND Females, and to require more points in a TPA before it checks it (10 ==> 90).
    • Fixed OpenVWBank to split the ATPA in to smaller boxes because some of the plantes behind the bankers were throwing it off (40x40 boxes ==> 30x30 boxes)
    • Removed SetAngle(True); from OpenVWBank and instead added it to the beginning of the main loop. To compensate for the wait time gained by using SetAngle, A longer static wait time was added after successfully casting the spell
    • Fixed a bug with the SRL Stats Implementation (forgot to re-mark time).


    Fixed lots of stuff with Xanith's input.
    Got a nice script going here Tom, waiting on 10k seaweeds.
    Faith is an oasis in the heart which will never be reached by the caravan of thinking.

  13. #13
    Join Date
    Feb 2009
    Location
    Irvine, CA
    Posts
    2,873
    Mentioned
    8 Post(s)
    Quoted
    138 Post(s)

    Default

    Bring Up My Post

    Any reports or anything? You guys need to tell me what doesn't work so I can optimize it.

    Edit:
    some small house keeping things.

    Revision 5:
    • Extraneous function "Commit()" removed.
    • All enumerations gathered into one place
    • New constant SCRIPT_VER for proggie ("Writeln('Rev 05')" ==> "Writeln('Rev ' + SCRIPT_VER)")
    • Added 5% chance to hover the magic skill every loop


    edit 2:
    Forgot to upload. See original post.
    Last edited by TomTuff; 01-26-2011 at 02:37 AM.

  14. #14
    Join Date
    Aug 2007
    Location
    Hawaii
    Posts
    3,880
    Mentioned
    7 Post(s)
    Quoted
    152 Post(s)

    Default

    Well I was running version 4 and sometimes it crashes I dont know why as I'm not watching it. I'll test out version 5.

    /---------------------------------------------------\
    | TomTuff's Super Glass Maker |
    | Rev 04 |
    |---------------------------------------------------|
    | Time Ran: 13m 34s |
    | Times Casted Superglass Make: 59 |
    | Molten Glass Made: 997 |
    | Experience Gained: 4602 |
    \---------------------------------------------------/
    /---------------------------------------------------\
    | TomTuff's Super Glass Maker |
    | Rev 04 |
    |---------------------------------------------------|
    | Time Ran: 21m 47s |
    | Times Casted Superglass Make: 96 |
    | Molten Glass Made: 1583 |
    | Experience Gained: 7488 |
    | Reason for stopping: |
    | could not open the bank |
    \---------------------------------------------------/
    Edit: It cant withdraw the seaweed or it has trouble.
    Last edited by kingarabian; 01-26-2011 at 02:42 AM.
    Faith is an oasis in the heart which will never be reached by the caravan of thinking.

  15. #15
    Join Date
    Feb 2009
    Location
    Irvine, CA
    Posts
    2,873
    Mentioned
    8 Post(s)
    Quoted
    138 Post(s)

    Default

    Yes, I just randomly experienced the same thing.

    Revision 5QP:
    • Increased color tolerance from 2 to 3 when searching for seaweed


    Edit:

    I've decided to add a debugging system. Please note that the time it takes to do all the Writeln()s can cause the script to run slow. I only recommend enabling the debug if you are having issues with the script, so then you can post in the thread with some good debug.

    Revision 6
    • Added: procedure Debug(What: string; Levels: Integer);
    • Added debugging lines to all/most functions.


    Proof it's working atm:
    Progress Report:
    /---------------------------------------------------\
    |            TomTuff's Super Glass Maker            |
    |                       Rev 06                      |
    |---------------------------------------------------|
    |  Time Ran: 09m 50s                                |
    |  Times Casted Superglass Make: 31                 |
    |  Molten Glass Made: 537                           |
    |  Experience Gained: 2418                          |
    \---------------------------------------------------/


    debug log from the same session: http://pastebin.com/MWgtwCfx
    Last edited by TomTuff; 01-26-2011 at 04:24 AM.

  16. #16
    Join Date
    Feb 2009
    Location
    Irvine, CA
    Posts
    2,873
    Mentioned
    8 Post(s)
    Quoted
    138 Post(s)

    Default

    Bump.

    Revision 7 is working perfectly for me, releasing now.

    Revision 7:
    • Changed OpenVWBank to sort the TPA from the center of the screen before splitting it to an ATPA
    • both withdrawing functions now record the last known bank index to use in case the bank index isn't found, so then the index is set to the last known.
    • Changed length check (90 ==> 60)
    • Removed script setup info from top of the script, see the thread if you need to.


    Progress Report by TomTuff:
    /---------------------------------------------------\
    |            TomTuff's Super Glass Maker            |
    |                       Rev 07                      |
    |---------------------------------------------------|
    |  Time Ran: 57m 58s                                |
    |  Crafting Levels Gained: 1                        |
    |  Times Casted Superglass Make: 242                |
    |  Molten Glass Made: 4064                          |
    |  Experience Gained: 18876                         |
    \---------------------------------------------------/

  17. #17
    Join Date
    Aug 2007
    Location
    Hawaii
    Posts
    3,880
    Mentioned
    7 Post(s)
    Quoted
    152 Post(s)

    Default

    Alright will try it out some more of course. Got 4k seaweed and sands left. Hopefully the latest revision is more stable.
    Faith is an oasis in the heart which will never be reached by the caravan of thinking.

  18. #18
    Join Date
    Aug 2007
    Location
    Hawaii
    Posts
    3,880
    Mentioned
    7 Post(s)
    Quoted
    152 Post(s)

    Default

    \---------------------------------------------------/
    /---------------------------------------------------\
    | TomTuff's Super Glass Maker |
    | Rev 07 |
    |---------------------------------------------------|
    | Time Ran: 08m 30s |
    | Times Casted Superglass Make: 33 |
    | Molten Glass Made: 564 |
    | Experience Gained: 2574 |
    | Reason for stopping: |
    | could not withdraw the seaweed |
    \---------------------------------------------------/
    Unstable... Following failsafes are needed:
    -Have the script check to make sure the inventory is not either A, filled with seaweed or B, filled with buckets of sand, or C, something else it manages to withdraw. Once it detects its not 13 seaweed and 13 buckets of sand, have it deposit, and re do the withdrawing process. All around it needs failsafes.

    Dont get me wrong, its a good script and the idea beyond it is extremely good, however its potential is limited due to it being unstable. Make Reflection your friend and use it as a failsafe.
    Faith is an oasis in the heart which will never be reached by the caravan of thinking.

  19. #19
    Join Date
    Feb 2009
    Location
    Irvine, CA
    Posts
    2,873
    Mentioned
    8 Post(s)
    Quoted
    138 Post(s)

    Default

    Quote Originally Posted by kingarabian View Post
    Unstable... Following failsafes are needed:
    -Have the script check to make sure the inventory is not either A, filled with seaweed or B, filled with buckets of sand, or C, something else it manages to withdraw. Once it detects its not 13 seaweed and 13 buckets of sand, have it deposit, and re do the withdrawing process. All around it needs failsafes.

    Dont get me wrong, its a good script and the idea beyond it is extremely good, however its potential is limited due to it being unstable. Make Reflection your friend and use it as a failsafe.
    odd...

    Progress Report:
    /---------------------------------------------------\
    |            TomTuff's Super Glass Maker            |
    |                       Rev 07                      |
    |---------------------------------------------------|
    |  Time Ran: 01h 49m 41s                            |
    |  Crafting Levels Gained: 1                        |
    |  Times Casted Superglass Make: 468                |
    |  Molten Glass Made: 7877                          |
    |  Experience Gained: 36504                         |
    |  Reason for stopping:                             |
    |  could not withdraw the seaweed                   |
    \---------------------------------------------------/


    It couldn't withdraw the seaweed because there was no more

    I'll make some counting procedures, thanks for the idea. Check back in a bit for Rev 8.

  20. #20
    Join Date
    Aug 2007
    Location
    Hawaii
    Posts
    3,880
    Mentioned
    7 Post(s)
    Quoted
    152 Post(s)

    Default

    Quote Originally Posted by TomTuff View Post
    odd...

    Progress Report:
    /---------------------------------------------------\
    |            TomTuff's Super Glass Maker            |
    |                       Rev 07                      |
    |---------------------------------------------------|
    |  Time Ran: 01h 49m 41s                            |
    |  Crafting Levels Gained: 1                        |
    |  Times Casted Superglass Make: 468                |
    |  Molten Glass Made: 7877                          |
    |  Experience Gained: 36504                         |
    |  Reason for stopping:                             |
    |  could not withdraw the seaweed                   |
    \---------------------------------------------------/


    It couldn't withdraw the seaweed because there was no more

    I'll make some counting procedures, thanks for the idea. Check back in a bit for Rev 8.
    Damn how are you getting nearly 2 hours of run time lol. I wish it ran forever for me!
    Faith is an oasis in the heart which will never be reached by the caravan of thinking.

  21. #21
    Join Date
    Feb 2009
    Location
    Irvine, CA
    Posts
    2,873
    Mentioned
    8 Post(s)
    Quoted
    138 Post(s)

    Default

    Quote Originally Posted by kingarabian View Post
    Damn how are you getting nearly 2 hours of run time lol. I wish it ran forever for me!
    I don't understand either. Out of curiousity, which bank stand do you start at? (Obviously Varrock west, but which bank booth in varrock west bank?)

  22. #22
    Join Date
    Aug 2007
    Location
    Hawaii
    Posts
    3,880
    Mentioned
    7 Post(s)
    Quoted
    152 Post(s)

    Default

    Quote Originally Posted by TomTuff View Post
    I don't understand either. Out of curiousity, which bank stand do you start at? (Obviously Varrock west, but which bank booth in varrock west bank?)
    Wessst siiiiyde?
    Bloodzzzzzz
    Ill switch to the east side.
    Cripzzzz
    Faith is an oasis in the heart which will never be reached by the caravan of thinking.

  23. #23
    Join Date
    Feb 2009
    Location
    Irvine, CA
    Posts
    2,873
    Mentioned
    8 Post(s)
    Quoted
    138 Post(s)

    Default

    Big update! I've implemented everything kingarabian recommended (namely inventory counting as a fail safe) and a few other procedures that make this script, as far as I'm aware, flawless. All of the recent (recent = ~the last 24 hours) commits made by Xanith and I use Revision 8, so we can assume it works pretty well.

    Revision 08:
    • Replaced CountGlass with Count(Which: Integer), and made it work for glass, seaweed, and sand.
    • Added AttemptAndSwivel(Func: function: Boolean; Attempts, SwivelPer: Integer)
    • Modified main loop to open the bank via AttemptAndSwivel
    • Modified DepositGlass to work for all 3 items.
    • New function WithdrawMaterials for failsafing, attempts withdrawing 5 times; replaced the individual functions being used in the main loop.
    • Merged WithdrawSeaweed and WithdrawSand to WithdrawWhich(Which: Integer): Boolean;
    • When opening VWB, sets to true and exits if the bankscreen is open at start of function
    • WithdrawWhich(): Boolean; now exits if item is in inv at start.
    • Edited Depositing process to not exit upon first successful item detiction (so now if it fails to right click and deposit, it will move on and check the other inventory slots).

  24. #24
    Join Date
    Aug 2007
    Location
    Hawaii
    Posts
    3,880
    Mentioned
    7 Post(s)
    Quoted
    152 Post(s)

    Default

    Testing as soon as I get 10k more seaweed.
    Faith is an oasis in the heart which will never be reached by the caravan of thinking.

  25. #25
    Join Date
    Feb 2009
    Location
    Irvine, CA
    Posts
    2,873
    Mentioned
    8 Post(s)
    Quoted
    138 Post(s)

    Default

    Quote Originally Posted by kingarabian View Post
    Testing as soon as I get 10k more seaweed.
    I saw you made some commits on SRL Stats, does that mean it works for you now?

Page 1 of 3 123 LastLast

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •