I was using 1.30, yes. Also, it seems like the
"cHerbsToClean = 50; // Script will stop when no materials are found or" doesn't work the way it is intended. I put 50 in there to test if it would stop after 50 materials. It continues until out of materials every time. Which is a problem if it stands in inventory, thinking it's not out of materials, but won't bank correctly. I don't know why it happened either.
What? Why is it a problem that it continues until out of materials? What do you mean "thinkings it's not out of materials"? What do you mean it won't bank correctly?
I noticed thatis the default value when downloading the script. This should be set to zero if you're not making Unf pots.Simba Code:cUnfPotsToMake = 555555;
Other than that, the script will terminate when no materials are found and it will end whenis false.Simba Code:((vHerbsCleaned < cHerbsToClean) or (vUnfPotsMade < cUnfPotsToMake) or (vPotsMade < cPotionsToMake))
and thats the reason he is telling you that it wont stop at 50... instead it cleans all the herbs and he doesnt want it to clean all.. He wants it to clean a certain number..
I've also noticed this... if I set herbs to clean at 0 but I put in a herb ID to clean, it will clean every single one. I believe its because you used dsgdsg <> 0
instead if an if statement.
Simba Code:if (vHerbsToClean <> 0) then docleanherbs //This would be such a statement.. rather than
while (vHerbsCleaned == vHerbsToClean) //This might have to be done.
do
docleanherbs
end;
//Cant remember and dont have the time to check atm but I believe u have:
if B_CLEAN <> 0...
Last edited by Brandon; 03-28-2011 at 04:04 PM.
I just posted how it works...
When that statement is false, the script ends.Simba Code:((vHerbsCleaned < cHerbsToClean) or (vUnfPotsMade < cUnfPotsToMake) or (vPotsMade < cPotionsToMake))
Uuh, now I just realised it should be '<=' rather than just '<'.
If you're not cleaning herbs, set cHerbsToClean to -1, same with cUnfPotsToMake and cPotionsToMake. That's why it continued even tho' vHerbsCleaned > cHerbsToClean
I'm not sure this addresses the main problem. This time around, it broke with around 700 grimy left in my bank, continuously clicking "use clean avantoe" as if it were cleaning the grimy, and never banking because it had never cleaned the inventory. Does this make sense?
Keep in mind that I am only cleaning herbs.
It makes absolutely no sense :S It calls the banking procedure on the start of every loop, and there is no loop within the loop that cleans herbs exceptBut that's obviously not the problem. Could you post some debug?Simba Code:for i:=0 to high(p) do
begin
R_ClickItem(p[i],True,'Clean');
wait(cCleanWaitTime + random(cCleanWaitTime/3));
end;
EDIT: Well I just learnt something new today! I thought a function would return a default value if no result variable var set, but apparently it doesn't.didWithdraw would equal true all the time because it is set as true earlier in the banking procedure and therefore it wouldn't terminate. While that's not related to your issue not banking at all, it should now terminate correctly. V1.33 releasedSimba Code:didWithdraw := R_WithdrawItemEx(cGrimyHerb, 0,trash,false);
Last edited by Emaziz; 03-29-2011 at 07:19 AM.
Progress Report:*-*- emHerb v1.10 ~ By Emaziz -*-* * Running for: 5 Hours, 21 Minutes and 12 Seconds * Experience: 107230 * Exp/hour: 20030 *Herbs cleaned: 21448 *Unf-pots made: 0 * Potions made: 0 *-*- herbsherbsherbsherbss -*-*
figured out you can only buy 10k herbs per 4 hours or something
BUT ran amazingly
Progress Report:*-*- emHerb v1.33 ~ By Emaziz -*-* * Running for: 4 Hours, 58 Minutes and 46 Seconds * Experience: 18330 * Exp/hour: 3681 *Herbs cleaned: 7336 *Unf-pots made: 7364 * Potions made: 0 *-*- herbsherbsherbsherbss -*-*
also to increase the speed, either mouse around the bank or right click the banker and open bank as soon as you have finished making pots or cleaning
yeah i thought the only thing stopping the banking is wrong ids
cant get rsbuddy or anything esle to load atm, i will look through how you loop/check till your done
edit: this is what im using
pretty sure thats right, according to the list anywayCode:doDebug = True; cBankName = 'ge'; // Which bank to use cGrimyHerb = 207; // ID of grimy herb to use, 0 if none should be used. cCleanHerb = 257; // ID of clea herb to use, 0 if none should be used. cUnfPotion = 99; // ID of unfinished potion, 0 if none should be used. cIngredient = 0; // ID of secondary ingredient, 0 if none should be used.
You don't technically "use" the unfinished potion, you just make it So that should be blank. But as long as you have cPotionsToMake set to zero it shouldn't matter. I checked the Ranarr ID and it seems to be correct? (According to GE)
Only other reason I can think of is that you have placed the herbs in a slot the function don't support. :\
Print debug when you try to withdraw ranarr?
changed all bank slots, all are visible, pretty sure its not finding the herb[R_WithdrawItemEx] Item not in bank
[08:45:16 PM] Failed to withdraw. Attempts: 1
[R_WithdrawItemEx] Item not in bank
[08:45:16 PM] Failed to withdraw. Attempts: 2
[R_WithdrawItemEx] Item not in bank
[08:45:17 PM] Failed to withdraw. Attempts: 3
[R_WithdrawItemEx] Item not in bank
[08:45:17 PM] Failed to withdraw. Attempts: 4
[R_WithdrawItemEx] Item not in bank
[08:45:17 PM] Failed to withdraw. Attempts: 5
[R_WithdrawItemEx] Item not in bank
[08:45:18 PM] Failed to withdraw. Attempts: 6
[R_WithdrawItemEx] Item not in bank
[08:45:18 PM] Failed to withdraw. Attempts: 7
[R_WithdrawItemEx] Item not in bank
[08:45:19 PM] Failed to withdraw. Attempts: 8
[R_WithdrawItemEx] Item not in bank
[08:45:19 PM] Failed to withdraw. Attempts: 9
[R_WithdrawItemEx] Item not in bank
[08:45:19 PM] Failed to withdraw. Attempts: 10
[R_WithdrawItemEx] Item not in bank
[08:45:20 PM] Failed to withdraw. Attempts: 11
[08:45:20 PM] *** ERROR *** Banking procedure failed 10 times. Terminating!
ids are fine, iirc some grabbing the id from the grand exchange isnt always correct, 99% of the case it is thoughCode:inv id 1 is (227, 1, 1, 'Vial of water', ['Deposit', 'Examine']) inv id 2 is (207, 1, 2, 'Grimy ranarr', ['Deposit', 'Examine']) inv id 3 is (99, 1, 3, 'Ranarr potion (unf)', ['Deposit', 'Examine']) inv id 4 is (257, 1, 4, 'Clean ranarr', ['Deposit', 'Examine']) bank id 4 is (227, 4, 1270, 'Vial of water') bank id 5 is (207, 5, 1268, 'Grimy ranarr') bank id 6 is (99, 6, 28, 'Ranarr potion (unf)') bank id 7 is (257, 7, 1, 'Clean ranarr')
edit: makes unfs perfectly, withdraws clean herbs and vial then combines them, banks then tries to withdraw ranarrs and fails, thats all the info i can think of
edit
works fineSimba Code:R_WithdrawItem(cGrimyHerb, 0);
im going to redownload your script
Last edited by Bonfield; 03-30-2011 at 09:57 AM.
I believe there was an issue with tabs when using R_WithdrawItem
Lol odd. But glad it worked out
Lol... I see u havent fixed the bugs I mentioned.. Not to mention by now I thought u'd have seen the R_ClickItemBy() Instead of clicking the item in the first slot... if it accidentally missclicks which it does whenever the user minimizes smart (due to loss of focus) it will withdraw a wrong item, and click the first slot(bad item) and then attempt to click the waters..
Where R_ClickItemBy() would make sure it only clicks what its supposed to.
Lol... I don't care much for your attitude tbh.
For some reason you keep expecting me to be able to track down and fix every possible bug there is. How am I supposed to do that when NONE of them are reported and NONE of them happen to myself? I do my best to fix the bugs that are reported. And the "Lol.. I see you havent fixed the bugs I mentioned" is that ticks me off. What bugs are still there? I apply fixes but how am I to know if they are actually working until someone gives me feedback? If you really want to help, help me instead of complaining on how I work on my script.
Maybe you should add supported banks to the script header
It's working I'll be making 1k super restores now (expect a prog ) and some antifires later (getting 70 herb).
E: Aww, it started to use the (Unf)s I had, but then it wouldnt clean more =( Maybe you should make it do this Maybe it did this because I already had some mixed - I'll try again.
E2: It wont mix more than 14 unfinished potions.
E3: Ok I didnt have lines 102-104 setup right
E4: Ok after setting those lines right it seems to work as expected now NOW you can expect a proggy later!
Last edited by TomTuff; 03-31-2011 at 02:07 AM.
There are currently 1 users browsing this thread. (0 members and 1 guests)