Poll: Is it good for my first script?

Results 1 to 18 of 18

Thread: Opcon's Powerminer(my first script

  1. #1
    Join Date
    Feb 2007
    Posts
    19
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default Opcon's Powerminer(newversion)

    ok I made it a bit more tidier and I tried to use dtms so it only dropped ores.
    The problem is I think it has the same problem as Jad's Powerminer. When I start it it logs in fine but then it moves the mouse up to the top left corner and stays there. Please help?
    My email address is frozen_dinosaur@hotmail.com If you want to talk to me.
    Trying to become a good scripter and an srl member
    http://www.fenjer.com/adnan/SRL/20/5...Powerminer.png

  2. #2
    Join Date
    Feb 2006
    Location
    Tracy/Davis, California
    Posts
    12,631
    Mentioned
    135 Post(s)
    Quoted
    418 Post(s)

    Default

    Omfg You Left User And Pass In Script
    Ill Change It For You

    EDIT:
    Told fakawi to remove script.
    Iv change your password and ill PM it to you.
    Be careful next time

  3. #3
    Join Date
    Feb 2006
    Location
    Amsterdam
    Posts
    6,136
    Mentioned
    28 Post(s)
    Quoted
    17 Post(s)

    Default

    Attachment Removed.

    People:

    DONT LEAVE YOUR L/P INSIDE YOUR SCRIPTS!
    SRL is a Library of routines made by the SRL community written for the Program Simba.
    We produce Scripts for the game Runescape.

  4. #4
    Join Date
    Sep 2006
    Location
    New Jersey, USA
    Posts
    5,347
    Mentioned
    1 Post(s)
    Quoted
    3 Post(s)

    Default

    I've found two scripts (not including this one) in the last couple days that had working usernames and passes in them. =) changed passes and pm'ed to owners
    Interested in C# and Electrical Engineering? This might interest you.

  5. #5
    Join Date
    Feb 2007
    Posts
    19
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Lol im an idiot. I forgot to change it.

  6. #6
    Join Date
    Dec 2006
    Location
    Third rock from the sun.
    Posts
    2,510
    Mentioned
    4 Post(s)
    Quoted
    1 Post(s)

    Default

    Lol, same thing happened to me today. Thanks again, Smartz

    I'll test your script out now.

    Havn't tested it yet, but I have read through it. Here are a few pointers:

    SCAR Code:
    procedure FindRandoms;
    begin
      FindNormalRandoms;
    //  if(FindFight)then RunAway;
      if Findname Then FindTalk;

    end;

    You gotta be careful with those "//", adding them means that that line of the script is for user notes only, excluding it from part of the script.

    SCAR Code:
    begin
      Setup;
      activateclient;
     repeat
     miner;
     dropal;
     until(loadsdone = loads);
     logout
    end.

    If you replace the area around "logout" with:

    SCAR Code:
    until(Loadsdone=Loads)
    if(Loadsdone=Loads)then
    NextPlayer(true)

    What that does is checks to see if Loadsdone=Loads, then it switches players. Notice the boolean to the right of "NextPlayer"? That means that the current player can still be used in the future, and is only being logged out for a while.

    SCAR Code:
    procedure miner;
    begin
    repeat
     if findcolorspiral(x,y,rockcolor,3,3,510,332) then
      mmouse(x,y,3,3)
      istextat2(9,9,'Mine',20)
      mouse(x,y,2,2,true)
     wait(rocktime+random(randomtime))
     begin
       FindRandoms;
     end;
     until(invfull)
      if (invfull = true) then
      loadsdone:= loadsdone + 1;
    end;

    Two things here.

    1) You can change "IsTextAt2(...)" to "IsUpText('Mine')" and save some time typing.

    2) Notice the bottom of the procedure. You have it check to see if the inventory is full, but you don't have a command to drop anything. Placing:

    SCAR Code:
    if(InvFull)then
     begin
      Loadsdone := Loadsdone + 1
       Dropall;

    In there will fix it.

    Those are just minor errors. All in all, good first script

    I'm on till at least 3-4 in the morning on weekends (EST), so feel free to PM me if you have any more questions.

  7. #7
    Join Date
    Sep 2006
    Location
    In Finland
    Posts
    124
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    I read it throught and its pretty good for a first script...keep it going...!

  8. #8
    Join Date
    Dec 2006
    Location
    Helsinki, Finland
    Posts
    177
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

  9. #9
    Join Date
    Oct 2006
    Posts
    2,297
    Mentioned
    1 Post(s)
    Quoted
    0 Post(s)

    Default

    yea pretty good for first script!
    Keep it up!
    Btw i have a comment for Jason2gs :

    Quote Originally Posted by Jason2gs View Post
    1) You can change "IsTextAt2(...)" to "IsUpText('Mine')" and save some time typing.
    I don't prefer using capitals when using to search for text, there would be more lagg while searching, you can just use "IsUpText('ine')";
    Not bad for first script but try to include a bit anti random or gas finding

  10. #10
    Join Date
    Feb 2007
    Posts
    3,616
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    LOL! i thought i was the only person in the world to ever leave my user name and pass in a script.. but i guess I'm not :P atleast i only did it when i pm'd my script to pwnaz0r and not in public forum :P but now the thing is, he keeps using my account for testing out his macro's like when he was helping mage of begu out :P anyways, looks like a good first script, I'll test it out later. I have my first power miner coming out and i hope i can post it here soon too anyway, i just saw one problem so far in script.
    SCAR Code:
    Procedure dropal;
    begin
    if pick=true then
    dropto(1,28) else //this could just be drop all as well.
    dropto(2,38) //this should be DropTo(2,28); considering there is no 38 :P
    end;
    so thats what I found on ways to improve, I'll edit post more if i see anything else.

  11. #11
    Join Date
    Dec 2006
    Location
    Third rock from the sun.
    Posts
    2,510
    Mentioned
    4 Post(s)
    Quoted
    1 Post(s)

    Default

    atleast i only did it when i pm'd my script to pwnaz0r and not in public forum :P but now the thing is, he keeps using my account for testing out his macro's like when he was helping mage of begu out :P
    Lol, nice one.

  12. #12
    Join Date
    Feb 2007
    Posts
    19
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Why do spammers always spam on my thread? lol.
    @ Jason2gs

    Quote Originally Posted by Jason2gs View Post

    If you replace the area around "logout" with:

    SCAR Code:
    until(Loadsdone=Loads)
    if(Loadsdone=Loads)then
    NextPlayer(true)

    What that does is checks to see if Loadsdone=Loads, then it switches players. Notice the boolean to the right of "NextPlayer"? That means that the current player can still be used in the future, and is only being logged out for a while.

    If I do that then will it support multiplayer? Also how can I acess the player-array varibles? I think it might be something like this: Players[0].orecol

    but I'm not sure.

    @Jad
    anyway, i just saw one problem so far in the script

    SCAR Code:
    Procedure dropal;
    begin
    if pick=true then
    dropto(1,28) else //this could just be drop all as well.
    dropto(2,38) //this should be DropTo(2,28); considering there is no 38 :P
    end;
    Yeah I must read through my script before I post them lol.

    And thanks for your feedback guys.

  13. #13
    Join Date
    Dec 2006
    Location
    Third rock from the sun.
    Posts
    2,510
    Mentioned
    4 Post(s)
    Quoted
    1 Post(s)

    Default

    I'm 95% sure that'll make your script support multi-players.

    Here's a four slot Player Array

    SCAR Code:
    procedure DeclarePlayers;
        begin
       
         HowManyPlayers := 4;
         NumberOfPlayers(HowManyPlayers);
         CurrentPlayer := 0;
         
          Players[0].Name := 'Username';
          Players[0].Pass := 'Passsword';
          Players[0].Nick := 'Nickname';
          Players[0].Active := True;
         
          Players[1].Name := 'Username';
          Players[1].Pass := 'Password';
          Players[1].Nick := 'Nickname';
          Players[1].Active := True;
         
          Players[2].Name := 'Username';
          Players[2].Pass := 'Password';
          Players[2].Nick := 'Nickname';
          Players[2].Active := True;
         
          Players[3].Name := 'Username';
          Players[3].Pass := 'Password';
          Players[3].Nick := 'Nickname';
          Players[3].Active := True;
         
         
        end;

    To add more, just copy it and change the numbers.

    Have fun!

    God bless,

    Mike.

  14. #14
    Join Date
    Feb 2007
    Posts
    19
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Ok I added a new version.
    It has multiplayer, gasfinding(hope it works) and a better color setting up procedure.
    I have not tested it since the update so I do not know how it functions.
    Please give me some feedback.
    Trying to become a good scripter and an srl member
    http://www.fenjer.com/adnan/SRL/20/5...Powerminer.png

  15. #15
    Join Date
    Dec 2006
    Location
    Helsinki, Finland
    Posts
    177
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Wow, looks and works pretty good for ur second script

  16. #16
    Join Date
    Feb 2007
    Posts
    19
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Well it's actually and update to my first script:P
    But thanks for the feed back.
    Trying to become a good scripter and an srl member
    http://www.fenjer.com/adnan/SRL/20/5...Powerminer.png

  17. #17
    Join Date
    Feb 2007
    Posts
    19
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    I added a new version.
    All I did was just tidy it up. I also used dtm's to find the ore in the inventory. Now You can choose if you want it to only drop ores.
    Trying to become a good scripter and an srl member
    http://www.fenjer.com/adnan/SRL/20/5...Powerminer.png

  18. #18
    Join Date
    Feb 2007
    Posts
    19
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    No One has viewed it?
    Trying to become a good scripter and an srl member
    http://www.fenjer.com/adnan/SRL/20/5...Powerminer.png

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Similar Threads

  1. PowerMiner , first script
    By zorro in forum First Scripts
    Replies: 11
    Last Post: 07-30-2008, 03:25 AM
  2. powerminer script help
    By Kyle in forum OSR Help
    Replies: 3
    Last Post: 12-23-2007, 03:11 AM
  3. My 2nd script. Powerminer!
    By owned1112 in forum RS3 Outdated / Broken Scripts
    Replies: 0
    Last Post: 10-11-2007, 03:05 PM
  4. First Script (PowerMiner)
    By I Karma I in forum OSR Help
    Replies: 7
    Last Post: 05-04-2007, 05:56 AM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •