Page 1 of 21 12311 ... LastLast
Results 1 to 25 of 512

Thread: Herblore PRO

  1. #1
    Join Date
    Apr 2007
    Location
    Estonia
    Posts
    156
    Mentioned
    0 Post(s)
    Quoted
    10 Post(s)

    Default Herblore PRO

    Hey, back in SRL, made new script:

    ~Herblore PRO~


    Features:

    Makes Unfs/Potions and cleans herbs!
    Supports almost all unfs and most common potions.
    Unfs/Cleans:
    PHP Code:
    GuamMarrentillTarrominHarralanderRanarrToadflaxIritWergali,
    AvantoeKwuarmSnapdragonDwarfTorstolCadantineLantadyme 
    Potsions:
    PHP Code:
    AttackStrengthRestore potionEnergypotionDefence potionPrayer,
    CraftingSuper attackSuper antipoisonSuper strengthSuper restore,
    Super defenceRanging potionMagic potionSaradomin brew 
    Setup:
    Setup in GUI:


    note: Try to keep similar herbs/unfs in other tabs, like Guam/torstol etc. for smooth perfomance...

    To Do List:
    1. Add Extremes and Ovl
    2. Need better Proggy
    3. Need paint in SMART.


    Post reports/suggestions/bugs, Thanks.
    Last edited by neeger; 11-17-2011 at 05:46 PM.
    ROCK IS NOT A DEVILS WORK, ITS MAGICAL AND RAD!

  2. #2
    Join Date
    Aug 2007
    Location
    Colorado
    Posts
    7,421
    Mentioned
    268 Post(s)
    Quoted
    1442 Post(s)

    Default

    Looks great! Could you maybe add an option for antifire potions? (Lantadyme(Unf) + ground dragon scales I think?)

    Rep+.

    Current projects:
    [ AeroGuardians (GotR minigame), Motherlode Miner, Blast furnace ]

    "I won't fall in your gravity. Open your eyes,
    you're the Earth and I'm the sky..."


  3. #3
    Join Date
    Sep 2007
    Location
    British Columbia, Canada
    Posts
    4,047
    Mentioned
    1 Post(s)
    Quoted
    2 Post(s)

    Default

    nice that you encode the pass and stuff:P
    Oh Hai Dar

  4. #4
    Join Date
    Apr 2007
    Location
    Estonia
    Posts
    156
    Mentioned
    0 Post(s)
    Quoted
    10 Post(s)

    Default

    Quote Originally Posted by Flight View Post
    Looks great! Could you maybe add an option for antifire potions? (Lantadyme(Unf) + ground dragon scales I think?)

    Rep+.
    Yeah, starting to work on Extremes soon, then I add it, and Ovls also, few things alos in "under construction" atm.
    ROCK IS NOT A DEVILS WORK, ITS MAGICAL AND RAD!

  5. #5
    Join Date
    Nov 2007
    Location
    I live in Slovenia! :)
    Posts
    837
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Thanks for the release. Rep +
    It working really great and the form is very nice to

    One thing I would suggest, is that you make it stop and log off when it runs out of herbs or vials.
    ~T2

  6. #6
    Join Date
    Oct 2011
    Posts
    3
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Can do the first trip nicely, but messes up at loop. Any chance of a fix?

  7. #7
    Join Date
    Apr 2007
    Location
    Estonia
    Posts
    156
    Mentioned
    0 Post(s)
    Quoted
    10 Post(s)

    Default

    Quote Originally Posted by Chpp View Post
    Can do the first trip nicely, but messes up at loop. Any chance of a fix?
    What you "mean messes up"?
    ROCK IS NOT A DEVILS WORK, ITS MAGICAL AND RAD!

  8. #8
    Join Date
    Apr 2007
    Location
    Estonia
    Posts
    156
    Mentioned
    0 Post(s)
    Quoted
    10 Post(s)

    Default

    Quote Originally Posted by tico2 View Post
    One thing I would suggest, is that you make it stop and log off when it runs out of herbs or vials.
    Fixed, Thanks :P
    ROCK IS NOT A DEVILS WORK, ITS MAGICAL AND RAD!

  9. #9
    Join Date
    Oct 2011
    Posts
    3
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    I'm making super attacks out of irit unf potions. It usually does the first inventory well, however, after that, it withdraws 14 eys of newt, closes bank, deposits all, withdraws 14 eyes of newt and loops that circle.

    May be a problem with my client setup, I'm new here. I did all the steps introduced at the threads, but it still does that. Any ideas?

    Btw, greetings from estonia :P

  10. #10
    Join Date
    Apr 2007
    Location
    Estonia
    Posts
    156
    Mentioned
    0 Post(s)
    Quoted
    10 Post(s)

    Default

    Quote Originally Posted by Chpp View Post
    I'm making super attacks out of irit unf potions. It usually does the first inventory well, however, after that, it withdraws 14 eys of newt, closes bank, deposits all, withdraws 14 eyes of newt and loops that circle.

    May be a problem with my client setup, I'm new here. I did all the steps introduced at the threads, but it still does that. Any ideas?

    Btw, greetings from estonia :P
    Hmm, looks like it doesn't find irit unf, made new DTM for it, maybe the color was off, try redownloading version 1.1, and see if that works
    ROCK IS NOT A DEVILS WORK, ITS MAGICAL AND RAD!

  11. #11
    Join Date
    Aug 2011
    Location
    Spooner Street
    Posts
    309
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    The form looks awesome!

    Thanks for the release, I'm sure to use this when taking up on herblore in the next couple of weeks.

  12. #12
    Join Date
    Mar 2010
    Posts
    40
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    It wasnt able to find the al karad bank when i started it, moving to varrock to see if that solves the problem. Script looks great otherwise.

    UPDATE: Yeh works flawlessly so far at West Varrock Bank
    Last edited by Versus The World; 11-06-2011 at 03:53 AM.

  13. #13
    Join Date
    Oct 2011
    Posts
    3
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Seems like it works. Thanks for the update man.

    //Edit: It worked for about 8 minutes and then stopped working, now restarting says out of supplies even tho i have 5k irit unf's and 9k eyes of newt.

    Edit 2: Moved ingredients to bank slots 1&2, worked for 1h 18min and then stopped for unknown reason (didn't specify in console and i wasn't at the computer).

    Good enough for me
    Last edited by Chpp; 11-06-2011 at 11:59 AM.

  14. #14
    Join Date
    Feb 2007
    Location
    Het ademt zwaar en moedeloos vannacht.
    Posts
    7,211
    Mentioned
    26 Post(s)
    Quoted
    72 Post(s)

    Default

    There's a bug in your MakePotions script:
    Simba Code:
    repeat
        FindNormalRandoms;
        Failsafe:= 0;
        LevelUp;
        Wait(500 + Random(300));
        Inc(Failsafe);
        if (FailSafe = 5) or (FailSafe = 10) then
          AntiBan;
      until  (not(FindDTM(First, x1, y1, MIX1, MIY1, MIX2, MIY2))) or (Failsafe = 20);
    Take a close look at the Failsafe variable. First you set it to 0 and increment one (so it will be 1), then you compare to see if it is 5, 10, or 20. But as it's always 1, those are useless thus your loop might just be infinite and your antiban won't work. You might just want to fix that

    Form looks good! Might wish to add that if the user presses the close (X) button, it just frees and terminates script instead of starting to do stuff. You could also disable resizing of the form and fix the Exit button to work.

    Bank function might also have a bug:
    Simba Code:
    if (not(BankScreen)) then
        begin
          if (not(OpenBank(WBank, False, False))) then
            WriteLn('Error: Cant open bank');
          Wait(200 + Random(300));
          if BankScreen then
            Wait(200 + Random(300));
            FixBank;
            if (not(InvEmpty)) then
              DepositAll;
        end;
    Either your indention is off (after the if bankscreen part) or you forgot a begin/end. Also, just writing there's an error and then continuing happily also doesn't yield expected results. Get some proper failsafes there! You did it right with the WithdrawItems.

    Hope this might help you with improving your script. Don't forget to keep up the good work! I didn't actually run the script but these were the few things I saw first.
    I made a new script, check it out!.

  15. #15
    Join Date
    Apr 2007
    Location
    Estonia
    Posts
    156
    Mentioned
    0 Post(s)
    Quoted
    10 Post(s)

    Default

    Awesome notes Markus, Thanks!

    Yes, changed few things dramatically before the relese, thatswhy the bank function is way off...
    ROCK IS NOT A DEVILS WORK, ITS MAGICAL AND RAD!

  16. #16
    Join Date
    Feb 2007
    Location
    Estonia.
    Posts
    1,938
    Mentioned
    0 Post(s)
    Quoted
    2 Post(s)

    Default

    Tere, tere, kaasmaalane!

    Kiidan tööd! Ega ei ole lähiajal plaanis herb cleanerit teha?
    Keep up the good work!!
    ~Eerik.

  17. #17
    Join Date
    Apr 2007
    Location
    Estonia
    Posts
    156
    Mentioned
    0 Post(s)
    Quoted
    10 Post(s)

    Default

    Quote Originally Posted by Heavenzeyez1 View Post
    Tere, tere, kaasmaalane!

    Kiidan tööd! Ega ei ole lähiajal plaanis herb cleanerit teha?
    Keep up the good work!!
    ~Eerik.
    Heh, Tere!
    Kle plaan lisada see siia scripti, vaatab kuidas aega saab :P Extremes veel vaja ennem lisada :P
    Tänud :P
    ROCK IS NOT A DEVILS WORK, ITS MAGICAL AND RAD!

  18. #18
    Join Date
    Nov 2011
    Posts
    56
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    hi guys

    I am new here and just getting up to speed. I am after a Unf pot maker.

    may i ask first how many Pots can this make an hour?

    many thanks#
    Ghola

  19. #19
    Join Date
    Jan 2011
    Posts
    335
    Mentioned
    0 Post(s)
    Quoted
    23 Post(s)

    Default

    I will be testing this soon, and going for 99 herb if works well.
    If I see you autoing with level 3/default clothes/crap name I WILL report you. Auto Correctly.

  20. #20
    Join Date
    Oct 2011
    Posts
    23
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    ill try it out

  21. #21
    Join Date
    Aug 2011
    Location
    Spooner Street
    Posts
    309
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by Heavenzeyez1 View Post
    Tere, tere, kaasmaalane!

    Kiidan tööd! Ega ei ole lähiajal plaanis herb cleanerit teha?
    Keep up the good work!!
    ~Eerik.
    Gotta love eesti keel. It's weird after decades and decades we still find Estonian funny.

    Greetings from Finland.

    Sorry for offtopic, I just had to.

  22. #22
    Join Date
    Nov 2007
    Location
    I live in Slovenia! :)
    Posts
    837
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    I have been having some problems lately. I've tried searching around the forums but I haven't found any solutions. When I start the script, I fill out the form, but SMART won't launch. I've tried reinstalling my simba but it still happens. Any ideas?
    ~T2

  23. #23
    Join Date
    Apr 2007
    Location
    Estonia
    Posts
    156
    Mentioned
    0 Post(s)
    Quoted
    10 Post(s)

    Default

    Quote Originally Posted by tico2 View Post
    I have been having some problems lately. I've tried searching around the forums but I haven't found any solutions. When I start the script, I fill out the form, but SMART won't launch. I've tried reinstalling my simba but it still happens. Any ideas?
    Hmm, it takes ~20-30 seconds for SMART to pop out...
    Last edited by neeger; 11-08-2011 at 06:28 PM.
    ROCK IS NOT A DEVILS WORK, ITS MAGICAL AND RAD!

  24. #24
    Join Date
    Nov 2011
    Location
    Turn Around...
    Posts
    528
    Mentioned
    1 Post(s)
    Quoted
    44 Post(s)

    Default

    This script works flawless except for one thing...lol im not sure if im not correct or not..but with the scroll of cleansing it just waits for the herb to be finished and when it doesnt, it just simply logs out...

  25. #25
    Join Date
    Nov 2011
    Location
    Turn Around...
    Posts
    528
    Mentioned
    1 Post(s)
    Quoted
    44 Post(s)

    Default

    False alarm...it works flawless

Page 1 of 21 12311 ... LastLast

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •