v 1.8 not coming up when i click on the link? HELP!!!
v 1.8 not coming up when i click on the link? HELP!!!
[Error] C:\Users\davinder\Downloads\BarbFlyFisher(1.75) (1).Simba(621:10): Duplicate identifier 'GETKEYBIND' at line 620
Compiling failed.
help :/
How do i solve this probelm?
[Error] C:\Simba\Includes\SRL/SRL/misc/SmartParams.Simba(283:1): Semicolon (';') expected at line 282
Compiling failed.
All you need to do is comment that entire section out, or remove it.
The section being;
As for my issue... It works perfectly! But when it comes to banking time, it teleports to Edgeville via Lodestone... But while it is still exiting out of the teleport it is trying to move, so not sure if that is the cause, but it manages to get to the banks door, then just gives up and teleports again, in an endless loop. I will try disabling the Lodestone functioning and making it walk, should solve it hopefully...Code:Function GetKeybind(Slot: Integer): String; var sArr: TStringArray; begin sArr := ['1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '-', '=']; Result := sArr[Slot-1]; end;
EDIT: I found the beta version (1.8) and it works like a charm!! Also, does anyone know how I can make the java applet window stop popping up every so often? I often do other things than watch the script, so it does get annoying after a while (not major though) so any thoughts?
Last edited by Zamalega; 04-16-2013 at 01:34 PM.
If you're trying to make money, you're wasting time/experience banking the fish as they aren't worth a lot anyways. I'd recommend just powerleveling/dropping fish until lvl 90's and then hunt cavefish, there may be a script out there for it, I'm not sure, for money making if that's what you're after. But fly fishing is just good for the experience.
Ok so of everyone who's used V.1.8 have any of you had issues with it yet? If so post them here and this evening I'll try to sort them out and then release 1.8 for everyone.
Current projects:
[ AeroGuardians (GotR minigame), Motherlode Miner, Blast furnace ]
"I won't fall in your gravity. Open your eyes,
you're the Earth and I'm the sky..."
no issues yet flight! Ill post this proggy before school, hopefully let it run 2-4 days
http://prntscr.com/10u230
Wasting time? On the contrary my friend!This script has saved me hours of time that I would have otherwise laboriously done by hand! So every single piece of XP that I get, I treasure, dearly! I'm not in it for the profit, I just wanna get my skills high enough so I can actually enjoy the game, as all the fun stuff (like dungeoneering) requires high levels in most skills!
V1.8 is way more stable and awesome! The only issue I seemed to have is;
After 2 hours, that's damn awesome! And I was banking to boot! So I haven't seen any issues with it as of yet... However there is one question I have...Code:[====================================] [ Barb Fly-Fisher 1.8 ] [ by Flight ] [====================================] [ Run Time : 2 Hr 12 Min 31 Sec ] [ Trout Caught : 486 ] [ Salmon Caught : 324 ] [ Fishing XP : 46,981 ] [ Loads : 30 ] [ Breaks : 0 ] [====================================] [ Barb Fly-Fisher 1.8 ] [====================================] Time until break: 01:17:28 Stage: 1 {{{==Script shutdown==}}} ----Reason: Failed to teleport to Edgeville---- Exception in Script: The given DTM Index[2] doesn't exist The following bitmaps were not freed: [6]
It seems most of the repertoire of this script is on repeat... As extensive as it is, if one were to stay and watch (listen) for a while, you would see that it is indeed a bot. I know there are random clicks here and there, but is there not a way to fully randomize everything the bot does, from choosing its fishing spot and when to fish, to when it goes to the bank (even if its inventory is not full like 25/28) and takes an alternate route?
And what about those strange rocks that players receive every so often (max 2 at a time) for each skill? Can we specify to have them banked along with everything else (or is that already done)?
Now I'm not asking you to do this (even though it'd probably take mere minutes with your genius) as I'd be more than willing to learn and make the edit myself and share back with the community as this has helped me greatly and saved much of my real life time...
But really, thank you for this awesome release! And looking forward to future releases!
Also, do you accept requests? I'd gladly tip you real life money to have you create another fishing script for higher levels, and if you were willing to even release it publicly as I wouldn't want to keep such awesomeness to just myself, I believe everyone should be able to share in, well at least those who are like me and are only doing this to not have to grind and actually have fun in the game.
EDIT: I got this random stop just now;
Meanwhile there's way more than enough feathers.Code:{{{==Script shutdown==}}} ----Reason: Out of feathers---- Exception in Script: The given DTM Index[2] doesn't exist The following bitmaps were not freed: [6]I don't know if there is any further information you need? The script by the lake, the inventory was full, it was supposed to go back to the bank, then it did that. :/
EDIT 2: Turns out that it's now crashing with;
Funny thing is it was literally a foot away from the Edgeville Lodestone, yet it still insists that it must teleport, then half-way through the teleport animation it suddenly realizes where it is and move forward a bit before giving up and exiting.Code:{{{==Script shutdown==}}} ----Reason: Failed to teleport to Edgeville----
Last edited by Zamalega; 04-16-2013 at 01:33 PM.
Cannot seem to find any replies that mention this but my client keeps sayign there is a problem with line 620.
Function GetKeybind(Slot: Integer): String;
var
sArr: TStringArray;
begin
sArr := ['1', '2', '3', '4', '5', '6', '7', '8', '9', '0', '-', '='];
Result := sArr[Slot-2];
end;
Line 620 is the first one I just posted the whole function incase that matters.
Can anyone help me I really want to start fishing soon.
Thanks, Phasmatys
Edit: woops forgot to add the debug message
[Error] C:\Simba\Scripts\Auto Fisher.simba(621:10): Duplicate identifier 'GETKEYBIND' at line 620
Compiling failed.
My Outdated ScriptsEdgeville Log Cutter | Edgeville AIO Jewelry | AIO Pickpocketer | Urn Activator | Slayer Tower | Slaying KuradalMy Working Scripts: Tutorials:Function Pointers and Why You Should Care! | Forms and Saving Settings | The Magic Behind Programming Tutorial | Recursive Recursion![]()
Stopped because out of feathers shortly after i left for schoolReason: out of feathers, but i have 70k left. Bitmaps 5+307 werent freed
Ok thanks alot man appreciate it
Hey I like the name! I'm actually a fan of Adidas myself.Anyways, as Zamalega had already mentioned there is an issue in the script to where the feathers are not found, and today I will be reworking this as well as many others that he pointed out. Thank you for the input.
@Zamalega:
Thank you for the suggestions buddy. That's what I like to see, a detailed report with specific problems (when they occur, ect...) as well as suggestions of human-like implantation for the script. Your post is the most constructive one I've seen in a long time for sure!
Now, today I'll be addressing the issue of the "Out of Feathers" glitch as well as the full Lodestone teleporting + banking. Of the suggestions you gave me I understand a few of them but when it comes to choosing the fishing spot (closest to player) that is indeed done on purpose. The alternate route-taking I suppose I could do but it probably wouldn't differ much for the normal route, perhaps the only difference is it would walk on the west side of the Edgeville coffin house rather than the east side.
I'll be working on it this morning (as I imagine these fixes will take no time at all) so if any other awesome ideas come to mind throw them my way and I'll see what I can do. This goes for everyone.
Current projects:
[ AeroGuardians (GotR minigame), Motherlode Miner, Blast furnace ]
"I won't fall in your gravity. Open your eyes,
you're the Earth and I'm the sky..."
Oh I know that the script does the work for you and you save a lot of time yourself, but what I mean was that by going to the bank its time/exp waste. By powerleveling, with the script, you can probably x2 the experience. Since the fish are worth very little you wouldn't be making a big profit, not even a decent one.
My guy only drops like 3-5 trouts then continues to fish? he never drops the salmon? why is this happening?
That means a lot to me coming from such a talented developer such as yourself!And it is the least I can do to assist in perfecting this script (not that it isn't, it gets the job done in the end).
For the Feathers issue, I would think it's getting confused somewhere just after a fish is caught, somewhere where it does a check, it bonks out... But also seems to happen if you crash and it logs you back in, standing near the lake.
As for the fishing spots, I understand you now, that isn't an issue at all. I actually like that it pauses for a bit after the spot is depleted, as it gives it a lifelike appearance as opposed to the others (surely bots) who spring immediately to the next spot. However is it possible that each time it goes to a next spot, it does it different from the last time? Let's say you have an array of 10 possible combinations, or even better; a script that randomizes on many possibilities, and uses it to determine how long before it jumps to the next spot (from 0.5 seconds to up to 2-3 seconds).
As for the walking, why I say a randomization would be great is because no human takes the exact same route 30 times consecutively. So if someone were to be watching (they're always watching!) we'd have a bit of a problem... It doesn't have to be something fancy, just instead of going ----- {bank} let it go ---__---|-- {bank} or many different variations, never in a loop, so also about 10+ different possibilities or a randomization option for much more, thus giving off a lifelike feel.
Some of the repetitive tasks that it does, and in the same order, looping is;
- Checking Player Names (way too often, should be random amount, and very low)
- Checking Fishing Level (who does this so often? I hardly ever do, maybe once or twice in 10 runs)
- Switching Way Too Fast Back To Inventory After Checking Fishing Level (that's godlike speed man, and always accurate, always the same!)
- After Switching To Teleport Switches Fast Back To Inventory (same as above, maybe leave it for a while and switch at bank randomly?)
- When It Comes Out Of Teleport Uses Exact Same Pathing To Bank (really botlike)
- Goes To Same Place In Bank After Teleport (and once it gets there it stands like an idiot for way too long, suspicious!)
- Leaves Bank Through Same Door On The West Of The Bank (alternate, perhaps even go intentionally through front and pause randomly)
- Paused For About 10 Seconds In Front Of A Fishing Spot On The Left And Rather Went To The One On The Left
- Checks NPC's Regularly (Fisherman) (way too often)
- Pans The Camera In Front Of The Player, Why Not From Behind? (also too frequently)
What you can do for the depositing, mix it up between the deposit box and actual bank, as I usually always just go and bank with the banker (right-click->bank) so if doing that you can add a "mistake" that I often do and "talk" to the banker instead of banking... That gives it a most human like feel if the character was monitored on an internal level. Also, I sometimes click on "bank 50 or bank 10" instead of "bank all" which is a good way to feel humanlike as well!
It seems you tried so hard to make it not look like a bot, that you actually did the opposite of that and tried too hard. Often when I'm fishing I don't do much at all, maybe just pan the view randomly out of boredom and that's it. But if you are gonna have such tasks, at least have them randomized, in different lengths, longer mouse movements, etc.
What you can also do is implement a AFK feature, randomly, very random and often short, to make the character just stand somewhere on the map (like just pause dead for a couple of seconds to up to minutes) and then resume again. It often happens, I wanna go to the bathroom or fetch a drink, I don't log off...
The main thing I can say, for every script, is where you have any function ensure there are 10+ different variations all happening in random sequences thus never having a loop scenario.
A word of warning though, there is a mugger near the Lodestone who likes to attack the unweary, so maybe have your script turn auto-retaliate off and try to avoid going near there if at a low combat level?
Another suggestion, a simple one. When someone starts your script and is not at one of the required points, i.e at the lodestone, or at a fishing spot, in the bank, if none of those match you can then have the script use the Lodestone to Edgeville and then proceed to the bank to deposit all items in the inventory and attempt to find feathers (in a pre-defined spot in the bank?) and if none are found, to go to the G.E (too complicated?) and buy some at the stock price. Just a suggestion, but anything more than teleporting to Edgeville if not in a location familiar is just a thought.
UPDATE: I just found a bug!It seems that if you do not select the teleport sub-tab (and the home teleport spell is not visible) it breaks the Lodestone teleport function... So basically what the script did was do its normal fishing, then when it wanted to switch to the magic tab, it was on the main "magic" tab, but not on the teleport sub-tab, so all it did was mouse over it, not clicking it... See below for what I mean...
Magic Tab (no teleport sub-tab selected)
Magic Tab (teleport sub-tab with home teleport visible)
So what the script can do is check if it is on the magic tab, with the teleport sub-tab selected, else click on the magic tab, then on the teleport sub-tab so as to avoid any issues with teleports.
IDEA: Imagine having an interface where the script "learns" from the user, by letting it do the task it wishes to do a couple of times, then taking all the information it can from that "test", from mouse movement to the way the user handles situations, and implement it into the script, obviously randomizing as much as it can in the process so it would have no loops ever! If we could create such a tool, it could be globally used for all scripts, we can set a standard, thus allowing true humanlike features, custom tailored to each unique user, thus no two scripts would ever be the same, practically undetectable, no patterns whatsoever!
If I think of anything else I'll definitely let you know, same goes for any issues I may find. Once again, thank you so much for making such an awesome script, I love it! If you require any help, making future scripts (imagine a universal one that can do everything?!) please do let me know as I'd really love to help and offer creative input!
Hmmm, yes, you do have a valid point... But my cooking level sucks a bit, so I'm collecting so as to cook them, so killing two birds with one stone, while helping to perfect this script (of which modules can be used for other projects!). But thanks for the tip buddy!
What version of the script are you using? Have you tried v1.8? Get it here.
Hm well of those repetitive tasks you listed most of them are designed to do that specifically.
- Right-clicking moving objects (accounts for players as well as NPCs) I set to my preference, you're welcome to change this.
- Checking our Fishing level: this is a default anti-ban in SRL and as far as I'm concerned it's the appropriate speed.
- Walking from the Lodestone to the bank is straightforward, there's only 1 path between those two points and because the deposit boxes are in the northern part of the bank we walk through the northern doors; it would simply be unhuman-like to deliberately take the longer path.
- Leaving through the bank: the same reason as why the script chooses the shorter path when entering the bank; it's smarter, faster and much more human-like.
- Rotating the camera west: this is so the script can detect we're fishing by finding our fishing rod. Also at this angle we have a much higher chance of finding the fishing spot.
- I use the bank deposit box so the script will never require the user to input their bank PIN # for everyone's on sense of security.
And your issue with the opening of the Home Teleport screen should be fixed in this next version.
So if no one else has any issues to report (with 1.8) then I'll release it this afternoon. Those who have 1.8 now be sure to use this new version instead.
Progress Report by Flight:[====================================] [ Barb Fly-Fisher 1.8 ] [ by Flight ] [====================================] [ Run Time : 2 Hr 11 Min 57 Sec ] [ Trout Caught : 530 ] [ Salmon Caught : 442 ] [ Fishing XP : 57,441 ] [ Loads : 38 ] [ Breaks : 0 ] [====================================] [ Barb Fly-Fisher 1.8 ] [====================================]
It seems to be working just fine for me.
Current projects:
[ AeroGuardians (GotR minigame), Motherlode Miner, Blast furnace ]
"I won't fall in your gravity. Open your eyes,
you're the Earth and I'm the sky..."
I can confirm that! :P It's DAMN awesome!
Guess my suggestions were TL;DR, hehehe, can't blame you! I do tend to get carried away, and I hope you didn't take any offense to anything I said in regards to the repetitive tasks etc. I love your work!Code:[====================================] [ Barb Fly-Fisher 1.8 ] [ by Flight ] [====================================] [ Run Time : 6 Hr 42 Min 8 Sec ] [ Trout Caught : 1204 ] [ Salmon Caught : 848 ] [ Fishing XP : 119,564 ] [ Loads : 72 ] [ Breaks : 0 ] [====================================] [ Barb Fly-Fisher 1.8 ] [====================================]![]()
Did you make any modifications to the code? Are all your plugins/extensions up to date? Open Simba then go to View->Extensions and enable all of those, then you will see them appear as menu items in the Simba main view, for example you'll see "SPS" then click on it and select "Check for Update". Do this for all extensions, then close Simba, open up your script and see if it isn't fixed then.
Other than that, I honestly cannot see why it wouldn't be working for you... Also, if you have the Firewall enabled for Simba (the one Simba provides, not Windows one) ensure you have allowed the script to run etc.
Also, try the option where it banks to see if that at least works (because I know it does for me). You can also try slotting both fish in slots 1 and 2 (pause SMART first) then run it again and see if that works.
Good luck!
Updated to version 1.8
This update includes all the modifications from the beta 1.8 + a handful of newly added mods I added this afternoon. So for those of you already running the beta 1.8 I urge you to update to this version.
Current projects:
[ AeroGuardians (GotR minigame), Motherlode Miner, Blast furnace ]
"I won't fall in your gravity. Open your eyes,
you're the Earth and I'm the sky..."
Yes I tested the banking one 3 times last night and it will bank fine for about 5 loads then it cannot seem to find the deposit box/ or it enters the deposit box but doesnt bank then it terminates. I wqill try slot 1 and 2 and I will check my firewall. All my extensions are fully updated so that isn't the problem. Anyways I hope this work or atleast hope the banking version works for more than 5 loads, atleast up to 100 haha. Idc if I don't powerfish I just want exp in some way.
Thanks, Phasmatys
That sucks mate, but it seems I'm having a similar problem with this new v1.8... Not the beta version.
It's crashing more and more frequently now, like not even after 2 loads...
I think I'm just gonna disable the teleport function then see what happens.Code:{{{==Script shutdown==}}} ----Reason: Failed to teleport to Edgeville---- Exception in Script: The given DTM Index[2] doesn't exist The following bitmaps were not freed: [6]![]()
There are currently 1 users browsing this thread. (0 members and 1 guests)