Tab 21 & 27

[Coh3n]

RISK, nice job. Can you post the .diff please?

[RISK]

@ Zyt3x : You were right. It did provide false-positives when there were no tabs. I'm sorry for that.

@ Coh3n : I am embarrassed to say this, but I do not know what a .diff is. Could you explain it, please?

Here's fix #2:

{*******************************************************************************
function TabExists(Tab: Integer): Boolean;
By: ZephyrsFury & IceFire908; fixed by Zyt3x; fixed again by RISK
Description: Returns True if the Tab exists.
*******************************************************************************}
function TabExists(Tab: Integer): Boolean;
var
  dif: Integer;
  tP: TPoint;
begin
  Result := false;
  if (not loggedIn) then
    exit;

  if (tab < 20) then
  begin
    SRL_Warn('TabExists', 'Tab ' + IntToStr(Tab) + ' is not using the new constants! Please upgrade your script.', warn_AllVersions);
    Exit;
  end;

  if (not(InRange(Tab, Tab_Combat, Tab_LogOut))) then
  begin
    SRL_Warn('TabExists', 'Tab ' + IntToStr(Tab) + ' is not a valid tab number.', warn_AllVersions);
    Exit;
  end;

  if (Tab = tab_LogOut) then
  begin
    Result := (GetColor(746, 0) = 65536);
    Exit;
  end;

  if (Tab = 21) or (Tab = 23) then
  begin
    dif := 92;
  end else
    dif := 81;

  tP := Point(((Tab - 21) mod 8 * 30) + 537, ((Tab - 21) div 8 * 298) + 186);
  Result := CountColorTolerance(5597817, tp.x-12, tp.y-12, tp.x+12, tp.y+12, 10) <= dif; // the count when no icons are overlapping the GameTab.
end;

E: I imagine that's a very "Hacky" fix it for it, but I was not able to find a color that worked properly for both the non-trained and the trained accounts.

[Coh3n]

A .diff is a file that shows the differences between one version and another. I usually get them from TortoiseGit/SVN, but I'm guessing you use the updater to get SRL files? I can just plug it into my repository to see the diff, no big deal.

Thanks for the fix, but I'm still confused as to why this was only happening to you. Grats said everything worked fine for him? Or did it not work sometimes when you reloaded the client?

[RISK]

Don't commit that fix, please. I'm still playing around with it.
Yeah, I use the updater to get the files.

It was only happening to me because I had a skill level under about 60, it would make the "Task list" glow, I think and confuse it. Littma was experiencing the same issue on their own new character.

A .diff is a file that shows the differences between one version and another. I usually get them from TortoiseGit/SVN, but I'm guessing you use the updater to get SRL files? I can just plug it into my repository to see the diff, no big deal.

Thanks for the fix, but I'm still confused as to why this was only happening to you. Grats said everything worked fine for him? Or did it not work sometimes when you reloaded the client?

[Coh3n]

Ohh the task list is always illuminated on low level players? Didn't know that.

[RISK]

I'm not sure how you'd detect if the illuminated task list tab exists or not without remaking the whole TabExists function.

[Coh3n]

There's no way to "de-illuminate" it? Lol.

[RISK]

The only way to "de-illuminate" it is to get a total level over 60 or so. I don't know the exact level, but. I think the whole function will have to be rewritten.

[Coh3n]

I'm sure it can be done.

[Kyle Undefined]

Sorry for the bump, but I think they changed this illumination effect of the tab. I have no accounts under 60 total levels to test this on so I created a new one, no skills trained and it doesn't have this illuminated tab.

I've reloaded the client, switched browsers, and still nothing. RISK, maybe test this again on the account that was doing this?

[Narcle]

I did update TabExists since this.

[Kyle Undefined]

But the tab isn't illuminated on the new account, wasn't that the issue that was messing up the "TabExists"?