+ Reply to Thread
Results 1 to 21 of 21

Thread: Cant find Falador pump

  1. #1
    Join Date
    Nov 2011
    Location
    United States
    Posts
    815
    Mentioned
    6 Post(s)
    Quoted
    284 Post(s)

    Default Cant find Falador pump

    When using falador vial filler it cant find the pump, just runs a little north of bank and cant find it. Keeps attempting to find falador water pump but cant find it :s tried running it two different times and also heard someone else was having same problem

  2. #2
    Join Date
    Dec 2009
    Location
    R_GetPlayerLoc;
    Posts
    2,235
    Mentioned
    0 Post(s)
    Quoted
    14 Post(s)

    Default

    I'll check this out an edit with what I find...
    "Logic never changes, just the syntax" - Kyle Undefined?

    Remember, The Edit Button Is There For A Reason!!!

  3. #3
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    Probably just have to update the object record.

  4. #4
    Join Date
    Dec 2009
    Location
    R_GetPlayerLoc;
    Posts
    2,235
    Mentioned
    0 Post(s)
    Quoted
    14 Post(s)

    Default

    Yeah. I created it a while ago and it wasn't perfect so Ill see if I can change a few things.

    Edit: Bump edit w/e...

    This is rather difficult/hard with SPS not being able to put you next to the pump therefore getting you to find other similar objects and yeah ...

    To MSI Developers:

    ----My proposition to fix this problem is to:

    • Change Accuracy to a New System. This change will probably be only a few lines of code.
    • Instead of accuracy there will be MaxAccuracy and MinAccuracy (You can change the names of the variables).
    • So, currently you need a minimum of Accuracy amount of colors.
    • With the new system you'd need a minimum of of minaccuracy and and cannot exceed a maximum of maxaccuracy...
    • This would solve all issues where there is an excess of colors and all colors are similar (such as the Falador Pump).
    "Logic never changes, just the syntax" - Kyle Undefined?

    Remember, The Edit Button Is There For A Reason!!!

  5. #5
    Join Date
    Oct 2007
    Location
    #srl
    Posts
    6,102
    Mentioned
    39 Post(s)
    Quoted
    62 Post(s)

    Default

    Quote Originally Posted by Yago View Post
    Yeah. I created it a while ago and it wasn't perfect so Ill see if I can change a few things.

    Edit: Bump edit w/e...

    This is rather difficult/hard with SPS not being able to put you next to the pump therefore getting you to find other similar objects and yeah ...

    To MSI Developers:

    ----My proposition to fix this problem is to:

    • Change Accuracy to a New System. This change will probably be only a few lines of code.
    • Instead of accuracy there will be MaxAccuracy and MinAccuracy (You can change the names of the variables).
    • So, currently you need a minimum of Accuracy amount of colors.
    • With the new system you'd need a minimum of of minaccuracy and and cannot exceed a maximum of maxaccuracy...
    • This would solve all issues where there is an excess of colors and all colors are similar (such as the Falador Pump).
    I believe this was brought up long ago actually, not sure if it was public or private conversation though. Regardless, I'm certainly not against it. Perhaps I'll have a look at the best way to add that.

  6. #6
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    I agree, Yago. Since it won't be needed for all objects we can just do
    Simba Code:
    if (maxAccuracy > 0) then
    begin
      if (not inRange(length(TPA), minAccuracy, maxAccuracy)) then
        continue;
    end else
      if (length(TPA) < minAccuracy) then
        continue;
    That would have to go in MSI_FindObjectsTPA I believe.

  7. #7
    Join Date
    Dec 2009
    Location
    R_GetPlayerLoc;
    Posts
    2,235
    Mentioned
    0 Post(s)
    Quoted
    14 Post(s)

    Default

    It would definitely solve a lot of problems.

    Also, like coh3n said we could make it optional so if max value is set to zero then use the old system unless you guys don't mind editing all TMSobjects. If anything, i'd probably help with changing up the object files.
    "Logic never changes, just the syntax" - Kyle Undefined?

    Remember, The Edit Button Is There For A Reason!!!

  8. #8
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    Quote Originally Posted by Yago View Post
    It would definitely solve a lot of problems.

    Also, like coh3n said we could make it optional so if max value is set to zero then use the old system unless you guys don't mind editing all TMSobjects. If anything, i'd probably help with changing up the object files.
    We could change them all, but the majority of them don't need changing as they work just fine as they are. There may be others that this could be applied to, though.

  9. #9
    Join Date
    Oct 2008
    Location
    C:\Simba\Includes\
    Posts
    7,566
    Mentioned
    19 Post(s)
    Quoted
    180 Post(s)

    Default

    I feel that even with a different accuracy system, finding this pump will still be a pain and not accurate. The colors in the surrounding area are just too close together. The pump has no unique color to lock onto, I've gone through pixel by pixel and can't get a color that is only on the pump.
    Away for awhile, life is keeping me busy. | Want to get my attention in a thread? @Kyle Undefined; me.
    { MSI Phoenix || SRL Stats Sigs || Paste || Scripts || Quotes || Graphics }

    When posting a bug, please post debug! Help us, help you!

    I would love to change the world, but they won't give me the source code. || To be the best, you've got to beat the rest. || Logic never changes, just the syntax.
    If you PM me with a stupid question or one listed in FAQ, or about a script that is not mine, I will NOT respond.


    SRL is a Library of routines made by the SRL community written for the Program Simba. We produce Scripts for the game Runescape.


  10. #10
    Join Date
    Jan 2011
    Posts
    121
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by Camo Developer View Post
    I feel that even with a different accuracy system, finding this pump will still be a pain and not accurate. The colors in the surrounding area are just too close together. The pump has no unique color to lock onto, I've gone through pixel by pixel and can't get a color that is only on the pump.
    Just use a simple DTM, 2 points, one is on the pump and one is on the path underneath it. Make sure the distance between the points is small. Then get a TPA of all instances of the DTM and wa-la it works.

  11. #11
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    Quote Originally Posted by legoace View Post
    Just use a simple DTM, 2 points, one is on the pump and one is on the path underneath it. Make sure the distance between the points is small. Then get a TPA of all instances of the DTM and wa-la it works.
    Have you ever used a DTM for object finding on the main screen? I don't think it's that simple. VE and EV are just as close to the fountain and well, I'd rather see the location removed then do a lot of work for something that doesn't really need to be done. But, it's not my decision to make.

  12. #12
    Join Date
    Oct 2007
    Location
    #srl
    Posts
    6,102
    Mentioned
    39 Post(s)
    Quoted
    62 Post(s)

    Default

    Quote Originally Posted by Camo Developer View Post
    I feel that even with a different accuracy system, finding this pump will still be a pain and not accurate. The colors in the surrounding area are just too close together. The pump has no unique color to lock onto, I've gone through pixel by pixel and can't get a color that is only on the pump.
    But are all the colors grouped similarly? Ex. are there 120 blue pixels on the fountain, plus 120 blue pixels in 3 other places on the MS? I have no doubt that it can easily be found, it just wouldn't fit with MSI's current object finding.

    I'll have to come back to this thread in a bit.

  13. #13
    Join Date
    Oct 2008
    Location
    C:\Simba\Includes\
    Posts
    7,566
    Mentioned
    19 Post(s)
    Quoted
    180 Post(s)

    Default

    There is no fountain, the pump is almost the exact color of the road.
    Away for awhile, life is keeping me busy. | Want to get my attention in a thread? @Kyle Undefined; me.
    { MSI Phoenix || SRL Stats Sigs || Paste || Scripts || Quotes || Graphics }

    When posting a bug, please post debug! Help us, help you!

    I would love to change the world, but they won't give me the source code. || To be the best, you've got to beat the rest. || Logic never changes, just the syntax.
    If you PM me with a stupid question or one listed in FAQ, or about a script that is not mine, I will NOT respond.


    SRL is a Library of routines made by the SRL community written for the Program Simba. We produce Scripts for the game Runescape.


  14. #14
    Join Date
    Jan 2011
    Posts
    121
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by Coh3n View Post
    Have you ever used a DTM for object finding on the main screen? I don't think it's that simple. VE and EV are just as close to the fountain and well, I'd rather see the location removed then do a lot of work for something that doesn't really need to be done. But, it's not my decision to make.
    I have my own vial filler that is optimized for speed that is using this method, and is working. I only wrote it because MSI's was broken.

  15. #15
    Join Date
    Dec 2009
    Location
    R_GetPlayerLoc;
    Posts
    2,235
    Mentioned
    0 Post(s)
    Quoted
    14 Post(s)

    Default

    Quote Originally Posted by Camo Developer View Post
    I feel that even with a different accuracy system, finding this pump will still be a pain and not accurate. The colors in the surrounding area are just too close together. The pump has no unique color to lock onto, I've gone through pixel by pixel and can't get a color that is only on the pump.
    I've counted to differences between after a few edits to the colors between the pump and other similar objects... The accuracy is off by around 100pixels. Max accuracy and min accuracy would eliminate this problem.
    "Logic never changes, just the syntax" - Kyle Undefined?

    Remember, The Edit Button Is There For A Reason!!!

  16. #16
    Join Date
    Oct 2008
    Location
    C:\Simba\Includes\
    Posts
    7,566
    Mentioned
    19 Post(s)
    Quoted
    180 Post(s)

    Default

    Are we going to move forward with taking out this as a vial filler location? Or take Yago's idea and implement it?
    Away for awhile, life is keeping me busy. | Want to get my attention in a thread? @Kyle Undefined; me.
    { MSI Phoenix || SRL Stats Sigs || Paste || Scripts || Quotes || Graphics }

    When posting a bug, please post debug! Help us, help you!

    I would love to change the world, but they won't give me the source code. || To be the best, you've got to beat the rest. || Logic never changes, just the syntax.
    If you PM me with a stupid question or one listed in FAQ, or about a script that is not mine, I will NOT respond.


    SRL is a Library of routines made by the SRL community written for the Program Simba. We produce Scripts for the game Runescape.


  17. #17
    Join Date
    Dec 2011
    Posts
    12
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    I was wondering if anyone has had a look at this recently, it doesnt sem to quite be working yet

  18. #18
    Join Date
    Oct 2008
    Location
    C:\Simba\Includes\
    Posts
    7,566
    Mentioned
    19 Post(s)
    Quoted
    180 Post(s)

    Default

    If you would of read the posts, you would of realized that we are talking about removing the Falador pump out all together.
    Away for awhile, life is keeping me busy. | Want to get my attention in a thread? @Kyle Undefined; me.
    { MSI Phoenix || SRL Stats Sigs || Paste || Scripts || Quotes || Graphics }

    When posting a bug, please post debug! Help us, help you!

    I would love to change the world, but they won't give me the source code. || To be the best, you've got to beat the rest. || Logic never changes, just the syntax.
    If you PM me with a stupid question or one listed in FAQ, or about a script that is not mine, I will NOT respond.


    SRL is a Library of routines made by the SRL community written for the Program Simba. We produce Scripts for the game Runescape.


  19. #19
    Join Date
    Oct 2007
    Location
    #srl
    Posts
    6,102
    Mentioned
    39 Post(s)
    Quoted
    62 Post(s)

    Default

    We will be adding a maxAccuracy attribute as that will be useful in numerous other situations as well.

    I'll come back to this after work today.

  20. #20
    Join Date
    Dec 2011
    Posts
    12
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by Kyle Undefined View Post
    If you would of read the posts, you would of realized that we are talking about removing the Falador pump out all together.
    I did read all of the posts, but their were suggestions that would eliminate the need to remove it, and I was wondering if anyone had still been considering those.

  21. #21
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    I'd remove it, but maxAccuracy will probably help.

+ Reply to Thread

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may post replies
  • You may post attachments
  • You may edit your posts
  •