Results 1 to 6 of 6

Thread: gold ore superheater

  1. #1
    Join Date
    Dec 2011
    Posts
    12
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default gold ore superheater

    rubbish
    Last edited by justleveling; 02-14-2012 at 07:52 AM.

  2. #2
    Join Date
    Aug 2007
    Location
    in a random little world
    Posts
    5,778
    Mentioned
    0 Post(s)
    Quoted
    7 Post(s)

    Default

    i will look in more detail in a min, but here is a couple of bits i noticed
    Simba Code:
    MMouse(X, Y, 3, 3)
        WaitUpText('se', 1000);
        IF IsUpText('se') THEN
            Mouse(X, Y, 0, 0, TRUE);
            Wait(1500+Random(300));

    if it doesnt find the uptext then it will not run Mouse, but it will run everything else

    you can replace IsUpText with just WaitUpText

    you have incorrect standards (look in my siggy for a tutorial on standards)

    and please post your script in simba tags

    ~shut

  3. #3
    Join Date
    Dec 2011
    Posts
    12
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    thanks, ill fix up everything and edit my post

    e/ i fixed it up a little more
    Last edited by justleveling; 01-17-2012 at 08:05 PM.

  4. #4
    Join Date
    Aug 2007
    Location
    in a random little world
    Posts
    5,778
    Mentioned
    0 Post(s)
    Quoted
    7 Post(s)

    Default

    after fixing up your standards i have noticed some more stuff

    on the case, you have a begin/end for each option, but if the option only have one function/procedue to run then you dont need a begin/end

    i also see some FindDTM's where you dont check if it actually found the DTM

    you dont seem to have used failsafes

    ~shut

    EDIT: on this bit
    Simba Code:
    MMouse(X, Y, 7,7);
          Wait(100+Random(50));
          WaitUpText('old', 1000);
          Mouse(X, Y, 0, 0, FALSE);
          WaitOption('All', 500);

    you dont check if it is actually hovering over the item

    also, you first move to x, y with 7 randomness, but a little bit down you move to the exact location

    you could do something like this
    Simba Code:
    MMouse(x, y, 7, 7);         //moves the mouse
    GetMousePos(x, y);         //gets the mouse position
    Mouse(x, y, 0, 0, False);   //doesnt move the mouse because x, y was set to its current location on the line above
    Last edited by Shuttleu; 01-17-2012 at 08:06 PM.

  5. #5
    Join Date
    Dec 2011
    Posts
    12
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    fixed up some failsafes, added GetMousePos(X, Y); and updates first post.
    i still need to work on the spacing (standards)

  6. #6
    Join Date
    Dec 2011
    Posts
    8
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    I am getting:
    failed to find gold bars in inv, (username) is now inactive.
    NextPlayer(False)
    SwitchToPlayer(PlayerNo: 0, Active: False);
    Player is not Active...
    All players not active!
    Successfully executed.
    The following DTMs were not freed: [2]

    I have my gold ore in the first slot of the main tab but it just opens the bank then logs out.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •