Page 11 of 42 FirstFirst ... 91011121321 ... LastLast
Results 251 to 275 of 1043

Thread: P1nky's PestController

  1. #251
    Join Date
    Oct 2006
    Location
    finland, helsinki
    Posts
    2,501
    Mentioned
    3 Post(s)
    Quoted
    2 Post(s)

    Default

    I looked thorught the script, i found alot of bad standards ALOT of infinite loops, bad coding practice ALOTof unnessecary stuff.

    Simba Code:
    Procedure FightPests;     //2305818 green pest
    var                     //2701962 = red pest
     Z, R, CTS: Integer;        //5051472 = PURPLE PEST POP UP

        begin
        Status('Fighting Pests');
           If not (EFindObjCustom(x,y,['hifter','Shifte','Shifter','hift'], [2108184,5051472,3228504,4942983], 3)) Then
           begin
            if (counter>1000) then
              begin
                Report;
                counter := 0;
              end;
               R := Random(4);
              case R of
            0: RandomButton;
            1:  wait(Random(25) + 20);
            2:   wait(Random(25) + 20);
            3:   wait(Random(25) + 20);
            end;
            Exit;
        end else
       Mmouse(x,y,0,0);
       wait(Random(100) + 20);
       if isuptext('ttac') then
        begin
        if not Faster500 then
        begin
      Mouse(x,y,0,0,False);
        ChooseOption('ttack');
        end else
        begin
        Mouse(x,y,0,0,true);
     end;
          if Faster500 then
            begin
            wait(Random(100) + 20);
            Report;
       end else
       wait(2000);
       Report;
       end;
    end;
    and what is this? Has to be the ugliest procedure i've seen in a long time, nothing personal but i wont be using this script, it screams bannage.

    1200 lines for a pestcontroll script, it enters the boat and fights middle? I could do this in 300 lines...

    Code:
    • Narcle: I recall Jukka releasing a bunch of scripts like this before... Its how he rolls I think. rofl
    • Solarwind: Dude, you are like... t3h s3x.
    • Hy71194: JuKKa you're a machine! You released 3 scripts in 10 minutes! :O
    • benjaa: woah.... Jukka is the man Guildminer pwns all
    • NaumanAkhlaQ: And JuKKa Is my Her0!

  2. #252
    Join Date
    Jan 2012
    Posts
    30
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    thank you for your invested time , i will test the E version on the highest level lander and see how it runs and hopefully post a progress report

  3. #253
    Join Date
    Jan 2012
    Posts
    30
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    it seems to be working fine so far
    Last edited by brentrobbins; 02-20-2012 at 03:16 PM.

  4. #254
    Join Date
    Dec 2011
    Location
    Delaware, US
    Posts
    43
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    awesome script, works perfectly and hours on end for me

  5. #255
    Join Date
    Dec 2006
    Location
    Program TEXAS home of AUTOERS
    Posts
    7,934
    Mentioned
    26 Post(s)
    Quoted
    237 Post(s)

    Default

    Quote Originally Posted by JuKKa View Post
    I looked thorught the script, i found alot of bad standards ALOT of infinite loops, bad coding practice ALOTof unnessecary stuff.


    1200 lines for a pestcontroll script, it enters the boat and fights middle? I could do this in 300 lines...
    Thank you for your feedback JuKKa, tbh reading this post made me feel embarrass and ashamed of myself. I will try to improve myself so I won't have to see a comment like this in the future.

    Also, I just made this script to 600 lines, by taking out the unnecessary DDTMs for portals.

    -Cheers.

  6. #256
    Join Date
    Mar 2007
    Location
    Brisbane, AUS
    Posts
    305
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    works great pinky keep up the great work! hows the sw bot going? will it only be for members??

  7. #257
    Join Date
    Jan 2012
    Posts
    4
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default Problem

    every1 seems to like this script :S im having problems on veteran boat, it plays 1-2 game then runs to the intermediate boat and goes in there and sometimes logs out some help pl0x
    ,

  8. #258
    Join Date
    Nov 2011
    Location
    In your bed ;)
    Posts
    123
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    is there an attack portal option?

  9. #259
    Join Date
    Oct 2006
    Location
    finland, helsinki
    Posts
    2,501
    Mentioned
    3 Post(s)
    Quoted
    2 Post(s)

    Default

    you have alot of "missing" begins for example
    Simba Code:
    procedure LeftSpot;
    begin
      MakeCompass('S');
      LeftGate := Left;
      if DTMRotated(LeftGate, X, Y, MMX1, MMY1, MMX2, MMY2) then
        MMouse(x, y, 0, 0);
      wait(Random(100) + 20);
      Mouse(x, y, 0, 0, True);
    end;
    for example this would click 0, 0 (upper left corner) if it didnt find the DTM, Alot of other functions do this aswell.

    and

    Simba Code:
    Function Range : Boolean;
    begin
     If (FindColorSpiralTolerance(x, y, 5372475, 267, 132, 292, 160, 1)) then
      begin
      Result := True;
      Writeln('TRUE');
      end else
      Result := False;
      Writeln('False');
    end;
    this would print both true and false in the debug box, if it found the color.

    the infinite loops this one is killer, i would not wish my main to be caught in this.
    Simba Code:
    Procedure AttackWhite;
    begin
    repeat
    if  FindObj(x, y, 'ortal', 13217188, 15) then
    MMouse(x,y,0,0);
    wait(Random(100) + 20);
    Mouse(x,y,0,0,false);
    ChooseOption('ttack');
    until(false);
      end;
    alot of improvement but you will get there.

    sorrry if i sounded a bit harsh in my earlier post.

    Code:
    • Narcle: I recall Jukka releasing a bunch of scripts like this before... Its how he rolls I think. rofl
    • Solarwind: Dude, you are like... t3h s3x.
    • Hy71194: JuKKa you're a machine! You released 3 scripts in 10 minutes! :O
    • benjaa: woah.... Jukka is the man Guildminer pwns all
    • NaumanAkhlaQ: And JuKKa Is my Her0!

  10. #260
    Join Date
    Feb 2012
    Location
    DON'T PM ME ASKING FOR STUFF
    Posts
    2,170
    Mentioned
    38 Post(s)
    Quoted
    423 Post(s)

    Default

    guys it does work, if it doesn't attack anything it will kick you out and start over. I have 2 sets of void now cause of this.

    as for what jukka said, your a good guy for pointing these out. As harsh as it is it will allow p1nky to improve.
    p1nky i'm not a great scripter but like I said in the pm need help with anything? Hit me up

  11. #261
    Join Date
    Jan 2012
    Posts
    4
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    I dont get that changes u told me i shud delete them from the script?

  12. #262
    Join Date
    Jan 2012
    Posts
    48
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Great script. Got my set of voids from this. One of the most used scripts ive seen to. i was playing last night late and saw this script running could tell by where they stoped. atleast 10people using it. good job man.

  13. #263
    Join Date
    Feb 2012
    Posts
    386
    Mentioned
    2 Post(s)
    Quoted
    2 Post(s)

    Default

    Quote Originally Posted by MattL191 View Post
    Great script. Got my set of voids from this. One of the most used scripts ive seen to. i was playing last night late and saw this script running could tell by where they stoped. atleast 10people using it. good job man.
    Ya, You're Right. Continu like this.

  14. #264
    Join Date
    Dec 2006
    Location
    Program TEXAS home of AUTOERS
    Posts
    7,934
    Mentioned
    26 Post(s)
    Quoted
    237 Post(s)

    Default

    Quote Originally Posted by JuKKa View Post
    you have alot of "missing" begins for example
    Simba Code:
    procedure LeftSpot;
    begin
      MakeCompass('S');
      LeftGate := Left;
      if DTMRotated(LeftGate, X, Y, MMX1, MMY1, MMX2, MMY2) then
        MMouse(x, y, 0, 0);
      wait(Random(100) + 20);
      Mouse(x, y, 0, 0, True);
    end;
    for example this would click 0, 0 (upper left corner) if it didnt find the DTM, Alot of other functions do this aswell.

    and

    Simba Code:
    Function Range : Boolean;
    begin
     If (FindColorSpiralTolerance(x, y, 5372475, 267, 132, 292, 160, 1)) then
      begin
      Result := True;
      Writeln('TRUE');
      end else
      Result := False;
      Writeln('False');
    end;
    this would print both true and false in the debug box, if it found the color.

    the infinite loops this one is killer, i would not wish my main to be caught in this.
    Simba Code:
    Procedure AttackWhite;
    begin
    repeat
    if  FindObj(x, y, 'ortal', 13217188, 15) then
    MMouse(x,y,0,0);
    wait(Random(100) + 20);
    Mouse(x,y,0,0,false);
    ChooseOption('ttack');
    until(false);
      end;
    alot of improvement but you will get there.

    sorrry if i sounded a bit harsh in my earlier post.

    To be honest, not trying to cover anything up, check the code out now. I deleted whatever is not being used; Also, the code you have posted up was being tested (such as just to see if the DDTMs were working, and if it can find the portal) and it was not being used anywhere in the script.

    But, I do understand the 'FightPests' procedure is quite messy and I shall work on it and a lot of other procedures. Also, add more 'begins'.
    Thank You Mate & No problem Mate, I actually appreciate you being straight-forward.

  15. #265
    Join Date
    Jan 2012
    Location
    Washington State
    Posts
    16
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    [E] works great, been running it non stop since it came out (: my longest one with it so far is 7 hours which i did last night... thanks so much for making a free pc bot

  16. #266
    Join Date
    Feb 2012
    Posts
    48
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    is this a legit 1 ? not trolling i srsly need 1 but some dumbass posted this bot is hacked it so pls respond.

  17. #267
    Join Date
    Nov 2006
    Posts
    2,369
    Mentioned
    4 Post(s)
    Quoted
    78 Post(s)

    Default

    Quote Originally Posted by akash22 View Post
    is this a legit 1 ? not trolling i srsly need 1 but some dumbass posted this bot is hacked it so pls respond.
    If you download it from the first post it is safe. If you download anywhere else it might not be safe.
    Quote Originally Posted by DeSnob View Post
    ETA's don't exist in SRL like they did in other communities. Want a faster update? Help out with updating, otherwise just gotta wait it out.

  18. #268
    Join Date
    Jan 2012
    Posts
    6
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Thanks bro got helm and gloves almost top then bottom full void melle void

  19. #269
    Join Date
    Jan 2012
    Posts
    18
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    I started first game with this script, it goes flawless for now, I will give some comments later

  20. #270
    Join Date
    Jan 2012
    Posts
    4
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Im still having problems trying to pc in veteran boat and it sometimes goes to the intermediate boat some1 help plz

  21. #271
    Join Date
    Jan 2012
    Posts
    11
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Can you make it so that if it gets off the middle, it doesnt just stand there. Maybe add something where the player can go back to the middle if he/she is outside of it

  22. #272
    Join Date
    Dec 2006
    Location
    Program TEXAS home of AUTOERS
    Posts
    7,934
    Mentioned
    26 Post(s)
    Quoted
    237 Post(s)

    Default

    Quote Originally Posted by Based God View Post
    Can you make it so that if it gets off the middle, it doesnt just stand there. Maybe add something where the player can go back to the middle if he/she is outside of it
    I'll work on that in version [F]

  23. #273
    Join Date
    Jan 2012
    Posts
    18
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    It works perfect for me, nice job. running 6 hours without error....

  24. #274
    Join Date
    Feb 2012
    Posts
    9
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    lmao 4+ hours and 4 commendations?! plz fix it up some?

  25. #275
    Join Date
    Feb 2012
    Posts
    6
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Works fine for me. Ive been botting it straight for 5 days with hour or so breaks

Page 11 of 42 FirstFirst ... 91011121321 ... LastLast

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •