Cow Killer ~ For Jordan

[Vinyl Scratch]

Hey, guys. My friend Jordan was needing a script to train his pure, so I made this simple script. I hope you guys like it!


E: [MUST READ!!] It kills goblins, not cows, I couldn't get it to kill cows, their color was to close to the fence post, so I made it kill goblins. I'm going to make more killing scripts as I can!



Cheers!

~Troll


P.S. For SRL Members, Let me know when you would say yes to my scripts, so that I know when to post A thread to apply, and not make useless threads like I have.

[TheWord]

I think you forgot to attach it..

[Vinyl Scratch]

No, There's an error. Gotta fix.

[BlackStorm]

Unable to download. Said incorrect address.

[Vinyl Scratch]

You can't download it, I haven't fixed it yet.

[Vinyl Scratch]

Sorry for the Double posting, But, UPDATED!! IT'S FLAWLESS!!!

[Gucci]

Sorry for the Double posting, But, UPDATED!! IT'S FLAWLESS!!!

NICE! You gonna upload it though?

[Vinyl Scratch]

NICE! You gonna upload it though?

Uploaded!! Also, Can't make it kill cows, so Goblins were the next best thing! Right next to the cows!!

[Vinyl Scratch]

Hey, Tell me of anything you guys want added, and I'll see what I can do!

[Er1k]

DeclarePlayers;
 Startup;
 repeat
  KillGoblin;
  AntiBan;
 until(false);

This is a bad main loop and the infinite loop is a big no-no. Many people tend to instant-no vote when they see this. The correct way of doing this is generally

repeat
  //something here
until not LoggedIn;

procedure KillGoblin;
var
 X, y : Integer;
begin
 if FindObjCustom(X, y, ['ttack', 'oblin'], [7514770, 8233358, 3702387, 7969929], 10) then
 begin
  GetMousePos(X, y);
  MMouse(X, y, 5, 5);
  if IsUpText('Attack') then
  ClickMouse2(true);
  Wait(20000);
  AntiBan;
 end;
end;

Again, this will not get you anywhere. FindObjCustom is fine, but people again want to see more, usually some custom TPA finding.

IsUptext isn't used a lot nowadays when there WaitUptext or WaitUpTextMulti functions. Always use the WaitSomething series functions when they're available, like WaitOption for choosing an option, and so on. They're in the include for a reason.

And this is not to mention how simplistic the fighting procedure is. No detection of whether player is in fight, no failsafes, not even FindNormalRandoms.

procedure AntiBan;
begin
 case Random(250) of
  0: begin GameTab(tab_stats) HoverSkill ('Mining', false) GameTab(28); end;
  1: begin SleepAndMoveMouse (9000+random(600)); end;
  2: begin GameTab(tab_inv) ExamineInv; GameTab(28); end;
  3: begin RandomAngle(1); end;
  4: begin GameTab(tab_stats) HoverSkill ('Attack', false) GameTab(28); end;
  5: begin SleepAndMoveMouse (4000+random(250)); end;
  6: begin RandomAngle(2); end;
 end;
end;

Your antiban has also shown bad standards in my opinion. Don't do one liner in general, unless you're doing one thing and the meaning is very straightforward. Your missing semicolons here are also bugging me. It compiles, but it just isn't good standard anyway.

I heard you have a fletcher too, and I looked at it. The main loop has the same infinite loop problem, as with some indenting are incorrect. You didn't even free your DTMs when the script terminates. And the list goes on.

I might be sounding harsh here, but I don't think you're ready for becoming a SRL member, if these are what you're capable of. In fact what you have shown here is far from members material. I am aware you're working on a SW script. My only hope is that you do something significantly better than what you have done with these scripts, or else I am sure others will just give you cold hard No-s for your appliance, for the very same reasons.

You might as well want to look at others' scripts to see how they approach the same problems and what the level of sophistication is expected. You might be able to pickup something from them.