Page 2 of 2 FirstFirst 12
Results 26 to 46 of 46

Thread: Gucci's Battle Staff Maker

  1. #26
    Join Date
    Apr 2012
    Posts
    14
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    I modified a bit of the script and now it works very well. I changed it so it didn't close the bank after it deposits the battlestaff and I added the ClickMouse2(True);
    Here it is if anyone wants it and doesn't want to make changes to the original, start it with an empty inv and bank screen open.

    Simba Code:
    program GuccisBattlestaffMaker;
    {$DEFINE SMART}
    {$i srl/srl/misc/smart.simba}
    {$loadlib sps}
    {$i srl/srl.simba}
    {$i sps/sps.simba}

    const
     SRLStats_User = ''; // Your SRL Stats Username
     SRLStats_Password = ''; // Your SRL Stats Password
     MEMBERS = True;
     NumbOfPlayers = 1;
     StartPlayer = 0;
     CraftingEXP = 135; // Edit this for exp gained per staff made.

     var
      StaffsMade, CraftEXP, Make, x, y: integer;

     procedure DeclarePlayers;
      var i:integer;
    begin
      NumberOfPlayers(NumbOfPlayers);
      CurrentPlayer := StartPlayer
      for i := 0 to NumbOfPlayers-1 do
      Players[i].BoxRewards := ['XP'];

      With Players[0] do
        begin
          Name := ''; //Username.
          Pass := ''; //Password.
          Pin := ''; // Bank Pin.
          Active := True;
        end;

    end;

    procedure GetGoods;
    begin
      SetAngle(SRL_ANGLE_HIGH);
      Wait(200 + Random(100));

      if (BankScreen) or (PinScreen) then

      begin
        if (PinScreen) then
          repeat
            InPin(Players[0].Pin);
          until (BankScreen);

        if (BankScreen) then
          begin
            WriteLn('Bank is Open');
            DepositAll;
            Withdraw(0, 0, 14);
            Withdraw(1, 0, 14);
            Wait(300);
            CloseBank;
            WriteLn('Got Goods');
          end;
        end;
    end;

    procedure DepositGoods;
    begin
      if (InvCount = 14) then
      begin
       OpenBankChest(SRL_BANK_SW);

      if (BankScreen) or (PinScreen) then

      begin
        if (PinScreen) then
          repeat
            InPin(Players[0].Pin);
          until (BankScreen);

        if (BankScreen) then
          begin
            WriteLn('Bank is Open');
            DepositAll;
            Wait(300);
            WriteLn('Deposited Staffs');
          end;
        end;
    end;
    end;

    procedure DTMS;
    begin
      Make :=  DTMFromString('mLgAAAHicY2JgYJBnYmDQBmIjIFYC4uJgAYYFC5YzwAAjFDMwAABU/wNo');
    end;

    procedure FrDTM;
    begin
      FreeDTM(Make);
    end;

    procedure MakeStaffs;
    begin
     MouseSpeed := 40;
     InvMouse(14, mouse_left);
     Wait(100);
     InvMouse(15, mouse_left);
     Wait(500 + Random(20));
     Mouse(257, 428, 0, 0, True);
     ClickMouse2(True);
     Wait(18000 + Random(20));
    end;

    procedure StaffMade;
    begin
      if BankScreen then
      IncEx(StaffsMade, 14);
    end;

    procedure Report;

    begin

      if (BankScreen) then
    begin
       CraftEXP:= (StaffsMade*CraftingExp);

      Writeln('############ Guccis Staff Maker ##########');
      Writeln('|= Player : ' + Players[CurrentPlayer].Name);
      Writeln('|= Time Running : ' + TimeRunning);
      Writeln('|= Crafting EXP gained : ' + IntToStr(CraftEXP));
      Writeln('##########################################');
    end;
    end;

    Begin
      Smart_Signed := TRUE;
      Smart_Members := MEMBERS;
      Smart_SuperDetail := FALSE;
      Smart_Server := 30;
      ActivateClient;
      SetupSRL;
      DTMS;
      DeclarePlayers;
      if not (LoggedIn) then
      LoginPlayer;
      Wait(4000+random(400));
      SetAngle(SRL_ANGLE_HIGH);
       Repeat
        GetGoods;
        MakeStaffs;
        if (InvCount = 14) then
        DepositGoods;
        Report;
       Until(False)
        FrDTM;
    End.
    Last edited by ZenoKurosagi; 04-23-2012 at 12:31 AM.

  2. #27
    Join Date
    May 2012
    Posts
    4
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by ZenoKurosagi View Post
    I modified a bit of the script and now it works very well. I changed it so it didn't close the bank after it deposits the battlestaff and I added the ClickMouse2(True);
    Here it is if anyone wants it and doesn't want to make changes to the original, start it with an empty inv and bank screen open.

    Simba Code:
    program GuccisBattlestaffMaker;
    {$DEFINE SMART}
    {$i srl/srl/misc/smart.simba}
    {$loadlib sps}
    {$i srl/srl.simba}
    {$i sps/sps.simba}

    const
     SRLStats_User = ''; // Your SRL Stats Username
     SRLStats_Password = ''; // Your SRL Stats Password
     MEMBERS = True;
     NumbOfPlayers = 1;
     StartPlayer = 0;
     CraftingEXP = 135; // Edit this for exp gained per staff made.

     var
      StaffsMade, CraftEXP, Make, x, y: integer;

     procedure DeclarePlayers;
      var i:integer;
    begin
      NumberOfPlayers(NumbOfPlayers);
      CurrentPlayer := StartPlayer
      for i := 0 to NumbOfPlayers-1 do
      Players[i].BoxRewards := ['XP'];

      With Players[0] do
        begin
          Name := ''; //Username.
          Pass := ''; //Password.
          Pin := ''; // Bank Pin.
          Active := True;
        end;

    end;

    procedure GetGoods;
    begin
      SetAngle(SRL_ANGLE_HIGH);
      Wait(200 + Random(100));

      if (BankScreen) or (PinScreen) then

      begin
        if (PinScreen) then
          repeat
            InPin(Players[0].Pin);
          until (BankScreen);

        if (BankScreen) then
          begin
            WriteLn('Bank is Open');
            DepositAll;
            Withdraw(0, 0, 14);
            Withdraw(1, 0, 14);
            Wait(300);
            CloseBank;
            WriteLn('Got Goods');
          end;
        end;
    end;

    procedure DepositGoods;
    begin
      if (InvCount = 14) then
      begin
       OpenBankChest(SRL_BANK_SW);

      if (BankScreen) or (PinScreen) then

      begin
        if (PinScreen) then
          repeat
            InPin(Players[0].Pin);
          until (BankScreen);

        if (BankScreen) then
          begin
            WriteLn('Bank is Open');
            DepositAll;
            Wait(300);
            WriteLn('Deposited Staffs');
          end;
        end;
    end;
    end;

    procedure DTMS;
    begin
      Make :=  DTMFromString('mLgAAAHicY2JgYJBnYmDQBmIjIFYC4uJgAYYFC5YzwAAjFDMwAABU/wNo');
    end;

    procedure FrDTM;
    begin
      FreeDTM(Make);
    end;

    procedure MakeStaffs;
    begin
     MouseSpeed := 40;
     InvMouse(14, mouse_left);
     Wait(100);
     InvMouse(15, mouse_left);
     Wait(500 + Random(20));
     Mouse(257, 428, 0, 0, True);
     ClickMouse2(True);
     Wait(18000 + Random(20));
    end;

    procedure StaffMade;
    begin
      if BankScreen then
      IncEx(StaffsMade, 14);
    end;

    procedure Report;

    begin

      if (BankScreen) then
    begin
       CraftEXP:= (StaffsMade*CraftingExp);

      Writeln('############ Guccis Staff Maker ##########');
      Writeln('|= Player : ' + Players[CurrentPlayer].Name);
      Writeln('|= Time Running : ' + TimeRunning);
      Writeln('|= Crafting EXP gained : ' + IntToStr(CraftEXP));
      Writeln('##########################################');
    end;
    end;

    Begin
      Smart_Signed := TRUE;
      Smart_Members := MEMBERS;
      Smart_SuperDetail := FALSE;
      Smart_Server := 30;
      ActivateClient;
      SetupSRL;
      DTMS;
      DeclarePlayers;
      if not (LoggedIn) then
      LoginPlayer;
      Wait(4000+random(400));
      SetAngle(SRL_ANGLE_HIGH);
       Repeat
        GetGoods;
        MakeStaffs;
        if (InvCount = 14) then
        DepositGoods;
        Report;
       Until(False)
        FrDTM;
    End.
    works now after this^, thanks

  3. #28
    Join Date
    May 2012
    Location
    Runeterra
    Posts
    36
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    I had an issue with the wait timers, so that it wouldn't begin combining the staffs properly and would have to go through the MakeStaffs procedure twice before the staffs were created. Doubling the wait time before clicking the "Combine" button to 1000 solved the problem on all worlds, while 800 didn't prove long enough.

    Combining that with Zeno's updated code solved all problems, so hopefully this saves a few people the trial-and-error tinkering.

    General commentary: this script is really useful to a newbie like myself in learning how a script functions. It's so stripped down and basic that I haven't had any problems figuring out what each function does, nor does it have tightly linked dependancies to unravel. While it might lack failsafes and the like, there are some advantages to the extreme simplicity.

  4. #29
    Join Date
    Jan 2012
    Location
    Calgary, AB, Canada
    Posts
    1,819
    Mentioned
    5 Post(s)
    Quoted
    120 Post(s)

    Default

    Quote Originally Posted by Nasus View Post
    I had an issue with the wait timers, so that it wouldn't begin combining the staffs properly and would have to go through the MakeStaffs procedure twice before the staffs were created. Doubling the wait time before clicking the "Combine" button to 1000 solved the problem on all worlds, while 800 didn't prove long enough.

    Combining that with Zeno's updated code solved all problems, so hopefully this saves a few people the trial-and-error tinkering.

    General commentary: this script is really useful to a newbie like myself in learning how a script functions. It's so stripped down and basic that I haven't had any problems figuring out what each function does, nor does it have tightly linked dependancies to unravel. While it might lack failsafes and the like, there are some advantages to the extreme simplicity.

    Yeah it's was just something I quickly whipped up I don't ever use it so I don't really check out bugs, but it's great people learn from it
    Current Project: Retired

  5. #30
    Join Date
    Feb 2012
    Location
    Brisbane, Australia
    Posts
    174
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Hey Gucci, I was using your script and it works flawlessly, b staffs take to long to buy so I have resorted to making Green d' bods, I cannot get a script to work for it, would be alright If i edit your script to make green d bods?
    WGS + Rotm completed91/99 SummoningMining 83/90

    Smart Botting Guide: http://villavu.com/forum/showthread.php?t=82519

    Previously known as Rbd banned

  6. #31
    Join Date
    Jan 2012
    Location
    Calgary, AB, Canada
    Posts
    1,819
    Mentioned
    5 Post(s)
    Quoted
    120 Post(s)

    Default

    Quote Originally Posted by rbd banned View Post
    Hey Gucci, I was using your script and it works flawlessly, b staffs take to long to buy so I have resorted to making Green d' bods, I cannot get a script to work for it, would be alright If i edit your script to make green d bods?
    Yeah for sure just don't release to public
    Current Project: Retired

  7. #32
    Join Date
    Feb 2012
    Location
    Denver, CO
    Posts
    863
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    I've been using the version that Zeno posted, and it has been working very well.

  8. #33
    Join Date
    Feb 2012
    Posts
    9
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    The script gets stuck when it needs to click the make all battlestaffs tab.
    Solution: change the prodedure in the script for my version, way more stable.

    procedure MakeStaffs;
    begin
    MouseSpeed := 20;
    InvMouse(14, mouse_left);
    Wait(150);
    InvMouse(15, mouse_left);
    Wait(1500 + Random(100));
    Mouse(257, 428, 0, 0, True);
    ClickMouse2(True);
    Wait(17000 + Random(20));
    end;

    Making staves all day long

  9. #34
    Join Date
    Feb 2012
    Location
    Denver, CO
    Posts
    863
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by neo arrow pk View Post
    The script gets stuck when it needs to click the make all battlestaffs tab.
    Solution: change the prodedure in the script for my version, way more stable.

    procedure MakeStaffs;
    begin
    MouseSpeed := 20;
    InvMouse(14, mouse_left);
    Wait(150);
    InvMouse(15, mouse_left);
    Wait(1500 + Random(100));
    Mouse(257, 428, 0, 0, True);
    ClickMouse2(True);
    Wait(17000 + Random(20));
    end;

    Making staves all day long
    I was having a similar issue, thanks for posting that!

  10. #35
    Join Date
    Dec 2007
    Posts
    289
    Mentioned
    4 Post(s)
    Quoted
    86 Post(s)

    Default

    Quote Originally Posted by Gucci View Post
    Bugs:
    - Not clicking the make button in the chatbox ( You need do put in your own coords for that at line 95)
    Coordinates are fine.
    Seems like most people have highlighted the issue and addressed it.
    The wait timer for the crafting menu is not long enough. Easily fixed, script runs fine now.

    Also, I'm not sure why it closes the bank after depositing the staves, personally I just commented that part out. :/

    Simba Code:
    WriteLn('Bank is Open');
            DepositAll;
            Wait(300);
            //CloseBank;
            //WriteLn('Deposited Staffs');

    Crude script but get's the job done - thanks.
    Last edited by honeyhoney; 06-15-2012 at 09:31 PM.

  11. #36
    Join Date
    Jan 2012
    Location
    Calgary, AB, Canada
    Posts
    1,819
    Mentioned
    5 Post(s)
    Quoted
    120 Post(s)

    Default

    Quote Originally Posted by honeyhoney View Post
    Coordinates are fine.
    Seems like most people have highlighted the issue and addressed it.
    The wait timer for the crafting menu is not long enough. Easily fixed, script runs fine now.

    Also, I'm not sure why it closes the bank after depositing the staves, personally I just commented that part out. :/

    Simba Code:
    WriteLn('Bank is Open');
            DepositAll;
            Wait(300);
            //CloseBank;
            //WriteLn('Deposited Staffs');

    Crude script but get's the job done - thanks.
    Haha yeah I never need to use it so that affects how much I update it, but tonight I'll update
    Current Project: Retired

  12. #37
    Join Date
    May 2011
    Location
    FL
    Posts
    30
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    I take it that this doesn't work anymore?
    Soup

  13. #38
    Join Date
    Jan 2012
    Location
    Calgary, AB, Canada
    Posts
    1,819
    Mentioned
    5 Post(s)
    Quoted
    120 Post(s)

    Default

    Quote Originally Posted by Uzu View Post
    I take it that this doesn't work anymore?
    You are correct didn't think anybody would use this anymore
    Current Project: Retired

  14. #39
    Join Date
    May 2011
    Location
    FL
    Posts
    30
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    I wanted to use it yesterday since staves are still a viable training method :P
    Soup

  15. #40
    Join Date
    Jan 2012
    Location
    Calgary, AB, Canada
    Posts
    1,819
    Mentioned
    5 Post(s)
    Quoted
    120 Post(s)

    Default

    Quote Originally Posted by Uzu View Post
    I wanted to use it yesterday since staves are still a viable training method :P
    Alright I'll take a look at fixing this tomm
    Current Project: Retired

  16. #41
    Join Date
    Jan 2013
    Posts
    294
    Mentioned
    1 Post(s)
    Quoted
    121 Post(s)

    Default

    im still learning how to script. im trying to fix your script since rs does not use the MAKE X option anymore.

  17. #42
    Join Date
    Nov 2011
    Location
    United States
    Posts
    815
    Mentioned
    6 Post(s)
    Quoted
    284 Post(s)

    Default

    Quote Originally Posted by dzpliu View Post
    im still learning how to script. im trying to fix your script since rs does not use the MAKE X option anymore.
    Make sure you get his permission if you intend of releasing it to the public to use his code.

  18. #43
    Join Date
    Jan 2013
    Posts
    294
    Mentioned
    1 Post(s)
    Quoted
    121 Post(s)

    Default

    and so i fixed the script by adding things from SIN's and Ashman88's scripts but im not sure if im allowed to post or not. will ask owner for permission first.
    Last edited by dzpliu; 03-04-2013 at 03:09 PM.

  19. #44
    Join Date
    Aug 2012
    Posts
    13
    Mentioned
    0 Post(s)
    Quoted
    4 Post(s)

    Default

    Thank you, I just started fiddling with this and loving it already. Appreciate it :-)

  20. #45
    Join Date
    Jan 2012
    Location
    Calgary, AB, Canada
    Posts
    1,819
    Mentioned
    5 Post(s)
    Quoted
    120 Post(s)

    Default

    Quote Originally Posted by googlebear View Post
    Thank you, I just started fiddling with this and loving it already. Appreciate it :-)
    Nice you see, lol I forgot this existed
    Current Project: Retired

  21. #46
    Join Date
    Jan 2013
    Posts
    294
    Mentioned
    1 Post(s)
    Quoted
    121 Post(s)

    Default

    ############ Guccis Staff Maker ##########
    |= Time Running : 1 Hours, 4 Minutes and 56 Seconds
    */////////We have gained: 227452 xp / Thats 210171 xp per hour
    */////////We have crafted 2274 Staff / Thats 2101 Staff Per Hour
    ##########################################
    thanks for script.

Page 2 of 2 FirstFirst 12

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •