Results 1 to 9 of 9

Thread: Dirty Kebab Buyer

  1. #1
    Join Date
    Jan 2012
    Posts
    27
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Smile Dirty Kebab Buyer

    Hi.
    I started this script a while back. Myself & a guy named Sirenia have been working on it, he has helped me quite a bit (Thanks man).

    To test the script you will need 28+Gp on you and have your PIN already activated.

    What does it do?
    It buys Kebabs from Karim in Al-Kharid and then banks them!



    Attachment 14876
    Noob here.

  2. #2
    Join Date
    Dec 2011
    Location
    New York, USA
    Posts
    1,242
    Mentioned
    12 Post(s)
    Quoted
    193 Post(s)

    Default

    Looks nice for a first script

    Your standards are pretty good too.

  3. #3
    Join Date
    Dec 2011
    Location
    The Netherlands
    Posts
    1,631
    Mentioned
    47 Post(s)
    Quoted
    254 Post(s)

    Default

    Looks good, but you might want to add some regularity to your scripts. Some times you have things like
    Simba Code:
    if FindNPCChatText('kebab', nothing)then
    And some times you have it like this;
    Simba Code:
    if FindNPCChatText('please', nothing) then
    So you might want to add a space to the first example.

    Also for this part
    Simba Code:
    if FindColorTolerance(X, Y,14340569,MSX1, MSY1, MSX2, MSY2, 2)then
    -->
    Simba Code:
    if FindColorTolerance(X, Y, 14340569, MSX1, MSY1, MSX2, MSY2, 2) then

    It's always good to start off with getting all the standards 100% right Atleast, that's what I did and it's easy to find specific parts in my scripts now :P

    Overall it looks pretty good!
    Oh yeah, you might want to look into using Cases. It's something that I enjoy doing to add randomness.

    An example from one of my scripts. This withdraw the required items on a couple different ways to add extra randomness and to look more like a human that switches things up sometimes!

    Simba Code:
    case random(36) of
            0..9: begin;
                Withdraw(2, 0, 5);
                Withdraw(2, 0, 9);
              Withdraw(3, 0, 5);
                Withdraw(3, 0, 9);
               end;

            10..19: begin;
                Withdraw(2, 0, 9);
                Withdraw(2, 0, 5);
              Withdraw(3, 0, 9);
                Withdraw(3, 0, 5);
               end;

          20..23: begin;
                Withdraw(3, 0, 5);
                Withdraw(3, 0, 9);
              Withdraw(2, 0, 5);
                Withdraw(2, 0, 9);
               end;

          24..27: begin;
                Withdraw(3, 0, 9);
                Withdraw(3, 0, 5);
              Withdraw(2, 0, 9);
                Withdraw(2, 0, 5);
               end;

          28..29: begin;
                Withdraw(2, 0, 9);
                Withdraw(2, 0, 5);
              Withdraw(3, 0, 5);
                Withdraw(3, 0, 9);
               end;

          30..31: begin;
                Withdraw(3, 0, 9);
                Withdraw(3, 0, 5);
              Withdraw(2, 0, 5);
                Withdraw(2, 0, 9);
               end;

          32: begin;
                Withdraw(3, 0, 9);
                Withdraw(2, 0, 5);
              Withdraw(3, 0, 5);
                Withdraw(2, 0, 9);
               end;

          33: begin;
                Withdraw(3, 0, 5);
                Withdraw(2, 0, 9);
              Withdraw(3, 0, 9);
                Withdraw(2, 0, 5);
               end;

          34: begin;
                Withdraw(3, 0, 5);
                Withdraw(2, 0, 9);
              Withdraw(3, 0, 5);
                Withdraw(2, 0, 5);
               end;

          35: begin;
                Withdraw(3, 0, 9);
                Withdraw(2, 0, 9);
              Withdraw(3, 0, 5);
                Withdraw(2, 0, 5);
               end;

          36: begin;
                Withdraw(3, 0, 5);
                Withdraw(2, 0, 5);
              Withdraw(3, 0, 9);
                Withdraw(2, 0, 9);
               end;
        end;
    I'm currently trying to figure out how to shorten this code and how to let Simba calculate all the possibilities. I can probably achieve that by using multiple arrays or something, but that's another story.

    Good luck!

    Script source code available here: Github

  4. #4
    Join Date
    Jan 2012
    Posts
    27
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by RuneScapeJJ View Post
    I'm currently trying to figure out how to shorten this code and how to let Simba calculate all the possibilities. I can probably achieve that by using multiple arrays or something, but that's another story.

    Good luck!
    Thanks for your feedback.
    Noob here.

  5. #5
    Join Date
    Dec 2011
    Posts
    36
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    I shall give this a test =] thankyou very much for making this script !! =]

  6. #6
    Join Date
    Jan 2012
    Posts
    117
    Mentioned
    0 Post(s)
    Quoted
    12 Post(s)

    Default

    giving it a shot now

  7. #7
    Join Date
    Dec 2011
    Posts
    36
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    seems to work fine , ran for 2 hours flawlessly... forgot i was doing it on a new account that has the trade limit fml lol ! =]

  8. #8
    Join Date
    Nov 2011
    Posts
    28
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Always stops at the bank for me... HMm

  9. #9
    Join Date
    Jan 2012
    Posts
    27
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by krushsawa View Post
    seems to work fine , ran for 2 hours flawlessly... forgot i was doing it on a new account that has the trade limit fml lol ! =]
    Wow, that's GREAT! 2hours is awesome. ^-^
    Noob here.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •