Results 1 to 12 of 12

Thread: PieSheller

  1. #1
    Join Date
    Sep 2010
    Posts
    305
    Mentioned
    0 Post(s)
    Quoted
    3 Post(s)

    Default PieSheller

    My first real attempt at a script and it works well enough for me to post it and get some feed back. There may be some issues with it, so please don't be upset

    Some things i would like help with and/or advice:

    -NPC banking (for GE)
    -Making the code look neat
    -Better failsafes
    -Different ways to code it, so i can learn new methods
    -Anything that doesn't work
    -Proggy
    -Any general advice

    If you are giving any advice i would appreciate if you would not tell me exactly how to write it because i would like to give it a try first.

    Setup:

    -Be in varrock west bank, or change the the location
    -Have pie dish in first slot and pastry dough in second slot, or visible on bank screen
    -Make Withdraw X 14 if using DTM(would like to find a way to do this in script)

    Change log:

    -v1.1: Added logout failsafes through the script. Added withdraw function with DTM failsafe. Added multiple bank support (no GE or SW). Added attachment.
    Last edited by blother; 04-10-2012 at 05:30 PM.

  2. #2
    Join Date
    Jan 2012
    Posts
    522
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Pretty good. Even though I hate DTM it's still good

  3. #3
    Join Date
    Mar 2012
    Posts
    9
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Doesnt click pastry dough or pie dish

  4. #4
    Join Date
    Dec 2011
    Location
    The Netherlands
    Posts
    1,631
    Mentioned
    47 Post(s)
    Quoted
    254 Post(s)

    Default

    Quote Originally Posted by blother View Post
    CURRENTLY WILL NOT STOP BY ITSELF. I WILL BE TRYING TO FIGURE HOW TO DO IT, BUT IF YOU KNOW PLEASE TELL ME :P
    This is probably the easiest way:
    Simba Code:
    repeat {procedure}
    until not(FindDTM(.......));
    or
    Simba Code:
    if not(FindDTM(......)) then
      begin
        Logout;
        TerminateScript;
      end else
      begin
        {procedure}
      end;

    Put the second one somewhere in your banking procedure, if it doesn't find the DTM for the ingredients it will log out and end the script.

    Script source code available here: Github

  5. #5
    Join Date
    Sep 2010
    Posts
    305
    Mentioned
    0 Post(s)
    Quoted
    3 Post(s)

    Default

    Quote Originally Posted by J J View Post
    This is probably the easiest way:
    Simba Code:
    repeat {procedure}
    until not(FindDTM(.......));
    or
    Simba Code:
    if not(FindDTM(......)) then
      begin
        Logout;
        TerminateScript;
      end else
      begin
        {procedure}
      end;

    Put the second one somewhere in your banking procedure, if it doesn't find the DTM for the ingredients it will log out and end the script.
    Oh i like that using the DTM. Makes sense because my script is DTM based Also, can you add multiple FindDTM... to the until() so i can account for both pastry dough and pie dishes?

    Any time i want to end any script should i use TerminateScript, or are there any other ways to do it?

    Doesnt click pastry dough or pie dish
    I am sorry, but i can't stand this. This comment does not help me at all in making a change to the scipt. I added Writeln to help in finding where a particular part of the script might have messed up, so if you are not just trolling me then please tell me what message was written when it did not work.

    Pretty good. Even though I hate DTM it's still good
    Thanks i appreciate that If you know any other way to do it i would love to hear them. The main of this script for me is to learn different methods of scripting. If you different ways to go about the process i do want to try them so i can get more familiar with simba and writing.
    Last edited by blother; 04-07-2012 at 02:47 PM.

  6. #6
    Join Date
    Jan 2012
    Posts
    522
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    For withdrawing you can use this function

    "Withdraw(0,0,AMOUNT)"

    The first 0 is the Row, and the second 0 is the Column. 0,0 is the very first slot. You should know what "AMOUNT" is

  7. #7
    Join Date
    Sep 2010
    Posts
    305
    Mentioned
    0 Post(s)
    Quoted
    3 Post(s)

    Default

    Quote Originally Posted by Phyaskou View Post
    For withdrawing you can use this function

    "Withdraw(0,0,AMOUNT)"

    The first 0 is the Row, and the second 0 is the Column. 0,0 is the very first slot. You should know what "AMOUNT" is
    Hmmm i think i might use that with an uptext check in case it cannot find the DTM. Although, then it should be able to make the shells unless as use inventory clicks there as well.

    The reason i didn't use that at first was because i didn't want to force one slot to be used. When it is two items that are specific i don't see why a DTM would be a bad choice to a straight up withdraw.

  8. #8
    Join Date
    Jan 2012
    Posts
    522
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    You may do the same for doing inventory slot.

  9. #9
    Join Date
    Sep 2010
    Posts
    305
    Mentioned
    0 Post(s)
    Quoted
    3 Post(s)

    Default

    Quote Originally Posted by Phyaskou View Post
    You may do the same for doing inventory slot.
    The one thing i don't like about inventory slot is that it will not correctly if it doesn't withdraw 14 of each. This should only happen on the last load, but still would fudge it up a bit. I could use it with uptext check then DTM use like i did for banking, but the only purpose that would serve would be practice. Of course, i do need the practice

  10. #10
    Join Date
    Jan 2012
    Posts
    522
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    You do need practice for inventory slots though. However the script should be babysat when it comes to something like this.

  11. #11
    Join Date
    Sep 2010
    Posts
    305
    Mentioned
    0 Post(s)
    Quoted
    3 Post(s)

    Default

    Quote Originally Posted by Phyaskou View Post
    You do need practice for inventory slots though. However the script should be babysat when it comes to something like this.
    Probably true on the babysitting part, but i plan for it to not have to be. I think i'll go and add the inventory part and possibly a progress report. Might have a few other ideas to add as well.

  12. #12
    Join Date
    Jan 2012
    Posts
    522
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    That's good. Learning is very good as it will come in handy some day.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •