Page 1 of 2 12 LastLast
Results 1 to 25 of 36

Thread: JJ's Varrock West Bank Cooker

  1. #1
    Join Date
    Dec 2011
    Location
    The Netherlands
    Posts
    1,631
    Mentioned
    47 Post(s)
    Quoted
    254 Post(s)

    Default JJ's Varrock West Bank Cooker

    Hey!

    I proudly present to you: JJ's Varrock West Bank Cooker! This script will cook multiple items on your own made fire just outside the varrock west bank. This script has antiban and it can solve randoms. All the stuff that the script does is randomized to avoid bans

    Video example:
    http://www.youtube.com/watch?v=CXlegMTjco0

    Before you start the script:
    • Your graphic settings must be set on the lowest possible
    • You must have a tinderbox on your toolbelt
    • Your bank has to be set up like this:
    • Your character has to be in this area:
    • Fill in the correct values at line 45 and 46
    • Leave feedback/rep or anything that can help me!


    Scripting notes:
    • SMART
    • Anti-ban
    • Solves random events
    • On screen progress report [NOTE: Will be inaccurate if you burn fish!]
    • Failsafes
    • TPA usage
    • DTM usage
    • Object DTM
    • Animation/PBox
    • Loads of mousebox used
    • Close to everythingis randomized


    Be sure to leave some feedback!

    Greetz,

    JJ.
    Last edited by J J; 04-07-2012 at 04:00 PM.

    Script source code available here: Github

  2. #2
    Join Date
    Feb 2012
    Posts
    89
    Mentioned
    2 Post(s)
    Quoted
    13 Post(s)

    Default

    Exception in Script: Unable to find file 'ObjectDTM/ObjDTMInclude.simba'
    Uhh?

    I never deleted a file so how can it not be able to find it?

  3. #3
    Join Date
    Dec 2011
    Location
    The Netherlands
    Posts
    1,631
    Mentioned
    47 Post(s)
    Quoted
    254 Post(s)

    Default

    Quote Originally Posted by Majnoon View Post
    Uhh?

    I never deleted a file so how can it not be able to find it?
    http://villavu.com/forum/showthread....ight=ObjectDTM
    Read & Install that. It's in the scripting notes that it used ObjectDTM and once you get an error like that you can just google it for a quick answer.

    Script source code available here: Github

  4. #4
    Join Date
    Feb 2012
    Location
    Somewhere, over the rainbow...
    Posts
    2,272
    Mentioned
    3 Post(s)
    Quoted
    45 Post(s)

    Default

    Its funny, I've literally almost completed a Varrock Cooker myself (hope you don't mind a bit of competition)....

    Anyway - your Proggy is inaccurate. It increases CookedFish by 27 every time it cooks - which means it doesn't take into account burnt food or the fact that the fire has run out before it finished cooking.

  5. #5
    Join Date
    Dec 2011
    Location
    The Netherlands
    Posts
    1,631
    Mentioned
    47 Post(s)
    Quoted
    254 Post(s)

    Default

    Quote Originally Posted by abu_jwka View Post
    Its funny, I've literally almost completed a Varrock Cooker myself (hope you don't mind a bit of competition)....

    Anyway - your Proggy is inaccurate. It increases CookedFish by 27 every time it cooks - which means it doesn't take into account burnt food or the fact that the fire has run out before it finished cooking.
    Yeah it assumes that your character doesn't burn anything. Oak logs last for around 30 fish it seems and most of the people that use this probably have 30+ firemaking and are probably using willow logs. However, if it would get in a random event or if something else happens the proggy will be inaccurate, indeed.

    I might add some things in the future such as even more randomized things, custom antiban, responding to common questions such as cooking level possibly. For now it works though :P I'm not sure how you can identify burned and cooked fish - especially because this script is mainly based on using mouseboxes and some failsafes for when something unexpected happens.. I would have to add bitmaps for loads of cooked / burned fish. The best way would probably be to get the total xp and the xp gained from RuneScape self and divide that by the cooking xp that a fish gives. That way you can have some simple maths such as

    Total trips = 10
    Total fish = (Total trips)*27 = 270
    Total xp = 2000
    Fish xp = 10
    Max cook xp gained = (fish xp)*(total fish) = 2700
    Burned fish = ((Max cook xp gained)-(total xp)/(Fish xp))

    I might look at other cooking script to see if they added a feature like this and see if I can learn from that & implement it :P Forgot to add to the main post that the proggy will be inaccurate when you burn fish. I would also like to let it update every second instead of once every trip, but this might take too much RAM, I'll see if it's possible.

    --

    For the other part, I don't mind "competition" We might be able to learn some stuff from eachothers scripts At first I was planning to make an Edgeville Bank Cooker, but there are some annoying lamps just outside the bank where you can't lit a fire. So I switched to Varrock West Bank as the walking distance isn't that big

    Script source code available here: Github

  6. #6
    Join Date
    Jan 2012
    Posts
    15
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Bot started good, but then became unresponsive. It did the first load just fine, but then it couldn't bank. Any thoughts? I am going to shut it down and try again.

    After the bot does the first load, it can't find the bank to deposit the cook fish.
    Last edited by Anubis89; 04-07-2012 at 10:33 PM.

  7. #7
    Join Date
    Mar 2007
    Location
    Brisbane, AUS
    Posts
    305
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    hey JJ, ill try this bit later today and post you if any bugs, thanks for the script tho

  8. #8
    Join Date
    Dec 2011
    Location
    The Netherlands
    Posts
    1,631
    Mentioned
    47 Post(s)
    Quoted
    254 Post(s)

    Default

    Quote Originally Posted by Anubis89 View Post
    Bot started good, but then became unresponsive. It did the first load just fine, but then it couldn't bank. Any thoughts? I am going to shut it down and try again.

    After the bot does the first load, it can't find the bank to deposit the cook fish.
    Might be a problem with your graphic settings or the colors have changed slightly. I will try it out myself tomorrow and see if it sell works correctly. You can try to add some more tolerance to the banker/bankbooth procedures or make the size where it searches for the colors larger. I'll see tomorrow.

    Quote Originally Posted by kunzy View Post
    hey JJ, ill try this bit later today and post you if any bugs, thanks for the script tho
    No problem, let me know

    Script source code available here: Github

  9. #9
    Join Date
    Jul 2010
    Posts
    1,115
    Mentioned
    1 Post(s)
    Quoted
    10 Post(s)

    Default

    jj if you look at my script, you can see my xp procedure that i use to find what im at exactly. You could use that and have "while cooking do proggy"
    then in your proggy have it call xp and youd have realtime info. If you do use it please give me credit.

    I have an ak cooker i released that you can see how i did the counting. Not sure if my released version has the proper counter. Im going to send out an update soon to it that i know has the proper counting

  10. #10
    Join Date
    Nov 2011
    Posts
    261
    Mentioned
    0 Post(s)
    Quoted
    14 Post(s)

    Default

    Ill try to test this out here later today.....

  11. #11
    Join Date
    Jan 2012
    Posts
    111
    Mentioned
    0 Post(s)
    Quoted
    3 Post(s)

    Default

    ill test it out, and post a proggy
    check out my falador tablet making script http://http://villavu.com/forum/show...177#post968177

  12. #12
    Join Date
    Feb 2012
    Location
    Canada
    Posts
    1,164
    Mentioned
    26 Post(s)
    Quoted
    433 Post(s)

  13. #13
    Join Date
    Mar 2007
    Location
    Brisbane, AUS
    Posts
    305
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    ran pretty well very impressed JJ

  14. #14
    Join Date
    Feb 2012
    Posts
    44
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    ran pretty well indeed almost 2 hours straight but sometimes need babysitting because sometimes it walks back and fourth between the spot where the fire is made and the bank without cooking the fish or closes out the bank too quickly with cooked fish still in inventory

  15. #15
    Join Date
    Mar 2007
    Location
    Brisbane, AUS
    Posts
    305
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    it must be your computer due to lag etc, fix the setting yourself (the waiting times, are in mini seconds remember)
    Quote Originally Posted by raiderbwoi View Post
    ran pretty well indeed almost 2 hours straight but sometimes need babysitting because sometimes it walks back and fourth between the spot where the fire is made and the bank without cooking the fish or closes out the bank too quickly with cooked fish still in inventory

  16. #16
    Join Date
    Dec 2011
    Location
    The Netherlands
    Posts
    1,631
    Mentioned
    47 Post(s)
    Quoted
    254 Post(s)

    Default

    Hmm sorry for the late responses, been busy with other stuff haha.

    Quote Originally Posted by bolshak25 View Post
    jj if you look at my script, you can see my xp procedure that i use to find what im at exactly. You could use that and have "while cooking do proggy"
    then in your proggy have it call xp and youd have realtime info. If you do use it please give me credit.

    I have an ak cooker i released that you can see how i did the counting. Not sure if my released version has the proper counter. Im going to send out an update soon to it that i know has the proper counting
    I will look into it next weekend I will probably add a realtime progress report and add detection of burned fish aswell. Will be a good "training" for another script I'm working on Thanks for the tips :P

    Quote Originally Posted by krasniy View Post
    Ill try to test this out here later today.....
    Okay.

    Quote Originally Posted by pigggy View Post
    ill test it out, and post a proggy
    Ok, thanks

    Quote Originally Posted by StickToTheScript View Post
    this script, in my case, ran perfectly!

    i enjoyed the work it did! Good jog J J.

    StickToTheScript
    Thanks, appreciate comments like this

    Quote Originally Posted by raiderbwoi View Post
    ran pretty well indeed almost 2 hours straight but sometimes need babysitting because sometimes it walks back and fourth between the spot where the fire is made and the bank without cooking the fish or closes out the bank too quickly with cooked fish still in inventory
    As said in a quote below here.. probably based on your computer. You can change the waiting times yourself to make it work better for you. It could be something with my script though, but it seems to be something with your script that it tries to withdraw some items before they are loaded on your RuneScape. I try to make my scripts work for every computer, but my own one is pretty fast so yeah.. Let me know if changing the waiting times helps you.

    Quote Originally Posted by kunzy View Post
    it must be your computer due to lag etc, fix the setting yourself (the waiting times, are in mini seconds remember)
    Responded in the post before this :P It's actually mi[b]lli[/b seconds haha 1000 milli seconds (ms) = 1 second (s)

    Script source code available here: Github

  17. #17
    Join Date
    Mar 2007
    Location
    Brisbane, AUS
    Posts
    305
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    hahaha "mini" seconds my bad, got 70 cooking on my pure from this JJ well done

  18. #18
    Join Date
    Feb 2012
    Location
    The Netherlands
    Posts
    35
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Its ok. But it doesn't work without supervision.

  19. #19
    Join Date
    Mar 2007
    Location
    Brisbane, AUS
    Posts
    305
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Ruben, you must be lagging.. change a few settings.. i ran it flawlessly for 22-70 cooking
    Doing SRL members script 80 % done

  20. #20
    Join Date
    Feb 2012
    Posts
    44
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by kunzy View Post
    Ruben, you must be lagging.. change a few settings.. i ran it flawlessly for 22-70 cooking
    what settings did you change?

  21. #21
    Join Date
    Dec 2011
    Location
    The Netherlands
    Posts
    1,631
    Mentioned
    47 Post(s)
    Quoted
    254 Post(s)

    Default

    Quote Originally Posted by kunzy View Post
    hahaha "mini" seconds my bad, got 70 cooking on my pure from this JJ well done
    Good to know

    Quote Originally Posted by RubenPriest View Post
    Its ok. But it doesn't work without supervision.
    Hm as Ruben said in a quote below, I think it's a problem with your own settings :P Who knows though I will be adding some new features this weekend I think.

    Quote Originally Posted by kunzy View Post
    Ruben, you must be lagging.. change a few settings.. i ran it flawlessly for 22-70 cooking
    Answered above

    Script source code available here: Github

  22. #22
    Join Date
    Dec 2011
    Posts
    18
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Thumbs up

    Great script, but found some issues.
    Firstly sometimes it wount click on bank and run back outside from bank.
    Secondly banking issue - Clicks on bank booth but runs imidatly when bank opens. (happens like once in 5 times,but comes back soon)
    Thirdly I'm not able to find, where to change time between lighting fire and start cooking. Fixed for myself bank timing but it takes like 5-6 seconds after a light has fired to start cooking and this always happens. I wouldnt mind it, but my campfire will sometimes extinguish before cooking ends and in those 5-6 seconds it can do some fishes instead staring around. (I'm not of a much scripter, but i'm learning something already just from checking issues and timing)

  23. #23
    Join Date
    Nov 2011
    Posts
    1,589
    Mentioned
    9 Post(s)
    Quoted
    17 Post(s)

    Default

    Time to rake in the XP.

  24. #24
    Join Date
    Dec 2011
    Location
    The Netherlands
    Posts
    1,631
    Mentioned
    47 Post(s)
    Quoted
    254 Post(s)

    Default

    Quote Originally Posted by hents1230 View Post
    Great script, but found some issues.
    Firstly sometimes it wount click on bank and run back outside from bank.
    Secondly banking issue - Clicks on bank booth but runs imidatly when bank opens. (happens like once in 5 times,but comes back soon)
    Thirdly I'm not able to find, where to change time between lighting fire and start cooking. Fixed for myself bank timing but it takes like 5-6 seconds after a light has fired to start cooking and this always happens. I wouldnt mind it, but my campfire will sometimes extinguish before cooking ends and in those 5-6 seconds it can do some fishes instead staring around. (I'm not of a much scripter, but i'm learning something already just from checking issues and timing)
    Thanks for pointing out the issues
    Point 1) I think the problem is mainly based on the waiting times, increasing them will probably fix it
    Point 2) Probably another waiting time problem
    Point 3) This is the script part
    Simba Code:
    { Light a log }
      Logs := DTMFromString('mAAEAAHiclcvBCkBAFIXhY9aewjNIyUISK5Pm8SeUhbJB3oC/WFiaW9+pU+fGkmojVciRIX2V6OBg0aLBws+AEbOevuPEhhUTPA70RUJGv11Ba8kE7r93A1hgD7U=');
      if FindDTM(Logs, X, Y, MIX1, MIY1, MIX2, MIY2) then
        begin
          MMouse(X, Y, 2, 2);
          Mouse(X, Y, 0, 0, 0);
          WaitOptionMulti(['ight', 'Light'], 150);
          Wait(600 + Random(300));
          if not(FindDTM(Logs, X, Y, MIX1, MIY1, MIX2, MIY2)) then
            begin
              Inc(BurnedLogs);
            end else
            begin
              FindDTM(Logs, X, Y, MIX1, MIY1, MIX2, MIY2)
              MMouse(X, Y, 2, 2);
              Mouse(X, Y, 0, 0, 0);
              WaitOptionMulti(['ight', 'Light'], 150);
            end;
        end;
      FreeDTM(Logs);
      { Check for fire animation }
      PBox := IntToBox(282, 145, 320, 195);
      FindNormalRandoms;
      Marktime(q);
      repeat
        Wait(100 + Random(100));
        Antiban;
        Wait(100 + Random(100));
      until (Animating(PBox, 100, 200)) or (TimeFromMark(q)>10000);
      WriteLn('We have ignited a log')

    This line will count the pixelshift in a box.
    Simba Code:
    until (Animating(PBox, 100, 200))
    The box is east of the character just about where the fire will be lit. It will currently check for 100, 200 which means it will count the pixelshift for 100 ms and it waits until the pixelshift has been more than 200 pixels. You can change those values. Either change it into a higher amount of ms waiting, or lower the pixelshift to detect the fire easier. If you have low FPS the pixelshift won't give correct results I believe.

    You can also change the waiting time. It waits a maximum of 10 seconds to find the desired animating fire in the box. If more than 10 seconds has passed since attempting to light it, it assumes that is has been lit. You can change this to a lower time if you have a high firemaking level, because you will always lit a log within 1-2 seconds.
    Simba Code:
    (TimeFromMark(q)>10000);
    That is the line you can change.

    You can also delete the animating part and just let the script wait a random 1-2 seconds
    Simba Code:
    Wait(1000 + Random(1000));
    Will wait 1-2 seconds


    Quote Originally Posted by Mat View Post
    Time to rake in the XP.
    Good luck

    Script source code available here: Github

  25. #25
    Join Date
    May 2012
    Posts
    8
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Add support for tuna please.

    EDIT: Does not work, I've tried other fish and it wont cook it.
    Last edited by Wescs; 05-12-2012 at 07:42 AM.

Page 1 of 2 12 LastLast

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •