Page 1 of 18 12311 ... LastLast
Results 1 to 25 of 438

Thread: Punkd's YouJustGotCrafted AIO Crafter

  1. #1
    Join Date
    Apr 2007
    Location
    Los Angeles
    Posts
    622
    Mentioned
    0 Post(s)
    Quoted
    6 Post(s)

    Default Punkd's YouJustGotCrafted AIO Crafter

    Alright, I just finished up my Script. Tested for over 150 hours (supervised) Much More overnight testing, FLAWLESS in my experience. You tell me

    So far I didn't see any bugs but please Post here if you have a problem. I will look into it, I want this script to be perfect. Will soon add spinning wool (Lumbridge or Seers) and Smithing/Smelting all items. Obviously its not a days worth of work but I want a Hybrid AIO for Smith/Craft.

    ---------------------------------------------------------------

    Current Status

    Leather works and gem crafting working

    Gold Bar Crafting NOT working, will update with v 2.0


    ---------------------------------------------------------------

    What it does:
    Crafts all Jewelery (Gold - Diamond)
    Crafts Leather items (Green Dhide - Black Dhide)
    Cuts Gems (Sapphire - Diamond)
    And a surprise, Cannonball maker. (Gift for getting 99 craft today(4-10-12)

    All Instructions are in the script. Read the NFO before you change anything. ITS THERE FOR A REASON!!


    ---------------------------------------------------------------

    Supported Locations:
    Edgeville(all tasks)
    Al-kharid will be members(for jewelery crafting)
    Soul wars will be added due to so many requests (for gem cutting and leatherworks)
    Will add more in future updates


    ---------------------------------------------------------------

    Suggestions: Post Here

    ---------------------------------------------------------------

    Known Bugs:
    May experience a bit buggy proggy but will soon fix with onscreen proggy

    ---------------------------------------------------------------

    To Do List:
    Add Crafting Leathers DONE
    Add Cutting Gems DONE
    Add Smelting All Bars (w/coal bag support)
    Add Smithing All items
    Add Spinning Wool (currently working on this)
    Add Urn Support
    Add Battlestaff Support
    Add GlassBlowing


    ---------------------------------------------------------------

    Credits:
    Flights Humanmmouse Fasinates me. I had to have it in my script!
    Dusk412 TPA's For Dummies Tutorial =P
    I'm sorry if I left out any credits. Please notify me and I will be sure to add them. Also some credits were given in the script itself
    Bolshak25 for Giving me the idea of Cases and writing 2 of the paths.


    ---------------------------------------------------------------



    Longest proggie yet (by chrisman):


    Making gold bracelets:
    ========YouJustGotCrafted==========
    Time: 8 Hours, 43 Seconds
    Items Total: 7112
    XP: 177800
    Items/h: 887
    XP/h: 22191
    Loads: 254
    Loads/h: 31

    Making rings of dueling:
    Time: 3 Hours, 59 Minutes and 28 Seconds
    Items Total: 2842
    XP: 161170
    Items/h: 712
    XP/h: 40385

    Making Gold Bracelets: Set to stop at 6000 items
    =====YouJustGotCrafted==========
    Time: 5 Hours, 24 Minutes and 12 Seconds
    Items Total: 6020
    XP: 150500
    Items/h: 1114
    XP/h: 27854
    ===================================

    Cannonball:
    Time: 5 Hours, 34 Minutes and 50 Seconds
    Items Total: 10864
    XP: 69300
    Items/h: 1946
    XP/h: 12418
    ^^6 hours past.

    Golden Jewelery:
    Time: 6 Hours, 2 Minutes and 22 Seconds
    Items Total: 6580
    XP: 164500
    Items/h: 1120
    XP/h: 28000
    Loads: 236
    Loads/h: 40

    Time: 5 Hours, 47 Minutes and 40 Seconds
    Items Total: 6160
    XP: 154000
    Items/h: 1063
    XP/h: 26577
    Loads: 222
    Loads/h: 38


    I have yet to see a problem running less than 6 hours unless stuck in a unsolvable random.

    My 99:
    [IMG]s15.postimage.org/d7aj37tmx/99_crafting.jpg[/IMG]


    ATTN: 1.16 for those experiencing sps walking problems (this does not include errors for SPS.simba), added 2 walking failsafes for your convenience. If experiencing problems, Post on thread or PM me.
    1.15 is unstable 1.16 has furnace failsafe.

    Please post all requested methods in the thread, I look at the thread and answer questions throughout the day.

    Enjoy
    Last edited by punkd; 05-30-2012 at 01:54 AM.

  2. #2
    Join Date
    Jul 2010
    Posts
    1,115
    Mentioned
    1 Post(s)
    Quoted
    10 Post(s)

    Default

    Simba Code:
    Procedure Gempath;
    begin
    if whatarewedoing = 'Cutting' then
      case What of
        'Sapphire':
        begin
          Jewl := uncutsapphire;
          xpi := 50;
        end;
        'Emerald':
        begin
          Jewl := uncutemerald;
          xpi := 68;
        end;
        'Ruby':
        begin
          Jewl := uncutruby;
          xpi := 85;
        end;
        'Diamond':
        begin
          Jewl := uncutdiamond;
          xpi := 108;
        end;
      end;
      items := 28;
    end;


    Procedure Leatherpath;
    begin
    if whatarewedoing = 'Leather' then
      case What of
        'Red':
        begin
          Jewl := Redleather;
          case Item of
            'Chaps':
            begin
              MPoint := Point(353, 422);
              items := 13;
              xpi := 156;
            end;
            'Body':
            begin
              MPoint := Point(163, 427);
              items := 9;
              xpi := 234
            end;
            'Vambs':
            begin
              MPoint := Point(257, 427);
              items := 27;
              xpi := 78;
            end;
          end;
        end;

        'Black':
        begin
          Jewl := Blackleather;
          case Item of
            'Chaps':
            begin
              MPoint := Point(353, 422);
              items := 13;
              xpi := 172;
            end;
            'Body':
            begin
              MPoint := Point(163, 427);
              items := 9;
              xpi := 258;
            end;
            'Vambs':
            begin
              MPoint := Point(257, 427);
              items := 27;
              xpi := 86;
            end;
          end;
        end;

        'Blue':
        begin
          Jewl := BlueLeather;
          case Item of
            'Chaps':
            begin
              MPoint := Point(353, 422);
              items := 13;
              xpi := 140;
            end;
            'Body':
            begin
              MPoint := Point(163, 427);
              items := 9;
              xpi := 210;
            end;
            'Vambs':
            begin
              MPoint := Point(257, 427);
              items := 27;
              xpi := 70;
            end;
          end;
        end;

        'Green':
        begin
          Jewl := GreenLeather;
          case Item of
            'Chaps':
            begin
              MPoint := Point(353, 422);
              items := 13;
              xpi := 124;
            end;
            'Body':
            begin
              MPoint := Point(163, 427);
              items := 9;
              xpi := 186
            end;
            'Vambs':
            begin
              MPoint := Point(257, 427);
              items := 27;
              xpi := 62;
            end;
          end;
        end;
      end;
    end;

    Well i converted two of them to cases. you should follow that example to convert the rest.

    You were missing
    Simba Code:
    Jewl := Blackleather;
    So i out it in as well as
    Simba Code:
    if whatarewedoing = 'Leather' then

    It looks nice, and i may test it to see how it runs, but until the cases are set i dont want to try to track through all of the if then statements

  3. #3
    Join Date
    May 2007
    Location
    knoxville
    Posts
    2,873
    Mentioned
    7 Post(s)
    Quoted
    70 Post(s)

    Default

    Since I know you plan on applying for members, I'll just say my opinions.

    Your standards are way off, it made reading through it a little painful.

    You c(sh)ould use cases instead of a bunch of if-thens of the same thing.

    I would like to see some sort of radial-walk or DDTM walking/positioning, but it's not really needed.

    Also, there a lot of tedious code, learn how to use arrays more effectively, I bet you could reduce your banking to one function.

    Your setup could be made much more organized with the use of Arrays + Records, but not needed. I'll edit if I see anything else
    <TViYH> i had a dream about you again awkwardsaw
    Malachi 2:3

  4. #4
    Join Date
    Apr 2007
    Location
    Los Angeles
    Posts
    622
    Mentioned
    0 Post(s)
    Quoted
    6 Post(s)

    Default

    Well i converted two of them to cases. you should follow that example to convert the rest.
    Hey, thanks for the advice. I just set everything to cases. I will credit you for the advice!

    Quote Originally Posted by Awkwardsaw View Post
    Since I know you plan on applying for members, I'll just say my opinions.

    Your standards are way off, it made reading through it a little painful.

    You c(sh)ould use cases instead of a bunch of if-thens of the same thing.

    I would like to see some sort of radial-walk or DDTM walking/positioning, but it's not really needed.

    Also, there a lot of tedious code, learn how to use arrays more effectively, I bet you could reduce your banking to one function.

    Your setup could be made much more organized with the use of Arrays + Records, but not needed. I'll edit if I see anything else
    Thank you for you advice! Yeah I understand what you mean. I separated bank to not make a single function so long and it helps me stay a bit more organized while changing something in a task. I am going to change Yo cases but don't really plan on making a single banking function but I might if it helps. Alot of the extra code are failsafes. For the walking, it's only a single click sps2 will be my best option. As for my standards =P yeah I know it's a bit messy, I rushed it. I never do this but I wanted opinions before applying. It'll be good when I'm done! The thing is, when I script my main priority is for the script to do the job, do it right, and do it humanlike. Thank you so much for the advice I will use them to improve my script! I hope to see you on the other side =P

    Thanks guys!
    Last edited by punkd; 04-11-2012 at 05:19 AM.

  5. #5
    Join Date
    Dec 2011
    Location
    011011011011
    Posts
    241
    Mentioned
    0 Post(s)
    Quoted
    25 Post(s)

    Default

    i'll try this out, im looking to get 99 smithing on my pure, may make use of the cball smither and keep you posted with bugs and such
    Quote Originally Posted by Markus View Post
    LSD RuneScape will be fun :P We must try some acid to see if it cancels the effects out.
    Back To Play & Bot RS07

  6. #6
    Join Date
    Apr 2007
    Location
    Los Angeles
    Posts
    622
    Mentioned
    0 Post(s)
    Quoted
    6 Post(s)

    Default

    Neros, enjoy the script! Cannonball maker is only 13k xp/h but I guess if you want to make money too its a fairly good option. I hope you enjoy =)

  7. #7
    Join Date
    Dec 2011
    Location
    011011011011
    Posts
    241
    Mentioned
    0 Post(s)
    Quoted
    25 Post(s)

    Default

    yeah, i always choose to do methods that take longer but produce profit, got 99 crafting a while back on sapphire rings then alched them for 99 mage, which produced more profit

    ive noticed one slight problem, sometimes it confused as to whether your at the furnace or not, it stands next to the bank booth (the closed one) clicking the inv then the co-ord where the furnace would be, could just be lag but it's something to look into, other than that, i made 14k cballs overnight, could not get a proggy, but i'll get one today for you :P
    Quote Originally Posted by Markus View Post
    LSD RuneScape will be fun :P We must try some acid to see if it cancels the effects out.
    Back To Play & Bot RS07

  8. #8
    Join Date
    Apr 2007
    Location
    Los Angeles
    Posts
    622
    Mentioned
    0 Post(s)
    Quoted
    6 Post(s)

    Default

    0.0 clicking random coord? 0.o it doesn't click a co-ord until it finds the furnace, checks the text that says Furnace, clicks item, then clicks the furnace so that's not somethings thats even possible 0.0. Would you mind recording it next time?

  9. #9
    Join Date
    Jan 2012
    Posts
    550
    Mentioned
    2 Post(s)
    Quoted
    177 Post(s)

    Default

    Are you planning on applying for membership with this script? I think it really could make you get members status!!!

    BTW your script is what first inspired me to decided to make my own. I'm starting on it tommorrow, hopefully I can make it good enough to get members.

  10. #10
    Join Date
    Apr 2007
    Location
    Los Angeles
    Posts
    622
    Mentioned
    0 Post(s)
    Quoted
    6 Post(s)

    Default

    I just submitted my application not 2 minutes ago before I saw this. ^.^ I hope you make a script 10x better than this! If you ever need help let me know!

  11. #11
    Join Date
    Dec 2011
    Location
    011011011011
    Posts
    241
    Mentioned
    0 Post(s)
    Quoted
    25 Post(s)

    Default

    Quote Originally Posted by punkd View Post
    0.0 clicking random coord? 0.o it doesn't click a co-ord until it finds the furnace, checks the text that says Furnace, clicks item, then clicks the furnace so that's not somethings thats even possible 0.0. Would you mind recording it next time?
    yeah, i'll record if it happens again, ill try to explain more too, it's like sometimes after withdrawing steel bars it might misclick and ends off standing at the bank right clicking the bar then looking for the furnace. seems like it gets confused and thinks it's on the tile next to the furnace, im not sure why tbh. but yea i'll, try and get it on video lol
    Quote Originally Posted by Markus View Post
    LSD RuneScape will be fun :P We must try some acid to see if it cancels the effects out.
    Back To Play & Bot RS07

  12. #12
    Join Date
    Feb 2012
    Posts
    89
    Mentioned
    2 Post(s)
    Quoted
    13 Post(s)

    Default

    It doesn't withdraw the bars from the bank

    Correction, it doesn't withdraw gold bars

    Cannonballs works perfects though.
    Last edited by Majnoon; 04-12-2012 at 07:50 PM.

  13. #13
    Join Date
    Apr 2007
    Location
    Los Angeles
    Posts
    622
    Mentioned
    0 Post(s)
    Quoted
    6 Post(s)

    Default

    Make sure u set whatarewedoing to jewelry

  14. #14
    Join Date
    Apr 2007
    Location
    Los Angeles
    Posts
    622
    Mentioned
    0 Post(s)
    Quoted
    6 Post(s)

    Default

    Whoops thats my error, I'm not home ATM so I can't edit but move to the setdtm procedure and change "Jewelery" to "Jewelry"

  15. #15
    Join Date
    Dec 2011
    Location
    011011011011
    Posts
    241
    Mentioned
    0 Post(s)
    Quoted
    25 Post(s)

    Default

    hmmk, punkd i think i've worked out what was causing that banking problem

    you know the tile closest to the wall in the bank spot where the script banks?
    well i think that if you lag while banking and get moved to that spot then the script thinks the walking procedure has been completed thus making it search for the furnace
    (which is obviously off-screen)

    im basically standing to the left of the banker (near the clan cup plaque on the exterior of bank, but on the interior) clicking the steel bar then searching for the furnace, noticed it hovers on the grey part of the wall next to doors

    im still not 100% sure why/whats causing and forgot to hypercam it again too lol, but once i disabled smart and moved to the furnace it continued working fine, that's why i think it could be the walking procedure, just my thoughts
    Last edited by Neros; 04-13-2012 at 09:26 AM.
    Quote Originally Posted by Markus View Post
    LSD RuneScape will be fun :P We must try some acid to see if it cancels the effects out.
    Back To Play & Bot RS07

  16. #16
    Join Date
    Apr 2007
    Location
    Los Angeles
    Posts
    622
    Mentioned
    0 Post(s)
    Quoted
    6 Post(s)

    Default

    Neros if u have time pm me a screenshot of where you stood.

  17. #17
    Join Date
    Feb 2012
    Posts
    89
    Mentioned
    2 Post(s)
    Quoted
    13 Post(s)

    Default

    Il post a 6hr proggy in 2 hours and 30 minutes!

  18. #18
    Join Date
    Feb 2012
    Posts
    125
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Rather interesting to see more a smithing script then a crafting haha. I'll be testing this out tonight using the cannon balls. Thanks for the post!

  19. #19
    Join Date
    Apr 2007
    Location
    Los Angeles
    Posts
    622
    Mentioned
    0 Post(s)
    Quoted
    6 Post(s)

    Default

    Quote Originally Posted by Majnoon View Post
    Il post a 6hr proggy in 2 hours and 30 minutes!
    I'll add it to the first post =P

    Quote Originally Posted by Here2help View Post
    Rather interesting to see more a smithing script then a crafting haha. I'll be testing this out tonight using the cannon balls. Thanks for the post!
    It's for crafting but cannonballs were a gift because I got 99 crafting using only my script =P. Im adding smithing, fletching in soon too =P. It'll be msi 2.0

  20. #20
    Join Date
    Feb 2012
    Posts
    89
    Mentioned
    2 Post(s)
    Quoted
    13 Post(s)

    Default

    I fell asleep behind my laptop :P sorry for the delay.

    Time: 6 Hours, 2 Minutes and 22 Seconds
    Items Total: 6580
    XP: 164500
    Items/h: 1120
    XP/h: 28000
    Loads: 236
    Loads/h: 40

    Il post some more later since i still have to do 93k gold bars
    Last edited by Majnoon; 04-14-2012 at 09:08 AM.

  21. #21
    Join Date
    Mar 2012
    Posts
    30
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Won't withdraw any gold bars from bank? Am I missing something?

    Tried

    whatarewedoing := 'Jewelery'; //Read NFO above
    What := 'Gold'; //Read NFO above
    Item := 'Amulet'; //Read NFO above
    Make := 25000; // How many items to make before it stops

    And

    whatarewedoing := 'Jewelry'; //Read NFO above
    What := 'Gold'; //Read NFO above
    Item := 'Amulet'; //Read NFO above
    Make := 25000; // How many items to make before it stops

  22. #22
    Join Date
    Feb 2012
    Posts
    89
    Mentioned
    2 Post(s)
    Quoted
    13 Post(s)

    Default

    Quote Originally Posted by Mindset View Post
    Won't withdraw any gold bars from bank? Am I missing something?

    Tried

    whatarewedoing := 'Jewelery'; //Read NFO above
    What := 'Gold'; //Read NFO above
    Item := 'Amulet'; //Read NFO above
    Make := 25000; // How many items to make before it stops

    And

    whatarewedoing := 'Jewelry'; //Read NFO above
    What := 'Gold'; //Read NFO above
    Item := 'Amulet'; //Read NFO above
    Make := 25000; // How many items to make before it stops
    Find the setdm procedure and change jewelery to jewelry

    6 hours proggy.

    Time: 5 Hours, 47 Minutes and 40 Seconds
    Items Total: 6160
    XP: 154000
    Items/h: 1063
    XP/h: 26577
    Loads: 222
    Loads/h: 38
    Last edited by Majnoon; 04-14-2012 at 02:56 PM.

  23. #23
    Join Date
    Apr 2007
    Location
    Los Angeles
    Posts
    622
    Mentioned
    0 Post(s)
    Quoted
    6 Post(s)

    Default

    Majnoon, have you had any problems similar to what neros is having

  24. #24
    Join Date
    Feb 2012
    Posts
    89
    Mentioned
    2 Post(s)
    Quoted
    13 Post(s)

    Default

    Not really

  25. #25
    Join Date
    Apr 2012
    Posts
    1
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    [Hint] C:\Simba\Includes\SRL/SRL/core/mapwalk.simba(1353:3): Variable 'BOX' never used at line 1352
    [Error] C:\Simba\Includes\Sps/sps.simba(300:3): Unknown identifier 'SPS_FilterMinimap' at line 299
    Compiling failed.
    what happened?

Page 1 of 18 12311 ... LastLast

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •