Results 1 to 10 of 10

Thread: Release Includes that Compile

  1. #1
    Join Date
    Oct 2010
    Posts
    1,255
    Mentioned
    0 Post(s)
    Quoted
    15 Post(s)

    Default Release Includes that Compile

    One of the newer SRL updates included certer.simba and it didn't compile.

    Had a few people complain to me about my script not working for them.
    I'm back

  2. #2
    Join Date
    Dec 2011
    Location
    Toronto, Ontario
    Posts
    6,424
    Mentioned
    84 Post(s)
    Quoted
    863 Post(s)

    Default

    Mistakes happen, pardon the devs for overlooking one small detail, because of course, they're getting paid for this and have no life outside of SRL

  3. #3
    Join Date
    Sep 2007
    Location
    Michigan
    Posts
    3,862
    Mentioned
    2 Post(s)
    Quoted
    1 Post(s)

    Default

    Thanks Sin.

    It happens and lesson learned for the Dev that did it .
    (Scripts outdated until I update for new SRL changes)
    AK Smelter & Crafter [SRL-Stats] - Fast Fighter [TUT] [SRL-Stats]
    If you PM me with a stupid question or one listed in FAQ I will NOT respond. -Narcle
    Summer = me busy, won't be around much.

  4. #4
    Join Date
    Oct 2007
    Location
    #srl
    Posts
    6,102
    Mentioned
    39 Post(s)
    Quoted
    62 Post(s)

    Default

    Note to self and everyone else; don't merge pull requests via gitHub.

    Note to smurg; You could have easily 'fixed' it and sent a pull request, rather than complain about it ~10 hours after it was fixed(was an extra semicolon on a request from a member..). That is the point of SRL being hosted on gitHub, after all.

  5. #5
    Join Date
    Oct 2008
    Location
    C:\Simba\Includes\
    Posts
    7,566
    Mentioned
    19 Post(s)
    Quoted
    180 Post(s)

    Default

    I remember when I broke MSI awhile back D:

    It happens, it was fixed, it's all good
    Away for awhile, life is keeping me busy. | Want to get my attention in a thread? @Kyle Undefined; me.
    { MSI Phoenix || SRL Stats Sigs || Paste || Scripts || Quotes || Graphics }

    When posting a bug, please post debug! Help us, help you!

    I would love to change the world, but they won't give me the source code. || To be the best, you've got to beat the rest. || Logic never changes, just the syntax.
    If you PM me with a stupid question or one listed in FAQ, or about a script that is not mine, I will NOT respond.


    SRL is a Library of routines made by the SRL community written for the Program Simba. We produce Scripts for the game Runescape.


  6. #6
    Join Date
    Oct 2010
    Posts
    1,255
    Mentioned
    0 Post(s)
    Quoted
    15 Post(s)

    Default

    I'm not trying to dog on anyone, I just think there should be some procedural steps taken before releases. Testing in some way, compiling the code, etc.

    Going to ignore the obvious flamebait by Sin.
    I'm back

  7. #7
    Join Date
    Mar 2007
    Posts
    5,125
    Mentioned
    275 Post(s)
    Quoted
    901 Post(s)

    Default

    Quote Originally Posted by smurg View Post
    I'm not trying to dog on anyone, I just think there should be some procedural steps taken before releases. Testing in some way, compiling the code, etc.

    Going to ignore the obvious flamebait by Sin.
    Like almost everyone in this thread has said, mistakes happen, some things are overlooked. SRL was down for like what.. 6 hours? and even then it was a simple fix as most people have already pointed out.

    Forum account issues? Please send me a PM

  8. #8
    Join Date
    Feb 2006
    Posts
    3,044
    Mentioned
    4 Post(s)
    Quoted
    21 Post(s)

    Default

    Quote Originally Posted by [J]ustin View Post
    Like almost everyone in this thread has said, mistakes happen, some things are overlooked. SRL was down for like what.. 6 hours? and even then it was a simple fix as most people have already pointed out.
    As for my self. I fixed it in 10 Secs, and pushed updated certer.simba to customers But I can understand Smurg side too. But we are all humans (Or are you Kyle )

    ~Home

  9. #9
    Join Date
    Oct 2007
    Location
    #srl
    Posts
    6,102
    Mentioned
    39 Post(s)
    Quoted
    62 Post(s)

    Default

    Quote Originally Posted by smurg View Post
    I'm not trying to dog on anyone, I just think there should be some procedural steps taken before releases. Testing in some way, compiling the code, etc.

    Going to ignore the obvious flamebait by Sin.
    There are steps taken. I always compile and test my code before committing. I was told the code in question (all 5? lines) had been tested prior to the pull request being sent. However, this was clearly not the case.

  10. #10
    Join Date
    Mar 2007
    Posts
    5,125
    Mentioned
    275 Post(s)
    Quoted
    901 Post(s)

    Default

    Quote Originally Posted by NCDS View Post
    There are steps taken. I always compile and test my code before committing. I was told the code in question (all 5? lines) had been tested prior to the pull request being sent. However, this was clearly not the case.
    I must of hit Ctrl-Z by accident instead of Ctrl-S just as I sent the request in. Not everyone is perfect. After all, we are only human.

    Forum account issues? Please send me a PM

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •