Page 13 of 54 FirstFirst ... 3111213141523 ... LastLast
Results 301 to 325 of 1345

Thread: OFFICIAL Social Slayer/SMART Not Working Thread

  1. #301
    Join Date
    Feb 2011
    Location
    The Future.
    Posts
    5,600
    Mentioned
    396 Post(s)
    Quoted
    1598 Post(s)

    Default

    Ahh well I'm awake now.. The reason I did not offset just the mouse functions which would probably be the one easiest possible fix is because if I did that then I'd have to do:

    Simba Code:
    if (FoundBar) then  //searches for the bitmap of the bar at the top.
    begin
      X := X + Offset;
      Y := Y + Offset;
    end;

    That means every call to the mouse function you'd be searching for the bar and I thought that'd be ridiculous. OR I'd have to do:

    Simba Code:
    //In SetupSRL, call IgnoreBar which will search once and offset the target pointer.
        //Then in the mouse function:

    If (LoggedIn) then
    begin
      X := X + XOffset;
      Y := Y + YOffset;
    end else
      IgnoreBar;    //Resets It To Normal. If Reset, Upon Loggin, Offset again.

    With this, every call to the mouse function will be checking if we're loggedin. If we aren't, reset the pointer to normal.
    I am Ggzz..
    Hackintosher

  2. #302
    Join Date
    Oct 2008
    Location
    C:\Simba\Includes\
    Posts
    7,566
    Mentioned
    19 Post(s)
    Quoted
    180 Post(s)

    Default

    Quote Originally Posted by Foooty View Post
    Im not sure exactly what you mean kyle, but login and gametab dont work.
    All the global constants that control the coordinates were updated to add the 50px bump. If it was such an easy fix, that would of taken care of it.

    EDIT: ggzz, The bar always shows for me when I'm on the login page, is it not showing for people?
    Away for awhile, life is keeping me busy. | Want to get my attention in a thread? @Kyle Undefined; me.
    { MSI Phoenix || SRL Stats Sigs || Paste || Scripts || Quotes || Graphics }

    When posting a bug, please post debug! Help us, help you!

    I would love to change the world, but they won't give me the source code. || To be the best, you've got to beat the rest. || Logic never changes, just the syntax.
    If you PM me with a stupid question or one listed in FAQ, or about a script that is not mine, I will NOT respond.


    SRL is a Library of routines made by the SRL community written for the Program Simba. We produce Scripts for the game Runescape.


  3. #303
    Join Date
    Feb 2011
    Location
    The Future.
    Posts
    5,600
    Mentioned
    396 Post(s)
    Quoted
    1598 Post(s)

    Default

    Quote Originally Posted by Kyle Undefined View Post
    All the global constants that control the coordinates were updated to add the 50px bump. If it was such an easy fix, that would of taken care of it.

    EDIT: ggzz, The bar always shows for me when I'm on the login page, is it not showing for people?
    Nope. The bar only shows for me when I'm logged in. If not then the client gets pushed back up. So..

    Login: Client pushes down the screen by 50.
    Not LoggedIn: Client Pushed down the screen by 22.
    I am Ggzz..
    Hackintosher

  4. #304
    Join Date
    Dec 2011
    Posts
    109
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Love to see all of you coming together and using your minds to help others...If I had the knowledge I would as well.
    Infowars .com Exposing government corruption...Liberty or Death!

  5. #305
    Join Date
    Jun 2012
    Location
    THE Students-City of Holland
    Posts
    332
    Mentioned
    0 Post(s)
    Quoted
    4 Post(s)

    Default

    Quote Originally Posted by Kyle Undefined View Post
    FYI, I pushed an update last night that updated the coords for all the constants (Thanks to Silent Spy), and I haven't heard a thing about it working. There's your answer
    you mean these constants?
    Code:
    { const MMX1, MMY1, MMX2, MMY2;
      Description: MiniMap Edge Points. }
    const
      MMX1 = 550;
      MMY1 = 8;
      MMX2 = 703;
      MMY2 = 161;
    
    { const MMCX, MMCY;
      Description: MiniMap Centre Point. }
    const
      MMCX = 627;
      MMCY = 85;
    
    { const MSX1, MSY1, MSX2, MSY2;
      Description: Main Screen EdgePoints. }
    const
      MSX1 = 4;
      MSY1 = 4;
      MSX2 = 515;
      MSY2 = 337;
    
    { const MSCX, MSCY;
      Description: Main Screen Centre Points. }
    const
      MSCX = 259;
      MSCY = 170;
    
    { const MIX1, MIY1, MIX2, MIY2;
      Description: Inventory EdgePoints. }
    const
      MIX1 = 547;
      MIY1 = 202;
      MIX2 = 737;
      MIY2 = 466;
    
    { const MICX, MICY;
      Description: Inventory Centre Points. }
    const
      MICX = 642;
      MICY = 334;
    
    { const MCX1, MCY1, MCX2, MCY2;
      Description: Chat Screen EdgePoints. }
    const
      MCX1 = 4;
      MCY1 = 342;
      MCX2 = 514;
      MCY2 = 475;
    
    { const MCCX, MCCY;
      Description: Chat Screen Centre Points. }
    const
      MCCX = 250;
      MCCY = 401;
      
    { const MBX1, MBY1, MBX2, MBY2;
      Description: BankScreen EdgePoints (where you click the items, does not include tabs). }
    const
      MBX1 = 26;
      MBY1 = 84;
      MBX2 = 480;
      MBY2 = 292;
    
    { const DBX1, DBY1, DBX2, DBY2;
      Description: Deposit box edgepoints (only where the item appear) }
    const
      DBX1 = 91;
      DBY1 = 57;
      DBX2 = 443;
      DBY2 = 262;

    Well, it's obvious that that won't be enough because we still need two more variables...

    ADD_TOP
    and
    ADD_LEFT

    (Or as I saw here below someone call it: Xoffset and Yoffset...)

    The only problem I have just thought of is, that the add_top and add_left can change. For example the add top is different when we logged in.


    I would do something like this, before the SRL include:

    Simba Code:
    program new;

    var
      ADD_TOP, ADD_LEFT : integer;

    procedure DetermineAdd;
    begin

    //Here it somehow has to determine if we are logged in or not. If we are logged in, the add_top is about 50 or so... so

    if(WeLoggedIn) then
    begin
      ADD_TOP := 50;
      ADD_LEFT := 0;
    end else begin
      ADD_TOP := 20;
      ADD_LEFT := 0;
    end;

    end;

    In every function that has hardcoded coords, we should add something like this:

    I did this for example to the function that determines where to go with the mouse for a skill-mouseover:
    Simba Code:
    function SkillCoords(Row, Column : ShortInt): TPoint;
    begin
      Result := Point(576+ADD_LEFT + (62 * (Column - 1)), 213+ ADD_TOP + (28 * (Row - 1)));
    end;

    We only need to do this to the "CORE" functions because we must not have any overlap... (The ADD_TOP only ahs to be added once...)

    So maybe this above isn't a good example... It should only be added in the search-color functions and the mousemovement function... but I don't exactly know which functions are those.

    In the end we need to determine the add_top and add_left every time we think it might have changed.

    that is... IN the beginning... and after something failed that should not have failed!

    So in the script it should be like this:

    Simba Code:
    begin
    DetermineAdd;

    LoginPlayer;

    DetermineAdd;

    //rest of script;

    end.
    Last edited by Master BAW; 07-12-2012 at 04:54 PM.
    Former Name: MasterCrimeZ.
    ToDo: 1. Finish my private bot 2. Make some cool bots for this community 3. Become a member
    If you have any questions about scripting, feel free to PM me

  6. #306
    Join Date
    Feb 2011
    Location
    The Future.
    Posts
    5,600
    Mentioned
    396 Post(s)
    Quoted
    1598 Post(s)

    Default

    Quote Originally Posted by MasterCrimez View Post
    ....
    That's exactly what I did...

    Guess no one approves of it so I'll try the bitmap hacky crap.
    I am Ggzz..
    Hackintosher

  7. #307
    Join Date
    Jun 2012
    Location
    THE Students-City of Holland
    Posts
    332
    Mentioned
    0 Post(s)
    Quoted
    4 Post(s)

    Default

    Quote Originally Posted by Brandon View Post
    That's exactly what I did...

    Guess no one approves of it so I'll try the bitmap hacky crap.
    Okay , didn't know that. Then I did it for nothing What exactly doesn't the community approve? The part of the DetermineAdd of the part of xOffset and yOffset?


    Another point I want to make:
    We need to be prepared of futher changes runescape makes. For example, maybe runescape will randomly add a different amount of pixels on the top and on the left every time you load RS... (for example 1-20 pixels on the left, and 1-20 pixels on the top) Then it would be different every time. What do we do then?

    I think all we need to do is:
    1. Add the variables xOffset and yOffset to all procedures and functions in SRL that have the hardcoded co-ords.
    2. Make a good procedure that determines the offset.... (procedure DetermineOffset; )

    It's at simple as that I believe
    Former Name: MasterCrimeZ.
    ToDo: 1. Finish my private bot 2. Make some cool bots for this community 3. Become a member
    If you have any questions about scripting, feel free to PM me

  8. #308
    Join Date
    Oct 2011
    Location
    Chicago
    Posts
    3,352
    Mentioned
    21 Post(s)
    Quoted
    437 Post(s)

    Default

    Why not just remove it?
    You can remove the element, or would that be bad/impossible? (Sorry not to familiar with Java, its been a while)




    Anti-Leech Movement Prevent Leeching Spread the word
    Insanity 60 Days (Killer workout)
    XoL Blog (Workouts/RS/Misc)

  9. #309
    Join Date
    Oct 2008
    Location
    C:\Simba\Includes\
    Posts
    7,566
    Mentioned
    19 Post(s)
    Quoted
    180 Post(s)

    Default

    Quote Originally Posted by Brandon View Post
    That's exactly what I did...

    Guess no one approves of it so I'll try the bitmap hacky crap.
    I see now why you did the changes to every call, instead of the base method. The bar shows up for me when I go to login, don't know why it's not there for you.

    Only thing that we would have to fix would be the UpText, which Wizzup? posted how to.

    It's not that nobody approves of it, where did you even get that idea from anyway?, we are just exploring all the options and brainstorming

    Quote Originally Posted by MasterCrimez View Post
    Okay , didn't know that. Then I did it for nothing What exactly doesn't the community approve? The part of the DetermineAdd of the part of xOffset and yOffset?


    Another point I want to make:
    We need to be prepared of futher changes runescape makes. For example, maybe runescape will randomly add a different amount of pixels on the top and on the left every time you load RS... (for example 1-20 pixels on the left, and 1-20 pixels on the top) Then it would be different every time. What do we do then?

    I think all we need to do is:
    1. Add the variables xOffset and yOffset to all procedures and functions in SRL that have the hardcoded co-ords.
    2. Make a good procedure that determines the offset.... (procedure DetermineOffset; )

    It's at simple as that I believe
    1. ggzz has already done this. As stated before, we are brainstorming ideas.

    2. You don't need the DetermineAdd at all, it would be pointless to add it since we know how many pixels the bar takes up.
    Away for awhile, life is keeping me busy. | Want to get my attention in a thread? @Kyle Undefined; me.
    { MSI Phoenix || SRL Stats Sigs || Paste || Scripts || Quotes || Graphics }

    When posting a bug, please post debug! Help us, help you!

    I would love to change the world, but they won't give me the source code. || To be the best, you've got to beat the rest. || Logic never changes, just the syntax.
    If you PM me with a stupid question or one listed in FAQ, or about a script that is not mine, I will NOT respond.


    SRL is a Library of routines made by the SRL community written for the Program Simba. We produce Scripts for the game Runescape.


  10. #310
    Join Date
    May 2008
    Location
    Mental Hospital
    Posts
    414
    Mentioned
    4 Post(s)
    Quoted
    42 Post(s)

    Default

    Kyle is it not possible to remove the bar? Or is it in the applet now? I haven't had a chance to look at it.

  11. #311
    Join Date
    Jun 2012
    Location
    THE Students-City of Holland
    Posts
    332
    Mentioned
    0 Post(s)
    Quoted
    4 Post(s)

    Default

    With this update runescape has done, we
    should be prepared for more. Maybe they
    will add a random amount of pixels to
    the top and the left, and maybe it will
    even change every hour or so. A human
    wouldn't care about that, but a bot will
    fail, if it doesn't determine the offset
    now and then.

    We have to do two things:

    1. we have to make the procedure
    DeterminePixelVars. See below. This
    procedure determines the pixel
    constants... At least, they are now
    constant... From now on, I think it
    would be better to see them as
    variables...

    2. we have to use these variables in all
    the SRL functions! From what I have seen
    now, a lot of co-ordinates are hard
    coded. The constants are not being used.
    This is something that will take a lot
    of time, because we have to look through
    all the functions that are clicking on
    hard-coded co-ordinates, or looking for
    colors on hardcoded coords

    I don't know if my help is apreciated
    right now , because when I started
    talking in this thread, it seemed a lot
    of people got annoyed by me, but I want
    to make a start anyway with point 1.

    Simba Code:
    function LoggedIn: Boolean; forward;

    var
      OX, OY,
      MMX1, MMY1, MMX2, MMY2, MMCX, MMCY, MSX1, MMY1, MSX2, MSY2, MSCX, MSCY,
      MIX1, MIY1, MIX2, MIY2, MICX, MICY, MCX1, MCY1, MCX2, MCY2, MCCX, MCCY,
      MBX1, MBY1, MBX2, MBY2, DBX1, DBY1, DBX2, DBY2: integer;


    procedure DeterminePixelVariables;
    begin

      { vars OX, OY;
      Description: Offset from the left (x) and Offset from the top (y) }

      OX := 0;
      if LoggedIn then OY := 60 else OY := 20;
      {Please NB: this is just a quick fix. We can make this better.
      I will return to this subject later. //MasterCrimeZ }



    { vars MMX1, MMY1, MMX2, MMY2;
      Description: MiniMap Edge Points. }


      MMX1 := 550+OX;
      MMY1 := 8+OY;
      MMX2 := 703+OX;
      MMY2 := 161+OY;

    { vars MMCX, MMCY;
      Description: MiniMap Centre Point. }

      MMCX := round((MMX1+MMX2)/2);
      MMCY := round((MMY1+MMY2)/2);

    { vars MSX1, MSY1, MSX2, MSY2;
      Description: Main Screen EdgePoints. }

      MSX1 := 4+OX;
      MSY1 := 4+OY;
      MSX2 := 515+OX;
      MSY2 := 337+OY;

    { vars MSCX, MSCY;
      Description: Main Screen Centre Points. }

      MSCX := round((MSX1+MSX2)/2);
      MSCY := round((MSY1+MSY2)/2);

    { vars MIX1, MIY1, MIX2, MIY2;
      Description: Inventory EdgePoints. }

      MIX1 := 547+OX;
      MIY1 := 202+OY;
      MIX2 := 737+OX;
      MIY2 := 466+OY;

    { vars MICX, MICY;
      Description: Inventory Centre Points. }

      MICX := round((MIX1+MIX2)/2);
      MICY := round((MIY1+MIY2)/2)

    { vars MCX1, MCY1, MCX2, MCY2;
      Description: Chat Screen EdgePoints. }

      MCX1 := 4+OX;
      MCY1 := 342+OY;
      MCX2 := 514+OX;
      MCY2 := 475+OY;

    { vars MCCX, MCCY;
      Description: Chat Screen Centre Points. }

      MCCX := round((MCX1+MCX2)/2);
      MCCY := round((MCY1+MCY2)/2)

    { vars MBX1, MBY1, MBX2, MBY2;
      Description: BankScreen EdgePoints (where you click the items, does not include tabs). }

      MBX1 := 26+OX;
      MBY1 := 84+OY;
      MBX2 := 480+OX;
      MBY2 := 292+OY;

    { vars DBX1, DBY1, DBX2, DBY2;
      Description: Deposit box edgepoints (only where the item appear) }

      DBX1 := 91+OX;
      DBY1 := 57+OY;
      DBX2 := 443+OX;
      DBY2 := 262+OY;

    end;

    That's what I just made. This is a good start I think because when runescape gets updated and adds in random offsets, we can still make our scripts run.


    Edit:
    With my solution the only thing you need to do is:

    1. add this include with the procedure in it and the vars into the SRL include....
    2. add DeterminePixelVariables; in the SetupSRL
    3. add DeterminePixelVariables; at the begin AND end of LoginPlayer
    4.(not needed: add DeterminePixelVariables every now and then into your loop, but if we do it at the end of LoginPlayer, that's also fine.)

    so no changes to the scripts at all... only to SRL

    Except for the hardcoded coords in scripts ofcousre.. everyone should use the constants for their coords: such as MSX1+70 instead of 70 (Or OX+70)


    Greetz,
    MasterCrimeZ
    Last edited by Master BAW; 07-12-2012 at 07:33 PM.
    Former Name: MasterCrimeZ.
    ToDo: 1. Finish my private bot 2. Make some cool bots for this community 3. Become a member
    If you have any questions about scripting, feel free to PM me

  12. #312
    Join Date
    May 2008
    Location
    Mental Hospital
    Posts
    414
    Mentioned
    4 Post(s)
    Quoted
    42 Post(s)

    Default

    Quote Originally Posted by MasterCrimez View Post
    With this update runescape has done, we
    should be prepared for more.
    ......
    .....
    Greetz,
    MasterCrimeZ
    I don't really think that is necessarily important to do right now, if ever. If you spend all your time 'fixing' stuff you 'think' might happen, you will waste a lot of time. I haven't noticed any randomness in the pixels, nor do I think jagex is going to do that. As well, I don't remember this kind of stuff happening too frequently, so it will probably stay like this for a good while.

  13. #313
    Join Date
    Jul 2012
    Location
    U.S.A.
    Posts
    13
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    how is this all going by the way I thought y'all were going to be done with this yesterday or today?
    Last edited by hunnyitsme3; 07-12-2012 at 05:54 PM. Reason: big meat
    ^Question of the day^

  14. #314
    Join Date
    Feb 2006
    Posts
    3,044
    Mentioned
    4 Post(s)
    Quoted
    21 Post(s)

    Default

    Why not just edit Client Dimensions..

    This code is related to it. From Simba sauce.

    Simba Code:
    while GetAsyncKeyState(VK_LBUTTON) <> 0 do
      begin;
        Handle:= WindowFromPoint(Mouse.CursorPos);
        if (Handle <> TempHandle) and (Handle <> EdgeForm.Handle) then
        begin;
          GetWindowRect(Handle, TargetRect);
          W :=TargetRect.Right - TargetRect.Left+1;
          H :=TargetRect.Bottom - TargetRect.Top+1;
          DragForm.SetBounds(TargetRect.Left,TargetRect.top,W,H);//Draw the transparent form

          SetWindowRgn(EdgeForm.Handle,0,false);//Delete the old region
          Region := CreateRectRgn(0,0,w-1,h-1); //Create a full region, of the whole form
          CombineRgn(Region,Region,CreateRectRgn(EdgeSize,EdgeSize,w-1-(edgesize),h-1-(edgesize)),RGN_XOR); //Combine a the 2 regions (of the full form and one without the edges)
          SetWindowRgn(edgeform.Handle,Region,true);//Set the only-edge-region!
          EdgeForm.SetBounds(TargetRect.Left,TargetRect.top,W,H);//Move the form etc..
          TempHandle := Handle;
        end;
        Application.ProcessMessages;
        Sleep

    I hope that you all get my point :P



    ~Home
    Last edited by Home; 07-12-2012 at 05:54 PM.

  15. #315
    Join Date
    Feb 2006
    Location
    Berkeley, CA
    Posts
    1,837
    Mentioned
    52 Post(s)
    Quoted
    60 Post(s)

    Default

    How about this: instead of brainstorming ways of hacking a fix together by adding offsets to what we already have, we just start fixing things?

    Obviously, as people have already done, we need to fix the main screen constants. Someone then needs to simply fix the login screen (and related) functions so that they work with or without the bar (should not be difficult, search for a bitmap, if you have to, or find some way to determine the proper coordinates. Wizzup posted a fix for uptext, someone slam that into SRL. At that point, everything should be fixed except problems with individual scripts.

    I suspect MOST of what I said is done already, but if not, someone with commit access to SRL (or someone willing to write pull requests) should get on it.

    Brandon: The image array stuff is neat (yes, I know it was my idea) but it's really trickery and will add more problems later (such as having to offset EVERYTHING that also uses coordinates, i.e. mouse movements), so we should abandon that. I think (I didn't look) that you have gone through and made sure everything coord based is reference to the global constants? That's 90% of the job.

    Since the game screen (while you are logged in) is no different except for having the bar, literally everything should be fixed by changing the coordinates. The login screen functions are a bit more tricky since it doesn't (always?) have the bar. Someone just needs to fix them.

    We should stop looking for an 'elegant' or 'neat' solution and implement the easiest thing that works.

    E: On that note, no dynamic screen constants. Assume screen constants are only valid if logged in and fix non-logged-in functions to work in whatever way necessary.
    Last edited by BenLand100; 07-12-2012 at 06:10 PM.

  16. #316
    Join Date
    Dec 2011
    Location
    New York, USA
    Posts
    1,242
    Mentioned
    12 Post(s)
    Quoted
    193 Post(s)

    Default

    Quote Originally Posted by Home View Post
    Why not just edit Client Dimensions..

    This code is related to it. From Simba sauce.

    Simba Code:
    while GetAsyncKeyState(VK_LBUTTON) <> 0 do
      begin;
        Handle:= WindowFromPoint(Mouse.CursorPos);
        if (Handle <> TempHandle) and (Handle <> EdgeForm.Handle) then
        begin;
          GetWindowRect(Handle, TargetRect);
          W :=TargetRect.Right - TargetRect.Left+1;
          H :=TargetRect.Bottom - TargetRect.Top+1;
          DragForm.SetBounds(TargetRect.Left,TargetRect.top,W,H);//Draw the transparent form

          SetWindowRgn(EdgeForm.Handle,0,false);//Delete the old region
          Region := CreateRectRgn(0,0,w-1,h-1); //Create a full region, of the whole form
          CombineRgn(Region,Region,CreateRectRgn(EdgeSize,EdgeSize,w-1-(edgesize),h-1-(edgesize)),RGN_XOR); //Combine a the 2 regions (of the full form and one without the edges)
          SetWindowRgn(edgeform.Handle,Region,true);//Set the only-edge-region!
          EdgeForm.SetBounds(TargetRect.Left,TargetRect.top,W,H);//Move the form etc..
          TempHandle := Handle;
        end;
        Application.ProcessMessages;
        Sleep

    I hope that you all get my point :P



    ~Home
    I don't know what any of that means, are you saying to just chop off the new area created by the update, and just make it how it used to be? like this:

    Don't see why that wouldn't work.

  17. #317
    Join Date
    Feb 2011
    Location
    The Future.
    Posts
    5,600
    Mentioned
    396 Post(s)
    Quoted
    1598 Post(s)

    Default

    Well this is my last and probably final suggestion: https://github.com/Brandon-T/SRL-5
    We now have 3 options:

    The offsets I suggested before where all values had + 50 added to them and + 22 on login screen.. Only thing required fixing was uptext. That's it.
    This option that I'm offering now described below. Where the only things that are messed up is stuff like GetMousePos. All finder functions read from the offsetted value automatically. Thus I am able to bot right now since everything else works.

    Or Someone else's suggestion in the thread.

    I used the Pointer Offset and offset the MMouse function. That's about it. All static values automatically reflect the changes.

    For example I don't have to change all the values in any include. The only includes actually changed were login.simba and player.simba.

    Globals hold the pointer offset function and the login and player files will call them when necessary.

    This means the entire SRL include still works. I changed nothing else. Uptext functions work too but like I said the downside is getmousepos and functions that return coordinates base on the client's dimensions. All finder functions work normally as they should and scripts will require the least amount of updates.

    basically if your script uses get mousepos and relies on it heavily then every time you call getmousepos just add 50 to the y values.
    Last edited by Brandon; 07-12-2012 at 06:23 PM.
    I am Ggzz..
    Hackintosher

  18. #318
    Join Date
    Feb 2006
    Location
    Amsterdam
    Posts
    13,692
    Mentioned
    146 Post(s)
    Quoted
    130 Post(s)

    Default

    Guys, do we really want to hardcode offsets in the mouse function?
    E: Unless that is required due to the offset with the pointer as well.

    Still, it seems silly to restrict a part of the client.



    The best way to contact me is by email, which you can find on my website: http://wizzup.org
    I also get email notifications of private messages, though.

    Simba (on Twitter | Group on Villavu | Website | Stable/Unstable releases
    Documentation | Source | Simba Bug Tracker on Github and Villavu )


    My (Blog | Website)

  19. #319
    Join Date
    Jun 2012
    Posts
    32
    Mentioned
    0 Post(s)
    Quoted
    15 Post(s)

    Default

    Good Job Brandon!

  20. #320
    Join Date
    Feb 2011
    Location
    The Future.
    Posts
    5,600
    Mentioned
    396 Post(s)
    Quoted
    1598 Post(s)

    Default

    Quote Originally Posted by Wizzup? View Post
    Guys, do we really want to hardcode offsets in the mouse function?
    E: Unless that is required due to the offset with the pointer as well.

    Still, it seems silly to restrict a part of the client.
    Yeah I know.. thats why I suggested two options. A: where all values have 50 added to them which I did a couple pages back. Or B: where the crap is offsetted in the mouse function itself. Or C: Someone else's ideas :S
    I am Ggzz..
    Hackintosher

  21. #321
    Join Date
    Feb 2006
    Location
    Amsterdam
    Posts
    13,692
    Mentioned
    146 Post(s)
    Quoted
    130 Post(s)

    Default

    Quote Originally Posted by Brandon View Post
    Yeah I know.. thats why I suggested two options. A: where all values have 50 added to them. Or B: where the crap is offsetted in the mouse function itself. Or C: Someone else's ideas :S
    If you mean by adding, adding it manually, then yes, that is sound. It just means going through a lot in SRL. Perhaps introduce constants for all the coordinates along the way. Perhaps even a constant for the size of the bar on top, so we can change that later if they decide to mess with us again.

    Simba Code:
    const
        _RS_BAR_SIZE = 50;

    function _bar(y: integer): integer;
    begin
      result := y + _RS_BAR_SIZE;
    end;

    function: LoggedIn: boolean;
    begin
      result := getcolor(1337, _bar(1337)) = foo;
    end;

    I think you get the idea. That way you could keep the old constants, and just dynamically add something to it.



    The best way to contact me is by email, which you can find on my website: http://wizzup.org
    I also get email notifications of private messages, though.

    Simba (on Twitter | Group on Villavu | Website | Stable/Unstable releases
    Documentation | Source | Simba Bug Tracker on Github and Villavu )


    My (Blog | Website)

  22. #322
    Join Date
    Feb 2011
    Location
    The Future.
    Posts
    5,600
    Mentioned
    396 Post(s)
    Quoted
    1598 Post(s)

    Default

    Quote Originally Posted by Wizzup? View Post
    If you mean by adding, adding it manually, then yes, that is sound. It just means going through a lot in SRL. Perhaps introduce constants for all the coordinates along the way. Perhaps even a constant for the size of the bar on top, so we can change that later if they decide to mess with us again.

    I think you get the idea. That way you could keep the old constants, and just dynamically add something to it.
    Like this?: http://villavu.com/forum/showpost.ph...&postcount=240
    I am Ggzz..
    Hackintosher

  23. #323
    Join Date
    Jun 2012
    Location
    THE Students-City of Holland
    Posts
    332
    Mentioned
    0 Post(s)
    Quoted
    4 Post(s)

    Default

    I got my script to login
    Yay
    Former Name: MasterCrimeZ.
    ToDo: 1. Finish my private bot 2. Make some cool bots for this community 3. Become a member
    If you have any questions about scripting, feel free to PM me

  24. #324
    Join Date
    Feb 2006
    Location
    Amsterdam
    Posts
    13,692
    Mentioned
    146 Post(s)
    Quoted
    130 Post(s)

    Default

    Quote Originally Posted by Brandon View Post
    Yes! But drop the addition (+ Some_Const) and turn it into a function that does the same. And make the function a short name, but also a name that's not really used, like _rsbar or something.



    The best way to contact me is by email, which you can find on my website: http://wizzup.org
    I also get email notifications of private messages, though.

    Simba (on Twitter | Group on Villavu | Website | Stable/Unstable releases
    Documentation | Source | Simba Bug Tracker on Github and Villavu )


    My (Blog | Website)

  25. #325
    Join Date
    Feb 2006
    Location
    Amsterdam
    Posts
    13,692
    Mentioned
    146 Post(s)
    Quoted
    130 Post(s)

    Default

    Actually, Brandon. Ignore my previous suggestion on the name. I suggest giving it a formal name so scripts can rely on it too.

    SRL_BarCoord() or something.



    The best way to contact me is by email, which you can find on my website: http://wizzup.org
    I also get email notifications of private messages, though.

    Simba (on Twitter | Group on Villavu | Website | Stable/Unstable releases
    Documentation | Source | Simba Bug Tracker on Github and Villavu )


    My (Blog | Website)

Page 13 of 54 FirstFirst ... 3111213141523 ... LastLast

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •