S1NCooker [260K /h+]

[Benny]

calm it guys

just don't rage on forums

[Sin]

Are you fucking kidding me? Someone please look at this procedure and tell me that this is considered even remotely decent:

begin
SetupLogin;
StartTime:=GetSystemTime;
  if (Players[CurrentPlayer].Integers[1] = 0) then
  begin
    if not IsXPBarOpen then ToggleXPBar(true);
      Players[CurrentPlayer].Integers[0] := GetXPBarTotal;
      Players[CurrentPlayer].Integers[1] := (Players[CurrentPlayer].Integers[1] + 1);
  end;
repeat
  Bank
  Cook;
until(AllPlayersInactive);
end.

Flawed logic example is shown below. The CTS thing is that I'm talking about.(also another bad standards example):

function OpenCGuildBank:Boolean;
var
  x,y,tmpCTS,i:integer;
  TPA:TPointArray;
  ATPA:T2DPointArray;
begin
tmpCTS := GetColorToleranceSpeed;
SetColorToleranceSpeed(2);
SetColorspeed2Modifiers(0.10,0.99);

  if FindColorsSpiralTolerance(x,y,TPA,4861235,MSX1,MSY1,MSX2,MSY2,5) then
  begin
    ATPA := TPAtoATPA(TPA,5);
    for i := 0 to High(ATPA) do
    begin
      MiddleTPAEx(ATPA[i],x,y);
      MMouse(x,y,2,2);
      if WaitUpTextMulti(['alk','anker','Banker'],750) then
      begin
        ClickMouse2(False);
        ChooseOption('ank B');
        Result := True;
        Break;
      end;
    end;
  end;
SetColorToleranceSpeed(tmpCTS);
SetColorspeed2Modifiers(0.2,0.2);
end;

And this; all integers start at 0 anyways... and you're just changing the value of t anways 5 seconds later so whats the point of that?

procedure Bank;
var
  t:Integer;
begin
  t := 0;
  if OpenCGuildBank then
  begin
    MarkTime(t);

"I can agree with you here, because OFCOURSE when a script hasn't even been released 12 hours, it has to be ABSOLUTELY PERFECT right?!"

It does have to be near perfect when you are representing the SRL members. (which I am not doing very well atm). I don't think it looks good when a SRL member produces a few kilobytes of shit.

"Still sore about me voting No on your application are we?"

Yeah a little actually. You really do need to look at the beginner tutorial if you think it's bad to make banking a function.

Wow, rep abuse big whoop. If rep really doesn't count for anything it shouldn't matter +I was high. It's not like I ruined your rep point count with my rep power of 1...

1)
That code wasn't written by me, it was written by NexPB and it ended up like that when I copied it (with his permission) from his Artisans Workshop script.


2)
Erm you're twisting up my script? There are NO bad standards in that piece of code.


That's how it looks like when you open it. Explain the CTS thing a bit more clearly, I have no idea what you're talking about.

3)

And this; all integers start at 0 anyways... and you're just changing the value of t anways 5 seconds later so whats the point of that?

They typically do, but i'm calling 't' and then MOVING BACK TO THE BEGINNING OF THE PROCEDURE.

4)

It does have to be near perfect when you are representing the SRL members. (which I am not doing very well atm). I don't think it looks good when a SRL member produces a few kilobytes of shit.

Agreed. Do you remember when whatshisname from RSBots.net released "Auto Dungeoneering Pro"? Was it REMOTELY decent? It was a horrible piece of code when I saw it (H.rs members had all the source codes for all PRO scripts). What you're saying is extremely opinionative, an SRL Member is still a human and doesn't need to be anywhere near perfect. And a few kilobytes of shit? Haha, it's better than having a few kilobytes of a picture in a script which has NO correlation to the point of the script.

Now kindly refrain from posting here as it's just ruining my mood. You don't need to respond to this post, if you want to, take it to a PM.

[Nebula]

...

I do know what I'm talking about. Let me show you:


First: I wasn't talking about the content of his mainloop, I was talking about the standards.

Second: His CTS never changes throughout his script so there's no point...

third: MarkTime(t); gives t an entire new value, it doesn't matter what its old value is so you can just shut up unless you know what you are talking about.

[Mat]

Shay I'm sure on Line 80 and 81 they need to be tabbed.
like the end;
Mat

[Jos3ph]

I'm just glad someone took the time to write a script, update it & make it public.... I could careless about how it was coded as long as it works.


Have any ideas of building a fire @ sw bank and cooking there?

[Sin]

Shay I'm sure on Line 80 and 81 they need to be tabbed.
like the end;
Mat

Idk mate, that's how I saw it done by the big shots like Kyle/Flight etc.
They made the CTS non tabbed and the main code tabbed.

I'm just glad someone took the time to write a script, update it & make it public.... I could careless about how it was coded as long as it works.


Have any ideas of building a fire @ sw bank and cooking there?

Can't light a fire in Soul Wars :l

[Jos3ph]

Idk mate, that's how I saw it done by the big shots like Kyle/Flight etc.
They made the CTS non tabbed and the main code tabbed.





Can't light a fire in Soul Wars :l

Ah chucks. I get hit with ransoms far to often. :/ just trying to avoid ransoms

[putonajonny]

My last post in this thread (unless I come to actually use the script in future)

Second: His CTS never changes throughout his script so there's no point...

Yes, but a whole lot of SRL functions require CTS1, especially random checks, leave it on CTS2 and it will mistake every item under the sun in your invent for a spin ticket or a reward box, and keep trying to open/claim them, then when it can't it will drop them, that's why he does what he did, and what if he wrote a CTS1 colour finding function in the future, would he want to go through the whole script changing the CTS?

third: MarkTime(t); gives t an entire new value, it doesn't matter what its old value is so you can just shut up unless you know what you are talking about.

That's not what I was talking about, I was saying it is good practice to give variables values...

[Sin]

This is how it should look:

Idk mate, that's how I saw it done by the big shots like Kyle/Flight etc.
They made the CTS non tabbed and the main code tabbed.

...

[Nebula]

I deleted that once I saw mats post.

[Jos3ph]

I get this; not a error but surly not something it should do\

Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up

Doesnt bank just tries to cook cooked shark after my first load. Using 1.1 wearing comp cape; all neon green / blue, with fire staff would something be the issue messing it up?


And now I get this error;

Error: divide by Zero at line 148
The following DTMs were not freed: [SRL - Lamp bitmap, 1]
The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap, SRL - Flag bitmap, SRL - NavBar Bitmap]

[Solar]

I'm getting the same thing as your first error.
Shay, did you put in some anti-leech?

[Justin]

Nice release Sin. It's a shame you release a working script to the public and then other SRL members feel like they NEED to correct you.

[Jos3ph]

Nice release Sin. It's a shame you release a working script to the public and then other SRL members feel like they NEED to correct you.

Cant make everyone happy; some feel the need to constantly correct others while I notice Sin has a lot of public scripts and the person who insisted to correct his script doesnt seem to have any public scripts. It is what it is; I'm glad someone took their time to give to the public, perfect or not, its free and a lot better then what I could do so for that I say thank you.

[Sin]

Alright, i'll take a look at it.

E*
Fixed it. 1.12.

[Jos3ph]

Working solid for the last 3hours.

[Sin]

Great! Looking into Urn Support now!

[Kyle Undefined]

There are NO bad standards in that piece of code.


That's how it looks like when you open it.

Um, that's bad standards, just saying. Nebula had it right with this image:

Idk mate, that's how I saw it done by the big shots like Kyle/Flight etc.
They made the CTS non tabbed and the main code tabbed.

I call BS on that, don't drag me into your little argument. Especially with the claim you're making about me is false. I don't care what the line is, anything after a begin gets indented.

Nice release Sin. It's a shame you release a working script to the public and then other SRL members feel like they NEED to correct you.

I don't agree with the public call out, however, there's more to this story that I can't share with you.

[Sin]

Um, that's bad standards, just saying. Nebula had it right with this image:





I call BS on that, don't drag me into your little argument. Especially with the claim you're making about me is false. I don't care what the line is, anything after a begin gets indented.



I don't agree with the public call out, however, there's more to this story that I can't share with you.

Yeah it wasn't you, it was someone else.
I talked with Axel and it was correct.

[Jos3ph]

Any new updates with urn support? Super excitedd!!

[Sin]

============S1NCooker==============
Time Running: 50 Minutes and 33 Seconds
XP Earned: 226500
XP/h: 278634
Items Cooked: 1050
===================================

Urns don't speed it up that much, just working out the kinks in it.

[Jos3ph]

Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up
Taking too much to get interface up



thats the error I keep getting...

[Jos3ph]

Clicks the second from top row, the last shark it clicks it again and gives me this error. ^

[Sin]

I'll add a few failsafes in, give me a quick bit.

[Jos3ph]

let me know when you added the fail safes and I'll test again