Results 1 to 14 of 14

Thread: apg1992's fisrt script-need reviewing

  1. #1
    Join Date
    Apr 2007
    Posts
    8
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default apg1992's fisrt script-need reviewing

    this is my first script and i was hopeing it would be a good review so here it is i dont know wat 2 post but i need hlp on color for willows

    hope fully it works for ur version

    SCAR Code:
    {_________           ___________      ___________
     |        \          |   _____  \    /  ______   \
     |         \         |   |    \  \  /  /      |   \
     |          \        |   |    |  | |  |       |   |
     |     |\    \       |   |    |  | |  |       |   |
     |     | \    \      |   |___/   / \  \_______|   |
     |     |  \    \     |      ____/   \_________    |
     |     _____    \    |      |                |    |
     |     ______    \   |      |                |    |
     |     |     \    \  |      |                /    |
    _|_____|______\____\_|______|_______________/     /
    |                                                /  1992's tree
    |_______________________________________________/   power chopper
    --------------------------------------------------------------------------------------------
     _______
    |_______|
       | |    __  _______   ___
       | |    | \ | | ___| /   \
       | |    |  \| | |_  |  |  |
       | |    |  |  | _|  |  |  |
     __|_|___ |  |\ | |   |  |  |
    |________||__| \|_|    \___/

    SET UP ANY WHERE THERE IS WILLOWS AND START MACRO THIS IS MY
    FIRST SCRIPT AND I AM VERY SATASFIED WITH IT I HOPE U WILL BE TO

    SET UP USERNAME INFO IN LINES 65-83
    ____________________________________________________________________________________________}



    {.Script Info:
    # ScriptName  = apgs tree master
    # Author      = apg1992
    # Description = simple woodcutter
    # Version     = 1.0
    # Date        = 4/20/2007
    # Comments    = my first script
    /Script Info}


    {program apg1992 willow master;
    {.Include SRL/SRL.Scar}

    {.Include SRL/SRL/Skill/woodcutting.Scar}
    var
    loads: integer;
    i: integer;
    logschopped: integer;

    //////////////SetUp-SetUp-SetUp/////////////////////////////////
    const                                                         //
    TreeColor = 396042;//the tree color                             //
    HowManyLoads = 2500000000000000; //how many loads you wnat to do//
    Cutlevl = 5000;   //the time in millisec for you to cut tree  //
    Axes = 0; //how many axes you have make sure there unequiped  //
    NOban = 12; //how much anti ban you want the less is better 10-17 //
    ////////////////////////////////////////////////////////////////


    Procedure DeclarePlayers;
    begin

     HowManyPlayers  := 4;
     NumberOfPlayers( HowManyPlayers );
     CurrentPlayer := 0;

     Players[0].Name      := '';
     Players[0].Pass      := '';
     Players[0].Nick      := '';
     Players[0].Active    := True;

     Players[1].Name      := '';
     Players[1].Pass      := '';
     Players[1].Nick      := '';
     Players[1].Active    := true;

     Players[2].Name      := '';
     Players[2].Pass      := '';
     Players[2].Nick      := '';
     Players[2].Active    := true;

     Players[3].Name      := '';
     Players[3].Pass      := '';
     Players[3].Nick      := '';
     Players[3].Active    := true;
    end;

    procedure antirandoms;
     begin
       if(NoGameTab= true)then
        Exit;
          FindNormalRandoms;
          if(FindCerter = True)then
        StupidSolveCerter;
       Solvepinball;
    end;

    procedure FindTreeAndCut;
     begin
      if(FindColortolerance(x,y,treecolor,msx1,msy1,msx2,msy2,5))then
        MMouse(x,y,0,0);
        if(FindEnt(treecolor))then
        Wait(10000);
        Wait(10);
       if (IsUpText('hop'))or
          (IsUpText('h op')) or
          (IsUpText('ho p')) then
         Mouse(x,y,0,0,true);
        FindNormalRandoms;

      Wait(cutlevl+(300));
    end;

    procedure Report;
    begin
      Writeln('[]I love runescape[]');
       Writeln('Worked For : ' + ScriptTime2(2))
       Writeln('choped '+ IntToStr(logschopped) + ' Logs');
       Writeln('droped '+ IntToStr(loads)+'loads');
      Writeln('[]baker 4 life[]');
    end;

    begin
      SetupSRL;
      DeclarePlayers;
       repeat
        if(not(loggedin))then
         begin
           Loginplayer;
             Fixchat;
              SetRun(true);
               end;
                case Random(Noban) of
                  1: PickUpMouse;
                  2: MouseBox(MSx1, MSy1, MSx2, MSy2, 3);
                  4: HoverSkill('woodcutting', False);
                  6: MouseBox(MIx1, MIy1, MIx2, MIy2, 3);
                  9: BoredHuman;
                  8:Almostlogout;
                 end;
                HighestAngle;
               MakeCompass('N');
              AntiRandoms
            FindTreeAndCut;
          LogsChopped:= LogsChopped + 1;
        Antirandoms;
       Cleardebug;
     if(Invfull)then
    begin
      i:=i+1;
       loads:=loads+1;
       report;
       FindNormalRandoms;
      Dropto(axes,28)
     end;
      if(i>=howmanyloads)then
       Nextplayer(true);
      I:=0;
     until(false);
    end.

  2. #2
    Join Date
    Feb 2007
    Location
    Yorkshire, England
    Posts
    180
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Hey mate Always put it in Scar tags

    Makes it a lot easier

    SCAR Code:
    {_________ ___________ ___________
    | \ | _____ \ / ______ \
    | \ | | \ \ / / | \
    | \ | | | | | | | |
    | |\ \ | | | | | | | |
    | | \ \ | |___/ / \ \_______| |
    | | \ \ | ____/ \_________ |
    | _____ \ | | | |
    | ______ \ | | | |
    | | \ \ | | / |
    _|_____|______\____\_|______|_______________/ /
    | / 1992's tree
    |_______________________________________________/ power chopper
    --------------------------------------------------------------------------------------------
    _______
    |_______|
    | | __ _______ ___
    | | | \ | | ___| / \
    | | | \| | |_ | | |
    | | | | | _| | | |
    __|_|___ | |\ | | | | |
    |________||__| \|_| \___/

    SET UP ANY WHERE THERE IS WILLOWS AND START MACRO THIS IS MY
    FIRST SCRIPT AND I AM VERY SATASFIED WITH IT I HOPE U WILL BE TO

    SET UP USERNAME INFO IN LINES 65-83
    __________________________________________________ __________________________________________}



    {.Script Info:
    # ScriptName = apgs tree master
    # Author = apg1992
    # Description = simple woodcutter
    # Version = 1.0
    # Date = 4/20/2007
    # Comments = my first script
    /Script Info}


    {program apg1992 willow master;
    {.Include SRL/SRL.Scar}

    {.Include SRL/SRL/Skill/woodcutting.Scar}
    var
    loads: integer;
    i: integer;
    logschopped: integer;

    //////////////SetUp-SetUp-SetUp/////////////////////////////////
    const //
    TreeColor = 396042;//the tree color //
    HowManyLoads = 2500000000000000; //how many loads you wnat to do//
    Cutlevl = 5000; //the time in millisec for you to cut tree //
    Axes = 0; //how many axes you have make sure there unequiped //
    NOban = 12; //how much anti ban you want the less is better 10-17 //
    ////////////////////////////////////////////////////////////////


    Procedure DeclarePlayers;
    begin

    HowManyPlayers := 4;
    NumberOfPlayers( HowManyPlayers );
    CurrentPlayer := 0;

    Players[0].Name := '';
    Players[0].Pass := '';
    Players[0].Nick := '';
    Players[0].Active := True;

    Players[1].Name := '';
    Players[1].Pass := '';
    Players[1].Nick := '';
    Players[1].Active := true;

    Players[2].Name := '';
    Players[2].Pass := '';
    Players[2].Nick := '';
    Players[2].Active := true;

    Players[3].Name := '';
    Players[3].Pass := '';
    Players[3].Nick := '';
    Players[3].Active := true;
    end;

    procedure antirandoms;
    begin
    if(NoGameTab= true)then
    Exit;
    FindNormalRandoms;
    if(FindCerter = True)then
    StupidSolveCerter;
    Solvepinball;
    end;

    procedure FindTreeAndCut;
    begin
    if(FindColortolerance(x,y,treecolor,msx1,msy1,msx2 ,msy2,5))then
    MMouse(x,y,0,0);
    if(FindEnt(treecolor))then
    Wait(10000);
    Wait(10);
    if (IsUpText('hop'))or
    (IsUpText('h op')) or
    (IsUpText('ho p')) then
    Mouse(x,y,0,0,true);
    FindNormalRandoms;

    Wait(cutlevl+(300));
    end;

    procedure Report;
    begin
    Writeln('[]I love runescape[]');
    Writeln('Worked For : ' + ScriptTime2(2))
    Writeln('choped '+ IntToStr(logschopped) + ' Logs');
    Writeln('droped '+ IntToStr(loads)+'loads');
    Writeln('[]baker 4 life[]');
    end;

    begin
    SetupSRL;
    DeclarePlayers;
    repeat
    if(not(loggedin))then
    begin
    Loginplayer;
    Fixchat;
    SetRun(true);
    end;
    case Random(Noban) of
    1: PickUpMouse;
    2: MouseBox(MSx1, MSy1, MSx2, MSy2, 3);
    4: HoverSkill('woodcutting', False);
    6: MouseBox(MIx1, MIy1, MIx2, MIy2, 3);
    9: BoredHuman;
    8:Almostlogout;
    end;
    HighestAngle;
    MakeCompass('N');
    AntiRandoms
    FindTreeAndCut;
    LogsChopped:= LogsChopped + 1;
    Antirandoms;
    Cleardebug;
    if(Invfull)then
    begin
    i:=i+1;
    loads:=loads+1;
    report;
    FindNormalRandoms;
    Dropto(axes,28)
    end;
    if(i>=howmanyloads)then
    Nextplayer(true);
    I:=0;
    until(false);
    end.

    And there you go like so

    When i have time i will take a look over it

  3. #3
    Join Date
    Nov 2006
    Location
    In an Amish Paradise
    Posts
    729
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Need to look at the standerds for scripts!! just so it makes it easier for people to read... looks pretty good but like I said its hard to read

  4. #4
    Join Date
    Apr 2007
    Posts
    8
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    where would i find the standerds for scar scripts?

  5. #5
    Join Date
    Feb 2007
    Location
    Yorkshire, England
    Posts
    180
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

  6. #6
    Join Date
    Apr 2007
    Posts
    8
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    is it good ..... for how long iv been working on it....... iv been working on it for the last day and a half

  7. #7
    Join Date
    Feb 2007
    Location
    Alberta, Canada
    Posts
    4,615
    Mentioned
    50 Post(s)
    Quoted
    429 Post(s)

    Default

    SCAR Code:
    Axes = 0

    Nobody would have 0 axes, it shouldnt even start the script if axes = 0

    SCAR Code:
    if (IsUpText('hop'))or
          (IsUpText('h op')) or
          (IsUpText('ho p')) then
    If im not mistaken, couldnt you use IsUpTextMulti, then use the three.?

    In all, it looks like a great script, you even used Cases, Good Job

    Scripts: Edgeville Chop & Bank, GE Merchanting Aid
    Tutorials: How to Dominate the Grand Exchange

    Quote Originally Posted by YoHoJo View Post
    I like hentai.

  8. #8
    Join Date
    Apr 2007
    Posts
    8
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    ty for congradulateing me =] =]

  9. #9
    Join Date
    Apr 2007
    Posts
    8
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    =)

  10. #10
    Join Date
    Feb 2007
    Posts
    3,616
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by apg1992 View Post
    =)
    9 days later and you double post with spam? Whats up with that..?

  11. #11
    Join Date
    Mar 2007
    Posts
    138
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Very nice script, just watch for spelling. you have for HowManyLoads = 2500000000000000; //how many loads you wnat to do// wnat should be "Want". Try to watch spelling just makes it look like but overall very nice script, keep up the great work!

  12. #12
    Join Date
    Jul 2006
    Posts
    152
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    When you say
    SCAR Code:
    If (NoGameTab= True) then
    you don't have to have the = True.
    If you just say
    SCAR Code:
    If (NoGameTab) Then
    it will act like there is true there.
    To say
    SCAR Code:
    If (NoGameTab= False) then
    Simply say
    SCAR Code:
    If(Not(NoGameTab)) then


  13. #13
    Join Date
    Apr 2007
    Location
    Finland
    Posts
    938
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by seaking View Post
    When you say
    SCAR Code:
    If (NoGameTab= True) then
    you don't have to have the = True.
    If you just say
    SCAR Code:
    If (NoGameTab) Then
    it will act like there is true there.
    To say
    SCAR Code:
    If (NoGameTab= False) then
    Simply say
    SCAR Code:
    If(Not(NoGameTab)) then

    I usually still say
    SCAR Code:
    if(Something = true)
    than
    SCAR Code:
    if(Something)
    Makes it clearer for me to read

  14. #14
    Join Date
    Feb 2007
    Location
    Alberta, Canada
    Posts
    4,615
    Mentioned
    50 Post(s)
    Quoted
    429 Post(s)

    Default

    I always just use if(something) then. Its the opposite for me, it makes it easier for me to read, than = and =, i dont know why, but whatever works for you

    Scripts: Edgeville Chop & Bank, GE Merchanting Aid
    Tutorials: How to Dominate the Grand Exchange

    Quote Originally Posted by YoHoJo View Post
    I like hentai.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •