Results 1 to 14 of 14

Thread: FoundBar/LoggedIn false positive when 'loading'

  1. #1
    Join Date
    Jan 2012
    Posts
    2,568
    Mentioned
    35 Post(s)
    Quoted
    356 Post(s)

    Default FoundBar/LoggedIn false positive when 'loading'



    FoundBar checks the existence of bitmap 'H' (shown above) of the 'Home' shown by the nav bar. However, it's common to frequently receive the message 'Loading - please wait.' in RS, which coincidentally covers up the H completely, resulting in FoundBar returning false. As FoundBar is used in SRL_ResetNavBar, which is in turn used in LoggedIn, this results in LoggedIn returning false if the function is called while the 'Loading' is displayed, and y offset will be set to -22 instead of -50, resulting in no chance of the script recovering (even multiplayer will fail since it can't log in).

    Fix:
    I created a bitmap of the 'S' of the 'Support' instead which is not covered up.
    Simba Code:
    SRL_NAVBAR_BITMAP:= BitmapFromString(8, 13, 'meJzj4pfi4FcS1fFMOnu78sefsF1' +
            'nRbXcOPmkOPjkZGwi8198Dd99HkgCpZLP32Xnk2PjU0m/81k+oJJV' +
            '3JNLITD5wj31qAp2fmWg4oLXP6x6trJIBrJKBoqaZLAKW7IJaIrpe' +
            'mfc+wZE7stPyjhVAaVYxZzZRCzZBXWsWlfEXPkGQe7LToqaZrFKeH' +
            'EIarEI26ilzQk5+QmOgBrZBbXFDKOACrgMcgzrN/od/gxEjvPPyPu' +
            'Xy4b2AsVZpYKACMh22fYRiCyWv9ea8oJLMYhVwhsipZK7Xqf1uGLZ' +
            'YcP5b3RbTwDNAemS8FLJW89lkMsu7qjQ8UJr+hsgUqw4BkTSkXPZR' +
            'G24hdXYxZ1EotcodL2SqHvK69jNIaTLJawDAP1wcSY=');
    Search area is also changed to 278, 11, 293, 32. Other than that no other changes should be required.

    Let me know if i've overlooked anything before i send a pull request.

  2. #2
    Join Date
    Apr 2012
    Location
    Australia
    Posts
    1,252
    Mentioned
    1 Post(s)
    Quoted
    22 Post(s)

    Default

    Looks good to me. Although I've never had an issue with this I'm sure it happens to others. Nice work!

  3. #3
    Join Date
    Feb 2012
    Location
    DON'T PM ME ASKING FOR STUFF
    Posts
    2,170
    Mentioned
    38 Post(s)
    Quoted
    423 Post(s)

    Default

    Is it not possible to remove the div tag within SMART?

  4. #4
    Join Date
    Jan 2012
    Posts
    2,568
    Mentioned
    35 Post(s)
    Quoted
    356 Post(s)

    Default

    Quote Originally Posted by xtrapsp View Post
    Is it not possible to remove the div tag within SMART?
    What do you mean? Div tag?

  5. #5
    Join Date
    Jul 2011
    Location
    /home/litoris
    Posts
    2,226
    Mentioned
    0 Post(s)
    Quoted
    159 Post(s)

    Default

    Just posting here, I think all check for the login should be small bitmaps rather than GetColor at a certain point. The shop interface stuff are also broken, I got a color count in the scroll bar of shops to check for them in a private script though.
    Miner & Urn Crafter & 07 Chicken Killer
    SPS BlindWalk Tutorial

    Working on: Nothing

    teacher in every art, brought the fire that hath proved to mortals a means to mighty ends

  6. #6
    Join Date
    Feb 2012
    Posts
    35
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    how do i add this, or what do i do with it? sorry im just getting to know this whole scripting thing

  7. #7
    Join Date
    Jan 2012
    Posts
    2,568
    Mentioned
    35 Post(s)
    Quoted
    356 Post(s)

    Default

    Quote Originally Posted by whisper133 View Post
    how do i add this, or what do i do with it? sorry im just getting to know this whole scripting thing
    SRL>Check for Update at the top of Simba.

  8. #8
    Join Date
    Feb 2012
    Posts
    35
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by riwu View Post
    SRL>Check for Update at the top of Simba.
    oh ok i knew that i just thought we ahd to add the code on OP somewhere, thanks

  9. #9
    Join Date
    Feb 2012
    Location
    DON'T PM ME ASKING FOR STUFF
    Posts
    2,170
    Mentioned
    38 Post(s)
    Quoted
    423 Post(s)

    Default

    Quote Originally Posted by riwu View Post
    What do you mean? Div tag?
    Web design, Div tags are what website are constructed with.

  10. #10
    Join Date
    Jan 2012
    Posts
    2,568
    Mentioned
    35 Post(s)
    Quoted
    356 Post(s)

    Default

    Quote Originally Posted by xtrapsp View Post
    Web design, Div tags are what website are constructed with.
    You mean removing the nav bar? The nav bar is now part of the client (you cant target RS w/o including it) so i don't think it's possible. Can possibly 'hide' it by adjusting SMART to have it above the visible range but no point doing so since it still exists there and hence affect coordinates.

  11. #11
    Join Date
    Mar 2007
    Posts
    5,125
    Mentioned
    275 Post(s)
    Quoted
    901 Post(s)

    Default

    Looks good to me. Send in a pull request.

    Forum account issues? Please send me a PM

  12. #12
    Join Date
    Aug 2012
    Posts
    144
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    I am a bit confused here. I made sure my SRL is up to date within Simba yet I am still getting this error with the LRC Miner script. Possibly this is an issue specific to the script?

    How can I change the bitmap within SRL? or is this fix automatically implemented?

  13. #13
    Join Date
    Nov 2011
    Location
    United states
    Posts
    516
    Mentioned
    1 Post(s)
    Quoted
    1 Post(s)

    Default

    This: http://villavu.com/forum/showthread.php?t=91757 would fix it because you would just search for if logged in and if not found then it checks for the navbar

  14. #14
    Join Date
    Mar 2007
    Posts
    5,125
    Mentioned
    275 Post(s)
    Quoted
    901 Post(s)

    Default

    Quote Originally Posted by xtrapsp View Post
    Web design, Div tags are what website are constructed with.
    Won't work. It's embedded into the client, not the webpage.

    Forum account issues? Please send me a PM

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •