Page 3 of 4 FirstFirst 1234 LastLast
Results 51 to 75 of 79

Thread: The path maker for SPS[2.0]

  1. #51
    Join Date
    May 2012
    Location
    Moscow, Russia
    Posts
    661
    Mentioned
    35 Post(s)
    Quoted
    102 Post(s)

    Default

    Running, it is duplicated in the main menu. You should see the point - Go to area:...
    Last edited by CynicRus; 01-20-2013 at 06:56 PM.
    Per aspera ad Astra!
    ----------------------------------------
    Slow and steady wins the race.

  2. #52
    Join Date
    May 2012
    Location
    Moscow, Russia
    Posts
    661
    Mentioned
    35 Post(s)
    Quoted
    102 Post(s)

    Default

    Quote Originally Posted by Coh3n View Post
    Whoops! In that case I would have a default path name set when the application starts (like path1 or something) so the user can immediately click the points.

    Now I can pick points, but the city list still doesn't work.
    Try to that exe, I think this should help.
    Attached Files Attached Files
    Per aspera ad Astra!
    ----------------------------------------
    Slow and steady wins the race.

  3. #53
    Join Date
    May 2012
    Location
    Moscow, Russia
    Posts
    661
    Mentioned
    35 Post(s)
    Quoted
    102 Post(s)

    Default

    Quote Originally Posted by Ollybest View Post
    Could you add an "area creator" in? where you can draw a box on the map and it will output it as a tbox? area := inttobox(100,100,200,200);

    just another suggestion
    Plsease explain the working principle in detail.
    Per aspera ad Astra!
    ----------------------------------------
    Slow and steady wins the race.

  4. #54
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    Quote Originally Posted by CynicRus View Post
    Try to that exe, I think this should help.
    I like how that version tells the user the name the path when you click the map. That solves one issue; however, the city list still doesn't work. @your PM: that's probably the issue as I'm using the updated maps (not the ones in the SPS updater). Can't you just base it off the file name rather than the size? The new maps will be in the SPS updater soon so the runescape_surface.png map will change size.

    It's possible the map will change sizes in the future as well, so it could pose future problems if you keep it binded by size.

  5. #55
    Join Date
    May 2012
    Location
    Moscow, Russia
    Posts
    661
    Mentioned
    35 Post(s)
    Quoted
    102 Post(s)

    Default

    Quote Originally Posted by Coh3n View Post
    I like how that version tells the user the name the path when you click the map. That solves one issue; however, the city list still doesn't work. @your PM: that's probably the issue as I'm using the updated maps (not the ones in the SPS updater). Can't you just base it off the file name rather than the size? The new maps will be in the SPS updater soon so the runescape_surface.png map will change size.

    It's possible the map will change sizes in the future as well, so it could pose future problems if you keep it binded by size.
    Perhaps it is possible, I'll do it when I come to work.
    Per aspera ad Astra!
    ----------------------------------------
    Slow and steady wins the race.

  6. #56
    Join Date
    Jan 2012
    Posts
    1,596
    Mentioned
    78 Post(s)
    Quoted
    826 Post(s)

    Default

    Quote Originally Posted by CynicRus View Post
    Plsease explain the working principle in detail.
    I think on this hes looking for something like...

    or like this...


    In the first, you make a path, then the program goes through the list and finds max and min of x and y to give you the area that contains all the path points. (similar to how when you do the code generation and it gives you the SPS map areas it uses)
    or in the second, there is a function/button where you click and select a box and then gives the area.

  7. #57
    Join Date
    Nov 2011
    Location
    England
    Posts
    3,072
    Mentioned
    296 Post(s)
    Quoted
    1094 Post(s)

    Default

    I spoke to him privately about it, and no you get the jist of it but it would better just to be able to draw a box anywhere and get the cords

  8. #58
    Join Date
    May 2012
    Location
    Moscow, Russia
    Posts
    661
    Mentioned
    35 Post(s)
    Quoted
    102 Post(s)

    Default

    Quote Originally Posted by Coh3n View Post
    Can't you just base it off the file name rather than the size?
    It's possible the map will change sizes in the future as well, so it could pose future problems if you keep it binded by size.
    Fixed in version 2.5.5
    Per aspera ad Astra!
    ----------------------------------------
    Slow and steady wins the race.

  9. #59
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    Quote Originally Posted by CynicRus View Post
    Fixed in version 2.5.5
    It worked the first time, but if I tried to right click again, the menu didn't pop up.

  10. #60
    Join Date
    May 2012
    Location
    Moscow, Russia
    Posts
    661
    Mentioned
    35 Post(s)
    Quoted
    102 Post(s)

    Default

    Quote Originally Posted by Coh3n View Post
    It worked the first time, but if I tried to right click again, the menu didn't pop up.
    How I can reproduce that?
    Per aspera ad Astra!
    ----------------------------------------
    Slow and steady wins the race.

  11. #61
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    Quote Originally Posted by CynicRus View Post
    How I can reproduce that?
    Run your application, open the world map, click on the map, enter in a path name, right click map, choose any city, then try to right click again and it won't work.

  12. #62
    Join Date
    May 2012
    Location
    Moscow, Russia
    Posts
    661
    Mentioned
    35 Post(s)
    Quoted
    102 Post(s)

    Default

    Quote Originally Posted by Coh3n View Post
    Run your application, open the world map, click on the map, enter in a path name, right click map, choose any city, then try to right click again and it won't work.
    Oh,lol. Thats bug has been fixed now Look to the new exe
    Per aspera ad Astra!
    ----------------------------------------
    Slow and steady wins the race.

  13. #63
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    Okay, that works now. Couple more issues/suggestions:

    • The dragging is still pretty glitchy.
    • I suggest for code generation, just print the path and SPS areas; there's really no need to have the entire script. If you insist on keeping the entire script, you should bring it up to SRL standards (i.e. the proper spacing and indenting).
    • There's a compiling error in the code (at least the snippet it generated for me):
      Simba Code:
      SPS_Setup(RUNESCAPE_SURFACE,[,'10_6','10_7','10_8','11_6','11_7','11_8','12_6','12_7','12_8'
      There's a misplaced comma in the array, and you're missing a ] and ; at the end of the line. Also, the path I made requires 2 areas at the most. Having unnecessary areas really slows SPS down; having 9 areas will make it too slow to run effectively.
    • I suggest making the application start at coordinates closer to the top left of the screen. On my laptop screen, it gets cut off at the bottom. Same goes with the code form.
    • You should add a 73 radius circle around the last point clicked to represent the minimap so users can better visualize how much space to put between points.
    • It may be easier to have an actual button at the bottom of the path list that has a caption "Generate Code". That would make it easier for users as now they have to hover each button to find the right one (I would still keep the current button, though).
    • Expandable window/full screen option if you've made a progress with that.


    Sorry I'm criticizing so much, I just want it to be as best as it can be. Take my suggestions for what their worth.

    E: I've also added a link to this thread in the official SPS thread.
    Last edited by Coh3n; 01-22-2013 at 05:28 PM.

  14. #64
    Join Date
    May 2012
    Location
    Moscow, Russia
    Posts
    661
    Mentioned
    35 Post(s)
    Quoted
    102 Post(s)

    Default

    Quote Originally Posted by Coh3n View Post
    Okay, that works now. Couple more issues/suggestions:

    • The dragging is still pretty glitchy.
    • I suggest for code generation, just print the path and SPS areas; there's really no need to have the entire script. If you insist on keeping the entire script, you should bring it up to SRL standards (i.e. the proper spacing and indenting).
    • There's a compiling error in the code (at least the snippet it generated for me):
      Simba Code:
      SPS_Setup(RUNESCAPE_SURFACE,[,'10_6','10_7','10_8','11_6','11_7','11_8','12_6','12_7','12_8'
      There's a misplaced comma in the array, and you're missing a ] and ; at the end of the line. Also, the path I made requires 2 areas at the most. Having unnecessary areas really slows SPS down; having 9 areas will make it too slow to run effectively.
    • I suggest making the application start at coordinates closer to the top left of the screen. On my laptop screen, it gets cut off at the bottom. Same goes with the code form.
    • You should add a 73 radius circle around the last point clicked to represent the minimap so users can better visualize how much space to put between points.
    • It may be easier to have an actual button at the bottom of the path list that has a caption "Generate Code". That would make it easier for users as now they have to hover each button to find the right one (I would still keep the current button, though).
    • Expandable window/full screen option if you've made a progress with that.


    Sorry I'm criticizing so much, I just want it to be as best as it can be. Take my suggestions for what their worth.

    E: I've also added a link to this thread in the official SPS thread.
    Hi!
    As for criticising me - I always like criticism as it allows me to have a look at the problem from another angle and, surely, improve the product quality, so I'm for healthy criticising-)
    As for your suggestions:
    1. Unfortunately, I can't reproduce this glitchy bug at my computer. I presume, the trouble is that you have to repaint this very big picture every time on the canvas, so in fast movement it gets "glitchy". I'll try to fix it somehow, but I can't promise to make it soon.
    2. Ok, I can easily add another script generation button under the point list.
    3. I'll add a circle symbolizing a minimap.
    4. I'll fix the script generator taking into account the code writing standard. Unfortunately, at the moment the procedure of relating a global map point to the relevant location in the area isn't optimal. The point value is divided by 400, the result is rounded down, that's how we create the area name. Because of this I have to add extra areas to the code just in case. So I'll gladly fix it if you suggest the right area calculation formula.
    5. I'll fix the form position.
    6. At the moment I can't create an expandable window as in the current condition of LCL there will be a lot of fuck up with LCL bugs. It can be painlessly achieved with the help of a platform-dependent functions. But it's not the way I would choose, tho-)

    Cheers,
    Cynic.
    Per aspera ad Astra!
    ----------------------------------------
    Slow and steady wins the race.

  15. #65
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    No problem about the dragging. If you manage to fix it, great, but it still works, so it's not a huge deal. The expandable window isn't a huge deal, either.

    About the path areas - I can understand including maybe one or two extra to maybe increase accuracy, but right now your function returns all these areas for just one point in VW bank:
    Simba Code:
    SPS_Setup(RUNESCAPE_SURFACE,[,'10_6','10_7','10_8','11_6','11_7','11_8','12_6','12_7','12_8'
    When all you need is 11_7, and MAYBE 11_6. Also, if you divide the x/y coords by 400 and round down, you get 11_7, so that's correct.

    Know what I mean**

  16. #66
    Join Date
    May 2012
    Location
    Moscow, Russia
    Posts
    661
    Mentioned
    35 Post(s)
    Quoted
    102 Post(s)

    Default

    Quote Originally Posted by Coh3n View Post
    No problem about the dragging. If you manage to fix it, great, but it still works, so it's not a huge deal. The expandable window isn't a huge deal, either.

    About the path areas - I can understand including maybe one or two extra to maybe increase accuracy, but right now your function returns all these areas for just one point in VW bank:
    Simba Code:
    SPS_Setup(RUNESCAPE_SURFACE,[,'10_6','10_7','10_8','11_6','11_7','11_8','12_6','12_7','12_8'
    When all you need is 11_7, and MAYBE 11_6. Also, if you divide the x/y coords by 400 and round down, you get 11_7, so that's correct.

    Know what I mean**
    Well. Version 2.5.6 has been released now.
    Changelog:
    - Window position partically was fixed now.
    - Initial implementation of the minimap round on the map.
    - Area generator was rewritten and has been fixed now.
    - Code-generator has been fixed and reduced to SRL coding standards.
    - Added an extra button to generate the code.
    - A lot of small changes and optimizations.

    Cheers,
    Cynic.
    Per aspera ad Astra!
    ----------------------------------------
    Slow and steady wins the race.

  17. #67
    Join Date
    Jan 2012
    Posts
    1,596
    Mentioned
    78 Post(s)
    Quoted
    826 Post(s)

    Default

    Every update seems to make it a tiny bit better than the last.

    Anyway. Suggestion as to calculating the size of the path dialog box...
    It appears to be about 1/4th of the entire screen width which for those with multiple monitors/eyefinity/super high resolutions, it doesnt turn out too nice.
    http://i.imgur.com/QSEIzQB.png

    ive got no idea how the size decision is made or if it can even be changed, but if this cant be changed, no harm done.

  18. #68
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

  19. #69
    Join Date
    May 2012
    Location
    Moscow, Russia
    Posts
    661
    Mentioned
    35 Post(s)
    Quoted
    102 Post(s)

    Default

    Glad to hear it

    Well, the critical bugs are not found, all the declared functions are working correctly - I declare it this first stable release.

    @Turpinator: this is standart LCL input query. Maybe I'll write your own implementation in the future.
    Per aspera ad Astra!
    ----------------------------------------
    Slow and steady wins the race.

  20. #70
    Join Date
    May 2012
    Location
    Moscow, Russia
    Posts
    661
    Mentioned
    35 Post(s)
    Quoted
    102 Post(s)

    Default

    Quote Originally Posted by Turpinator View Post
    Every update seems to make it a tiny bit better than the last.

    Anyway. Suggestion as to calculating the size of the path dialog box...
    It appears to be about 1/4th of the entire screen width which for those with multiple monitors/eyefinity/super high resolutions, it doesnt turn out too nice.
    http://i.imgur.com/QSEIzQB.png

    ive got no idea how the size decision is made or if it can even be changed, but if this cant be changed, no harm done.
    Fixed in the 2.5.6 stable.

    Stable version has been uploaded now. A lot of memory leak fixes and Input query implementation rewritten from scratch.

    PS: Sorry, I forgot to upload it yesterday

    Cheers,
    Cynic.
    Per aspera ad Astra!
    ----------------------------------------
    Slow and steady wins the race.

  21. #71
    Join Date
    May 2012
    Location
    Moscow, Russia
    Posts
    661
    Mentioned
    35 Post(s)
    Quoted
    102 Post(s)

    Default

    Version 2.5.7 has been released now.

    Whats new:
    - I've update a codegen, this generated a completed script now.(See example)
    - Codegen reduced to SRL coding standards.
    - Minor fixes

    Script example:
    Simba Code:
    program Walker;
    //The code was generated with the path generator for SPS version 2.5.7 by Cynic
    {$DEFINE SMART}
    {$i SRL/srl.simba}
    {$i sps/sps.simba}

    var
    //place your variables here
     Status: string;

    procedure DeclarePlayers;
    begin
      HowManyPlayers:=1;
      NumberOfPlayers(HowManyPlayers);
      CurrentPlayer:=0;
      with Players[0] do
      begin
        Name:='';
        Pass:='';
        BoxRewards:=[''];
        LampSkill:=SKILL_PRAYER;
        Pin:='';
        Active:=true;
      end;
    end;

    procedure SeersToCatherby;
    var
      SeersToCatherbyVar: TPointArray;
    begin
      SeersToCatherbyVar:=[Point(2593,2710),Point(2633,2714),Point(2663,2712),Point(2700,2708),Point(2721,2709),Point(2760,2713),Point(2798,2729),Point(2820,2732),Point(2861,2746),Point(2881,2762),Point(2896,2791),Point(2904,2807),Point(2921,2822),Point(2933,2842),Point(2954,2861),Point(2979,2885),Point(2994,2904),Point(3011,2918),Point(3034,2921),Point(3057,2915),Point(3066,2912),Point(3073,2895)];
      if SPS_WalkPath(SeersToCatherbyVar) then
        Status := 'SeersToCatherby'
      else begin
        Status :='Failed SeersToCatherby';
        WriteLn(status + '#Time Running:' +TimeRunning);
        Logout;
        TerminateScript;
      end;
      WriteLn(status + '#Time Running:' +TimeRunning);
    end;

    procedure CatherbyToCamelot;
    var
      CatherbyToCamelotVar: TPointArray;
    begin
      CatherbyToCamelotVar:=[Point(3076,2889),Point(3065,2907),Point(3051,2914),Point(3042,2919),Point(3027,2921),Point(3008,2915),Point(2992,2897),Point(2975,2880),Point(2951,2858),Point(2940,2844),Point(2927,2826),Point(2917,2813),Point(2907,2804),Point(2900,2795),Point(2894,2783),Point(2892,2776),Point(2881,2760),Point(2867,2743),Point(2869,2731),Point(2867,2712)];
      if SPS_WalkPath(CatherbyToCamelotVar) then
        Status := 'CatherbyToCamelot'
      else begin
        Status :='Failed CatherbyToCamelot';
        WriteLn(status + '#Time Running:' +TimeRunning);
        Logout;
        TerminateScript;
      end;
      WriteLn(status + '#Time Running:' +TimeRunning);
    end;

    procedure SetupWalker;
    begin
      SRL_SIXHOURFIX := TRUE;
      SMART_FIXSPEED := TRUE;
      SetupSRL;
      DeclarePlayers;
      LoginPlayer;
      Wait(774+ Random(277));
      ClickNorth(SRL_ANGLE_HIGH);
      SPS_Setup(RUNESCAPE_SURFACE,['6_6','7_6','7_7']);
    end;

    begin
      SetupWalker;
      SeersToCatherby;
      CatherbyToCamelot;
    end.

    Cheers,
    Cynic.
    Last edited by CynicRus; 02-03-2013 at 08:52 PM.
    Per aspera ad Astra!
    ----------------------------------------
    Slow and steady wins the race.

  22. #72
    Join Date
    Mar 2006
    Location
    Belgium
    Posts
    3,564
    Mentioned
    111 Post(s)
    Quoted
    1475 Post(s)

    Default

    Nice work!

    Creds to DannyRS for this wonderful sig!

  23. #73
    Join Date
    May 2012
    Location
    Moscow, Russia
    Posts
    661
    Mentioned
    35 Post(s)
    Quoted
    102 Post(s)

    Default

    Version 2.5.8 has been released now.

    - Codegen update. Added support for the ProjectRS 06 Include.
    Per aspera ad Astra!
    ----------------------------------------
    Slow and steady wins the race.

  24. #74
    Join Date
    Apr 2008
    Location
    Marquette, MI
    Posts
    15,252
    Mentioned
    138 Post(s)
    Quoted
    680 Post(s)

    Default

    Curious, what did you have to change for it to work for ProjectRS06?

  25. #75
    Join Date
    May 2012
    Location
    Moscow, Russia
    Posts
    661
    Mentioned
    35 Post(s)
    Quoted
    102 Post(s)

    Default

    Quote Originally Posted by Coh3n View Post
    Curious, what did you have to change for it to work for ProjectRS06?
    Just connect the necessary includes to the codegen
    Per aspera ad Astra!
    ----------------------------------------
    Slow and steady wins the race.

Page 3 of 4 FirstFirst 1234 LastLast

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •