Results 1 to 7 of 7

Thread: RandomRClick after EoC may cause problems

  1. #1
    Join Date
    Nov 2008
    Location
    Norway, Alesund
    Posts
    924
    Mentioned
    0 Post(s)
    Quoted
    37 Post(s)

    Default RandomRClick after EoC may cause problems

    Hey Just noticed that with new skill interface we can have some problems.
    Simba Code:
    (*
    RandomRClick
    ~~~~~~~~~~~~

    .. code-block:: pascal

        procedure RandomRClick

    Performs random right click to stay active.

    .. note::

        Author: phantombmx/EvilChicken!, idea by Naum
        Last Modified: Unknown

    Example:

    .. code-block:: pascal

        RandomRClick;
    *)
       
    procedure RandomRClick;
    var
      I: TBooleanArray;
      II, M, R: Byte;
      Inv: Boolean;
    begin
      if (not LoggedIn) then exit;
      M := MouseSpeed;
      MouseSpeed := 7 + Random(25);
      Inv := (GetCurrentTab = tab_Inv);
      if (Inv) then Inv := ((not InvEmpty) and (Random(3) > 0));
      if (not Inv) then
        MouseBox(MSX1, MSY1, MIX2, MIY2, mouse_right)
      else
      begin
        SetLength(I, 28);
        for II := 0 to 27 do
          I[II] := ExistsItem(II + 1);

        R := RandomRange(1, 28);
        while (not I[R - 1]) do
          R := RandomRange(1, 28);
        InvMouse(R, mouse_right);
      end;
      Inv := False;
      if (Random(3) > 0) then
        Inv := ChooseOption('xamine');
      if (not Inv) then ChooseOption('ancel');
      MouseSpeed := M;
    end;
    Since if here is no option = 'xamine', he chooses 'ancel'.
    yeah so my point is if he "random" click at center of screen on skilling interface cancel button. he will get 2 cancel options.
    1. Cancel - Cancel current process (smithing gold ores as in image)
    2. Cancel - to cancel right click interface



    screen shoot.

  2. #2
    Join Date
    Feb 2012
    Location
    Discord
    Posts
    3,114
    Mentioned
    37 Post(s)
    Quoted
    538 Post(s)

    Default

    lol! "cancel
    cancel"? nice thinking jagex,way to confuse legits :P

  3. #3
    Join Date
    Nov 2008
    Location
    Norway, Alesund
    Posts
    924
    Mentioned
    0 Post(s)
    Quoted
    37 Post(s)

    Default

    Quote Originally Posted by The Killer View Post
    lol! "cancel
    cancel"? nice thinking jagex,way to confuse legits :P
    yeah, I had to check out, even it's obviously what is what..

  4. #4
    Join Date
    Mar 2012
    Posts
    690
    Mentioned
    2 Post(s)
    Quoted
    40 Post(s)

    Default

    If they wont hotfix that then could that little area be excluded?

  5. #5
    Join Date
    Feb 2012
    Location
    Wonderland
    Posts
    1,988
    Mentioned
    41 Post(s)
    Quoted
    272 Post(s)

    Default

    I'm submitting a fix in a second, testing before I do.

    Sent Pull Req : https://github.com/Fratello/SRL-5/co...bc0f92b990e6f5
    Last edited by Le Jingle; 11-29-2012 at 08:02 PM.

  6. #6
    Join Date
    Mar 2007
    Posts
    5,125
    Mentioned
    275 Post(s)
    Quoted
    901 Post(s)

    Default

    Quote Originally Posted by Le Jingle View Post
    I'm submitting a fix in a second, testing before I do.

    Sent Pull Req : https://github.com/Fratello/SRL-5/co...bc0f92b990e6f5
    Your pull will break scripts that use RandomRClick since you renamed the function

    Forum account issues? Please send me a PM

  7. #7
    Join Date
    Feb 2012
    Location
    Wonderland
    Posts
    1,988
    Mentioned
    41 Post(s)
    Quoted
    272 Post(s)

    Default

    Quote Originally Posted by [J]ustin View Post
    Your pull will break scripts that use RandomRClick since you renamed the function
    Oh, thanks for the catch. I forgot to revert back to original name after testing. Also noted that I forgot to change the Random(9) back to Random(25). Also added in credit to GetChooseOptions.
    Last edited by Le Jingle; 11-29-2012 at 11:43 PM.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •