Page 3 of 6 FirstFirst 12345 ... LastLast
Results 51 to 75 of 127

Thread: [EoC] DannyRS RangeGuildTrainer

  1. #51
    Join Date
    May 2012
    Posts
    51
    Mentioned
    0 Post(s)
    Quoted
    3 Post(s)

    Default

    Hey Danny. I was running this last night and for the 10mins I spent watching it, it seemed to run pretty damn good. I couldn't get you a proggy due to my laptop restarting to install new updates overnight.

    But all in all it's working like a charm!

    Thanks broski!

  2. #52
    Join Date
    Nov 2012
    Posts
    2,351
    Mentioned
    55 Post(s)
    Quoted
    603 Post(s)

    Default

    Quote Originally Posted by Ann_arbor View Post
    Hey Danny. I was running this last night and for the 10mins I spent watching it, it seemed to run pretty damn good. I couldn't get you a proggy due to my laptop restarting to install new updates overnight.

    But all in all it's working like a charm!

    Thanks broski!
    Awesome to know its working for you


    Programming is like trying keep a wall of shifting sand up, you fix one thing but somewhere else starts crumbling

  3. #53
    Join Date
    May 2012
    Posts
    51
    Mentioned
    0 Post(s)
    Quoted
    3 Post(s)

    Default

    Two very minor things.

    After about an hour, the angle of my screen will move and my screen will face northwest, thus eliminating the view of the targets (I think this may have to do with the script not being able to find the judge)

    One other minor problem is that the proggy doesn't work. It shows how long the script has ran, but the exp calculations remain at 0.

    These are just minor problems. I dont mind babysitting the script a little, especially since I'm using this for my main. The proggy doesn't really matter either, I can do that manually. Just wanted to point these out for ya.

  4. #54
    Join Date
    Nov 2012
    Posts
    2,351
    Mentioned
    55 Post(s)
    Quoted
    603 Post(s)

    Default

    Quote Originally Posted by Ann_arbor View Post
    Two very minor things.

    After about an hour, the angle of my screen will move and my screen will face northwest, thus eliminating the view of the targets (I think this may have to do with the script not being able to find the judge)

    One other minor problem is that the proggy doesn't work. It shows how long the script has ran, but the exp calculations remain at 0.

    These are just minor problems. I dont mind babysitting the script a little, especially since I'm using this for my main. The proggy doesn't really matter either, I can do that manually. Just wanted to point these out for ya.
    i can fix the camera thing at some point maybe,

    the proggy is due to you needing to reset your XP counter ingame and set it to range


    Programming is like trying keep a wall of shifting sand up, you fix one thing but somewhere else starts crumbling

  5. #55
    Join Date
    Dec 2012
    Posts
    21
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Works great, what's the average xp/h? I'm getting 24k/h

  6. #56
    Join Date
    Nov 2012
    Posts
    2,351
    Mentioned
    55 Post(s)
    Quoted
    603 Post(s)

    Arrow

    Quote Originally Posted by Bwpz View Post
    Works great, what's the average xp/h? I'm getting 24k/h
    Glad its working for you, honestly the XP varies so much on level and gear, i cant give you an average, but its a cheap reliable way to level range up


    Programming is like trying keep a wall of shifting sand up, you fix one thing but somewhere else starts crumbling

  7. #57
    Join Date
    Dec 2012
    Posts
    21
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Quote Originally Posted by DannyRS View Post
    Glad its working for you, honestly the XP varies so much on level and gear, i cant give you an average, but its a cheap reliable way to level range up
    Yeah, definitely better than killing cows xD

    The better gear you wear, the more exp? I'll get decked out lmao.

  8. #58
    Join Date
    Nov 2012
    Posts
    2,351
    Mentioned
    55 Post(s)
    Quoted
    603 Post(s)

    Default

    Quote Originally Posted by Bwpz View Post
    Yeah, definitely better than killing cows xD

    The better gear you wear, the more exp? I'll get decked out lmao.
    Actually no idea in EoC, used to be your chance of hitting the better score on the target was base off your range bonus, but in EoC thats some kind of weakness system?

    So i have no idea, but cant hurt to wear the best gear you can / have just incase


    Programming is like trying keep a wall of shifting sand up, you fix one thing but somewhere else starts crumbling

  9. #59
    Join Date
    Sep 2012
    Location
    Minnesota
    Posts
    107
    Mentioned
    4 Post(s)
    Quoted
    36 Post(s)

    Default

    Have you ever tried to implement the SixHourFix? It would be awesome if you could do that! get some real nice proggies
    Last edited by garyman; 12-15-2012 at 03:43 AM. Reason: typo

  10. #60
    Join Date
    Nov 2012
    Posts
    2,351
    Mentioned
    55 Post(s)
    Quoted
    603 Post(s)

    Default

    Quote Originally Posted by garyman View Post
    Have you ever tried to implement the SixHourFix? It would be awesome if you could do that! get some real nice proggies
    Going to add this soon if you learn some basic simba scripting you can add it yourself currently, really easy, i just never bothered but i'll get to it


    Programming is like trying keep a wall of shifting sand up, you fix one thing but somewhere else starts crumbling

  11. #61
    Join Date
    Dec 2012
    Posts
    21
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default

    Ran it overnight (not sure how long it went for, woke up in the middle of the night and changed scripts). Got me from 40-57 Ranged though.

  12. #62
    Join Date
    Nov 2012
    Posts
    2,351
    Mentioned
    55 Post(s)
    Quoted
    603 Post(s)

    Default

    Quote Originally Posted by Bwpz View Post
    Ran it overnight (not sure how long it went for, woke up in the middle of the night and changed scripts). Got me from 40-57 Ranged though.
    Awesome!

    Glad its going to good use


    Programming is like trying keep a wall of shifting sand up, you fix one thing but somewhere else starts crumbling

  13. #63
    Join Date
    Apr 2007
    Posts
    7
    Mentioned
    0 Post(s)
    Quoted
    0 Post(s)

    Default Good job

    Hey Danny, thanks for the script.

    I've had some good runs I just keep forgetting to copy+paste reports.

    Very rarely it seems to miss-click the target and walk to an area around the targets. I'll try to get a screenshot of it.



    Quote Originally Posted by MMOE View Post
    Welcome to RangeGuildTrainer V1.0 by Dannyrs
    Starting in 3...
    Starting in 2...
    Starting in 1...
    Talking To Judge
    Talking To Judge
    Talking To Judge
    Talking To Judge

    Code:
    Procedure TalkJudge;
    Var
      x,y,attempts: Integer;
      Check: Boolean;
    
    Begin
      Check:=False;
    ...
    Quote Originally Posted by DannyRS View Post
    glad to hear its what you needed, like everything i do, its going to be improved as i discover better ways to accomplish things
    If you would like a coding suggestion, whenever you see a long line of nested repetitive ifs (or repetition in general), it means its a good area for refactoring. Take your TalkJudge Procedure, it can be changed to this with the exact same effect:

    Code:
    Procedure TalkJudge;
    Var
      x,y,attempts: Integer;
      Check: Boolean;
      positions: T2DIntegerArray;
      positionsLength : Integer;
      Index: Integer;
    
    Begin
      Check:=False;
    
      positionsLength := 10;
      SetLength(positions,positionsLength);
      positions := [
        TIntegerArray([217, 201, 228, 259]),
        TIntegerArray([252, 225, 261, 284]),
        TIntegerArray([233, 175, 237, 228]),
        TIntegerArray([256, 189, 270, 250]),
        TIntegerArray([293, 208, 301, 240]),
        TIntegerArray([340, 228, 344, 291]),
        TIntegerArray([335, 145, 340, 198]),
        TIntegerArray([378, 225, 382, 240]),
        TIntegerArray([278, 175, 282, 214]),
        TIntegerArray([305, 180, 308, 229])
      ];
    
    
      repeat begin
      if not(FindColorSpiralTolerance(x, y, 10092288, 402, 163, 465, 193, 20))then
        begin
          //Target View Screen
          Wait(563+Random(193));
          if(Debug)then begin Writeln('Talking To Judge'); end;
    
    
          //Reduced ifs to 10 lines
          for Index := 0 to (positionsLength-1) do
            begin
              DragMouseSpot(positions[Index][0], positions[Index][1], positions[Index][2], positions[Index][3]);
              If IsUpTextMultiCustom(['Talk-to','alk-to']) then
                begin
                  ClickCurrent(False);
                  if (ChooseOptionMulti(['Compete','ompete'])) then begin Check:=True; end
                  else begin Exit; Break; end;
                end
            end;
          //end of changes
    
    
        end else begin CloseTVUp; end;
        //Wait(563+Random(193));      
    ...

    Hope to see more!
    Last edited by tekgen; 12-15-2012 at 10:24 PM.

  14. #64
    Join Date
    Nov 2012
    Posts
    2,351
    Mentioned
    55 Post(s)
    Quoted
    603 Post(s)

    Default

    Quote Originally Posted by tekgen View Post

    Very rarely it seems to miss-click the target and walk to an area around the targets. I'll try to get a screenshot of it.

    If you would like a coding suggestion, whenever you see a long line of nested repetitive ifs (or repetition in general), it means its a good area for refactoring.
    If its miss-clicking targets, your not zoomed out to the max in RS most likely? i cant make it missclick personally

    Thanks for the tip, i just slightly modified the judge detection to use TPA's, so there's barely any repetitive If's now anyway


    Programming is like trying keep a wall of shifting sand up, you fix one thing but somewhere else starts crumbling

  15. #65
    Join Date
    Nov 2012
    Posts
    2,351
    Mentioned
    55 Post(s)
    Quoted
    603 Post(s)

    Default

    UPDATED to 2.1, added TPA for judge detection, Log-in Support, slight optimization tweaks

    Can someone test the log-in support for me? if it doesn't work go back to 2.0a till i fix it


    Programming is like trying keep a wall of shifting sand up, you fix one thing but somewhere else starts crumbling

  16. #66
    Join Date
    Sep 2012
    Location
    Minnesota
    Posts
    107
    Mentioned
    4 Post(s)
    Quoted
    36 Post(s)

    Default

    Log in went very smooth! ill keep it running to make sure six hour fix works. I tried to fix it myself earlier but i had some compiling errors so im glad you got this released
    Keep up the awesome work!!

  17. #67
    Join Date
    Nov 2012
    Posts
    2,351
    Mentioned
    55 Post(s)
    Quoted
    603 Post(s)

    Default

    Quote Originally Posted by garyman View Post
    Log in went very smooth! ill keep it running to make sure six hour fix works. I tried to fix it myself earlier but i had some compiling errors so im glad you got this released
    Keep up the awesome work!!
    Thanks for the support!

    I took the time working on it to mess with a bunch of stuff lol, i tried to improve it, but making that many changes, i could of broke something, so if anyone can find any bugs in long proggies, let me know!

    And if 2.1 is not working for you, try 2.0a


    Programming is like trying keep a wall of shifting sand up, you fix one thing but somewhere else starts crumbling

  18. #68
    Join Date
    Sep 2012
    Location
    Minnesota
    Posts
    107
    Mentioned
    4 Post(s)
    Quoted
    36 Post(s)

    Default

    The script misclicked and it logged out and when trying to log back in it clicked on the members tab and started opening internet tabs for that. Idk if this is an issue with the script or if its a client bug? Other than this the scripts still running well.

  19. #69
    Join Date
    Nov 2012
    Posts
    2,351
    Mentioned
    55 Post(s)
    Quoted
    603 Post(s)

    Default

    Quote Originally Posted by garyman View Post
    The script misclicked and it logged out and when trying to log back in it clicked on the members tab and started opening internet tabs for that. Idk if this is an issue with the script or if its a client bug? Other than this the scripts still running well.
    Seems to be something weird going on with the way i used the login include,

    Where did it missclick? When loggin in or when running shooting the targets?, if it missclicked while playing, where did it click?


    Programming is like trying keep a wall of shifting sand up, you fix one thing but somewhere else starts crumbling

  20. #70
    Join Date
    Mar 2012
    Location
    San Diego
    Posts
    760
    Mentioned
    4 Post(s)
    Quoted
    91 Post(s)

    Default

    Trying this now

  21. #71
    Join Date
    Nov 2012
    Posts
    2,351
    Mentioned
    55 Post(s)
    Quoted
    603 Post(s)

    Default

    Quote Originally Posted by [PRO]metheus View Post
    Trying this now
    Leme know how it goes

    If 2.1 is broken try previous version


    Programming is like trying keep a wall of shifting sand up, you fix one thing but somewhere else starts crumbling

  22. #72
    Join Date
    Sep 2012
    Location
    Minnesota
    Posts
    107
    Mentioned
    4 Post(s)
    Quoted
    36 Post(s)

    Default

    Where did it missclick? When loggin in or when running shooting the targets?, if it missclicked while playing, where did it click?
    the script misclicked so I moved out of the target range over by the shed (on the opposite side of the range) which caused me to log out. Then it clicked on the members tab and the issue I explained happened.

  23. #73
    Join Date
    Mar 2012
    Location
    San Diego
    Posts
    760
    Mentioned
    4 Post(s)
    Quoted
    91 Post(s)

    Default

    Using 2.1, here's an hour proggy:
    =========RangeGuildTrainer==============
    =========Version: V2.1==================
    Time Running: 1 Hours, 59 Seconds
    Experience Earned: 21970
    Experience/Hour: 21612
    ========================================
    It's still running right now. It works really good!

  24. #74
    Join Date
    Nov 2012
    Posts
    2,351
    Mentioned
    55 Post(s)
    Quoted
    603 Post(s)

    Default

    Quote Originally Posted by [PRO]metheus View Post
    Using 2.1, here's an hour proggy:


    It's still running right now. It works really good!
    Awesome, glad 2.1 works good, thanks for sharing your proggy I'll add to OP


    Programming is like trying keep a wall of shifting sand up, you fix one thing but somewhere else starts crumbling

  25. #75
    Join Date
    Mar 2012
    Location
    San Diego
    Posts
    760
    Mentioned
    4 Post(s)
    Quoted
    91 Post(s)

    Default

    =========RangeGuildTrainer==============
    =========Version: V2.1==================
    Time Running: 6 Hours, 2 Minutes and 52 Seconds
    Experience Earned: 126285
    Experience/Hour: 20881
    ========================================
    Another proggy. Didn't work after the 6 hour thing, though

Page 3 of 6 FirstFirst 12345 ... LastLast

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •